Commit Graph

2651 Commits

Author SHA1 Message Date
wmayer
c2d5bf03a1 Tests: Make PD and Sketcher tests independent of user settings
The Refine property must be explicitly set as otherwise some tests will break because of different user settings
2024-07-08 11:19:36 -05:00
bgbsww
a807c9e25b Toponaming: Tweak test framework to allow leaving documents for examination 2024-07-08 11:12:45 -05:00
wmayer
e9f3178715 MSVC: Fix warning C4005: 'NOMINMAX': macro redefinition 2024-07-05 17:04:43 +02:00
Shai Seger
3957a84c19 Merge branch 'FreeCAD:main' into Fix-Python-getElement 2024-07-05 16:45:36 +03:00
wmayer
fc9a8f4e76 PD: Remove dead code from workbench class 2024-07-05 15:32:52 +02:00
FEA-eng
b6d8771dd3 PD: Update Workbench.cpp 2024-07-05 12:09:04 +02:00
wmayer
4ba4b08747 PD: Reformat TaskThicknessParameters 2024-07-04 22:24:15 +02:00
wmayer
04ff80b18f PD: Refactor TaskThicknessParameters 2024-07-04 22:24:15 +02:00
wmayer
8f38d1fce6 PD: Fix linter warnings in TaskThicknessParameters 2024-07-04 22:24:15 +02:00
wmayer
ea5b53a6a8 PD: Do not set hard-coded maximum for thickness parameter
Fixes #15140: Thickness value Task panel issue
2024-07-04 22:24:15 +02:00
wmayer
d7e9e9ef48 Fixes #14772: Random color problem 2024-07-04 22:23:10 +02:00
shai
b38bfb1aeb Add fixes suggested by @bgbsww 2024-07-04 19:53:09 +03:00
shai
2c062fc2c1 Fix python shape setElement function. Partially fixes #15095 2024-07-04 11:48:44 +03:00
Yorik van Havre
56e46e5f4e Translations (#15107)
* Updated ts files

* Merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-07-02 12:21:53 +02:00
wmayer
10ac9a63a5 PD: Rename duplicated test method
Fixes #14795: testPartDesignElementMapSketch: Duplicate test method name
2024-07-01 11:18:46 -05:00
Max Wilfinger
86b1c2e863 Activate Part/Part Design check and refine preferences by default (#14406)
* Activate Part/Part Design check and refine preferences by default

* added bool in .ui

* Update tests

* Fix Sketcher tests
2024-07-01 10:50:42 -05:00
pre-commit-ci[bot]
3d6a490003 Review cleanups 2024-06-28 11:57:43 -05:00
bgbsww
08859462ea Toponaming: Cleanups 2024-06-28 11:57:43 -05:00
Zheng, Lei
3dbc1d7393 Toponaming: Transfer in missing Code for BaseFeatures and Sketches 2024-06-28 11:57:43 -05:00
bgbsww
cc93d99f49 Toponaming: Add tests for subshaoebinder, attachment problems. 2024-06-28 11:57:43 -05:00
Chris Hennes
da37ccc674 TNP: Update test to use AttachmentSupport 2024-06-26 10:46:36 -05:00
Syres916
08ee9fa728 Part/Toponaming: makeElementWires
* Added tests developed by Syres916
2024-06-26 10:46:36 -05:00
Chris Hennes
9d506e3bfc Merge pull request #14898 from bgbsww/bgbsww-toponamingSaveRestoreElementMaps
Toponaming: Fix save and restore of elementmaps
2024-06-25 09:58:59 -05:00
Syres916
c06cbce42c [PartDesign] Fix thread depth level not enabled unless clicked 3 times 2024-06-24 11:19:06 -05:00
Adrián Insaurralde Avalos
7502f1f96d PD: improve hole dialog layout (#14031) 2024-06-24 10:44:13 -05:00
mosfet80
5f38b52114 [MOD:PART] removed unused parameter (#14252)
d variable are never used

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-06-24 10:41:39 -05:00
bgbsww
aa66518568 Toponaming: Fix save and restore of elementmaps 2024-06-23 23:33:12 -04:00
bgbsww
8675aa87b4 Toponaming: Check for selection mapped element name 2024-06-22 17:10:54 -05:00
wmayer
b56e896f5d PD: Fix crash in ViewProviderBody::unifyVisualProperty
Make sure that the view provider of a body feature provides the requested property
2024-06-18 10:41:41 -05:00
xtemp09
2248fc7adb Fix crash described in 14370 (issue comment)
The crash occurs because
PartDesignGui::TaskDressUpParameters::setSelection was invoked with
nullptr.
2024-06-17 11:27:07 -05:00
wmayer
36b8639059 PD: Fixes issue #14598: FreeCAD crashes on Undo 2024-06-17 11:11:12 -05:00
Chris Hennes
101118fdde Merge branch 'main' into vp_texture_ext 2024-06-17 10:48:45 -05:00
wmayer
2b8cf894f7 PD: Fix Qt warning at runtime
QListWidget::item is not declared as Q_SIGNALS and thus cannot be used as sender in QObject::connect()
2024-06-16 22:21:01 -05:00
wmayer
636fa43c99 MSVC: Fix warnings and build failure 2024-06-12 10:36:58 -05:00
wmayer
3fd2f64639 Fix several regressions:
+ improve PropertyMaterialList::readString
+ fix transparency handling in ViewProviderPartExt
+ do not register the private member '_diffuseColor' as property because it would be exposed to the
  public where it can be modified
+ fix ViewProviderPartExt::finishRestoring() to correctly restore old project files
+ fix ViewProviderPartExt::setHighlightedFaces() to correctly show face colours if VBO is enabled
+ fix ViewProviderBoolean::updateData()
  fix ViewProviderMultiFuse::updateData()
  fix ViewProviderMultiCommon::updateData()
  fix ViewProviderCompound::updateData()
  fix ViewProviderFillet::updateData()
  fix ViewProviderChamfer::updateData()
  that all set invalid transparency values
+ Filter ShapeAppearance in ViewProviderBody::unifyVisualProperty
  because body features usually have different number of faces than the body itself
+ manually fix some bad looking auto-formatted code
+ clean up code and remove duplicated code
2024-06-11 11:58:32 +02:00
wmayer
d88253c2a1 Fix several compiler warnings
* variable 'xAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'yAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'zAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* unused variable 'base' [-Werror,-Wunused-variable]
* unused variable 'extrude' [-Werror,-Wunused-variable]
2024-06-11 11:42:12 +02:00
Kacper Donat
86e07e9181 Gui: Fix use of no longer existing DiffuseColor property 2024-06-10 19:40:48 -05:00
Florian Foinant-Willig
b9dfc493b8 Fix can't pad a sketch on datum plane (#14397)
* Fix can't pad a sketch on datum plane

* Add a unit test for Pad a sketch on datum plane
2024-06-10 11:21:32 -05:00
Kacper Donat
988d31bed8 GUI: Add UI for Up To Shape feature
Add UI for Up To Shape feature and overall refactor of Pad / Pocket.
2024-06-10 18:05:21 +02:00
Kacper Donat
83cf2a17cd Gui: Refactor DressUp VP to use setHighlighted*
This refactors DressUp VP a bit so it does no longer store original copy
of original faces colors to properly support selection, but uses
highlight methods provided by the base class. It simplfies code a bit
and ensures coherent behavior.
2024-06-10 18:05:21 +02:00
wmayer
707b0e6264 Fix compiler warnings 2024-06-04 20:23:19 +02:00
Chris Hennes
7abadaf7f3 Merge pull request #14485 from bgbsww/bgbsww-toponamingFixDressUpShadowSubs
Toponaming fix dress up shadow subs
2024-06-03 21:01:22 -05:00
bgbsww
617e63bc23 Toponaming: reformat code 2024-06-03 19:29:01 -04:00
Florian Foinant-Willig
7ffddb6f7d PD Extrude up to multiple faces or shape 2024-06-03 11:26:19 -05:00
Chris Hennes
6404de9c21 Update translations 2024-06-03 11:04:42 -05:00
Chris Hennes
5f601eb6c7 Merge pull request #12589 from NomAnor/pd-trans-body
Add a new mode to PD patterns that will transform the base feature's shape instead of the tool shapes
2024-06-03 10:46:33 -05:00
Chris Hennes
f331c91b89 Merge pull request #13317 from Ondsel-Development/add-prop-varset
Core: Add properties to variable sets
2024-06-03 10:34:57 -05:00
Zheng, Lei
a926cd41b3 Toponaming: update TaskDressUp addAllEdges 2024-06-03 11:22:55 -04:00
bgbsww
a495280693 Toponaming: fix bug with points in sketches 2024-06-01 22:57:31 -05:00
David Carter
5feb963f9d Material: Appearance Updates 2
Improves the use of the ShapeAppearance property for the Part workbench.

    removes DiffuseColor property
        adds Python compatibility using custom attributes
        transitions DiffuseColor to ShapeAppearance on open
    Improved UI elements for setting object appearance, and appearance per face
    Lays the foundation for future texture support
2024-06-01 19:57:16 -05:00