Commit Graph

423 Commits

Author SHA1 Message Date
Yorik van Havre
94144ecd99 Translations: Merged crowdin translations 2025-06-02 11:48:26 +02:00
luzpaz
09f91baa2b BIM: fix typo in Arch.py (#21696) 2025-06-01 18:36:10 +02:00
tetektoza
8ec6605fc4 BIM: Add support for deactivation active object to BIM Views Tree (#21570)
* BIM: Use checkbox in model tree for Activation/Deactivation of WP

* BIM: Set active object after deactivating current object if it exists

Currently we can get into a scenario where user can activate two working
planes, one after another. For example, Level, and  then Level001. If
they activate both, and then deactivate Level001, working plane switches
back to Level. But, we didn't set the object as the active one, so user
didn't have clear information that they can deactivate it, only the
working plane was switching it.

So this patch sets the object as the active one, if it exists.

* BIM: Add support for deactivation active object to BIM Views Tree

As the title says - it adds the checkbox that's similarly done in Part
workbench, so user can select/deselect the item and if they had previous
active object, it will also fall back to the previous object.

Also, moved out part of the common logic from ArchBuildingPart and
BimViews to utils.

* BIM: Handle correct context on activating WP for NativeIFC/BIM

* BIM: Remove redundant logic from BIM Views upon double click

As all of the logic is being handled now in `activate` function in
BimViews, this logic is redundant

* BIM: Rename button for taskbar and BIM Views from Activate to Active
2025-05-28 11:27:11 +02:00
tetektoza
8eaaaaff50 BIM: Parse Classification in IFC correctly for conversion/type assign 2025-05-26 10:24:34 +02:00
Furgo
5386ca838a BIM: add first iteration of unit tests 2025-05-26 10:23:24 +02:00
Furgo
edc4d04a41 BIM: refactor to reduce code duplication and improved readability 2025-05-26 10:23:24 +02:00
Furgo
df2e055183 BIM: remove command now removes windows from walls
Fixes: #21551
2025-05-26 09:53:21 +02:00
Furgo
92a9b1ae54 BIM: add test for window removal from walls 2025-05-26 09:53:21 +02:00
Paul Lee
8ff5c71101 [ArchWall] Fix SetLength Error When Base Sketch has External Geom
fix #21357 error message problem

Github issue and discussion:
https://github.com/FreeCAD/FreeCAD/issues/21357
https://github.com/FreeCAD/FreeCAD/issues/21357#issuecomment-2886010914

ArchWall return error when Base Sketch has external(projected) geometry.

External projected geometry has TNP-problem, until the feature is TNP-tolerant,  support of external(projected) geometry at ArchWall is not encouraged. The reported error message is fixed in the meantime in this PR.
2025-05-26 09:49:36 +02:00
Benjamin Nauck
e4eeb66626 Merge pull request #21289 from tetektoza/fix/fix_transparency_doors_windows_ifc
BIM: Change from RGBT to RGBA for IFC
2025-05-23 14:10:47 +02:00
paul
62cc73c104 BIM - ArchWindow - Add AutoNormalReversed property 2025-05-23 12:08:33 +02:00
tetektoza
bcb8932930 BIM: Additional improvements for Activate button in BIM Views
This patch introduces a few things:
- changes Activate button to be first in the list
- puts it in bold text, also adding (Default) to point it is default
  action
- removes all of the hiding logic upon double click and leaving Activate
by default to be called after double-clicking a BuildingPart
2025-05-23 12:06:55 +02:00
Roy-043
5cb88a63d0 BIM: Revise close panel on doc close solution (#21302)
* BIM: Revise close panel on doc close solution

Use built-in feature to close the task panels. See #21253.

* Keep self.doc
2025-05-23 11:49:55 +02:00
tetektoza
41dad48e5c BIM/Help: Access DockWidgetArea QFlag enum correctly
Currently, for both Help and BIM Views panels we can get a traceback
about incorrect casting if we move the panel.

This is because the QFlag of DockWidgetArea that is being passed, as it is not
able to be parsed down to an int. Most probably some historical change
either in Qt or FC.

This error also caused to not write current BIM Views/Help panel setup
to config, resulting in the position being resetted every run.
2025-05-23 11:47:10 +02:00
tetektoza
391a41cbda BIM: Add missing IFC attributes for both Pipe and Rebar
As the title says - those two tools missed IFC attributes, since they
used different path of initialization than other components, so this
patch makes sure we initialize those properties properly.
2025-05-23 10:50:47 +02:00
Furgo
88d9be2e10 BIM: allow deleting locked IFC properties when needed 2025-05-23 10:18:36 +02:00
Furgo
78fcaaee34 Revert "BIM: add workaround for Draft workbench test mockup"
This reverts commit 5be803863e7552f7cb96998cd682edd3c556b4be.
2025-05-23 10:14:40 +02:00
Furgo
f901477601 BIM: add workaround for Draft workbench test mockup 2025-05-23 10:14:40 +02:00
Furgo
e710617093 BIM: add basic error checking in unit test, make extrusion a solid 2025-05-23 10:14:40 +02:00
Furgo
844bdada9c BIM: add area calculation unit tests for Arch Components 2025-05-23 10:14:40 +02:00
Furgo
1107f5f364 BIM: support curved vertical edges for area calculation 2025-05-23 10:14:40 +02:00
Furgo
7fa289cae4 BIM: refactor component area calculation into a helper class 2025-05-23 10:14:40 +02:00
Furgo
cc70fee4d7 BIM: correct planar check to avoid vertical/horizontal misclassification 2025-05-23 10:14:40 +02:00
Furgo
f5737a9c5a BIM: add support for bsplines in Arch structures 2025-05-23 10:14:40 +02:00
Ralf Habacker
74ad3978a0 BIM: Add support for concatenation of lines in Obj files
If a line in an obj file ends with '\', the following line is appended.
2025-05-22 12:54:35 +02:00
Ralf Habacker
5e0c109cb1 BIM: Add support to import lines from obj files
Single lines and polylines from 'l' instructions are imported as
Draft::Wire objects and grouped with an App:Part object so that
the lines contained in the obj file are included in the
corresponding object definition.

Single lines defined in the obj file within a block are converted
into a non-closed polyline if the second point of a line matches
the first point of the following line.

Fixes #21326
2025-05-22 12:54:03 +02:00
tetektoza
bba139985a BIM: Make a correct mapping to weight during IFC Quantities assignment
Currently we can assign quantities to a BIM object, but upon exporting
quantities are not visible in the IFC file.

This was because we didn't have a correct mapping to weight property.
`App::PropertyWeight" basically doesn't exist, so this patch changes it
to `App::PropertyMass`, as it is the same. The incorrect mapping
resulted in a traceback, which in turn resulted in missing a big part of
additional processing for the properties, which resulted in
`writeQuantities` checking for non-existent IfcData in the object.
2025-05-19 18:10:37 +02:00
Furgo
52daf829a7 BIM: do not prune Roof objects on export 2025-05-19 18:00:38 +02:00
Benjamin Nauck
02e1bbe1ae Merge pull request #21042 from furgo16/add-taskpanel-walloffset
BIM: add Offset input to wall creation task panel
2025-05-19 17:45:46 +02:00
tetektoza
ca9041ce50 BIM: Avoid traceback if there is no Classification selected
As the title says, if user selects `OK` button and has no Classification
selected (which can happen only if the list is empty I think), then they
get a traceback since we're trying to access list of selections
directly.

So this patch adds a small patch to close the form if user has pressed
`OK` button and did not select anything.
2025-05-19 17:41:24 +02:00
tetektoza
d9881f6384 BIM: Rename to alpha instead of trans after switch to RGBA 2025-05-15 23:00:20 +02:00
Luz Paz
5d052cc043 Fix various typos
Missed by the codespell CI not being functional for a period of time.
2025-05-15 10:59:48 -05:00
Chris Hennes
f2e78e53e9 UI: Remove qPixmapFromMimeSource pixmap function
This function dates back to Qt3, and was removed in Qt4. Modern Qt no
longer uses this ui file entry, and in some circumstances the uic
complains about its presence.
2025-05-15 00:56:30 +02:00
Paul Lee
d10485b156 [ArchStairs] ArchSketch Support and Refactoring Phase 3 + Regression
Phase 2 Subsequent to #21025 + Regression Fix

FC Forum Discussion:-
https://forum.freecad.org/viewtopic.php?p=814274#p814274

ArchSketch Support, PropertySet, and Refactoring to enable more complex Stairs shape.
2025-05-13 11:31:09 +02:00
Paul Lee
7b078e2c96 [BimWindow] Interactive Creation Tool: Check if SketchArch is Enabled (ArchSketchLock)
Improvement to User Interactive Experience:
- The Window Interactive Tool would check if SketchArch-addon is enabled by user, i.e. if ArchSketckLock is checked.
- If not, the conventional creation behaviour is used, SketchArch properties would not be added to Window object.
- It also check if Base of Wall is ArchSketch or not.

Github Discussion:
- https://github.com/paullee0/FreeCAD_SketchArch/issues/27#issuecomment-2837652351
2025-05-13 11:29:09 +02:00
tetektoza
2c9c80fefa BIM: Allow changing Sill parameter in Properties for Window
User has no possibility to change Sill parameter upon adding Window, it
is only possible while creating Window for the first time.

So this patch adds this parameter, and changing it moves the *BASE*
coordinate of the object in Z direction.
2025-05-13 11:25:31 +02:00
tetektoza
1de7024a43 BIM: Switch Visibility of ViewObj on/off to restore it in all objs 2025-05-13 11:03:05 +02:00
tetektoza
0da05071a5 BIM: Do not hide children of Building if Building has been isolated 2025-05-13 11:03:05 +02:00
tetektoza
8fd7c94d8f BIM: Remove additional recompute at the end of isolate 2025-05-13 11:03:05 +02:00
tetektoza
2cd492424c BIM: Exclude viewtree from cached items and add a sanity check 2025-05-13 11:03:05 +02:00
tetektoza
ccd40ed03b BIM: Cache the tree elements beforehand and hide only necessary ones 2025-05-13 11:03:05 +02:00
tetektoza
d24dabbdc2 BIM: Hide all objects that aren't selected during Isolate
Currently if user selects an item and does `Isolate` operation on it in
BIM, everything is being hidden if the item was inside another container
(like Building).

This is because we are prioritizing on hiding parents of current object
if they are not the selected ones, which is causing the child of the
parent to be hidden as well (duh).

So, this patch fixes isolate method to hide all other parents and their
childs. If they are not a parent of our child under selection -> hide
them and proceed further. If we are processing parent of our selection,
just hide anything on current level that is not our selection while
leaving parent intact.
2025-05-13 11:03:05 +02:00
tetektoza
5e46843031 BIM: Change from RGBT to RGBA for IFC
Currently users by default have transparent window frames and doors.

Turns out that at some point there was a switch from RGBT to RGBA, which
means last transparency element differs in the range of transparency
that it specifies (RGBT, where 1 - fully visible, RGBA where 1 - fully
transparent). As the changed happened, all of the windows and door
became transparent.

This patch changes that, from RGBT to RGBA so we will map transparency
properly, as well as adding a possibility to set transparency through
material.
2025-05-12 23:36:13 +02:00
Furgo
9590224fe2 BIM: change Snapping menu order for workplane commands 2025-05-12 22:32:26 +02:00
Furgo
2b5833fa49 BIM: Add working plane selection command 2025-05-12 21:27:30 +02:00
tetektoza
b0599f0cde BIM: Update tooltip for Activate button 2025-05-12 18:00:52 +02:00
tetektoza
464e7d5144 BIM: Introduce Activate for BIM Views
Currently there's no option for selecting active working plane other
than selecting `DoubleClickActivates` property on a BIM Level.

So, this patch adds an additional button for the submenu that BIM Views
provides - to activate working plane of the selected item.
2025-05-12 18:00:52 +02:00
tetektoza
bda260336c BIM: Fix missing IFC attributes for certain BIM objects
Some of the objects, like Column, or Beam do not contain `IFC
Attributes` if they are initially created.

As it turns out, they are not being created as we are checking for
`onDocRestoredDone` attribute, which is assigned in `onDocumentRestored`
function. Since users can usually just not restore a document, but just
play on a newly created document, this attribute won't be available,
thus we won't be going through whole `onChanged` logic which populates
`IFC Attributes`.

To preserve current functionality of this additional parameter and not
cause the previous errors to happen, this patch just changes from the
custom flag to globally available `Restoring` flag which tracks document
being restored more reliably.
2025-05-12 17:50:11 +02:00
Roy-043
ca0630aa50 BIM: close BIM_Library task panel on doc close
Fixes #21179.

This PR uses the built-in solution to close the task panel.

I was not aware of this feature before. My 2 previous PRs related to the closing of task panels, #20719 and #21073, will (largely) have to be reverted/redone in favor of this solution.
2025-05-12 17:48:39 +02:00
marcuspollio
67f1b41bc2 BIM: fix some imports and cleanup miscellaneous (#20914) 2025-05-12 17:40:12 +02:00