Commit Graph

95 Commits

Author SHA1 Message Date
edi271
1a8e88eeec [TD] Move Circulation method to DrawUtil 2022-01-21 11:22:40 -05:00
Wanderer Fan
28c5890bc9 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wmayer
3fa4a321d3 TD: replace usage of raw pointers of Vertex and Face with shared pointers.
This fixes issue 4741: Broken File After Using Landmark Dimension in TechDraw
2021-12-10 14:25:24 +01:00
wmayer
5dbf7e93d7 Gui: fix -Winconsistent-missing-override, TD: fix -Wunused-parameter 2021-08-21 12:15:43 +02:00
Uwe
50da5a74d8 Update src/Mod/TechDraw/App/Cosmetic.cpp
Co-authored-by: 0penBrain <48731257+0penBrain@users.noreply.github.com>
2021-08-03 13:23:14 +02:00
donovaly
e9a94d1e78 [TD] comment the new centerline behavior
add missing info to understand the new centerline behavior as introduced with commit d1476c64
2021-08-03 13:23:14 +02:00
donovaly
2bc5ac2e4b [TD] fix centerline crashes and bugs
the PR fixes the following things:
- change the way centerlines between 2 lines are calculated. The current implementation leads to many bugs and even crashes (e.g. when the 2 selected lines are parallel ones of a square). There are different forum threads from the last 1.5 years.
The new endpoint line sorting is the one described here: https://forum.freecadweb.org/viewtopic.php?f=35&start=20&t=44255&sid=989a668890f954c13ef81e4a04ee6912#p501179

- as consequence the erroneous and misleading line end flipping can go and is removed (only used internally)

- when creating a new centerline, you see it immediately

- when creating a new or editing an existing centerline and press Cancel, the creation/editing is aborted

- fix crash when the 2 selected lines are bot horizontal and one tries to create a vertical centerline

- fix crash when changing the orientation  of an existing centerline and the result would be invalid

- cleanup the code a bit
2021-05-15 05:21:29 +02:00
donovaly
4bae944950 [TD] make LineGroup selectable
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
2020-12-03 17:24:49 +01:00
wandererfan
fa111f86ad [TD]draw line through 2 points 2020-08-19 09:02:25 -04:00
wmayer
4807fd3b33 PVS: V730 Not all members of a class are initialized inside the constructor 2020-07-18 10:59:27 +02:00
wandererfan
862b2cdf83 [TD]makeCosmeticLine Y inversion 2020-07-12 09:04:59 -04:00
wandererfan
94e5f205ee [TD]CosmeticVertex default size 2020-06-23 08:21:13 -04:00
wandererfan
476b19590b [TD]Fix CosmeticVertex size 2020-06-09 16:12:14 -04:00
wandererfan
eaf2f0e8a4 [TD]Simplify Cosmetic List & PyObject handling 2020-05-16 07:42:45 -04:00
wandererfan
a3029fec74 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
wandererfan
26ea08e8c5 [TD]Fix handling of CL flip parameter 2020-03-21 09:40:22 -04:00
wandererfan
cb2a3d529c [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00
wmayer
f23188a99e TechDraw: [skip ci] fix 'copy-constructor' of CenterLine 2019-12-17 12:41:14 +01:00
wandererfan
8cbcd243e6 [TD]Py routines for CenterLines 2019-12-16 20:36:10 -05:00
wandererfan
b54212f82c [TD]Python routines and extension for line formating 2019-12-16 20:36:10 -05:00
wandererfan
f63cd9255a [TD]Python routines & extension for CosmeticVertex 2019-12-16 20:36:10 -05:00
wandererfan
e64929de14 [TD]const-ness for dump function parameter 2019-11-10 15:58:45 -05:00
wandererfan
a7c491e639 [TD]Fix wrong default for parameter 2019-11-07 16:59:10 -05:00
wandererfan
44b1f46858 [TD]Allow skip restore cosmetics
- temporary work around due to format changes during v019
  devl
2019-11-06 20:31:02 -05:00
wandererfan
cf94e56905 [TD]Save geometry and tag with centerline 2019-11-06 20:31:02 -05:00
wandererfan
f539a0ea8c [TD]use UUID for CosmeticEdges instead of indices 2019-11-06 20:31:02 -05:00
wandererfan
b34eb9de77 [TD]Implement unique tags for Cosmetic Vertex 2019-11-02 14:59:32 -04:00
wandererfan
88b07896e6 [TD]Extent Dimensions 2019-11-02 14:59:32 -04:00
wandererfan
ffcafaf1a5 [TD]Add uuid tags for cosmetics 2019-08-22 17:11:55 -04:00
wmayer
a79ce8d823 add missing std:: namespace to build on Debian 10 2019-08-21 23:56:46 +02:00
wandererfan
ee3abc840b [TD]Fix crash on same end points 2019-07-19 20:17:20 -04:00
wandererfan
cb10b651ea [TD]Py functions for CenterLines and formatting 2019-07-19 20:17:20 -04:00
wandererfan
a4577a1e5b [TD]Edge and Vertex center lines 2019-07-15 12:36:48 -04:00
wandererfan
23658da79a [TD] Fix Centerline position 2019-07-15 12:36:48 -04:00
wandererfan
9828655f48 [TD]Add Properties for Cosmetic persistence 2019-07-15 12:36:48 -04:00
wandererfan
b4edc9e227 [TD]Add line appearance editor 2019-07-15 12:36:48 -04:00
wandererfan
5d601c1cdd [TD]Add CenterLine edit function 2019-07-15 12:36:48 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
5eb7145d97 Cosmetic CL for Section and Detail 2019-06-06 19:58:15 -04:00
wandererfan
4a2720cf51 Initial version of Cosmetic Eraser 2019-06-06 19:58:15 -04:00
wandererfan
07e26d3624 Initial working version Face Centerline 2019-06-06 19:58:15 -04:00
wmayer
c7334dc875 fix warning C4930: prototyped function not called 2019-05-25 13:07:33 +02:00
wmayer
fe3b75683f move includes to repsect PCH option 2019-05-25 13:04:57 +02:00
wandererfan
108038df91 Add Midpoint and Quadrant Cosmetic Vertex 2019-05-24 19:38:02 -04:00
wandererfan
3f7570ad80 Initial version addCosmeticVertex 2019-05-24 19:38:02 -04:00