Commit Graph

5383 Commits

Author SHA1 Message Date
Stefan Tröger
97a51686c7 PartDesign: Adopt primitive preview
The preview was developed when the "one feature only" visibility rule was not yet introduced. This commit maks it work again.
2016-04-12 18:12:23 +02:00
Stefan Tröger
303578efc6 PartDesign: Fix attachment external references 2016-04-12 18:12:23 +02:00
Stefan Tröger
3e79c09d10 Fix rebase error 2016-04-12 18:12:23 +02:00
Stefan Tröger
ced37e29c1 Fix Windows build errors 2016-04-12 18:12:23 +02:00
Stefan Tröger
103ed524f5 PartDesign: Unify datum and shapebuilder visuals 2016-04-12 18:12:23 +02:00
Stefan Tröger
6fa3b94ff1 Override mode works with non-toplevel viewprovider
And adopt the part design body to handle the override mode correctly
2016-04-12 18:12:23 +02:00
Stefan Tröger
48b2bb86ab PartDesign: body is responsible for visuals
-Hide all visual properties of features when they are part of a body
-Propagate all body visual changes to features
-Separate display mode from body mode to enable setting display mode for both "tip" and "through" modes
-Use default visuals for body shape and only make "through" a new display mask mode for the children
2016-04-12 18:12:23 +02:00
Stefan Tröger
49489bfe62 Fix sketch positioning with part and body 2016-04-12 18:12:23 +02:00
Stefan Tröger
8cbf27dbd6 PartDesign: Fix context menus 2016-04-12 18:12:23 +02:00
Stefan Tröger
e64569aa2c PartDesign: prevent claiming features 2016-04-12 18:12:23 +02:00
Stefan Tröger
a6e885e867 Fix rebase error 2016-04-12 18:12:23 +02:00
Stefan Tröger
9ab137f3c9 PartDesign: prevent crash on delete and add body 2016-04-12 18:12:23 +02:00
Stefan Tröger
815a8e4d30 Remove ShapeBinder2D
As profile based features can work with faces and wires now ShapeBinder can do everything that needed ShapeBinder2D before.
2016-04-12 18:12:23 +02:00
Stefan Tröger
47985c4fc7 Fix workflow manager crash on windows 2016-04-12 18:12:23 +02:00
Stefan Tröger
12e793bde8 PartDesign: Adopt pattern to face based features 2016-04-12 18:12:22 +02:00
Stefan Tröger
ae9dac71d7 PartDesign: Modeling features work with faces
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
2016-04-12 18:12:22 +02:00
Stefan Tröger
7e97cdaafe Datums not selectable during edit 2016-04-12 18:12:22 +02:00
Stefan Tröger
463070b1f6 Fix crash on aborted pattern external axis 2016-04-12 18:12:22 +02:00
Stefan Tröger
3c39410002 PartDesign: Adopt to new property status bits 2016-04-12 18:12:22 +02:00
Stefan Tröger
c027277128 no body allowed as body base feature 2016-04-12 18:12:22 +02:00
Stefan Tröger
063ffd8700 ShapeBinder: fix Null shape on recompute for copy 2016-04-12 18:12:22 +02:00
Stefan Tröger
a924d723c5 Fix shape binder placement
-- hidden for user
-- inherited by linked part
2016-04-12 18:12:22 +02:00
Stefan Tröger
73ab046ad6 Ensure only a single PartDesign feature is visible 2016-04-12 18:12:22 +02:00
Stefan Tröger
f392ed30d2 PartDesign mirror must work with base planes 2016-04-12 18:12:22 +02:00
Stefan Tröger
6b7b2176fb Fix transform feature crash on apply
-Redundant "reset edit" and command commit removed
-Redundant apply call removed
2016-04-12 18:12:22 +02:00
Stefan Tröger
7609c6e8c1 Add missing files 2016-04-12 18:12:22 +02:00
Stefan Tröger
0d4e941b0a fix reference selection of origin features 2016-04-12 18:12:22 +02:00
Stefan Tröger
732834c6d8 Handle external references for revolution et all
The reference selection, used in multiple part design features, treated body external references not corectly.
2016-04-12 18:12:22 +02:00
Stefan Tröger
846aa8febe Fix shutdown crash with primitives in the document
and cleanup the header
2016-04-12 18:12:22 +02:00
Stefan Tröger
cf4964fa8b Prevent dressup crash due to multi command commit
the same functionality is provided by upstream accept functions
2016-04-12 18:12:21 +02:00
Stefan Tröger
252865d43f Active view may not be 3d viewer
When for example the spreadsheet is open and an recompute is issued, the active view is not the 3d viewer which leads to crash if used for scene graph calculations.
2016-04-12 18:12:21 +02:00
Alexander Golubev
e8b323ba20 PartDesignGui: small rework to sketch-based task parameters
This done mostly for thurther unification them with other task
parameters/dialogs.
2016-04-12 18:12:21 +02:00
Alexander Golubev
7d8fc476bd PartDesign/App: a small fix to offset constraint syntax for Pad and Pocket 2016-04-12 18:12:21 +02:00
Alexander Golubev
eaeba5686f Suppress a couple more warnings 2016-04-12 18:12:21 +02:00
Alexander Golubev
27667cf5e6 Fix warnings introduced in new PartDesign
Mostly unused wariables and compare of signed & unsigned
2016-04-12 18:12:21 +02:00
DeepSOIC
f143e08fad Fix problems with unlimited external geometry
Caused by recent changes by abdullah, which assumes there is external
geometry only if sketch has support.
http://forum.freecadweb.org/viewtopic.php?f=3&t=12746&p=102087#p102087
2016-04-12 18:12:21 +02:00
Stefan Tröger
1a748c4d51 Simplify the feature pick dialog
less options are easier to grasp for the user
2016-04-12 18:12:21 +02:00
Stefan Tröger
f058ae12e9 fix sketch classification for other body
hasObject does search recursive only in groups, but a body is not a group. Hence for sketches within a body this will always return false. Annother logic must be used to detect sketches in bodies.
2016-04-12 18:12:21 +02:00
Stefan Tröger
571e5d55d2 fix sketch selection in part design
validateSketch was faulty: as every sketch is valid (non is removed) it could happen that the returned number was >0 but the iterator firstValidSketch was NULL nontheless. The routine needed to be udated to make snese and the usage in prepareSketchbased together with it.
2016-04-12 18:12:21 +02:00
Stefan Tröger
ad5785654e add only a single reference copy 2016-04-12 18:12:21 +02:00
Stefan Tröger
fe5d8b957d Fix incorrect ShapeBinder recalculation 2016-04-12 18:12:21 +02:00
Stefan Tröger
932f976dd9 Ensure correct sketch placement calculation
As bodies are movable now they need to be taken into account for calculating the sketch placement.
2016-04-12 18:12:21 +02:00
Stefan Tröger
d878028c60 Fix sketch on face of other body or part
The shapebinder object reduces the number of faces to 1, hence the subshape to select is always Face1 and not the original face name
2016-04-12 18:12:21 +02:00
Stefan Tröger
3b43f2cdc5 fix body booleans 2016-04-12 18:12:20 +02:00
Stefan Tröger
f2ad7bde4b PartDesign/Gui: minor fix sWhatsThis of text 2016-04-12 18:12:20 +02:00
Stefan Tröger
08287504fa Fix crossreference handling 2016-04-12 18:12:20 +02:00
Stefan Tröger
a92746da22 crossreferences only with ctrl button and fix missing return value 2016-04-12 18:12:20 +02:00
DeepSOIC
b21950326c Sketcher: when refusing to link external, print why (in statusbar) 2016-04-12 18:12:20 +02:00
DeepSOIC
61dd847db1 Sketcher: allow referencing everything; add testing for circular references 2016-04-12 18:12:20 +02:00
Stefan Tröger
a8781fdacc handle independent copies more gracefully 2016-04-12 18:12:20 +02:00