kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
23,414 Commits 41 Branches 6 Tags
985f3510f5f53d59914ce1efe2ad40288f401723
Commit Graph

18270 Commits

Author SHA1 Message Date
Abdullah Tahiri
985f3510f5 Sketcher: Fix crash when creating an angle constrain on a line segment 
======================================================================

Most of these crashes come from previous code not checking for Constraint::GeoUndef.

Most of these crashes come from isBSpline(), any of the two overloads.

isBSpline is made to throw exception when null, which should prevent the crash while
creating a reportable error.
 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
70f85505d0 Sketcher: delete internal alignment geometry using new delGeometries function 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
117c63ad21 Part: Geometry - BSplineCurve - add IsRational member function 2020-12-19 11:58:54 +01:00
sliptonic
8e911b347c Merge pull request #4157 from sliptonic/bug/4466 
fixes 4466  Path Template Saving incorrect attributes
 2020-12-18 15:31:47 -06:00
wmayer
5aac143e66 PartDesign: [skip ci] fix Hole feature 
* by default ThreadDirection must be set read-only since Threaded by default is None
* use suitable values to initialize the class properties
 2020-12-18 21:18:41 +01:00
sliptonic
b2e993e97a Merge branch 'master' into bug/4466 2020-12-18 11:11:18 -06:00
sliptonic
5cea165a66 Merge pull request #4160 from mlampert/bugfix/issue-4500-segfault 
Path: Bugfix/issue 4500 segfault
 2020-12-18 11:03:42 -06:00
wmayer
1c897b7ba9 PartDesign: [skip ci] fix order of controls so that by pressing TAB always the next control gets focus 2020-12-18 17:04:27 +01:00
M G Berberich
055424342e cleanup of hole dialog 
* replaced widget with radiobuttons by button Group, to improve alignemt
  of DrillPointAngle with grid-layout

* made Thread Pitch/Angle/Cutoffs widgets wider
 2020-12-18 16:38:46 +01:00
wmayer
9be9abe476 PartDesign: [skip ci] fix layout of Drill point controls 2020-12-18 16:28:35 +01:00
Aapo
8462fc1842 [TD] Balloon, fix Origin and scale refresh bugs, make Balloon scale change more reasonable per UI click. 2020-12-18 12:45:34 +01:00
Aapo
3038633069 [TD] Balloon, fix EndTypeScale refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
f3bce14f29 [TD] Balloon, move property LineVisible to View tab and fix a refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
b41cf98583 [TD] Balloon, change ordering of the data properties to more logical. 2020-12-18 12:45:34 +01:00
Markus Lampert
72b70c52a1 Added provision for gcc peculiarities in unit tests 2020-12-17 23:11:02 -08:00
Markus Lampert
3b69d23571 Reuse existing QuantitySpinBox'es in order to avoid segfault on focus change. 2020-12-17 23:01:55 -08:00
Markus Lampert
c1549ba3a8 Allowing QuantitySpinBox to be reused for different attribute; using properties to get values to work around build differences. 2020-12-17 22:56:42 -08:00
Markus Lampert
d136394376 Rearranged BitTool shape update so dependent ops don't execute with invalid tool. 2020-12-17 20:27:42 -08:00
Markus Lampert
a5e992f700 Make BitShape read/writeable, so the tool can be edited when shared to a different system 2020-12-17 19:59:44 -08:00
Markus Lampert
3da82fa6af Hide document when loading a ToolBit. 2020-12-17 19:55:59 -08:00
Markus Lampert
7049c09448 Only update the shape if it has changed. 2020-12-17 19:14:44 -08:00
sliptonic
9ea837fd90 fixes 4466 2020-12-17 16:21:31 -06:00
Aapo
97e3947948 [TD] Make Dimension Tolerances respect the Prefs formatSpec when creating a Dimension. 2020-12-17 17:30:29 +01:00
wmayer
627fea4e22 PartDesign: [skip ci] make the spin box for the angle of the drill point wider 2020-12-17 17:10:42 +01:00
M G Berberich
249b3c3a1b make the hole-cut-type dropdown-box wider 
This drop-down box contains long names and did not use the space of
the dialog.
 2020-12-17 16:59:26 +01:00
Abdullah Tahiri
6c6f5e7fbf Sketch: Fix exception on redraw 
===============================

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=458293#p458293

Rationale:
In order to fix B-Spline pole dragging, the order was inverted.
This fixed the B-Spline pole dragging issue, but introduced a
draw before solve approach that is not consistent with the rest
of the Sketcher.

In my parallel development I had already identified this inconsistency,
switched the order, and provided a new mechanism to fix the issue with
the B-Spline pole dragging. This will be merged as part of another PR.

In the meantime, this PR restores the intended behaviour, and let us
identify if the particular reported exception also happens in other
situations.
 2020-12-16 19:35:42 +01:00
Abdullah Tahiri
51189caba4 Sketcher: Fix equality constraint command 
=========================================

For select constraint then click elements mode.

Fixes:
https://forum.freecadweb.org/viewtopic.php?f=10&t=51716&p=458207#p457974
 2020-12-16 15:21:21 +01:00
Abdullah Tahiri
e8674fc13d Sketcher: Fix crash on applying angle constraint on arc 
=======================================================

The GeoId passed was Constraint::GeoUndef (-2000).

Fixes:
https://forum.freecadweb.org/viewtopic.php?f=10&t=51716&p=458202#p458160
 2020-12-16 14:20:02 +01:00
Yorik van Havre
c158e640d2 Merge pull request #4025 from travisapple/master 
New WebGL Exporter
 2020-12-16 12:07:17 +01:00
wmayer
fc9be21345 Path: [skip ci] fix TooltablePy::getTools to avoid possible double destruction of a Tool instance 2020-12-16 10:34:24 +01:00
Yorik van Havre
e672aa26b4 Draft: Small layer improvements 
- Added 'Print Line Color' property
- Added 'Add new layer' context menu action to layers group
 2020-12-15 16:43:33 +01:00
Yorik van Havre
8e223cdf5d Draft: Small wording fix 2020-12-15 16:41:35 +01:00
Yorik van Havre
bc4856672f Draft: Small fixes to Draft SetStyle panel 2020-12-15 16:40:16 +01:00
sliptonic
b920bbf73a Merge pull request #4143 from mlampert/bugfix/vcarve-depth 
Path: Bugfix/vcarve depth
 2020-12-14 17:18:30 -06:00
travisapple
6d065963d3 Merge branch 'master' into master 2020-12-14 11:47:09 -08:00
sliptonic
07e2e8fcf3 Merge pull request #4141 from gauna85/PathToolcontroller 
Path: Added missing signal-connection causing spindle speed not to be updated using ToolControllerDlg Bug 4479
 2020-12-14 12:28:56 -06:00
sliptonic
3a07613137 Merge pull request #4136 from gauna85/PathEngrave 
[Path] Sort edges before splitting at selected vertex
 2020-12-14 12:27:54 -06:00
sliptonic
b6a83cbebf Merge pull request #4132 from gauna85/Path 
[Path] Check if startpoint is not lower than bounds in order to work always …
 2020-12-14 12:21:20 -06:00
wmayer
9b39c6784e Path: [skip ci] fix memory leak in TooltablePy::getTools() 
For some background information see: https://forum.freecadweb.org/viewtopic.php?f=15&t=50583&start=20#p457516
 2020-12-14 17:19:52 +01:00
Zheng, Lei
0a35cb5b01 Part: improve TopoShape::findPlane() 
Make the returned plane normal consistent with the underlying face
geometry.
 2020-12-14 16:04:40 +01:00
Yorik van Havre
c25ff3ac16 Draft: Hide undo button from modify operations 2020-12-14 15:21:25 +01:00
Yorik van Havre
0e556a082b Merge pull request #4121 from everlanes/TechDraw_Segfault 
[TD] Check return value of getMDIViewPage() a second time
 2020-12-14 12:43:28 +01:00
Yorik van Havre
fe721a1934 Merge pull request #4116 from chennes/fixAirfoilImportNumberRegex 
[Draft] Fix airfoil data detection regex
 2020-12-14 12:29:50 +01:00
Yorik van Havre
dd580a49ab Merge pull request #4115 from JAndersM/patch-1 
[Draft] Update task_scale.py
 2020-12-14 12:21:47 +01:00
Yorik van Havre
cbcf45a4b9 Merge pull request #4109 from donovaly/TD-dimensioning-fix 
[TD] treat dimensions the same way, no matter if with unit or not
 2020-12-14 12:08:46 +01:00
Yorik van Havre
115963d79e Merge pull request #4100 from marioalexis84/draft-upgrade 
Draft: Improve makeWires in upgrade function
 2020-12-14 11:59:21 +01:00
Yorik van Havre
46a6ea3351 Merge pull request #4069 from aapo-aapo/TD-Balloon-improvements 
[TD] TechDraw Balloon improvements with two new App::PropertyType properties
 2020-12-14 11:56:08 +01:00
Yorik van Havre
6e88f40886 Merge pull request #4137 from abdullahtahiriyo/_arc_fix 
[ARCH] Make ArchWall use Sketcher GeometryFacade
 2020-12-14 11:41:16 +01:00
Chris Hennes
50d97a3f24 Merge branch 'master' into fixAirfoilImportNumberRegex 2020-12-13 23:02:36 -06:00
Markus Lampert
ee92a1d2f9 Adding g0 to safety to base op so it's applied to all ops 2020-12-13 15:00:05 -08:00