kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
19,196 Commits 41 Branches 6 Tags
9870ec27b1813f5e1e7369778e9a3ef41b89f9c6
Commit Graph

43 Commits

Author SHA1 Message Date
carlopav
9870ec27b1 [Draft] Edit bugfix 
Fixed contemporary editing of Draft and Part objects.
Implemented better showTrackers and hideTrackers functions.
 2020-01-08 15:20:36 +01:00
carlopav
5a63ad51b1 [Draft] Edit cleanup 
Cleaned up imports a suggested by @vocx.
Also cleaned up various things inside the tool.
[Draft] Edit small change in imports


[Draft] Edit updated documentation
 2020-01-08 15:20:36 +01:00
carlopav
b189fd6450 [Draft] Edit: set shortcut to D,E 
Changed subelement highlight to S,E
[Draft] Edit bugfix


bugfix
 2020-01-08 15:20:36 +01:00
carlopav
7e50cc7c7a [Draft] Edit: context menu for Bezcurve editing 2020-01-08 15:20:36 +01:00
carlopav
d3b9aeb7f6 [Draft] Edit bugfix 
traker was not updated if endEditing function was called by numericInput
 2020-01-08 15:20:36 +01:00
carlopav
e238a4b9fc [Draft] Context menu for EditTrackers 
Initial support for context menu.
Menu is triggered by Alt+Click or by pressin E Key.
Menu is customized on the clicked object.
Supported functions ATM: addPoint, deletePoint.
 2020-01-08 15:20:36 +01:00
carlopav
100dd0bfcc [Draft] Edit, changed endEdit 
Before behaviour when user click and when user input coordinates:
1- mousePressed -> endEditing -> numericInput -> update
2- numericInput -> update
Now:
1- mousePressed -> endEditing -> update
2- numericInput -> endEditing -> update
 2019-12-28 15:59:26 -03:00
carlopav
af8671caa2 [Draft] Edit Documentation 
Documented better the whole tool.
Changed the name of self.call to self. selection_callback for easier code reading.
[Draft] Edit small bugfix

Deleted a bunch of code I PR by error
 2019-12-28 15:59:26 -03:00
luz.paz
8cfa85cf18 Draft: [skip ci] Fix header uniformity 
This PR fixes header uniformity across all Draft files
 2019-12-27 00:16:12 +01:00
carlopav
b14dca0918 [Draft] Edit further cleanup 
[Draft] Edit fix minor bug
 2019-12-26 13:31:06 -03:00
carlopav
6ab4a8a202 [Draft] Edit _ code cleanup 
According to @vocx_fc suggestions, this commit is a first cleanup of the code.
 2019-12-26 13:31:06 -03:00
carlopav
81862dd280 [Draft] Edit: improved Draft Circle editing 
Now Draft circle editing works also with App::Part
 2019-12-26 13:31:06 -03:00
carlopav
64314e557a [Draft] Edit _ improved rectangle editing 
Improved rectangle editing to use 3 nodes. Now it works also inside App::Part
 2019-12-26 13:31:06 -03:00
carlopav
7042446504 [Draft] Edit: general refactor 
Changed names of several methods from set to get, changed the general set of nodes, improved placement calculation to use getGlobalPlacement instead of Placement.
 2019-12-26 13:31:06 -03:00
carlopav
54f59edff1 [Draft] Edit: allow multiple objects editing 
Allow editing of multiple objects at once.
 2019-11-11 18:00:02 -03:00
carlopav
e3d8da2cf1 [Draft] Edit: fix bug #4187 
Fix bug #4187. When canceling a Dwire editing session with the Esc key or the "close" button Dwire editing breaks.
 2019-11-11 17:59:08 -03:00
luz.paz
690209ae5a Draft: whitespace fix [skip-ci] 2019-10-25 10:25:31 -03:00
luz.paz
ef95ac7d46 Draft: DraftEdit.py use string operator instead of numeric LGTM fix [skip ci] 2019-10-25 10:25:31 -03:00
carlopav
5783027945 [Draft] Edit: pick radius according to user preferences (issue #4162) 
Reference tracker issue #4162 https://freecadweb.org/tracker/view.php?id=4162
Reference topic. https://forum.freecadweb.org/viewtopic.php?f=23&t=40060.
Changed ui file to insert edit preferences (at the moment inside draft and grid, for the affinity with snap). Created a new draft preference: DraftEditPickRadius.
 2019-10-21 16:00:36 -03:00
carlopav
f3a4dda5b3 [Draft] Edit: preview node with mouseover 
Preview editing nodes with mouse move.
Modified edit trackers to store in self.color the value. Also added a method to it to set color.
 2019-10-17 17:43:57 -03:00
luz.paz
daf96d29fd Draft: DraftEdit.py now gets PickRadius from user preferences 
...instead of being hardcoded.  
Note: PickRadius is the proximity in pixels for picking elements in the 3D view  
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=39203
 2019-09-28 12:49:33 +02:00
luz.paz
7af7c10cf1 Fix misc. typos, whitespace, and http:// to https:// issues 2019-09-03 11:11:43 -03:00
carlopav
6b693ebcb4 [Draft] Edit by default one object at once 
Small optimization and set max number of edited objects to 1
 2019-09-02 16:13:08 -03:00
carlopav
d7ece2d1d8 [Draft] Edit: Allow multi object editing 
Modified to accept multiple object (max 5). The tool set EditTrackers for every selected object. Then edited object is identified using clicked EditTracker.
 2019-09-02 16:13:08 -03:00
carlopav
cd3c649146 Allow for multiple object trackers + 1 line sketch edit 
self.trakers is changed from list to dictionary. It now stores EditTrackers with {'object':[pointlist]}. Initial implementation is to allow editing wall height and wall base object.
 2019-09-02 16:13:08 -03:00
carlopav
46e5a4c1f2 [Draft] Edit: Refactored object selection + bug on wall editing 
Draft edit now get the editing object from data stored inside the EditTracker. This is the first step towards implementation of multi object editing.
 2019-09-02 16:13:08 -03:00
carlopav
8ad88c75f2 [Draft] Edit: fixed bug with dimensions 
Update function always receive global vector as target of the transformation.
 2019-09-02 16:13:08 -03:00
carlopav
5aeadc5175 [Draft] Edit: use lineui instead of pointui 
use lineui for editing instead of pointUi and minor documentation changes
 2019-09-02 16:13:08 -03:00
carlopav
54e327ba9b [Draft] Edit: separate selectstate functions 
Separated functions that save, restore and set the select state of edited object from main functions.
 2019-09-02 16:13:08 -03:00
carlopav
b57132d53d Draft Edit: enable Part::Line editing 
Implemented editing part lines. Preview still to come.
 2019-08-20 10:29:50 -03:00
carlopav
ed021a042c Draft Edit: enable editing Part::Box 
Added code to handle editing of part objects, ATM only for Part::Box
 2019-08-20 10:29:50 -03:00
carlopav
4383652ff4 Draft Edit: bugfix when Draft is activated without document 
Fixed bug when Draft is activated but no document is active
 2019-08-20 10:29:50 -03:00
carlopav
644c2bae46 [Draft] Small bugfix in bezcurve editing 
Solved bug when clicking on empty space while editing continuity.
 2019-08-20 10:29:50 -03:00
carlopav
5e24782f40 [Draft] Draft Edit: completed subcommand key event 
Completed subcommand key edit
 2019-08-20 10:29:50 -03:00
carlopav
ef8ce0a820 [Draft] Draft Edit - various fixes (fixes #3537) 
https://forum.freecadweb.org/viewtopic.php?f=3&t=29743&start=70
To solve issue with Hidpi display  (fixes #3537), but also to improve node selection, I used some of @looo code from pivy graphics into the tool. 
So:
- i got rid of the action function
- i separated selection and editing callbacks
- i got the mouse position from the callback event and not from FreeCADGui.ActiveDocument.ActiveView.getCursorPos()
- i rewrote the node selection mechanism using soraypickaction instead of getObjectInfo() and getObjectsInfo()
- i tried to put a bit of order in all the mess i made and try to document it.
- also fixed some of the preview code.
- i'm really really sorry for not being able to split the commit in multiple one, but the changes are huge and i was just able to separate minor things...
 2019-08-20 10:29:50 -03:00
Yorik van Havre
4d3f24a5b8 Draft: Reorganizing DraftEdit and future Draft command modules 2019-08-12 21:30:45 -03:00
luz.paz
ba9d945308 [Draft] source comment typo fix 2019-07-11 19:17:07 +02:00
Yorik van Havre
993e0d5032 Arch/Draft: Fixed remaining bugs from latest commits 2019-07-09 15:07:00 -03:00
Yorik van Havre
0b0fc6c3cf Draft: Fixed bug in edit mode - Fixes #4047 2019-07-08 18:28:41 -03:00
carlopav
37b9cb67c9 [Draft] Edit: Fix bug in Bezcurve editing preview 
Better handling of coincident point check.
 2019-07-02 20:02:43 -03:00
carlopav
630f0ba906 [Draft] Fixed a bug in arc editing and added preview 
Fixed a bug so arc editing take correctly the placement into account.
Added preliminary support for preview during arc editing. To be improved in the future.
 2019-06-27 11:50:45 -03:00
carlopav
4ee893b78a [Draft] Update DraftEdit PR with Yorik suggestions 
Cleanings of import at the beginning of new module.
Moved command setup in InitGui and removed import DraftEdit from DraftTools.
 2019-06-17 16:39:56 -03:00
carlopav
555d04c221 Separate Draft Edit 
My last attempt to separate draft edit. Everything seems to work fine.
 2019-06-17 16:39:56 -03:00