Commit Graph

24012 Commits

Author SHA1 Message Date
luz paz
98d29647e6 [Arch] fix header uniformity
Make uniforum all Arch headers
2022-11-18 20:22:24 +01:00
Bernd Hahnebach
f0b151dc09 FEM: gmsh binary location on osx, add comment 2022-11-18 12:05:36 +01:00
Bernd Hahnebach
c0a45ec61e FEM: add standard path for gmsh on osx 2022-11-18 12:02:22 +01:00
wmayer
5adcfd1dd4 Arch: replace tabs with spaces 2022-11-18 11:47:17 +01:00
0penBrain
862c092c0b Sketcher: disable auto-constraint in Copy/Clone/Move commands 2022-11-18 08:18:58 +01:00
0penBrain
f6884b307c Sketcher: Clone: do not apply parallel constraint if angle constraint is applied on arc 2022-11-18 08:18:58 +01:00
Aapo
2e19e5f6fb [TD] DrawViewPart: Fix Dimension attachment on Cosmetic CenterLines upon document restore 2022-11-17 19:25:43 -05:00
luz paz
7a8a453746 Path: remove trailing whitespace 2022-11-18 00:01:25 +01:00
luz paz
875f9eaad6 Sketcher: remove trailing whitespace 2022-11-17 23:56:13 +01:00
luz paz
dc5b3cb495 Arch: remove trailing whitespace 2022-11-17 23:54:03 +01:00
sliptonic
c8074a972e Merge pull request #7759 from LarryWoestman/staging
Path:  Changes for Path refactoring to fix regressions.
2022-11-16 18:09:38 -06:00
Ajinkya Dahale
249ee72333 [Sketcher][planegcs] Make changes as per comments on #7484
Comments by @abdullahtahiriyo.

Remove default values and smaller constructor for `CenterOfGravity` and
`WeightedLinearCombination` constraints.

Clarify comments.

Improve readability of `CenterOfGravity` and `WeightedLinearCombination`
constraints.
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
2537ea883f [Sketcher][planegcs] Set knot constraint as internal alignment 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
19810fac2a [Sketcher] Do not make knots construction points 2022-11-16 15:35:37 +01:00
Ajinkya Dahale
430b0baa00 [Sketcher] Stop treating knots as fixed in GUI commands
This stops constraints from becoming non-driving when not set.

Follow 0penbrain's comments

typo
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
7cd2cbd29c [Sketcher] Constrain B-spline knots as linear combination of poles
Also squashes:

[Sketcher] Create center of gravity constraint in planegcs

[Sketcher] typo

[Sketcher] Use accurate "weights" for knots

By weights we mean the linear combination factor B_i(x) such that
spline(x) = sum(pole_i * B_i(x)) for _non-rational_ splines.

[Sketcher] Use more appropriate weights for knots

These are relevant for knots _away_ from any ends (and possibly other high
multiplicity knots).

[Sketcher] Make COG constraint weights user-definable

[Sketcher] Make `flattenedknots` for periodic B-Splines

[Sketcher] Fix incorrect setup of `flattenedknots`

Without ensuring enough space, iterators become invalid. These iterators are
needed because for periodic B-splines we need to pad flattenedknots with offset
values within flattenedknots.

Apparently there is still some iterator issues even after the reserve. Just use
fresh vectors instead.

[Sketcher] Apply knot constraints by parameter

Hopefully this will allow directly applying constraints on knots.

[Sketcher] Disable some knot updating

[Sketcher] Use center of gravity constraint on knots

[Sketcher] Fix knot COG constraint for periodic splines

[Sketcher] Add start/end point of periodic spline to solver

This removes the trouble of transferring constraints to the underlying knot.

[Sketcher] Support knot constraints on rational B-splines

[Sketcher] Remove virtual from overridden methods in planegcs

Follow 0penbrain's comments

[Sketcher][planegcs] Use `unsigned int` in signatures

Also `size_t` at places

Suggestions by @abdullahtahiriyo
2022-11-16 15:35:37 +01:00
Ajinkya Dahale
027504ce16 [Sketcher] Reformat some if-else for readability
Weren't folding right in spacemacs.
This commit can be omitted if undesired.
2022-11-16 15:35:37 +01:00
wandererfan
4f96b1bf60 [TD]fix alignment of section line marks on rotated base view 2022-11-16 08:56:00 -05:00
0penBrain
e3cd132af7 [Typo]Sketcher: 'Clone' is the first command of CompCopy, match the tooltip 2022-11-16 14:48:39 +01:00
Yorik van Havre
e1aa6f58e3 Merge pull request #7526 from paullee0/ArchWall_15_UseAndCreate-ArchSketch-If-Present
[ArchWall]  Use and Create ArchSketch if add-on is present
2022-11-16 11:08:11 +01:00
Yorik van Havre
f6b70cce41 Merge pull request #7786 from Roy-043/Draft-housekeeping-rename-snap-icons
Draft: housekeeping: rename snap icons
2022-11-16 09:58:47 +01:00
wmayer
9e9c784041 TD: fix memory leaks with raw pointers of GeometryObject
Replacing the use of raw pointers of GeometryObject with shared pointers fixes the observed memory leaks when running the unit tests of TechDraw
2022-11-15 16:16:08 -05:00
luz paz
6e542b6fad Part: remove trailing whitespace 2022-11-15 14:19:30 -06:00
luz paz
b389f6e602 TechDraw: remove trailing whitespace 2022-11-15 16:17:22 +01:00
luz paz
57d0c2000a MeshPart: remove trailing whitespace 2022-11-15 12:45:52 +01:00
luz paz
390e09db32 Mesh: remove trailing whitespace 2022-11-14 21:37:03 -06:00
wandererfan
0c83a17ce8 [TD]prevent Complex Section with no Base View 2022-11-14 19:41:12 -05:00
wandererfan
26d7fe14e1 [TD]add section line marks for simple section 2022-11-14 19:41:12 -05:00
marioalexis
93133040e8 TechDraw: Improve and clean up code in some Python classes 2022-11-14 16:40:07 -05:00
wandererfan
53f5883ea1 [TD]fix handling of multiple pages
- the routines for retrieving a view's parent page
  did not correctly deal with duplicate page entries
2022-11-14 16:38:27 -05:00
wandererfan
075cbb64f0 [Measurement]apply globalPlacement to geometry 2022-11-14 16:38:06 -05:00
wmayer
de04434d1f Test: [skip ci] add method clear() to document observers 2022-11-14 19:53:35 +01:00
Paddle
f9ba739e70 Sketcher: Coincidence constraint: fix error introduced by concentric capability. 2022-11-14 17:39:09 +01:00
wmayer
fce59ca723 Sketcher: fix clazy warnings:
* Wclazy-connect-by-name
* Wclazy-unused-non-trivial-variable
* Wclazy-detaching-temporary
2022-11-13 15:39:27 +01:00
Paddle
0a5358c24f Sketcher: Fix element widget repaint delay bug
Related to https://github.com/FreeCAD/FreeCAD/pull/7567#issuecomment-1304724547
2022-11-13 07:13:06 +01:00
wandererfan
2a6bd73fc0 [TD]apply review comments from @chennes
- also delete empty execute method
2022-11-12 11:35:22 -05:00
wandererfan
fe4a402b04 [TD]simplify section hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
3ce218d1d7 [TD]simplify embedded image handling 2022-11-12 11:35:22 -05:00
wandererfan
199fd11623 [TD]simplify embedded file handling 2022-11-12 11:35:22 -05:00
wandererfan
75e163213a [TD]simplify embedded hatch file handling 2022-11-12 11:35:22 -05:00
wandererfan
9c9013810e [TD]fix embedded template file handling 2022-11-12 11:35:22 -05:00
Chris Hennes
eed9b6480f Addon Manager: Refactor to extract metadata checker 2022-11-11 21:50:16 -06:00
wandererfan
d7ace29c75 [TD]fix vertical alignment of section pieces 2022-11-11 19:37:42 -05:00
Roy-043
e920410607 Draft: housekeeping: rename snap icons 2022-11-11 17:33:09 +01:00
wandererfan
a4fbb2d802 [TD]Section dialog gui tweaks 2022-11-11 08:53:29 -05:00
Uwe
dbff8faef6 [Mesh] Feature*: remove unused includes
- also some sorting
2022-11-11 14:02:49 +01:00
Chris Hennes
33f671c6c1 Addon Manager: Ensure check message closes 2022-11-10 21:35:46 -06:00
Chris Hennes
103f8b77bf Addon Manager: Refactor to extract connection check GUI 2022-11-10 21:09:47 -06:00
Uwe
8f2720b8b7 [Path] PathSimulator: remove unused includes
- also some sorting
2022-11-11 04:04:33 +01:00
Uwe
7e7b046041 [Mesh] Imp* - end: remove unused includes
- also some sorting
2022-11-11 03:34:31 +01:00