kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
23,984 Commits 41 Branches 6 Tags
9d343219b0f3988705ffaa887ca5bd8e1f9ff3a6
Commit Graph

316 Commits

Author SHA1 Message Date
luz paz
9b440f9b26 LGTM: remove redundant variable assignment 
ref: ddeaa48851/files/src/Mod/Spreadsheet/App/Spreadsheet_legacy.py (x687bc63f783c60bd):1
 2021-02-07 13:42:55 +01:00
Yorik van Havre
321fd7c840 Merge pull request #4215 from hyarion/feature-spreadsheet-equal-prefix-for-expressions 
[Spreadsheet] Only evaluate cell values when prefixed with '='
 2021-02-05 13:29:57 +01:00
Benjamin Nauck
51f8ea11d9 Spreadsheet: Add test for undo alias issue 2021-01-30 14:04:57 +01:00
Benjamin Nauck
aa91457491 Spreadsheet: Allow alias removed by undo to be reused 
Fixes issue descripted in the forum post:
https://forum.freecadweb.org/viewtopic.php?f=3&t=54009
 2021-01-30 14:04:57 +01:00
Benjamin Nauck
8589c4e782 Spreadsheet: make setContent use unique_ptr and cleanup 
Make `Cell::setContent` use `unique_ptr` and
`make_unique` for expressions to avoid potential memory
leaks.
Also renames `expo` to `newExpr` to avoid mixup with the
member variable `expression`.

Both changes was made at the request of @chennes.
 2021-01-20 18:55:27 +01:00
Benjamin Nauck
991e8bfb2b [Spreadsheet] Add unit tests for new input behaviour 2021-01-20 18:55:27 +01:00
Benjamin Nauck
7fdbd87b13 [Spreadsheet] Only evaluate cell values when prefixed with '=' 
This commit only changes the user interaction with spreadsheet and does
not affect backwards compatibility (as valid cell expressions are
prefixed with '=' when serialized).

This fixes [#4156](https://tracker.freecadweb.org/view.php?id=4156),
which is discussed in the forum thread:
https://forum.freecadweb.org/viewtopic.php?f=3&t=39665

There has been additional logic added to handle numbers and simple
fractions without using '='.
The behaviour is what is expected by the spreadsheet test cases
and in line with how other spreadsheet software works.
The '-prefix can still be used to force the input to be handled as
as string instead.

Example of numbers and fractions handled are:
  3
  2mm
  1/8
  1mm/2
  1/2mm
  2/m
  1mm/2s

More complex expressions are not handled without '=' and will be stored
as strings instead, for example:
  2 / 3 / 2
  1 + 1/3
 2021-01-20 18:55:27 +01:00
Benjamin Nauck
b690a69973 [Spreadsheet] Remove alias from dynamic properties on removeRows/Columns 
When removing a row in a spreadsheet which has an assigned alias, the
alias will not be removed from the list of dynamic properties.

This makes it impossible to create a new alias which uses the same name
even if the original was removed (using removeRows/removeColumns)

Fixes #4492
 2021-01-04 22:10:58 +01:00
Yorik van Havre
22f7d5f3bc Merged crowdin translations 2020-12-23 15:13:05 +01:00
Yorik van Havre
16effcb2af Updated ts files 2020-12-23 14:51:04 +01:00
luz paz
786d84d288 Spreadsheet: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the Spreadsheet Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
luz paz
abf4c92280 Spreadsheet: Fix header uniformity + trailing whitespace 
[skip ci]
 2020-11-27 19:39:06 +01:00
Yorik van Havre
ae2c707892 Merged crowdin translations 2020-11-10 14:58:06 +01:00
luz paz
068997112c Spreadsheet: Make all file headers uniform [skip-ci] 2020-11-03 14:52:53 +01:00
Yorik van Havre
43596a68af Merged crowdin translations 2020-10-28 12:04:37 +01:00
Yorik van Havre
c2cec2c38a Merged crowdin translations 2020-09-30 14:37:02 +02:00
Cheuksan Wang
a178990acb Move the aliases before other content of cells 
When a user performs insert rows, remove rows, insert columns, or
remove rows, we need to move multiple cells as a batch. The cells are
moved sequentially. For each cell, its dependent alias positions are
looked up and dependencies are added.  However, those cells with
aliases may be moved later in the batch. Thus the earlier dependencies
become wrong. This commit fixes this bug by moving all the aliases
before moving the cells. Unit tests are added to for this bug.

fixes issue #4429
 2020-09-13 11:58:54 +02:00
wmayer
1291e910f1 Spreadsheet: [skip ci] disable unused function 2020-09-09 21:18:31 +02:00
wmayer
698777b213 Spreadsheet: [skip ci] use global scheme to display quantities in a spreadsheet table 2020-09-09 16:28:55 +02:00
luz paz
f0d823eb51 Crowdin: Merge new translations [skip-ci] 2020-08-07 17:17:35 +02:00
wmayer
0a6929a122 Coverity: Dereference after null check 2020-07-20 17:34:25 +02:00
wmayer
bd58cfe81a PVS: V506 Pointer to local variable '_value' is stored outside the scope of this variable. Such a pointer will become invalid. 2020-07-18 10:59:28 +02:00
wmayer
6c94ed51ab PVS: V690 The copy constructor is declared as private in the 'PropertySheet' class, but the default copy assignment operator will still be generated by compiler. It is dangerous to use such a class. 2020-07-18 10:59:28 +02:00
luz paz
e4f6689e0a Merged crowdin translations 2020-07-13 14:49:45 +02:00
Yorik van Havre
da262c0b45 Updated master ts files 2020-07-13 13:20:21 +02:00
Tobias Bossert
a7fb422f6d fixed xlsx import issue, now compatible with python 2.x and 3.x 2020-07-06 16:28:17 +02:00
Tobias Bossert
dd7563b5dc Fixed import from XLSX files 
since getText() already returns a string, the encode() function results in a byte object which is not compatible with setAlias().
 2020-07-06 16:28:17 +02:00
wmayer
dc551e1fb0 Spreadsheet: [skip ci] avoid to show scroll buttons in PropertiesDialog when a style sheet is used 2020-06-28 18:24:16 +02:00
donovaly
37c4c90ab0 [Spreadsheet] add visible alias check 
as discussed in https://forum.freecadweb.org/viewtopic.php?p=408992#p408981
visible feedback is missing for the Alias field. This PR add it and also adapts the UI label style.
 2020-06-19 12:17:04 +02:00
wmayer
d6169d6478 boost: fix for boost < 1.60 2020-06-15 19:38:39 +02:00
wmayer
cff0638672 Qt5: QDesktopWidget is deprecated use QScreen [-Wdeprecated-declarations] 2020-06-12 17:51:33 +02:00
wmayer
730154a684 boost 1.73.0: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated 2020-06-12 17:51:33 +02:00
wmayer
7b72dcb062 Qt5: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations] 2020-06-12 17:51:33 +02:00
Yorik van Havre
141764e64f Merged crowdin translations 2020-04-29 16:08:23 +02:00
Yorik van Havre
7003b3f747 Updated source ts files 2020-04-29 15:41:26 +02:00
wmayer
8e05325137 Spreadsheet: [skip ci] add generated Imp files to repository to avoid possible build failures 2020-04-16 12:24:38 +02:00
luz.paz
4acdf2613d [skip-ci] Various typo fixes 
Found via codespell  v1.17.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-04-07 18:17:03 +02:00
wmayer
e14e5b845e [skip ci] use QLocale class consistently to make it possible to change it application-wide 2020-03-26 16:37:45 +01:00
mwganson
4643e3b170 [Spreadsheet] [skip ci] fix bug where aliases renamed in the spreadsheet were not getting renamed in sketcher constraints 2020-03-22 15:20:53 +01:00
mwganson
938dd27cae [Spreadsheet] fix tooltip to show newline instead of \n characters 2020-03-13 15:40:30 +01:00
mwganson
f6f80256c8 [Spreadsheet] add tooltip for alias line edit. Also, per user request, make it so when creating a new spreadsheet it is open for viewing/editing 2020-03-13 15:40:30 +01:00
mwganson
e2e0018df6 [Spreadsheet] fix minor bug where failure to set alias message appears erroneously. Fixes #4287 2020-03-13 15:40:30 +01:00
mwganson
2609ec5441 [Spreadsheet] fix bug where duplicate / bad aliases were being allowed. 2020-03-12 15:47:54 +01:00
mwganson
54549d0931 [Spreadsheet] add alias line edit next to contents line edit -- add back in some inadvertently removed code 2020-03-12 15:47:54 +01:00
mwganson
77114fa942 [Spreadsheet] add alias line edit next to contents line edit 2020-03-12 15:47:54 +01:00
Yorik van Havre
8933e8ed38 Merged latest translations from crowdin 2020-03-05 11:58:03 -03:00
donovaly
24ec114cb8 remove program-specific SVG namespaces 
while fixing a SVG export issue for techDraw I noticed that some SVG files have program-dependent (and thus not clean) code in it. These are traces of the programs Sodipodi and Inkscape, like e.g. this line:
inkscape:export-filename="/home/yorik/PartDesign_Groove.png

This is unnecessary and FC should not use program-dependent code in the SVG but use instead plain SVG strictly following the SVG specification.

This PR transforms the few affected SVGs to a plain version.
 2020-02-07 07:34:49 -05:00
wmayer
abb258855a Spreadsheet: [skip ci] fix regression when pressing Return/Enter when completion list is shown 2020-01-01 10:43:12 +01:00
wmayer
fef75daca7 Spreadsheet: [skip ci] fix inconsistent German translation 2019-12-31 17:37:49 +01:00
Zheng, Lei
9d66dbbbbf App: fix Expression _moveCells() 
The problem is caused by not refreshing ObjectIdentifier internal cache
after change.
 2019-12-31 15:23:03 +01:00