Commit Graph

1154 Commits

Author SHA1 Message Date
bgbsww
9f2210313d Toponaming: Tests, cleanup, and fix axis drawing 2024-07-26 11:49:56 -04:00
Zheng, Lei
77f181a307 Toponaming: Transfer in ExportGeo and associated 2024-07-26 11:49:56 -04:00
Chris Hennes
1b4afb2caa Apply suggestions from code review 2024-07-24 21:48:59 -05:00
bgbsww
1eda66dfd8 Cleanup, format 2024-07-24 16:41:15 -04:00
Zheng, Lei
38269241e6 Toponaming: Transfer in getHigherElement 2024-07-24 15:10:42 -04:00
Zheng, Lei
a600952665 Toponaming: Transfer in SketchObject::InternalShape 2024-07-22 17:26:52 -04:00
bgbsww
19e450a667 Refactor all element name pairs into clearer struct names - renames 2024-07-20 16:32:12 -04:00
bgbsww
16b8d99d62 Toponaming: refactor getExportElementName to separate method 2024-07-19 10:19:57 -04:00
bgbsww
52294ce8c1 Toponaming: Clean Code adding RefIndex to ExternalGeometry and supporting new migration types. 2024-07-19 09:39:19 -04:00
Zheng, Lei
31e2b3104c Transfer in code from linkstage3 2024-07-19 09:22:17 -04:00
Chris Hennes
df8315d747 Sketcher: Fix crash on recompute with points
Fixes #15154.
2024-07-17 10:25:22 -04:00
Pesc0
02b2092f55 Rename variables and clean method 2024-07-15 12:50:30 -04:00
Zheng, Lei
af080ef0fe Toponaming: Missing getSubObject code in PartDesign::Body and SketchObject::getSubObject 2024-07-15 11:59:15 -04:00
PaddleStroke
b82ecb815f Sketcher: Fix undo of external creation not working. 2024-07-12 09:41:55 -05:00
bgbsww
a74b7b83b5 Toponaming: Comment out console warnings triggered by external geometry 2024-07-09 08:55:21 -05:00
Max Wilfinger
8ff5a1f688 Fix source string typos mentioned on Crowdin (#15261) 2024-07-08 17:18:31 -05:00
wmayer
cbfd9f0d7e Sketcher: Fix format string in ExternalGeometryFacade::initExtensions()
The format string of the warnings were incorrect and caused an fmt::format_error exception
2024-07-04 22:05:22 +02:00
Chris Hennes
e371f7fb43 Merge pull request #14461 from AjinkyaDahale/sk-fix-12592-bsp-by-knot-trim
[Part][Sketcher] Fix some B-spline trimming issues
2024-07-01 11:28:50 -05:00
bgbsww
bdcdb630c0 Cleanup 2024-06-28 22:24:30 -04:00
pre-commit-ci[bot]
3d6a490003 Review cleanups 2024-06-28 11:57:43 -05:00
bgbsww
08859462ea Toponaming: Cleanups 2024-06-28 11:57:43 -05:00
Zheng, Lei
3dbc1d7393 Toponaming: Transfer in missing Code for BaseFeatures and Sketches 2024-06-28 11:57:43 -05:00
Ajinkya Dahale
bf649e2419 [Sketcher] Delete point-on-object on trimmed portion
This could cause undesirable shape change, especially in B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
ee2d324744 [Sketcher] Fix some issues with trimming splines
1. Transfer point-on-object to the correct resulting curve: Currently the
constraint remains on the "start" curve created after the trim.
2. Expose internal geometries of both resulting B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
1a6a7d07c2 [Sketcher] Rearrange directives to appease syntax highlight
Spacemacs doesn't handle the braces flow very well. This commit can be dropped
if necessary.
2024-06-24 21:56:58 +05:30
wmayer
127f935711 Fix several compiler warnings
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
Chris Hennes
c601438b71 Fem/Sketcher: Fix missing PreCompiled.h files 2024-06-18 08:05:32 -05:00
bgbsww
c5de6ccfc7 Toponaming: Fix crash with invalid external geometry 2024-06-17 11:31:04 -05:00
Mihail Dumitrescu
7eff7ee9d0 Fix importing arcs and elliptical arcs as external geometry.
Fix importing elliptical arcs issue #8700.
Fix importing arcs into sketches in the case where they project as elliptical arcs.
Fix a discontinuity that happens when an external arc projects down to a segment. The segment end points should not jump around if the projection angle changes from 89.9 to 90 degrees.
When handling external geometry compare points for equality in a consistent way and remove some dead code.
2024-06-17 11:04:52 -05:00
bgbsww
42eb4fdda6 Guard all uses of basic_random_generator for thread safety 2024-06-10 11:10:57 -05:00
mosfet80
e31aa5e5e3 [mod] clean (#14378)
* [mod] clean

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-10 11:07:14 -05:00
Chris Hennes
6759c72eb6 Merge pull request #14337 from wwmayer/refactor_sketch_analysis
Sketch: Refactor SketchAnalysis
2024-06-03 10:49:30 -05:00
wmayer
560cab6f31 clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
wmayer
2b108b1bb3 Sketch: Refactor SketchAnalysis
Refactor detectMissingPointOnPointConstraints()
2024-05-28 15:28:53 +02:00
wmayer
60574c6507 Sketch: Refactor SketchAnalysis
Refactor detectMissingEqualityConstraints()
2024-05-28 15:10:51 +02:00
wmayer
4b8ef4721a Sketch: Refactor SketchAnalysis
Fix linter warnings
2024-05-28 14:43:46 +02:00
wmayer
645c7acf65 Sketch: Refactor SketchAnalysis
Refactor autoconstraint()
2024-05-28 14:28:07 +02:00
wmayer
ad56548739 Sketch: Refactor SketchAnalysis
Refactor makeMissingEquality()
2024-05-28 14:19:58 +02:00
wmayer
b052470b93 Sketch: Refactor SketchAnalysis
Refactor makeMissingVerticalHorizontal
2024-05-28 14:08:44 +02:00
wmayer
7f00aad6aa Sketch: Refactor SketchAnalysis
Refactor makeMissingPointOnPoint
2024-05-28 13:40:38 +02:00
wmayer
8abbed295e Sketch: Refactor SketchAnalysis
Refactor detectMissingPointOnPointConstraints
2024-05-28 13:24:05 +02:00
wmayer
7a2fa1dce8 Sketch: Refactor SketchAnalysis
Move helper classes to anonymous namespace
2024-05-28 12:26:23 +02:00
wmayer
72fb5782ed Sketch: Add test case for validating constraints 2024-05-27 19:15:18 +02:00
wmayer
1e81b7f393 Sketch: Add test case for degenerated geometry 2024-05-27 19:15:18 +02:00
PaddleStroke
a7c2b9cc6f Sketcher: Fix copy of geo constrained to axis. Fixes #14233 2024-05-27 11:37:33 -05:00
wmayer
0a5a049c87 Sketcher: Fixes #14240 2024-05-27 12:09:35 +02:00
wmayer
9f44b3f9a8 Sketch: Refactor Sketch::updateGeometry() 2024-05-20 11:38:06 -05:00
bgbsww
b82e3c73d4 Toponaming: Fix point crash bug 2024-05-16 09:05:27 -05:00
bgbsww
6fa5dc42c6 Toponaming: bring in missing code fragments in Sketcher 2024-05-13 15:47:44 -05:00
bgbsww
ffba7dcbe6 Fix #13858
Mistaken enabling of known bad code
2024-05-07 10:17:48 -05:00