kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
42,798 Commits 40 Branches 6 Tags
a3e43d97f61c133fd59ab26f779022d4823baa94
Commit Graph

46 Commits

Author SHA1 Message Date
wmayer
25e73289ae PD: Fix regression about single-solid check 
For several PD features the single-solid check fails. The regression
is caused by PR 13960 and reported as issue 19002. The reason for the
failure is that the first solid of the output shape is retrieved and
then checked for a single solid. This test will always pass, of course.

The single-solid is fixed for these features:
* Pad
* Pocket (never worked there)
* Fillet
* Chamfer
* Groove (never worked there)
* Revolution (never worked there)
* Loft

Fixes: 17ad40b2c9f0 ("PartDesign: Refactor single-solid rule enforcement")
 2025-06-25 00:09:33 +02:00
Benjamin Nauck
913850ef04 PartDesign: Add #include <limits> where used 2025-03-31 23:52:18 +02:00
Benjamin Nauck
c2e885d774 PartDesign: Use std::numeric_limits and std::numbers instead of defines 2025-03-29 13:32:38 +01:00
Chris Hennes
6edce0cafa PD: Add onlyHaveRefined() to FeatureRefine 2025-02-07 21:44:43 -06:00
Florian Foinant-Willig
115667f73a PartDesign: decouple refine and other geometric computation (#17008) 2024-12-02 10:57:30 -06:00
bgbsww
e4a509cc77 Toponaming: Remove all FC_USE_TNP_FIX protected old code 2024-08-26 11:12:48 -05:00
bgbsww
c54a98718f TopoNaming: restore defenses against multisolids when enabled 2024-05-21 21:42:05 -04:00
Kacper Donat
d0a35c8c03 PartDesign: Refactor single-solid rule enforcement 
This refactors a single solid rule checking code from using the solid
count directly to using well abstracted `isSingleSolidRuleSatisfied`
method. This makes code easier to read and is the basis for next step
which is allowing users to disable this checks.
 2024-05-20 12:25:36 -04:00
bgbsww
52ed6eb848 Toponaming: Bring in Chamfer, Fillet code and add tests (#14035) 
* Toponaming: bring in missing code fragments in Sketcher

* Toponaming: Fix infinite recursion, remove debug cruft, rough in fillet test

* Bring in missing code; fix chamfers

* Toponaming: Add code for fillets and test
 2024-05-15 19:43:30 -04:00
bgbsww
7961e82c66 Toponaming/Part: Fix all getBaseTopoShape calls. Tests and missing code. 2024-04-26 21:15:11 -05:00
wmayer
3e09b8ee2d PD: modernize C++: use range-based for loop 2023-08-16 21:54:56 -05:00
Chris Hennes
397807b72d Gui: Minor translation fixes 2023-05-11 18:31:34 -05:00
Chris Hennes
272a84ca5b PD: Add translation to error messages 2023-04-28 11:32:56 -05:00
Paddle
bc22bf9c0d PartDesign: Fillet, Chamfer, Draft, Thickness : Enable tool to start with no selection. 2023-03-28 12:52:42 +02:00
luz paz
d265c9ff63 PD: remove trailing whitespace 2022-11-10 10:32:04 +01:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
53ba98d636 Mod: use empty 2022-08-06 19:30:13 +02:00
Uwe
783655a4e3 [PD] Boolean to Groove: remove unused includes 2022-02-21 01:07:36 +01:00
Mark Ganson TheMarkster
abe0c9222a [PartDesign Fillet/Chamfer] add UseAllEdges boolean property (#5340) 
- [PartDesign Fillet/Chamfer] add UseAllEdges boolean property
- add UseAllEdges checkbox to fillet and chamfer dialogs
- put UseAllEdges property into Chamfer and Fillet groups, create Fillet group for fillets and put Radius into it, too.
 2022-02-05 01:50:51 +01:00
luz paz
909030859d PD: Fix typo in function getContiniusEdges->getContinuousEdges 
Related to PR #5029
 2021-09-15 10:11:37 -04:00
wmayer
ba2ad05983 PD: move handling of changed properties of the Chamfer/Fillet to handleChangedPropertyType 2021-09-15 15:14:14 +02:00
vosk
d667dd7102 [PartDesign]: Fix refine boolean not being obeyed at multiple places 
Related to issue #3927
 2021-01-07 14:04:31 +01:00
wandererfan
a712d49685 Revise multiple solids message 2018-07-13 10:23:42 -03:00
wandererfan
0d3008e4eb Fix #3401 warning on multiple solid 
- PartDesign only uses the first result shape
  of an operation and discards the rest without
  warning.

- this also fixes #1707
 2018-07-13 10:23:42 -03:00
wmayer
0d617f97d6 Port to occ7.2: 
+ Standard_Failure::Caught() is now marked as deprecated and should be replaced with standard C++ exception handling
 2017-09-01 16:27:46 +02:00
wmayer
91cc8a4817 try to fix tolerance if shape is broken after fillet/chamfer operation 2017-07-24 12:29:46 +02:00
Abdullah Tahiri
0b3bec3396 Fillet Feature: Return if radius <= 0 2017-05-30 23:09:29 +02:00
Peter Lama
fa4bebf2e0 Use OCCT Handle macro for Handle_ classes 
This is the result of running OCCT's upgrade script provided
with OCCT 7.0. See
https://www.opencascade.com/content/freecad-occt710-and-windows-rtti-data-missing#comment-form
and
https://www.forum.freecadweb.org/viewtopic.php?f=4&t=21405&start=120#p169019
for why this is necessary for OCCT >= 7.1
 2017-04-20 12:27:34 +02:00
Wolfgang E. Sanyer
d1d2f1f811 This commit adds getShape and setShape to TopoShape 2016-08-06 23:42:55 +02:00
Stefan Tröger
609da4749a fixes #0002512 Allow multi-face part design tools 2016-05-18 23:54:18 +02:00
Stefan Tröger
afee98c1e9 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
jrheinlaender
dbc6b1b12e Some code unification for DressUp features 2016-04-12 18:11:56 +02:00
jrheinlaender
4f643b2218 Made the rest of the PartDesign features aware of the Body 2016-04-12 18:11:49 +02:00
wmayer
be63f43e2e + add extra check if fillet operation returns valid shape 2016-04-04 14:26:27 +02:00
Eivind Kvedalen
533514e8d3 PartDesign: Fixed issue #2302 with unit handling when using an expression for the fillet radius. 2015-11-09 21:37:08 +01:00
jrheinlaender
4d595ff499 PartDesign module moving float -> double 2013-03-25 17:42:29 +04:30
jrheinlaender
1befcbb2b4 PartDesign: tidy up PartDesign feature dependencies 2012-09-09 10:05:43 +02:00
logari81
8985f085db + fix non-affine placement transformation in PartDesign/Chamfer 
+ simplify placement transformations in PartDesign/Fillet
+ revert accidentally canceled change in PartDesign/Pad


git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5301 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-12-14 16:12:09 +00:00
wmayer
be8f843ce1 + do not use geometric transform in fillet feature 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5300 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-12-14 12:36:46 +00:00
logari81
16b4578667 + synchronize PartDesign/Chamfer version with PartDesign/Fillet 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5299 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-12-13 19:32:19 +00:00
logari81
f6ce9caf79 + fix Placement of PartDesign/Fillet feature to the Placement of its base 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5289 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-12-13 07:17:09 +00:00
wmayer
a99f6293d2 0000532: fillet command in Part Design shows only partial dialog 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5264 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-12-10 22:10:09 +00:00
wmayer
32cd807f3c + fix crash when filleting a shape 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5235 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-12-08 09:40:16 +00:00
jriegel
c2fefaeff9 + fetched actual documentation 
+ icon for fillet dialog
+ small updates in wiki2qhelp.py

git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5115 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-11-11 07:21:00 +00:00
wmayer
5ccf289f29 + check if filleting shape is valid 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5010 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-10-13 15:36:13 +00:00
wmayer
120ca87015 + unify DLL export defines to namespace names 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5000 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
 2011-10-10 13:44:52 +00:00