Commit Graph

2540 Commits

Author SHA1 Message Date
Zheng, Lei
3c112b466d Toponaming: Missing code for shapebinder 2024-05-23 09:47:25 -04:00
André Althaus
099e33a77f Remove feature selection dialog for transformed features
The dialog is no longer necessary because without a selection the
transformed features default to "Transform body".
2024-05-23 12:40:41 +02:00
André Althaus
40a1487cb5 Set TransformMode to "Transform body" if no features are selected on creation of transform features 2024-05-23 12:23:32 +02:00
André Althaus
ebad053c70 Change MultiTransform child detection to the previous method
isMultiTransformChild() tried to do a better job by checking
for a parent MultiTransform in the dependency list, but this
is unusable during initialization, when these dependencies are
not established.

The method is changed back to the previous one which only checks for
default property values. This will give false results during
initialization but not cause problems.
2024-05-23 12:23:32 +02:00
André Althaus
f4aa5879cc Fix solid feature detection for "Transform Body" mode
Because the Origins property is empty in "Transform Body" mode, the
features are detected as not solid.
This messes with the feature order on insertions and moves.

This is fixed by calling the isMultitransformChild() method of the
Transformed features instead of checking the Origins property in the
Body code.
2024-05-23 12:23:32 +02:00
André Althaus
f021ea6c7f Fix ambiguous setValue() call 2024-05-23 12:23:32 +02:00
André Althaus
f2c3ade1f5 Remove unused function 2024-05-23 12:23:32 +02:00
André Althaus
5c0aaa40d9 Modernize code 2024-05-23 12:23:32 +02:00
André Althaus
75bba376c4 Format code with clang-format 2024-05-23 12:23:28 +02:00
André Althaus
98d46c41be Add a combo box to the transform featues UI for the TransformMode 2024-05-23 12:22:26 +02:00
André Althaus
5790795f03 Add a TransformMode property to the pattern features
This property controls wether the selected features tool shapes are
transformed or the whole base feature's shape.
2024-05-23 12:22:26 +02:00
André Althaus
d213827319 Add function to check if a Transformed feature is a sub-feature of MultiTransform
This will check the in-list instead of relying on an empty Originals property.
2024-05-23 12:22:26 +02:00
wmayer
1d78063df8 Fix accessibility of some group commands
Several group commands are active but require an active document to work. This PR overrides the method isActive() to
disable the commands if no active document exists.

The affected commands are:
* Std_ViewGroup
* Std_LinkActions
* PartDesign_CompDatums
* PartDesign_CompSketches
2024-05-23 10:14:46 +02:00
bgbsww
c54a98718f TopoNaming: restore defenses against multisolids when enabled 2024-05-21 21:42:05 -04:00
bgbsww
db85748e7d Toponaming: fix shapebinder selection error 2024-05-21 21:41:26 -04:00
Pieter Hijma
b6026c98c9 Core: Add VarSets to Groups
If a Group is selected, add the VarSet to the group.
2024-05-21 09:59:49 +02:00
marcuspollio
f2c6d9ed62 Resolve conflicts 2024-05-21 10:51:07 +12:00
bgbsww
9e2a8343a0 Toponaming: Cleanup verified face calls 2024-05-20 17:48:01 -05:00
marcuspollio
ed88002018 Merge remote-tracking branch 'upstream/main' into UI-TaskPanels-cleanup-1 2024-05-21 10:36:10 +12:00
Chris Hennes
40c5d137d2 Merge pull request #14074 from NomAnor/pd-icons
Change PartDesign Pad and Revolution tree icons
2024-05-20 11:45:16 -05:00
Florian Foinant-Willig
cded7480bf PartDesign: hide Suppressed property with FC_USE_TNP_FIX flag 2024-05-20 11:32:34 -05:00
Kacper Donat
302706be38 Gui: Add ability to disable single-solid rule by default 2024-05-20 12:25:36 -04:00
Kacper Donat
e4ed0d883f PartDesign: Introduce ability to disable single-solid rule
This adds "SingleSolidRuleMode" enum that controls if PartDesign will
enforce singular solid. By default the single-solid is enforced so
nothing changes for the user, it must be explicitly disabled by setting
new Allow Compound boolean property on a given body.

Default for this value is controled using user parameter under
Mod/PartDesign/AllowCompoundDefault
2024-05-20 12:25:36 -04:00
Kacper Donat
d0a35c8c03 PartDesign: Refactor single-solid rule enforcement
This refactors a single solid rule checking code from using the solid
count directly to using well abstracted `isSingleSolidRuleSatisfied`
method. This makes code easier to read and is the basis for next step
which is allowing users to disable this checks.
2024-05-20 12:25:36 -04:00
Max Wilfinger
ba9240a3f2 Update Part Design toolbars.
Command group for datum. Removed ShapeBinder. Added CheckGeometry.
2024-05-20 10:39:32 -05:00
marcuspollio
f0707c542f Merge remote-tracking branch 'upstream/main' into UI-TaskPanels-cleanup-1 2024-05-20 09:14:08 +12:00
André Althaus
eaa5b5c294 Use Body toolbar icon for the tree 2024-05-19 12:17:16 +02:00
André Althaus
641e866319 Remove unused icons 2024-05-19 12:16:56 +02:00
André Althaus
de6fe29d30 Replace the yellow Part primitive toolbar icons with the blue tree icons 2024-05-19 12:12:48 +02:00
André Althaus
d8c139fef0 Make "Sketch" in Pad icon red
In other icons the support geometry is red and this mirrors the other icons
2024-05-19 12:12:48 +02:00
bgbsww
6a947afda5 Toponaming: adjust tests 2024-05-18 14:12:04 -05:00
bgbsww
e50ef22e7b Minor test tweaks, and small fixes to pass tests 2024-05-17 19:14:01 -05:00
André Althaus
fd74429dfa Change PartDesign Pad and Revolution tree icons
Use the same icons as the toolbar buttons.
2024-05-17 09:09:46 +02:00
bgbsww
52ed6eb848 Toponaming: Bring in Chamfer, Fillet code and add tests (#14035)
* Toponaming: bring in missing code fragments in Sketcher

* Toponaming: Fix infinite recursion, remove debug cruft, rough in fillet test

* Bring in missing code; fix chamfers

* Toponaming: Add code for fillets and test
2024-05-15 19:43:30 -04:00
marcuspollio
1b2a3c3c29 Address feedback 2024-05-15 14:27:18 +12:00
marcuspollio
a5a26aee9e Merge remote-tracking branch 'upstream/main' into UI-TaskPanels-cleanup-1 2024-05-15 13:45:43 +12:00
bgbsww
86abf074c0 Toponaming: bring in missing code fragments in PartDesign 2024-05-13 08:45:26 -05:00
Chris Hennes
9fead3682d Update translations 2024-05-12 17:06:56 -05:00
bgbsww
5054cace46 Rework makeElementChamfer to match current parms, and add PartDesign code for Chamfers 2024-05-12 13:28:20 -05:00
marcuspollio
12a09af5cd PartDesign UI: Update Task panels titles and icons
update Workbench.cpp, TaskFeaturePick.cpp
2024-05-12 15:08:14 +12:00
wmayer
c2e3d61059 PD: Fix ShapeBinder::execute() if Support is empty
This fixes the reported regression: https://forum.freecad.org/viewtopic.php?t=87229
2024-05-10 15:06:22 +02:00
wmayer
f3637096e3 PD: Fix linter warnings 2024-05-10 15:06:22 +02:00
bgbsww
9fc744fbe3 Fix tests, slip in TNP defense 2024-05-07 13:42:21 -04:00
bgbsww
3ee0530ac2 Toponaming/Part: Fix fillet/pad bug, add tests 2024-05-07 09:40:48 -04:00
Chris Hennes
a5d8aaa21c Update translations
Also removes Web from translation scripts.
2024-05-06 18:17:53 +02:00
Martin Rodriguez Reboredo
51987dc1ab Fixups with Qt6 enums (#13611)
* Python PySide enums to C++ converter

* Python IntFlags to C++ int in getStandardButtons

* Remove int conversion in mods Python sources
2024-05-06 18:02:18 +02:00
bgbsww
920032c5a0 Lint corrections 2024-05-03 12:07:02 -04:00
bgbsww
b80d628c69 Merge branch 'main' into bgbsww-toponamingMissingAppMethods 2024-05-02 22:43:36 -04:00
bgbsww
20cae6c026 Toponaming/Part: unify revolution changes 2024-05-02 18:50:02 -05:00
bgbsww
4a0df0ea6d Test for changed Sketches avoiding TNP 2024-05-01 20:29:26 -04:00