Commit Graph

267 Commits

Author SHA1 Message Date
Hannu Koivisto
e5ce7e763d [Draft] Mitigate crash in Draft_Edit (#8749) (#8750)
This mitigates the crash reported in issue #8749.  The crash happens when
using Draft_Edit and using keyboard to enter a coordinate in Edit node
dialog.  This change partially restores behaviour before commit b45258b,
after which FreeCADGui.Control.closeDialog and showDialog calls during
execution of DraftToolBar.editUi are no longer made using the todo.delay
mechanism.  The crash can still be triggered by artificially slowing down key
event processing, so this is not a proper fix, just a mitigation.
2023-03-11 17:44:04 +01:00
Roy-043
1e03fddb67 Draft: housekeeping: remove obsolete code (uiMode and DraftGui.py) (#8327) 2023-02-02 23:24:27 +01:00
Roy-043
9351bbe7bf Draft: Escape should not switch off continue mode 2022-10-15 12:14:51 +02:00
Roy-043
25ee38495e Draft: Improve Draft_Edit context menus 2022-09-26 10:03:50 +02:00
Roy-043
c142e1ad62 Draft: Improve In-Command-shortcut Undo implementation 2022-08-13 14:10:43 +02:00
Yorik van Havre
367ce63a8a Draft: Enabled shortcut for undo segment - fixes #6181
That shortcut had apparently been left out last time the system was recoded..
I used the default shortcut '/' because Ctrl doesn't really work with the
current system, and Z is already taken
2022-08-04 17:40:05 +02:00
luzpaz
95070bded4 Draft: Fix 'testing inequality to None' syntax (#7275)
* Draft: Fix 'testing inequality to None' syntax 

- Substitute `is not None` for `!= None`
- Trim trailing whitespace on touched files
2022-07-30 00:26:56 +02:00
Peter Marquardt
a1c8380be3 Draft: fix spacing of ToolTip text 2022-07-12 02:59:30 +02:00
Roy-043
732489de2d Draft: Fix default fillmode in DraftGui.py 2022-06-28 15:42:28 +02:00
Roy-043
cd6f894986 Draft: Fix Angle Lock
Fix problem with self.angle = None.
2022-04-21 12:17:42 +02:00
Roy-043
b830f77215 Draft: Fix Angle Lock for non-XY workingplane 2022-03-10 17:44:38 +01:00
Roy
359f9d7886 Draft: Fix several translation issues 2022-01-28 14:01:42 -06:00
Roy
c7da560d39 Draft: fix task panel related issues
This PR fixes several task panel related issues for Draft modifier commands.
2022-01-15 18:23:05 +01:00
marioalexis
5acf2f5340 Draft: Use super() to call base class methods 2022-01-07 22:24:21 +01:00
Roy
418ca4a235 Draft: Draft_Label fix label type list 2021-12-10 18:40:43 +01:00
Roy-043
aec803fe8d Draft: fix task panel issues (DraftGui.py) 2021-12-04 21:57:31 +01:00
Roy-043
54d43ce262 Update DraftGui.py
The Y and Z inputs also require the event filter.
2021-10-22 20:04:06 +02:00
Roy-043
80d0a5e97d Draft: Fix snap cycling if length input has focus 2021-10-22 19:47:23 +02:00
Yorik van Havre
24d1a3f054 Merge pull request #5023 from marioalexis84/gui-encoding
Gui:  Harmonize encoding/decoding between view, property editor and command line.
2021-10-14 12:24:49 +02:00
Roy-043
878f97b234 Draft: prevent negative snaprange
Also fixed misspelled related in-command shortcuts.
2021-10-01 20:38:30 +02:00
marioalexis
e2b3310277 Draft: Fix Unicode and UTF-8 encoding character behavior 2021-09-23 21:21:24 -03:00
Roy-043
2b35383744 Draft: Draft_Trimex: Fix wrong angle units in taskpanel: tooltip in DraftGui.py
I have changed the tooltip from "Trim distance" to "Offset distance" to match the tooltip in gui_trimex.py
2021-07-02 11:37:31 +02:00
marioalexis
22b157dbbf Draft: Check special characters using focused input field 2021-06-14 01:37:44 -03:00
Yorik van Havre
966906da96 Merge pull request #4557 from luzpaz/crowdin/whitespaces-substituted-into-code
Crowdin: represent whitespace in code instead of in string
2021-05-05 17:18:35 +02:00
Yorik van Havre
c0c49ebffc Merge branch 'master' into draft-feature_name 2021-04-29 12:40:27 +02:00
Yorik van Havre
07c914a8bb Merge pull request #4710 from marioalexis84/draft-draftgui
Draft: Sync input fields in task panel
2021-04-20 11:50:22 +02:00
luz paz
b94ee8b275 Crowdin: represent whitespace in code instead of in string [skip ci]
Removing possible whitespace from strings lead to more accurate translations
2021-04-19 06:16:09 -04:00
marioalexis
2f81ca40be Draft: Sync input fields in task panel 2021-04-07 18:36:56 -03:00
marioalexis
cce80c6ba4 Draft: Fix tooltip typo and trimex task panel title 2021-03-29 10:51:53 -03:00
Yorik van Havre
4a8319d63e Merge branch 'master' into draft-close_button 2021-03-26 11:19:09 +01:00
Yorik van Havre
94b9374b37 Merge pull request #4348 from marioalexis84/draft-coordinate_input
[0.20] [Draft] Add global mode to enter points - Fixes #0004108
2021-03-26 11:18:23 +01:00
marioalexis
6795e0d7e6 Draft: Change selectUi and makeDumbTask argument named 'callback' to 'on_close_call'
Suggested by user @carlopav
2021-03-20 17:12:58 -03:00
marioalexis
7c00d19a28 Draft: Call finish method if pressed Close button in dumb taskdialog 2021-03-20 17:12:58 -03:00
Chris Hennes
a7522c384e [DRAFT] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
marioalexis
8952eddf83 Draft: Add global mode to enter points - fixes #0004108 2021-02-01 01:26:15 -03:00
Yorik van Havre
f54b452327 Draft: Hide undo button from modify operations 2020-12-14 15:21:25 +01:00
luz paz
fc99ff2def Draft: fix header uniformity + trailing whitespace
[skip ci]
2020-12-11 13:19:49 +01:00
Yorik van Havre
ed3b5a1dd0 Draft: Fixed regression caused by new setstyle button 2020-11-18 11:41:38 +01:00
Yorik van Havre
583b59c29f Draft: Condensed the Draft toolbar style buttons into one with more options 2020-11-10 14:14:18 +01:00
vocx-fc
3a31a36fae Draft: use new name of the icon Part_3D_object
It is defined in the Part Workbench. Before, it was called `Tree_Part`.
2020-10-22 15:11:45 +02:00
vocx-fc
3c6fdca582 Draft: move units functions outside DraftGui.py
The functions `getDefaultUnit`, `makeFormatSpec`, `displayExternal`
are used to get the default unit schema for lengths and angles,
and display a string with a particular format.

They aren't used in `DraftGui.py`, but are used by the
viewprovider of the Dimension objects. Therefore, they are moved
into a separate module, so that they can be imported without
using the entire `DraftGui` module.
2020-07-10 12:29:30 +02:00
carlopav
78a5036048 [Draft] Improved Snapper Toolbar Behaviour
Changed snap toolbar behaviour:
- create a list of available snaps (Gui.Snapper.snaps)
- make it consistent with Snap Gui Commands (in gui_snaps module)
- create a list of active snaps (Gui.Snapper.active_snaps)
- refactor the isEnabled() method to allow it to check if the given snap is in Gui.Snapper.active_snaps and not if the snap toolbar button isChecked()
- updated and reordered the new list of gui snap commands in draftutils.init_tools and used it as a base to refactor the creation of draft toolbar
- updated all the draft snap gui tools to make them control the toolbar buttons directly
.


.


.
2020-04-20 12:38:06 +02:00
vocx-fc
9d9102bc7e Draft: Draft_Text split lines by newline characters 2020-04-06 13:01:32 +02:00
vocx-fc
2a340bcfd3 Draft: move ScaleTaskPanel to a module
We remove it from `DraftGui.py` to reduce the size of this file.
Then we import it and tie it to its command defined
in `DraftTools.py`.
2020-04-02 16:53:49 +02:00
vocx-fc
46216d6032 Draft: move ShapeStringTaskPanel to a module
We remove it from `DraftGui.py` to reduce the size of this file.
Then we import it and tie it to its command defined
in `DraftTools.py`.
2020-04-01 13:22:04 +02:00
vocx-fc
580270ce4a Draft: move DraftSnap to another module
And do not load the `Snapper` in `DraftGui`.
The Snapper should be initialized by the module
that imports `DraftGui`, most probably `DraftTools`
or even by the `InitGui` of the workbench.
2020-03-20 08:11:04 -03:00
carlopav
6d2c8b5df3 [Draft] Uniform length and xyz inputfield behaviour
Single returnPressed to accept point if cursor is parallel to xyz axis for bot setfocus on x and on length inputfields.
[Draft] Edit_updated tooltip


[Draft] DraftGui Further cleanup and bugfix
2020-03-12 09:11:34 -03:00
carlopav
4396b40fec [Draft] DraftGui and DraftEdit Cleanup to remove AddPoint & DelPoint
Lines to be deleted in DraftGui in the future, are now commented.
2020-03-12 09:11:34 -03:00
carlopav
786eac8c01 [Draft] DraftGui Bugfix on selecting inputfields
https://forum.freecadweb.org/viewtopic.php?f=23&t=43145&p=367517#p367517
2020-03-12 09:11:34 -03:00
Syres916
b90d181188 [Draft] Bugfix for new users opening Shapestring
See Discussion : https://forum.freecadweb.org/viewtopic.php?f=23&t=42808
2020-02-05 10:51:12 +01:00