Commit Graph

101 Commits

Author SHA1 Message Date
Jolbas
202a6ca6b8 return pure rotation from getPlaneRotation() 2023-02-28 01:07:56 +01:00
Roy-043
6cd35b86fe Draft: Fix workingplane auto alignment to Front view 2022-09-01 09:54:09 +02:00
Roy-043
28ea41cb32 Draft: Improve alignToFace in WorkingPlane.py 2022-07-24 18:52:41 +02:00
marioalexis
8baaa1028e Draft: Fix orientWP method used by in Draft_Line command 2022-04-20 14:12:26 -03:00
marioalexis
a18b00bc7e Draft: Fix WorkingPlane setup in automatic mode - fixes #6060 2022-04-10 16:17:16 +02:00
marioalexis
727d21499f Draft: Fix projectPoint method 2022-01-08 23:16:15 -03:00
luzpaz
95a0c9c008 Add requested revision by @chennes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2021-10-30 15:20:28 -04:00
luzpaz
005a5d8cd7 Add requested revision by @chennes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2021-10-30 15:20:28 -04:00
luz paz
8aab47fb06 Draft: Fix superfluous whitespace in translations + misc. typos 2021-10-30 15:20:28 -04:00
Roy-043
d1fca44fb6 Draft: Fix Draft_SelectPlane ignores nesting 2021-10-20 10:15:12 +02:00
Yorik van Havre
fe7f1ba1c3 Draft: Fixed working plane set on non-coin view 2021-06-22 16:12:59 +02:00
marioalexis
6f101761bb Draft: Improve alignToSelection method on WorkingPlane 2021-06-06 21:30:20 -03:00
Yorik van Havre
1cce61670c Draft: better checks for no active document 2020-11-16 13:25:12 +01:00
carlopav
aff02d706a Draft: possibility to set the working plane to an App::Part placement 2020-07-07 10:13:23 +02:00
Yorik van Havre
2175eb0939 Draft: Added convenience methods to the Draft Working Plane to set top, front and side positions 2020-04-09 16:59:01 +02:00
vocx-fc
106cd631e0 Draft: WorkingPlane.py clean up imports and docstrings
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Cleaned up the class docstring, so it is in only one place
below the class definition. Also small fixes
in the docstrings of the class methods.

The class is now in upper case `Plane` to conform with Python
guidelines. An alias in lowercase `plane` is still provided
for compatibility purposes; this will be deprecated
in the future.
2020-04-07 18:12:06 +02:00
luz.paz
8cfa85cf18 Draft: [skip ci] Fix header uniformity
This PR fixes header uniformity across all Draft files
2019-12-27 00:16:12 +01:00
Yorik van Havre
91ca523f54 Draft: Moved SelectPlane stuff from DraftGui to its own ui file 2019-09-02 22:15:58 -03:00
luz.paz
020a66cddf Fix misc. typos
Found via `codespell -q 3 -I ../fc-word-whitelist.txt -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller -L od,orign,orginx,orginy`
2019-08-14 14:36:53 -03:00
vocx-fc
813338d62e Draft: WorkingPlane, improved Pythonic style, line length < 79 characters; shorter variables
to save space and have line lengths < 79 characters; added whitespace to comments
and used the self.__repr__() method to shorten the impression to the terminal;
broke the line inside parentheses to make the line shorter; inside alignToSelection() test for faces first
to use alignToFace(), which actually works; leave alignToCurve() for later,
as it doesn't actually do anything at the moment; improved docstrings in isOrtho(),
the orthogonality is tested for u, v, and axis, on the global axis +Y only;
removed wrongly placed comment in restore() method;
improved file docstring at the top.
2019-08-14 14:31:56 -03:00
vocx-fc
b7ad13b34f Draft: WorkingPlane, Pythonic style, improved the docstrings, use a shape of type Part.Face 2019-08-09 16:54:50 -03:00
vocx-fc
3eda73fae9 Draft: WorkingPlane, Pythonic style, improved the docstrings; moved the description of the points within the parameter section 2019-08-09 16:54:50 -03:00
vocx-fc
817f076e2e Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
8aa3f38a7b Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
abf3139563 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
fbc3abc0de Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
41300ee257 Draft: WorkingPlane, Pythonic style, improved the docstrings; added the other getLocalRot() and getGlobalRot() related functions to the 'See also' sections; need to verify their operation as some of these methods seem to just return the original point 2019-08-09 16:54:50 -03:00
vocx-fc
3f84f43564 Draft: WorkingPlane, Pythonic style, improved the docstrings; added a graphic to explain the type of point that the functions return; maybe getLocalCoords() should be named getRelativeCoords(), as the return value is a relative vector referred to the plane. 2019-08-09 16:54:50 -03:00
vocx-fc
212640b3ce Draft: WorkingPlane, Pythonic style, improved the docstring; why does the projection invert the direction of the component, that is, -x instead of x, if the angle between the vectors x and u is larger than 1 radian? Why specifically 1 radian? 2019-08-09 16:54:50 -03:00
vocx-fc
a5451e6234 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
b430036a8b Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
8b6a3222b6 Draft: WorkingPlane, Pythonic style, improved the docstring 2019-08-09 16:54:50 -03:00
vocx-fc
8004f89e20 Draft: WorkingPlane, Pythonic style, improved the docstring 2019-08-09 16:54:50 -03:00
vocx-fc
6a87b6fe57 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
f0eafbc25f Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
a7d70a7aa3 Draft: WorkingPlane, Pythonic style, improved the docstring 2019-08-09 16:54:50 -03:00
vocx-fc
a569bed31b Draft: WorkingPlane, Pythonic style, improved the docstring; these methods only work when 'FreeCAD.GuiUp' is True; it should print a message to the console indicating that. 2019-08-09 16:54:50 -03:00
vocx-fc
15b186bbfe Draft: WorkingPlane, Pythonic style, improved the docstring; setup() only works when 'FreeCAD.GuiUp' is True, otherwise it fails silently. This should be change to print a message to the console. 2019-08-09 16:54:50 -03:00
vocx-fc
e7aaf4b771 Draft: WorkingPlane, Pythonic style, improved the docstrings; alignToSelection() only works when 'FreeCADGui.Selection' is available, that is, when the graphical interface is loaded. 2019-08-09 16:54:50 -03:00
vocx-fc
8ade7083d6 Draft: WorkingPlane, Pythonic style, improved the docstrings; alignToSelection() only really works with Faces because it calls alignToFace(); it doesn't work with Edges nor Wires because alignToCurve() isn't fully implemented. 2019-08-09 16:54:50 -03:00
vocx-fc
0ec668a057 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
df54c400a0 Draft: WorkingPlane, Pythonic style, improved the docstring, although alignToCurve is not yet implemented so it doesn't do anything 2019-08-09 16:54:50 -03:00
vocx-fc
7ef7c17d03 Draft: WorkingPlane, Pythonic style, improved the docstring. 2019-08-09 16:54:50 -03:00
vocx-fc
f900e57036 Draft: WorkingPlane, Pythonic style, improved the docstring. 2019-08-09 16:54:50 -03:00
vocx-fc
a941c0179e Draft: WorkingPlane, Pythonic style, improved the docstrings. 2019-08-09 16:54:50 -03:00
vocx-fc
5eaa98629d Draft: WorkingPlane, Pythonic style, improved the docstrings, in particular offsetToPoint(); I have some doubts about the implementation in 3D space as it seems to calculate a projected distance, and not the real distance; I don't think this is very helpful when the direction is different from perpendicular (normal); perpendicular distance is certainly the most common case, so I don't know if there is any problem at all in practice. 2019-08-09 16:54:50 -03:00
vocx-fc
5fd074bfa9 Draft: WorkingPlane, Pythonic style, docstring of the initialization of the plane class 2019-08-09 16:54:50 -03:00
vocx-fc
c02260de90 Draft: WorkingPlane, Pythonic style, docstring of the plane class 2019-08-09 16:54:50 -03:00
vocx-fc
4ce2e481e5 Draft: WorkingPlane, Pythonic style, docstring of the plane class 2019-08-09 16:54:50 -03:00
vocx-fc
1037258387 Draft: WorkingPlane, Pythonic style, added whitespace 2019-08-09 16:54:50 -03:00