kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
29,743 Commits 40 Branches 6 Tags
a93082bc0660c2138e8c0f76ac015e9d5fd78147
Commit Graph

29 Commits

Author SHA1 Message Date
wmayer
a93082bc06 PD: [skip ci] Fix several clazy issues: 
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
 2022-07-25 13:40:19 +02:00
Uwe
17e6ebf120 [PD] remove more unused includes 2022-02-22 01:19:32 +01:00
wmayer
c2823b0435 PD: hide the sections of a loft only if it can be recomputed successfully 2021-12-15 15:13:33 +01:00
wmayer
e6ea67bc1e PD: highlight current profile and sections of a loft when selecting a new profile/section 2021-12-13 15:01:08 +01:00
wmayer
a6838cf58f Gui: rename methods of SelectionObserver to clarify intention in client code 2021-12-07 14:17:07 +01:00
wmayer
8424c9323b PD: enable selection only on request and disable it after selecting an object 2021-12-07 13:06:48 +01:00
Ajinkya Dahale
4d006a5098 [PD] Allow sketch point profile in selection-based loft workflow 2021-11-22 04:16:02 +01:00
Ajinkya Dahale
6f5159180b [PD] Use PropertyLinkSubList for loft and sweep sections 
This change is necessary since we restrict part-design features to only use
other features from the same body.
 2021-11-20 21:37:14 +01:00
Ajinkya Dahale
99bafa24e8 [PD] Clear other taskbox buttons in loft and pipe when one pressed 2021-11-10 17:59:45 +01:00
Ajinkya Dahale
854b547503 [PD] Fixed loft and sweep breaking on section deletion 
Item removal in `onDeleteSection()` was also clearing subname details so if one
of the remaining sections was a face this caused a failure.
 2021-11-09 23:05:29 +01:00
Ajinkya Dahale
9cade40755 [PD] Support adding solid faces for loft and pipe sections 
With these changes, one face per solid can be added as either the first
"profile" or subsequent sections in loft and pipe.

This commit depends on `App::PropertyXLinkSubList` preserving the order in which
sections are added.

A minor change this also adds is that when a solid's face is selected that face
is mentioned in the fields instead of the solid (eg `Box:Face1` instead of
`Box`).
 2021-11-09 23:05:29 +01:00
Uwe
fe00d3ab59 [PD] fixes loft visibility on creation and modification 
- the PR fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=63252

- (also a MSVC code formatting fix)
 2021-11-07 21:57:00 +01:00
Uwe
f1bc66b323 [PD] simplify Loft code 
- also two automatic style fixes made by MSVC
 2021-11-07 19:04:38 +01:00
Ajinkya Dahale
a24b94efc8 [PartDesign] Fix typo in method name 2021-11-06 00:03:48 +01:00
donovaly
bcadbe3b1b [PD] rename icons to match Wiki files 
For the What#s this feature we need to have a uniform naming of the features and its icons. For some PD icons this is not the case and since we are in feature freeze, this is the right time to address this.
(I see the same is already done for Mesh.)
 2021-02-11 12:47:25 +01:00
donovaly
b483fc0518 [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
donovaly
78efc9c34f [PD] simplify item handling 
according to https://github.com/FreeCAD/FreeCAD/commit/c1fd0320

"QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous"
 2020-09-18 17:30:09 +02:00
donovaly
8217e0f0d0 [PD] make sections sortable 
- allow to sort loft sections by dragging: https://forum.freecadweb.org/viewtopic.php?f=19&t=50222

- fix bug of uninitialized options: https://forum.freecadweb.org/viewtopic.php?f=19&t=50221

- use better code for the context menu of the listWidget (the same we use in other placed of PD)

- add missing tooltip for mirror feature
 2020-09-17 23:59:15 +02:00
wmayer
fb03c31b28 PD: whitespace improvements 2020-09-15 14:20:24 +02:00
mwganson
7d392d1209 [Part Design] allow for preselecting loft sections and pipe spines prior to invoking command 2020-09-15 10:48:09 +02:00
Zheng, Lei
cd2b7e297c PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
81b133e174 fixes #0003597: PartDesign Additive and Subtractive Loft features don't allow changing the first section after creation 2018-09-20 22:12:43 +02:00
Kurt Kremitzki
f0c0c10f45 PDN: Make Loft hide its sections when task dialog accepted 2017-07-26 23:16:12 +02:00
wmayer
dd7c91ddcf fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
Stefan Tröger
30d763a67a PartDesign: Fix loft preview 2016-05-18 23:54:03 +02:00
Mateusz Skowroński
a8d37dabbe QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-04-15 11:55:12 +02:00
Alexander Golubev
266a36bb94 PartDesign/TaskLoftParameters: Added UpdateView checkbox +cleanup 2016-04-12 18:12:19 +02:00
Alexander Golubev
9347f66a9e PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Stefan Tröger
d18cd54743 make part design loft functional 2016-04-12 18:12:10 +02:00