kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
31,360 Commits 40 Branches 6 Tags
a95b7dc4b5878608691ed5819685fa20cd572926
Commit Graph

29 Commits

Author SHA1 Message Date
wmayer
88accdb421 PD: [skip ci] Fix several clazy issues: 
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
 2022-07-25 13:40:19 +02:00
Uwe
278abf5675 [PD] remove more unused includes 2022-02-22 01:19:32 +01:00
wmayer
94d8a2034a PD: hide the sections of a loft only if it can be recomputed successfully 2021-12-15 15:13:33 +01:00
wmayer
6289ff40d5 PD: highlight current profile and sections of a loft when selecting a new profile/section 2021-12-13 15:01:08 +01:00
wmayer
ca5c799ce2 Gui: rename methods of SelectionObserver to clarify intention in client code 2021-12-07 14:17:07 +01:00
wmayer
ce88fa2052 PD: enable selection only on request and disable it after selecting an object 2021-12-07 13:06:48 +01:00
Ajinkya Dahale
ea10dfd85d [PD] Allow sketch point profile in selection-based loft workflow 2021-11-22 04:16:02 +01:00
Ajinkya Dahale
71e70c876b [PD] Use PropertyLinkSubList for loft and sweep sections 
This change is necessary since we restrict part-design features to only use
other features from the same body.
 2021-11-20 21:37:14 +01:00
Ajinkya Dahale
37df050d59 [PD] Clear other taskbox buttons in loft and pipe when one pressed 2021-11-10 17:59:45 +01:00
Ajinkya Dahale
314ff0053c [PD] Fixed loft and sweep breaking on section deletion 
Item removal in `onDeleteSection()` was also clearing subname details so if one
of the remaining sections was a face this caused a failure.
 2021-11-09 23:05:29 +01:00
Ajinkya Dahale
03a8ff7841 [PD] Support adding solid faces for loft and pipe sections 
With these changes, one face per solid can be added as either the first
"profile" or subsequent sections in loft and pipe.

This commit depends on `App::PropertyXLinkSubList` preserving the order in which
sections are added.

A minor change this also adds is that when a solid's face is selected that face
is mentioned in the fields instead of the solid (eg `Box:Face1` instead of
`Box`).
 2021-11-09 23:05:29 +01:00
Uwe
0b77c2b2b5 [PD] fixes loft visibility on creation and modification 
- the PR fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=63252

- (also a MSVC code formatting fix)
 2021-11-07 21:57:00 +01:00
Uwe
0b4405e935 [PD] simplify Loft code 
- also two automatic style fixes made by MSVC
 2021-11-07 19:04:38 +01:00
Ajinkya Dahale
e30efba754 [PartDesign] Fix typo in method name 2021-11-06 00:03:48 +01:00
donovaly
2834075d6a [PD] rename icons to match Wiki files 
For the What#s this feature we need to have a uniform naming of the features and its icons. For some PD icons this is not the case and since we are in feature freeze, this is the right time to address this.
(I see the same is already done for Mesh.)
 2021-02-11 12:47:25 +01:00
donovaly
2ac84872ec [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
donovaly
a44f8ffd42 [PD] simplify item handling 
according to https://github.com/FreeCAD/FreeCAD/commit/2b676020

"QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous"
 2020-09-18 17:30:09 +02:00
donovaly
03c2c76963 [PD] make sections sortable 
- allow to sort loft sections by dragging: https://forum.freecadweb.org/viewtopic.php?f=19&t=50222

- fix bug of uninitialized options: https://forum.freecadweb.org/viewtopic.php?f=19&t=50221

- use better code for the context menu of the listWidget (the same we use in other placed of PD)

- add missing tooltip for mirror feature
 2020-09-17 23:59:15 +02:00
wmayer
42d643c8f7 PD: whitespace improvements 2020-09-15 14:20:24 +02:00
mwganson
74e4a3e976 [Part Design] allow for preselecting loft sections and pipe spines prior to invoking command 2020-09-15 10:48:09 +02:00
Zheng, Lei
11a93a0578 PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
ac21bcc35c fixes #0003597: PartDesign Additive and Subtractive Loft features don't allow changing the first section after creation 2018-09-20 22:12:43 +02:00
Kurt Kremitzki
373d81b2bc PDN: Make Loft hide its sections when task dialog accepted 2017-07-26 23:16:12 +02:00
wmayer
664cf65d26 fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
Stefan Tröger
4f8973fe8e PartDesign: Fix loft preview 2016-05-18 23:54:03 +02:00
Mateusz Skowroński
b5519922d8 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-04-15 11:55:12 +02:00
Alexander Golubev
36fbf73011 PartDesign/TaskLoftParameters: Added UpdateView checkbox +cleanup 2016-04-12 18:12:19 +02:00
Alexander Golubev
c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Stefan Tröger
d435e15a97 make part design loft functional 2016-04-12 18:12:10 +02:00