Commit Graph

21071 Commits

Author SHA1 Message Date
wmayer
aa3fde2dae Coverity: Big parameter passed by value 2020-07-20 17:34:25 +02:00
wmayer
d26aafa833 Coverity: Argument cannot be negative (actually a bug by using the wrong index variable) 2020-07-20 17:34:24 +02:00
wmayer
0e279348f1 Coverity: Use after free (_removeObject may delete the DocumentObject) 2020-07-20 17:34:24 +02:00
wmayer
0b45b11344 Coverity: Resource leak 2020-07-20 17:34:24 +02:00
wmayer
12670655a9 Coverity: Uninitialized scalar variable 2020-07-20 17:34:23 +02:00
wmayer
5919874437 Coverity: Invalid printf format string 2020-07-20 17:34:23 +02:00
Bernd Hahnebach
14d08db7fc FEM: migrate tools, fix github links 2020-07-20 16:22:47 +02:00
Bernd Hahnebach
95f611f0bb FEM: writer base: use warning instead of error message 2020-07-20 16:22:47 +02:00
mikeprice99
a0480dc62c fixed door open plan symbol and make makeWindow use name parameter 2020-07-20 14:26:35 +02:00
mwganson
5b56ce4d11 [openscad] mirror mesh feature -- rename OpenSCADUtils.mirror() to OpenSCADUtils.mirrormesh(), and provide some better interactive help information when typing OpenSCADUtils.mirrormesh() into the python console 2020-07-20 14:24:29 +02:00
mwganson
2c0b49ea46 [openscad] mirror mesh feature -- separate gui from function 2020-07-20 14:24:29 +02:00
mwganson
92b14ba161 [openscad] fix refine shape feature 2020-07-20 14:24:29 +02:00
mwganson
a1d7b128d2 [openscad] add updated icon to qrc file 2020-07-20 14:24:29 +02:00
mwganson
6ab4726126 [openscad] work on icon for mesh mirror 2020-07-20 14:24:29 +02:00
mwganson
4c259e43b3 [openscad] add icon for mirror mesh feature 2020-07-20 14:24:29 +02:00
mwganson
c5b93d698e [openscad] add ulrich's mirror mesh macro, fix error in refine shape 2020-07-20 14:24:29 +02:00
vocx-fc
d106be0b9b Draft: add Draft Layer unit tests
Also create a test `Layer` in the `draft_test_objects` script.
2020-07-20 14:21:15 +02:00
vocx-fc
831e517717 Draft: migrate Layer object and function to the new structure
Move `make_layer` to `draftmake`; `Layer` and `LayerContainer`
to `draftobjects`; `ViewProviderLayer` and `ViewProviderLayerContainer`
to `draftviewproviders`.

The make function and the classes are imported in `Draft.py`
to support the usage of the older `VisGroup`.
2020-07-20 14:21:15 +02:00
vocx-fc
cdc6c5f541 Draft: move GuiCommand for Draft Layer to its own module 2020-07-20 14:21:15 +02:00
Mateusz Skowroński
54aa706145 Mod/Web: Use of deprecated not thread-safe setter, use setUrlRequestInterceptor instead. 2020-07-20 14:18:12 +02:00
paul lee
4e36cde00a [ArchWall] Failed if Sketch as Base has Point, now OK
FC Forum Discussion -
https://forum.freecadweb.org/viewtopic.php?f=23&t=48668&sid=ba6dd68ad32eefbad6ae95d8fadc30e6#p416779
2020-07-20 14:17:28 +02:00
mwganson
8565736dea avoid saving to parameters if new shortcut is the default, better check for if setting shortcut was success 2020-07-20 14:11:14 +02:00
mwganson
43be29c3b1 return false when unable to set shortcut 2020-07-20 14:11:14 +02:00
Mark Ganson TheMarkster
42a4b11d1f convert tab to spaces 2020-07-20 14:11:14 +02:00
Mark Ganson TheMarkster
c437ab007c move preprocessor directives back to column 1 2020-07-20 14:11:14 +02:00
Mark Ganson TheMarkster
5c42e35f52 remove some commented lines 2020-07-20 14:11:14 +02:00
mwganson
5f347447b1 [Python Gui] add new command Gui.setCommandShortcut(), fix bug in Gui.getCommandShortcut() and Gui.getCommandInfo() where user has changed shortcut via customize dialog, but these 2 commands returned previous default information 2020-07-20 14:11:14 +02:00
mwganson
ac8259e560 [Standard Views] change preference label to default camera orientation 2020-07-20 13:48:37 +02:00
mwganson
78cd1790df [Standard Views] add Home view command. Default shortcut is 'Home' key. Restores camera orientation to current home view, configurable in edit menu -> preferences -> display -> navigation -> New Document Camera Orientation / Home view. 2020-07-20 13:48:37 +02:00
Bernd Hahnebach
ce18f6afdb FEM: elmer tasks, comment regression added with ece663444c 2020-07-20 08:09:52 +02:00
mwganson
2bfc6301bc [Sketcher] add python command sketch.getGeoVertexIndex(int index) -- returns tuple (geoId, posId) of vertex at that index in the sketch. usage example: (geoId, posId) = App.ActiveDocument.Sketch.getGeoVertexIndex(int(Gui.Selection.getSelectionEx()[0].SubElementNames[0][6:])-1) 2020-07-19 05:50:12 +02:00
wmayer
71e1f7c331 Gui: [skip ci] add some security checks before dereferencing pointer to QTreeWidgetItem 2020-07-18 12:05:02 +02:00
mwganson
9ea45bc8b7 [crash fix] Edit Parameters right click was causing crash unless right clicking on item 2020-07-18 11:55:24 +02:00
wmayer
d562c52fdc PVS: V571 Recurring check. A condition was already verified in previous line 2020-07-18 10:59:28 +02:00
wmayer
dff82ea08a PVS: V506 Pointer to local variable '_value' is stored outside the scope of this variable. Such a pointer will become invalid. 2020-07-18 10:59:28 +02:00
wmayer
7fdf514fb3 PVS: V1016 Value is out of range of enum values. This causes unspecified or undefined behavior. 2020-07-18 10:59:28 +02:00
wmayer
864483d550 PVS: V560 A part of conditional expression is always true 2020-07-18 10:59:28 +02:00
wmayer
6e00846cdd PVS: V646 Consider inspecting the application's logic. It's possible that 'else' keyword is missing. 2020-07-18 10:59:28 +02:00
wmayer
f77bfe3e57 PVS: V768 The expression is of enum type. It is odd that it is used as an expression of a Boolean-type. 2020-07-18 10:59:28 +02:00
wmayer
2b97a10323 PVS: V1046 Unsafe usage of the 'bool' and 'int' types together in the operation '&='. 2020-07-18 10:59:28 +02:00
wmayer
0bee47d5b7 PVS: V612 The '(4) / 3' expression was implicitly cast from 'int' type to 'float' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part 2020-07-18 10:59:28 +02:00
wmayer
6f06fbf36d PVS: V601 The bool type is implicitly cast to the double type 2020-07-18 10:59:28 +02:00
wmayer
af9c5274b4 PVS: V688 The local variable possesses the same name as one of the class members, which can result in a confusion 2020-07-18 10:59:28 +02:00
wmayer
811efa6107 PVS: V690 The copy constructor is declared as private in the 'PropertySheet' class, but the default copy assignment operator will still be generated by compiler. It is dangerous to use such a class. 2020-07-18 10:59:28 +02:00
wmayer
473553a212 PVS: V595 A pointer was utilized before it was verified against nullptr 2020-07-18 10:59:28 +02:00
wmayer
93f61a3154 PVS: V590 Consider inspecting this expression. The expression is excessive or contains a misprint. 2020-07-18 10:59:28 +02:00
wmayer
56252d8ad6 PVS: V1762 It is possible a virtual function was overridden incorrectly 2020-07-18 10:59:28 +02:00
wmayer
1d7299502e PVS: V1023 A pointer without owner is added to the container by the 'emplace_back' method. A memory leak will occur in case of an exception. 2020-07-18 10:59:28 +02:00
wmayer
e1363e5d0f PVS: V575 The null pointer is passed into 'strcpy' function. Inspect the first argument 2020-07-18 10:59:28 +02:00
wmayer
4dae806188 PVS: V572 It is odd that the object which was created using 'new' operator is immediately cast to another type 2020-07-18 10:59:28 +02:00