Commit Graph

12762 Commits

Author SHA1 Message Date
Russell Johnson
aaae829704 Path: Integrate 4th-axis feature to PathPocketShape and 3D Surface ops (#2114)
* PathSurface: Add StepDown support

Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.

* Update PageOpSurfaceEdit.ui

* PathSurface: Activate CompletionMode input

Update code to use CompletionMode selection from user.

* PathSurfaceGui: Add Completion Mode selection box

Add Completion Mode selection box for user input.

* PathSurface: Use depth_params() for step control

Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.

* PathSurface: Improve stability - Rev3

Organized code better, improved path optimization algorithm

* PathSurface: Add XY rotational surfacing

Add options to perform 3D surfacing by rotating object around X or Y axis.

* PathSurface: update setup function

Add properties to setup function

* PathSurface: Remove extraneous code

removed commented lines that consume processing time

* PathSurface: Correct nxt.z point assignment

Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z

* PathSurface: Update 4th axis operation

Provided both parallel and perpendicular to axis  scans when performing rotational operation.

* PathSurface: Corrected Y-axis rotation to gcode

Inverted Y-axis scan values in gcode to produce correct result

* PathSurface: Adjust gcode feed rates

Adjust feed rates for axial rotations

* PathSurface: Implement waterline alternative

Used OCL dropcutter scan as data base for python algorithm to extract a waterline.  Waterline also incorporates step down feature.

* PathSurface: Update to 3m-Usable

stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills

* PathSurface: Update 3m-Usable_r1

change instantiated static class attributes from value None, to 0.0

* PathSurface: Revert to 3i-Usable_r1

Further testing needed for 3m-Usable release

* PathSurface: Update to Rev. 3s Usable

fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb

* PathSurface: Update to Rev. 3t Usable

Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation

* Implement 4th-axis feature

Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii

* Deleted reference to undeclared variable

* Added missing class attributes/variables

* Added missing class variables/attributes

* Relocate class variables to higher class

* Remove references to undeclared variables

relocated class variables here
delete references to undeclared variables

* Correct rotation direction for normal-to-Y faces

* Remove X oriented 180 degree rotation adjustment

Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation

* Update 4th-axis integration

Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature.  EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.

* PathSurface: Add StepDown support

Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.

* Update PageOpSurfaceEdit.ui

* PathSurface: Activate CompletionMode input

Update code to use CompletionMode selection from user.

* PathSurfaceGui: Add Completion Mode selection box

Add Completion Mode selection box for user input.

* PathSurface: Use depth_params() for step control

Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.

* PathSurface: Improve stability - Rev3

Organized code better, improved path optimization algorithm

* PathSurface: Add XY rotational surfacing

Add options to perform 3D surfacing by rotating object around X or Y axis.

* PathSurface: update setup function

Add properties to setup function

* PathSurface: Remove extraneous code

removed commented lines that consume processing time

* PathSurface: Correct nxt.z point assignment

Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z

* PathSurface: Update 4th axis operation

Provided both parallel and perpendicular to axis  scans when performing rotational operation.

* PathSurface: Corrected Y-axis rotation to gcode

Inverted Y-axis scan values in gcode to produce correct result

* PathSurface: Adjust gcode feed rates

Adjust feed rates for axial rotations

* PathSurface: Implement waterline alternative

Used OCL dropcutter scan as data base for python algorithm to extract a waterline.  Waterline also incorporates step down feature.

* PathSurface: Update to 3m-Usable

stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills

* PathSurface: Update 3m-Usable_r1

change instantiated static class attributes from value None, to 0.0

* PathSurface: Revert to 3i-Usable_r1

Further testing needed for 3m-Usable release

* PathSurface: Update to Rev. 3s Usable

fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb

* PathSurface: Update to Rev. 3t Usable

Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation

* Implement 4th-axis feature

Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii

* Deleted reference to undeclared variable

* Added missing class attributes/variables

* Added missing class variables/attributes

* Relocate class variables to higher class

* Remove references to undeclared variables

relocated class variables here
delete references to undeclared variables

* Remove X oriented 180 degree rotation adjustment

Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation

* Correct rotation direction for normal-to-Y faces

* Update 4th-axis integration

Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature.  EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.

* Apply XYZ Model translations to paths; Add rotation axis selection property

* Spelling correction

ln 110

* Geometry list box: shrink height

560 to 400 height

* Update 4th-axis integration

Clean up code
Add comments for visionary elements
Apply axis selection to opHeights rotational calculations

* Update 4th-axis integration

Prepare sorting of vertical faces per axis_angle grouping, just as horizontal faces are sorted, for analysis as connected shapes

* Reset to FreeCAD master current

* Reset to current FreeCAD master version

* Update PathPocketBase.py

* Reset to current FreeCAD master

* Corrected __created__ date

* Convert all print() to PathLog.debug()

* Convert print() to PathLog.debug(); Clean up code

Use PathLog.debug over print() for troubleshooting
Clean up large commented sections of code.

* Convert print() to PathLog.debug(); combine duplicate methods

* Update last modified stamp

* Update last mofified timestamp

Also, removed commented-out code

* Typo corrected: "selt." to "self."

Discovered in https://api.travis-ci.org/v3/job/526456071/log.txt
on 30 April 2019 while searching for errors related to failure of PR #2114

* Restore initialization of self.depthparams

PR is failing Travis CI build test. Previous deletion of this code appears to be the reason.
See report at: https://api.travis-ci.org/v3/job/526492709/log.txt

* Convert tuple sizes from other PathWB ops

* B-axis rotation: render correction

* Revert "rebase to FC master 2019-05-02"

* Correct depthparams opOnDocumentRestored() issue

* Relocate "UseRotation" property from PathAreaOp.py

* Improve meshFromShape() calculation per @sliptonic

faster mesh creation
helps smooth jagged lines in path results

* Part: Make 3rd party libraries into PCH

* PartDesign: 3rdParty to PCH

* Sketcher: PCH

* PartDesign: PCH GUI

* Sketcher: GUI PCH

* Travis windows build (#2110)

Travis windows build

* Travis: enable clcache debug

* disable travis clcache debug

* respect user settings for dialog used in merge-document command

* msbuild verbose and logo

* Travis force wait 60 minutes

* Travis: Use & between vars sourcing and msbuild

* Travis: Move building to external batch script (#2131)

* Travis: Move building to external batch script

* Travis: double quotes to escape route

* Travis: use cmd.exe to call batch file

* Crowdin: fix grammatical error + whitespace 

https://crowdin.com/translate/freecad/569/en-fi#6498705

* Crowdin: experiment to fix crowdin 'ghost' strings

The following translation strings still perpetuate after updating crowdin translations. This commit experiments with removing their source counterparts in the FC .ts files. I'm not sure why they are not rendered obsolete by the normal operations. 
  
* https://crowdin.com/translate/freecad/6766/en-en#6499472  
* https://crowdin.com/translate/freecad/6766/en-en#6573450

* fix for edit tracker draw styles

* deleted commented code

* Travis: filter out

* AddonManager: allow to add custom repositories

* Revert "rebase to FC master 2019-05-02"

* Draft: Fixed Draft text justification

* Arch: Fixed bug in arch windows creation

* Arch: Fixed export of windows colors to IFC

* Draft: Fixed 0.18.1 bug in DXF importer

* Arch: Fixed wrong exported objects in IFC export

* Arch: Fixed export of sites to IFC

* Start: Fixed bad default icon in start page

* Correct depthparams opOnDocumentRestored() issue

* Relocate "UseRotation" property from PathAreaOp.py

* Improve meshFromShape() calculation per @sliptonic

faster mesh creation
helps smooth jagged lines in path results

* Relocate "UseRotation" property in PathAreaOp.py

* Syntax correction

Travis CI python 3.7 build test fails regularly due to syntax error at this point

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* path pep8 cleanup

* Multi-face geometry selection repaired

Previous version broke ability to select process multiple faces selected by user in geometry tab in operation task window.
Also performed some syntax cleaning per PEP8 linter

* Update script version info
2019-05-06 21:29:08 -05:00
carlopav
49ed29cd0b Update DraftGui.py
found another bug: when aligning to y axis while tracing a line, the focus is not set on the length if the option is checked in preferences. this should fix it.
2019-05-06 10:23:37 -03:00
carlopav
c17a89973f Draft GUI setfocus if lengthValue is not visible
If set focus on length instead of x coordinate is checked, Draft set the focus on it also if the lengthValue is not visible
2019-05-06 10:23:37 -03:00
luz.paz
519bbfe503 Misc. source comment typo and whitespace fixes 2019-05-06 13:42:30 +02:00
sliptonic
56953251ad Merge pull request #2101 from Schildkroet/master
G2 arcs for helix ramp in PathAdaptive operation
2019-05-06 05:35:45 -05:00
wandererfan
d078f901c7 Pass font/fontsize to RT editor 2019-05-05 21:01:31 -04:00
wandererfan
6c699887c0 Leader and RichText block improvements 2019-05-05 21:01:31 -04:00
wandererfan
7f07195f93 Text Leader initial version 2019-05-05 21:01:31 -04:00
sliptonic
8118359fdd Merge branch 'master' into master 2019-05-05 17:05:50 -05:00
brad
6bd378b0e1 Path: refactor PathEngrave.py 2019-05-04 17:27:45 -05:00
easyw
6a7649d2f0 fix stpZ file exporting (six & py3 issue) 2019-05-04 14:34:30 -03:00
easyw
dd62a3e66b fixing locale issue for Image WB
https://forum.freecadweb.org/viewtopic.php?f=3&t=36069#p305570
2019-05-04 14:33:01 -03:00
Yorik van Havre
8d237da7cb Draft: Keep using the already set working plane, if existing 2019-05-04 14:31:43 -03:00
Syres916
fad8fa4071 importDXF draftWPlane Fix
To fix error:
    w.Placement = placementFromDXFOCS(polyline)
  File "E:\Data\My Downloads\FreeCAD_0.19.16587_x64_Conda_Py3QT5-WinVS2015\FreeCAD_0.19.16587_x64_Conda_Py3QT5-WinVS2015\Mod\Draft\importDXF.py", line 422, in placementFromDXFOCS
    draftWPlane = FreeCAD.DraftWorkingPlane
<class 'AttributeError'>: module 'FreeCAD' has no attribute 'DraftWorkingPlane'
2019-05-04 14:31:43 -03:00
wmayer
222ae7305f revert 3a133ee0 to fix build failure 2019-05-04 12:36:00 +02:00
Abdullah Tahiri
df38102017 PCH: Part GUI 2019-05-03 23:15:25 +02:00
Abdullah Tahiri
3a133ee0cb Path: Add libarea to PCH 2019-05-03 23:15:09 +02:00
Abdullah Tahiri
5866306efd Path: PathSimulator PCH 2019-05-03 23:15:09 +02:00
Abdullah Tahiri
1bb08559d4 PCH: Path GUI 2019-05-03 23:15:09 +02:00
Abdullah Tahiri
b22d59c0aa PCH: Path App 2019-05-03 23:15:09 +02:00
wmayer
c373a58746 fix warning 2019-05-03 18:20:36 +02:00
Yorik van Havre
d4ed08f75a Start: Fixed bad default icon in start page 2019-05-02 18:01:08 -03:00
Yorik van Havre
f94cdfd798 Arch: Fixed export of sites to IFC 2019-05-02 17:02:14 -03:00
Yorik van Havre
5c700f76ec Arch: Fixed wrong exported objects in IFC export 2019-05-02 16:21:39 -03:00
Yorik van Havre
e98bb1fc21 Draft: Fixed 0.18.1 bug in DXF importer 2019-05-02 16:09:36 -03:00
Yorik van Havre
107fa5ae28 Arch: Fixed export of windows colors to IFC 2019-05-02 16:02:19 -03:00
Yorik van Havre
0493d23d8d Arch: Fixed bug in arch windows creation 2019-05-02 15:43:07 -03:00
Yorik van Havre
bd7aa678f7 Draft: Fixed Draft text justification 2019-05-02 15:23:20 -03:00
Yorik van Havre
23d914b3e8 AddonManager: allow to add custom repositories 2019-05-02 15:05:48 -03:00
luz.paz
acf12ee8f0 Crowdin: experiment to fix crowdin 'ghost' strings
The following translation strings still perpetuate after updating crowdin translations. This commit experiments with removing their source counterparts in the FC .ts files. I'm not sure why they are not rendered obsolete by the normal operations. 
  
* https://crowdin.com/translate/freecad/6766/en-en#6499472  
* https://crowdin.com/translate/freecad/6766/en-en#6573450
2019-05-02 13:35:32 -03:00
luz.paz
25c3310fbd Crowdin: fix grammatical error + whitespace
https://crowdin.com/translate/freecad/569/en-fi#6498705
2019-05-02 13:34:39 -03:00
Abdullah Tahiri
dc32a0685b Sketcher: GUI PCH 2019-05-02 07:12:51 +02:00
Abdullah Tahiri
e82c154d1d PartDesign: PCH GUI 2019-05-02 07:12:51 +02:00
Abdullah Tahiri
95788dde71 Sketcher: PCH 2019-05-02 07:12:27 +02:00
Abdullah Tahiri
a415ad72e1 PartDesign: 3rdParty to PCH 2019-05-02 07:12:27 +02:00
Abdullah Tahiri
a56658489b Part: Make 3rd party libraries into PCH 2019-05-02 07:09:22 +02:00
wmayer
43bdef67d6 continue PCH on Part module 2019-05-01 16:10:38 +02:00
wmayer
bf06b51e77 add comment 2019-05-01 13:54:06 +02:00
Abdullah Tahiri
e80af8b4f2 PCH for Sketcher/PartDesign 2019-05-01 09:05:55 +02:00
Bernd Hahnebach
a733dc6ddd Arch: ifc properties, Py3 fix 2019-04-30 18:01:43 +02:00
Abdullah Tahiri
3f42ee7664 Part: Missing PCH header 2019-04-30 15:35:25 +02:00
luz.paz
0238906d38 Misc. typo and whitespace fixes
Found via `codespell`
2019-04-30 10:15:59 -03:00
carlopav
33861e075e Update DraftTools.py
Draft Edit, fixed a problem in bezier curve editing.
2019-04-30 10:14:29 -03:00
carlopav
1b421dcd05 Update DraftTools.py
Improved Draft Edit node selection adding tolerance when selectin a node that is coincident to an edge or a face
2019-04-30 10:14:29 -03:00
carlopav
129ed37b0f Update DraftTools.py
cleaned comments
2019-04-30 10:14:29 -03:00
carlopav
350a7a58cb Update DraftTools.py
Fixed selection of editpoint on edge
2019-04-30 10:14:29 -03:00
carlopav
accc8815e6 Improved node selection
Allows to select an edit node also if it doesn't lay on an object.
2019-04-30 10:14:29 -03:00
Bernd Hahnebach
90dadd19c0 Arch: ifc export, ifc roof does not have a predefined type in IFC 2x3 2019-04-30 07:41:47 +02:00
wandererfan
66b091e625 Fix handling of Visibility property on Restore 2019-04-29 14:19:41 -04:00
Bernd Hahnebach
3651b9b8c1 Merge pull request #2102 from berndhahnebach/bhbdev211
Material: editor improvements
2019-04-29 18:57:16 +02:00