Commit Graph

1783 Commits

Author SHA1 Message Date
Markus Lampert
ab9bf8c222 Add basic thread milling op 2020-12-03 18:15:36 -08:00
sliptonic
9f930af3fe Merge pull request #4097 from Russ4262/millface_fix
Path: Millface fix - Address rounding issue
2020-12-03 13:29:14 -06:00
sliptonic
1951c20f66 Add finaldepth property.
Operation now sets start/final depth more reasonably.
Will not violate the finaldepth.
2020-12-02 15:05:08 -06:00
Russell Johnson
6200f1afc0 Path: Swap list instantiation per senior devs specifications 2020-12-02 11:34:58 -06:00
Russell Johnson
361e5edc29 Path: Instate obj.removalshape property for debugging purposes 2020-12-02 11:34:58 -06:00
Russell Johnson
ffa9b78df1 Path: Address problem with rounding issue
Translate removal shape down into buffer zone to offset rounding issue.
2020-12-02 11:34:58 -06:00
sliptonic
6c3dc29194 Merge pull request #4071 from Russ4262/fix_rotational_drilling_depth
Path: Fix Drilling Op issues when using rotation feature
2020-12-02 10:22:01 -06:00
sliptonic
292a711922 Merge pull request #4096 from sliptonic/bug/toolbit
[path]  make toolbit reject invalid filenames and prompt user for valid toolbit working location
2020-12-02 08:51:49 -06:00
luzpaz
cb3326b8cb Path: Added revision suggested by @cheenes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
[skip ci]
2020-12-02 06:57:56 -05:00
luz paz
141d018781 Path: fix translation to reflect the correct context
[skip ci]
2020-12-02 06:57:28 -05:00
luz paz
10790ed701 Path: Added missing Path_Custom in previous commit 2020-12-02 06:57:28 -05:00
luz paz
aeafcec125 Path: Change filenames in the rest of the Path code
Reflects changes in 
* PathOpGui.SetupOperation()
* GetResources()
* sPIxmap
* pixmap
* *.UI files

Also contains minor translation context renames (these were edits made near to original intent of this commit)
2020-12-02 06:57:28 -05:00
sliptonic
5a0e0bada6 PR review suggestions and fixes 2020-12-01 09:43:45 -06:00
Russell Johnson
3cc32fc991 Path: Delete unnecessary comment block 2020-11-30 21:09:58 -06:00
Russell Johnson
50ad479bfb Path: Replace all-caps variable name 2020-11-30 21:09:58 -06:00
Russell Johnson
b0916dd6bc Path: Simplify ActiveDocument references 2020-11-30 21:09:58 -06:00
Russell Johnson
ad6645f492 Path: Fix rotational errors and organize/simplify some rotational code
Fix rotational alignment and drilling depth issues for rotational drilling ops.
Issues identified in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=52262.
Path:
2020-11-30 20:57:25 -06:00
Russell Johnson
ce65794a10 Path: Clean up comments and simplify one code block 2020-11-30 20:57:25 -06:00
Russell Johnson
0a59b5307c Path: Synchronize methods with same in PathAreaOp module
The affected methods exist in the PathAreaOp module.  This commit synchronizes the versions here with those.
2020-11-30 20:57:25 -06:00
Russell Johnson
6bbc56cd4b Path: Apply the user's Final Depth value 2020-11-30 20:57:25 -06:00
sliptonic
411562361b fix ui bugs 2020-11-30 15:35:30 -06:00
sliptonic
daea1f53da [path] make toolbit reject invalid filenames
help user create toolbit working location
2020-11-30 15:32:28 -06:00
sliptonic
a42355939a Merge pull request #4073 from Russ4262/fix_slot
Path: Fix arc slotting direction in Slot operation
2020-11-23 15:08:40 -06:00
sliptonic
152351e8a8 Merge pull request #4014 from sliptonic/feature/toolbitdock
[PATH] Feature/toolbitdock
2020-11-23 10:12:58 -06:00
Russell Johnson
37cd09e7ae Path: LGTM cleanup 2020-11-22 18:27:21 -06:00
Russell Johnson
1468c7e842 Path: Implement LazyLoader for Arcs module 2020-11-22 18:27:21 -06:00
Russell Johnson
da3f052270 Path: Fix g-code arc direction
Fixed incorrect point orders assigned to g2 and g3 commands.
Add application of `ReverseDirection` property to `ZigZag` cut pattern.
Make default arc direction clockwise(g2) for all cut patterns and layer modes.
Make tool diameter access backward compatible.
2020-11-22 18:27:21 -06:00
Russell Johnson
1ee1c9a5df Path: Simplify and fix debugging code 2020-11-22 15:38:50 -06:00
Russell Johnson
0d5a728698 Path: Standardize debugging mode control code 2020-11-22 15:37:31 -06:00
sliptonic
015250c810 revert docstring format for help box formatting.
log levels reset to INFO
remove unnecessary comments.
2020-11-22 11:08:28 -06:00
sliptonic
3a8f40a458 fix 'add' button in Job task panel
fix chamfer bit
lgtm cleanup
2020-11-19 17:10:50 -06:00
sliptonic
2e552e88b2 bug: on deleting tool controllers 2020-11-16 12:40:18 -06:00
sliptonic
fff4ed8a5c minor change to make toolcontroller labels better 2020-11-15 18:41:08 -06:00
sliptonic
5f52152f2c Rework default library and toolbits 2020-11-15 18:22:45 -06:00
sliptonic
4fc3adc8f6 Add toolcontroller to open operation 2020-11-15 18:22:45 -06:00
sliptonic
145b915663 Only allow editing of toolbit if shapefile is found 2020-11-15 18:22:45 -06:00
sliptonic
dbf3ebeabe Handle errors is toolbit json more gracefully 2020-11-15 18:22:45 -06:00
sliptonic
cbc8524ff9 Make Toolbit find Bit files relative to the current library directory 2020-11-15 18:22:45 -06:00
sliptonic
1672a33647 Fix duplicate docs being created
fix edit changes not being retained
fix edit removing new toolbit from diretory
2020-11-15 18:22:45 -06:00
sliptonic
d563530c3c Removed diameter dependencies so lathe tools work 2020-11-15 18:22:45 -06:00
sliptonic
3b6dbf8dca Fix default directory bug 2020-11-15 18:22:45 -06:00
sliptonic
ec3285a006 added attribute to Toolbit for spindlepower
setting this to false will suppress M3 commands.
User can configure a toolbit to never have the spindle turn on
this is to prevent accidental powering of the spindle with
unpowered tools like dragknife and probe
2020-11-15 18:22:45 -06:00
sliptonic
5c47912cc1 Better cleanup on new toolbit creation 2020-11-15 18:22:45 -06:00
sliptonic
09bb0d404d fix bug in create toolbit flow 2020-11-15 18:22:45 -06:00
sliptonic
e335fe5384 Editing Works 2020-11-15 18:22:45 -06:00
sliptonic
b556aa47de Basic workflow. No editing
concept dock work
most functions working.
made linuxcnc export work
Fixed some defaults on new install
fixed display label in dock
2020-11-15 18:22:45 -06:00
Russell Johnson
60249f543c Path: Delete irrelevant code 2020-11-13 16:34:59 -06:00
Russell Johnson
6046e0600b Path: Fix div by zero error
Fix MillFace div by zero error reported in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=51415.
Rotational-related variables were exposed to non-rotational code block.  They have been moved into correct rotational code block.
2020-11-13 16:34:59 -06:00
Russell Johnson
5bb979e34a Path: LGTM cleanup 2020-11-13 16:34:59 -06:00
Russell Johnson
cae33892e1 Path: Organize rotational code in areaOpShapes() method
Relocate the rotational analysis code into smaller independent methods to allow for easier maintenance and support.
Commented out recently added debug object creation statement.
2020-11-13 16:34:59 -06:00