wmayer
abed4bd421
PD: [skip ci] fixes #0004205 : Bad behavior when entering manually PD/AdditivePipe path
2021-02-15 00:06:29 +01:00
donovaly
bcadbe3b1b
[PD] rename icons to match Wiki files
...
For the What#s this feature we need to have a uniform naming of the features and its icons. For some PD icons this is not the case and since we are in feature freeze, this is the right time to address this.
(I see the same is already done for Mesh.)
2021-02-11 12:47:25 +01:00
Chris Hennes
40c99417bd
[PD] Catch Python exceptions in dtors (Coverity)
...
In some PartDesign task dialogs, the destructors call functions that may
throw exceptions. If that occurs and the exception is uncaught, this
will ususally end up terminating the program. This commit adds try-catch
blocks around each instance of that (identified by Coverity) and handles
the Python exception in the normal reporting workflow.
2021-02-08 21:30:22 +01:00
donovaly
b483fc0518
[PD] make pointers to the UI std::unique_ptr
...
Same as PR #4293 , just for PartDesign
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.
This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
2021-02-05 18:01:57 +01:00
wmayer
c69612c748
PD: improve reference highlighting of a pipe
...
This change allows to highlight the spline, auxiliary spine, profile and sections of a pipe.
This gives the user a much better feedback of what external shapes are already used to build the pipe
2020-09-17 16:19:38 +02:00
wmayer
44b1a27cd4
PD: [skip ci] fixes for pipe task panel
...
+ Add/Remove are checkable buttons so if user unchecks it then disable highlighting of spine
+ Avoid superfluous char* -> QString conversion
2020-09-17 14:04:36 +02:00
wmayer
8fa096f23b
PD: fixes for pipe task panel
...
+ fix Qt4 build failure
+ fix handling of adding items to spine/auxiliary spine/sections to allow to remove them again
+ QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous
2020-09-17 11:35:41 +02:00
donovaly
329c763916
[PD] add context menus to sweep Dialog
...
- elements in the list of edges/spines/sections can now be deleted by pressing DEL and there is a context menu for this action
see https://forum.freecadweb.org/viewtopic.php?f=19&t=50222&p=431021#p431021
2020-09-17 00:45:43 +02:00
wmayer
dc7de6b195
PD: do not use active document in task dialogs because this is error-prone
2020-09-15 13:21:32 +02:00
mwganson
7d392d1209
[Part Design] allow for preselecting loft sections and pipe spines prior to invoking command
2020-09-15 10:48:09 +02:00
wmayer
9b2a6edeb0
Coverity: Uncaught exception
2020-07-20 17:34:29 +02:00
wmayer
7683bb2b4f
Fix usage of Reference dialog:
...
+ fix memory leak by using QDialog on the stack
+ open a transaction where needed when making a copy to avoid mess with undo/redo
+ set proper title and use main window as parent
+ replace class name Dialog with PartDesignGui::DlgReference
2018-12-03 17:54:05 +01:00
wmayer
00de5bb7ad
Replace Base::Exception with appropriate subclass
2018-11-14 19:28:00 +01:00
wmayer
0b8ff8de0b
clean-up work in TaskPipeOrientation
2018-09-20 17:47:36 +02:00
wmayer
149262a7cc
fixes #0003599 : PartDesign Additive and Subtractive Pipe features don't allow changing sections after creation
2018-09-20 17:17:41 +02:00
wmayer
525a44905a
issue #0003599 : PartDesign Additive and Subtractive Pipe features don't allow changing sections after creation
2018-09-20 15:14:33 +02:00
wmayer
0e4a3d2dba
fix possible crash in pipe/scaling task panels
2018-03-10 16:53:14 +01:00
Unknown
31a32b9931
Doxygen Typos
...
+ doxy whitespace formatting
+ added more misc. typos
+ grammar fixes
[skip ci]
2017-10-15 16:27:42 +02:00
wmayer
14f6de974b
fix typos
2017-09-25 22:36:31 +02:00
Kurt Kremitzki
79a6f66b35
Check PartDesign::AdditivePipe's auxiliary spine for existence before deciding its externality
2017-07-01 19:30:49 -05:00
Kunda
9410e751e9
source typo fixes pt4 (only on py3 merged code)
2017-03-02 13:47:21 +01:00
wmayer
7b782e595f
fix crash when pressing cancel on pipe task panel
2017-01-24 15:00:41 +01:00
Stefan Tröger
526d895a5d
PartDesign: Port body to be a origin group
2017-01-04 16:01:58 +01:00
wmayer
dd7c91ddcf
fix -Wextra in PartDesign
2016-09-22 18:34:56 +02:00
wmayer
9e4bed2983
fix whitespaces
2016-08-25 12:27:08 +02:00
wmayer
17de4e2efa
fix Coverity issues
2016-08-22 15:02:18 +02:00
Stefan Tröger
42cb9ee8cd
PartDesign: Fix pipe preview display
...
When a base feature was available the preview mode did not show the pipe and also set the visibility of the pipe to false
2016-05-18 23:53:49 +02:00
Stefan Tröger
bad7901b66
PartDesign: Handle pipe external references
2016-05-18 23:53:33 +02:00
Alexander Golubev
9347f66a9e
PartDesign/Gui: Move various utility stuff from Workbench to a separate file
...
Also do some header cleanup.
2016-04-12 18:12:17 +02:00
Stefan Tröger
5b44e38c89
remove linear and S-shape scaling from pipe
...
They worked and are nice feature, but the handling with properties must be worked out better. To avoid any incompatibility due to property changes the functionality is removed now.
2016-04-12 18:12:13 +02:00
Stefan Tröger
4b2cecb59a
fix pipe task dialog icon
2016-04-12 18:12:13 +02:00
Stefan Tröger
d18cd54743
make part design loft functional
2016-04-12 18:12:10 +02:00
Stefan Tröger
b425c028ee
Update pipe icon and add it to the taskwatcher
2016-04-12 18:12:09 +02:00
Stefan Tröger
7d584f82a2
simple bugfixes
2016-04-12 18:12:09 +02:00
Stefan Tröger
f199c844e6
add two scaling modes
2016-04-12 18:12:09 +02:00
Stefan Tröger
ad352e9b33
make multisection work
2016-04-12 18:12:09 +02:00
Stefan Tröger
7fc0111944
better pipe view handling
2016-04-12 18:12:09 +02:00
Stefan Tröger
254e2226ba
generalize preview mode
2016-04-12 18:12:09 +02:00
Stefan Tröger
31ac29501c
implement faster pipes with inner wires
2016-04-12 18:12:09 +02:00
Stefan Tröger
be7d962595
add options for pipe tool
2016-04-12 18:12:09 +02:00
Stefan Tröger
835085bc7c
add basic part design pipe infrastructure
2016-04-12 18:12:09 +02:00
