Commit Graph

158 Commits

Author SHA1 Message Date
wmayer
acded1c954 save values before invalidating iterator, whitespace improvements 2018-01-27 13:09:44 +01:00
Abdullah Tahiri
94ca105315 Sketcher: Setting in Preferences to switch on/off notification of constraint substitution
=========================================================================================

By default notification is on, so that Newbies do not complain why FC is deleting that other constraint they have added before.

Power users generally will set it off, as they do not want to be bothered by pop ups and know what they are doing.
2018-01-27 12:33:11 +01:00
Abdullah Tahiri
620188073e Sketcher: Avoid single tangency plus coincident when preexisting single tangency
================================================================================

fixes #3299 (remaining)

Draw a line. Draw an arc. Make edge to edge tangency. Select endpoints. Try to create a coincident constraint. You now get an Endpoint-to-Endpoint tangency.
2018-01-27 12:33:11 +01:00
Abdullah Tahiri
180d722a53 Sketcher: Avoid single tangency when preexisting coincident
==========================================================

partly fixes 3299

Draw a line. Draw an arc. Make one endpoint of each coincident. Select the line. Select the Arc. Hit tangency. You now get an Endpoint-to-Endpoint tangency.
2018-01-27 12:33:11 +01:00
wmayer
38da0c7312 improve whitespace, fix const correctness 2018-01-23 00:40:41 +01:00
Abdullah Tahiri
c7b137fe85 Sketcher: Change nomenclature relating to Block constraint 2018-01-22 22:52:56 +01:00
Abdullah Tahiri
c27d5a26b2 Sketcher: UI Block constraint creation sanity checks
====================================================

Avoid creation of constraints if they would lead to undesirable conflicting situations.
2018-01-22 22:52:56 +01:00
Abdullah Tahiri
9634da6811 Sketcher: Block constraint - Prevent from adding constraint if the solver has redundant/conflicting constraints 2018-01-22 22:52:56 +01:00
Abdullah Tahiri
1932a2f152 Sketcher: Blocked Constraint toolbar commands 2018-01-22 22:52:56 +01:00
luzpaz
048c787e32 Sketcher: comment typos 2017-12-25 10:59:48 +01:00
Abdullah Tahiri
4006c6ee97 Sketcher: Fixes no horizontal/vertical on edge if previous horizontal/vert aligment on vertex
=============================================================================================

fixes #3257
2017-12-07 11:11:40 +01:00
Abdullah Tahiri
aa43197976 Refactoring solve+recompute and reinstating initial solve+recompute behaviour 2017-08-19 17:14:27 +02:00
wmayer
2004544e57 fixes #0002710: Freecad doesn't show sketch elements added when overconstrained
issue #0002836: Crash in sketcher
2017-08-19 17:14:27 +02:00
luzpaz
81bdb1f276 Sketcher: typo fix 2017-07-24 18:21:17 -03:00
Abdullah Tahiri
40c6d4be1a Sketcher: Vertical alignment constraint command 2017-05-01 22:39:37 +02:00
Abdullah Tahiri
cfc2d86c2e Sketcher: Horizontal alignment constraint command 2017-05-01 22:39:08 +02:00
Abdullah Tahiri
e44208d56c Sketcher: Lock constraint bug fix 2017-04-22 18:16:27 +02:00
Abdullah Tahiri
0aa9438c0a Sketcher: Lock constraint relative mode and group locking 2017-04-22 18:16:27 +02:00
wmayer
c2e83c7818 consistently use term 'B-spline' in the sketcher GUI 2017-04-12 09:37:58 +02:00
wmayer
ce36b29cb7 fix scan coverity issues 2017-04-11 15:06:37 +02:00
Abdullah Tahiri
2a58ac0cf8 Sketcher: New function to reuse of python exception message text in the UI 2017-04-10 08:57:25 +02:00
Abdullah Tahiri
418beea589 Sketcher: Only Reference constraints allowable on construction points like bspline knots 2017-04-08 12:58:06 +02:00
Abdullah Tahiri
02e370d392 Sketcher: Enable reuse of constraint helper functions in other toolbars
=======================================================================

bool checkBothExternal(int GeoId1, int GeoId2);
void getIdsFromName(const std::string &name, const Sketcher::SketchObject* Obj, int &GeoId, Sketcher::PointPos &PosId);
bool inline isVertex(int GeoId, Sketcher::PointPos PosId);
bool inline isEdge(int GeoId, Sketcher::PointPos PosId);
bool isSimpleVertex(const Sketcher::SketchObject* Obj, int GeoId, Sketcher::PointPos PosId);
bool IsPointAlreadyOnCurve(int GeoIdCurve, int GeoIdPoint, Sketcher::PointPos PosIdPoint, Sketcher::SketchObject* Obj);
2017-04-08 12:58:06 +02:00
wmayer
b217fe2287 set continuous constraint mode consistently to true by default 2017-02-24 16:30:13 +01:00
wmayer
a90014c646 add missing word, fix layout 2017-02-24 16:24:24 +01:00
AjinkyaDahale
fc08fa1c09 Sketcher: costraint creation mode uses toolbar icons 2017-02-24 15:20:26 +01:00
AjinkyaDahale
6be9a9bc53 Sketcher: Added option to turn constraint creation modes on/off
Can be found below geometry creation "continous mode" option
2017-02-24 15:20:26 +01:00
AjinkyaDahale
e757c57a30 Sketcher: External edges in constraint modes (Symmetry) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
31456a7e30 Sketcher: External edges in constraint modes (Angle) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
167b28d200 Sketcher: External edges in constraint modes (Equal) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
ff74ba32a8 Sketcher: External edges in constraint modes (radius) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
2ffd94df5f Sketcher: External edges in constraint modes (tangent) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
daf5a1fdbf Sketcher: External edges in constraint modes (perpendicular) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
29761fc90d Sketcher: External edges in constraint modes (parallel) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
89664982fb Sketcher: External edges in constraint modes (DistanceX/Y) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
c6fd807bd4 Sketcher: External edges in constraint modes (point on object) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
ab4a222dc6 Sketcher: External edges in constraint modes (distance) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
39725ff777 [Sketcher] Moved angle to constraint creation mode
plus some cosmetic changes
2017-02-24 15:20:26 +01:00
Abdullah Tahiri
9e6beb1a01 Sketcher: Information layer scenography update on geometry change 2017-02-21 13:24:10 +01:00
AjinkyaDahale
cc46acf10e [Sketcher] Moved radius to constraint mode framework 2017-02-10 17:32:18 +01:00
AjinkyaDahale
3d9b46d9f3 [Sketcher] corrected artifact introduced by faulty conflict resolution 2017-02-10 17:32:18 +01:00
AjinkyaDahale
3cf00a1314 [Sketcher] Moved distance to constraint mode 2017-02-10 17:32:18 +01:00
AjinkyaDahale
47624cf3e1 Moved vertical and horizontal distance to constraint creation mode 2017-02-10 17:32:18 +01:00
AjinkyaDahale
5ff6895080 Moved symmetric to general constrain creation mode framework
That makes all of the non-dimensioned constraints
2017-02-10 17:32:18 +01:00
AjinkyaDahale
45cb028f34 Moved equal to general constrain creation mode framework 2017-02-10 17:32:18 +01:00
AjinkyaDahale
adc13eda06 Move tangent to general constraint mode framework 2017-02-10 17:32:18 +01:00
AjinkyaDahale
df658ae889 Replace some of the allowedSelSequences with more general form
Greatly shortens the number of sequenses needed if you replace SelVertex
and SelRoot with SelVertexOrRoot and similar for the edges/axes.
For e.g. implemented sequences for perpendicular dropped from the older
25 to now 6.
2017-02-10 17:32:18 +01:00
wmayer
17a3d1e81f fix warnings: -Wmaybe-uninitialized 2017-02-04 15:16:47 +01:00
wmayer
33e0bc3a46 fix various warnings 2017-02-02 20:42:56 +01:00
AjinkyaDahale
e8c822c93e Changes based on wwmayer's comments 2017-01-31 17:07:45 +01:00