Commit Graph

2127 Commits

Author SHA1 Message Date
sliptonic
caf30cd7ce Merge pull request #4071 from Russ4262/fix_rotational_drilling_depth
Path: Fix Drilling Op issues when using rotation feature
2020-12-02 10:22:01 -06:00
sliptonic
60e1d7a7f7 Merge pull request #4096 from sliptonic/bug/toolbit
[path]  make toolbit reject invalid filenames and prompt user for valid toolbit working location
2020-12-02 08:51:49 -06:00
luzpaz
22c652f766 Path: Added revision suggested by @cheenes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
[skip ci]
2020-12-02 06:57:56 -05:00
luz paz
5dc381a71d Path: fix translation to reflect the correct context
[skip ci]
2020-12-02 06:57:28 -05:00
luz paz
0e4cf2e758 Path: Added missing Path_Custom in previous commit 2020-12-02 06:57:28 -05:00
luz paz
fe547195bf Path: Change filenames in the rest of the Path code
Reflects changes in 
* PathOpGui.SetupOperation()
* GetResources()
* sPIxmap
* pixmap
* *.UI files

Also contains minor translation context renames (these were edits made near to original intent of this commit)
2020-12-02 06:57:28 -05:00
sliptonic
af153643f2 PR review suggestions and fixes 2020-12-01 09:43:45 -06:00
Russell Johnson
2461d942af Path: Delete unnecessary comment block 2020-11-30 21:09:58 -06:00
Russell Johnson
99beebc2af Path: Replace all-caps variable name 2020-11-30 21:09:58 -06:00
Russell Johnson
43d54e7f18 Path: Simplify ActiveDocument references 2020-11-30 21:09:58 -06:00
Russell Johnson
d52a96f2b5 Path: Fix rotational errors and organize/simplify some rotational code
Fix rotational alignment and drilling depth issues for rotational drilling ops.
Issues identified in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=52262.
Path:
2020-11-30 20:57:25 -06:00
Russell Johnson
43cd864f8f Path: Clean up comments and simplify one code block 2020-11-30 20:57:25 -06:00
Russell Johnson
693db4e4b6 Path: Synchronize methods with same in PathAreaOp module
The affected methods exist in the PathAreaOp module.  This commit synchronizes the versions here with those.
2020-11-30 20:57:25 -06:00
Russell Johnson
aa2d35cad8 Path: Apply the user's Final Depth value 2020-11-30 20:57:25 -06:00
sliptonic
3eb300a8c2 fix ui bugs 2020-11-30 15:35:30 -06:00
sliptonic
3d822cf269 [path] make toolbit reject invalid filenames
help user create toolbit working location
2020-11-30 15:32:28 -06:00
sliptonic
fc3bf09512 Merge pull request #4073 from Russ4262/fix_slot
Path: Fix arc slotting direction in Slot operation
2020-11-23 15:08:40 -06:00
sliptonic
40d79fc048 Merge pull request #4014 from sliptonic/feature/toolbitdock
[PATH] Feature/toolbitdock
2020-11-23 10:12:58 -06:00
Russell Johnson
d41369ad52 Path: LGTM cleanup 2020-11-22 18:27:21 -06:00
Russell Johnson
c6d5bb8404 Path: Implement LazyLoader for Arcs module 2020-11-22 18:27:21 -06:00
Russell Johnson
a61aa0563e Path: Fix g-code arc direction
Fixed incorrect point orders assigned to g2 and g3 commands.
Add application of `ReverseDirection` property to `ZigZag` cut pattern.
Make default arc direction clockwise(g2) for all cut patterns and layer modes.
Make tool diameter access backward compatible.
2020-11-22 18:27:21 -06:00
Russell Johnson
9f489b59eb Path: Simplify and fix debugging code 2020-11-22 15:38:50 -06:00
Russell Johnson
a0d7ff24e0 Path: Standardize debugging mode control code 2020-11-22 15:37:31 -06:00
sliptonic
56b6874526 revert docstring format for help box formatting.
log levels reset to INFO
remove unnecessary comments.
2020-11-22 11:08:28 -06:00
sliptonic
634fce6e35 fix 'add' button in Job task panel
fix chamfer bit
lgtm cleanup
2020-11-19 17:10:50 -06:00
sliptonic
26eac120b8 bug: on deleting tool controllers 2020-11-16 12:40:18 -06:00
sliptonic
a5efc81ff8 minor change to make toolcontroller labels better 2020-11-15 18:41:08 -06:00
sliptonic
c415272905 Rework default library and toolbits 2020-11-15 18:22:45 -06:00
sliptonic
f2eaa98bf1 Add toolcontroller to open operation 2020-11-15 18:22:45 -06:00
sliptonic
2da3308bc3 Only allow editing of toolbit if shapefile is found 2020-11-15 18:22:45 -06:00
sliptonic
472cb83ae7 Handle errors is toolbit json more gracefully 2020-11-15 18:22:45 -06:00
sliptonic
aa59e98b37 Make Toolbit find Bit files relative to the current library directory 2020-11-15 18:22:45 -06:00
sliptonic
7c3300dbf2 Fix duplicate docs being created
fix edit changes not being retained
fix edit removing new toolbit from diretory
2020-11-15 18:22:45 -06:00
sliptonic
0a77421481 Removed diameter dependencies so lathe tools work 2020-11-15 18:22:45 -06:00
sliptonic
e64f868765 Fix default directory bug 2020-11-15 18:22:45 -06:00
sliptonic
234b88cc18 added attribute to Toolbit for spindlepower
setting this to false will suppress M3 commands.
User can configure a toolbit to never have the spindle turn on
this is to prevent accidental powering of the spindle with
unpowered tools like dragknife and probe
2020-11-15 18:22:45 -06:00
sliptonic
88a24475b8 Better cleanup on new toolbit creation 2020-11-15 18:22:45 -06:00
sliptonic
42f7854a5e fix bug in create toolbit flow 2020-11-15 18:22:45 -06:00
sliptonic
7c4c25ceed Editing Works 2020-11-15 18:22:45 -06:00
sliptonic
0a2183fe4f Basic workflow. No editing
concept dock work
most functions working.
made linuxcnc export work
Fixed some defaults on new install
fixed display label in dock
2020-11-15 18:22:45 -06:00
Russell Johnson
d3c3a11d90 Path: Delete irrelevant code 2020-11-13 16:34:59 -06:00
Russell Johnson
a273bef210 Path: Fix div by zero error
Fix MillFace div by zero error reported in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=51415.
Rotational-related variables were exposed to non-rotational code block.  They have been moved into correct rotational code block.
2020-11-13 16:34:59 -06:00
Russell Johnson
9f13c8c23b Path: LGTM cleanup 2020-11-13 16:34:59 -06:00
Russell Johnson
01fa1fecd8 Path: Organize rotational code in areaOpShapes() method
Relocate the rotational analysis code into smaller independent methods to allow for easier maintenance and support.
Commented out recently added debug object creation statement.
2020-11-13 16:34:59 -06:00
Russell Johnson
c03a0bba62 Path: Fix and cleanup removal shape creation code
The `isFaceUp()` method in the PathAreaOp module was returning false results in some instances.
Rotational code has been consolidated and better organized to fix certain errors reported in the forum.
Overall, this code section has been better organized as a part of the necessary fixes.
2020-11-13 16:34:59 -06:00
Russell Johnson
7fb8f1149a Path: Improve accuracy of isFaceUp() method
This method is used in rotational operations and some standard operations to identify if a face's normal-direction Z value is +1.0
2020-11-13 16:07:18 -06:00
Russell Johnson
c357cb77a1 Path: Remove null comments and improve debugging
Added method to create a FreeCAD object when in debug mode.
2020-11-13 16:07:18 -06:00
sliptonic
9c49dc595f Merge pull request #3989 from Russ4262/Surface_fixes
Path: 3D Surface fix to apply `CutMode` when `CutPattern = Offset`; and LGTM cleanup
2020-11-13 14:25:19 -06:00
Dave Seff
139fac133f Make the tool setup images a bit nicer. 2020-11-12 16:59:22 +10:00
Daniel Wood
0392ca9b79 [Path] rename TurnPart to TurnPartoff 2020-11-11 08:44:09 +00:00