kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests 1 Actions Packages Projects 9 Releases 2 Wiki Activity
38,247 Commits 40 Branches 6 Tags
af114a021c089b546678c7757424a236cc9041e3
Commit Graph

65 Commits

Author SHA1 Message Date
wmayer
af114a021c PD: Fix possible crashes in dress-up task panels 2024-07-18 15:13:29 +02:00
wmayer
b1029bc682 PD: Replace helper functions in subclasses of TaskDlgFeatureParameters with a template function 2024-07-18 00:02:07 +02:00
wmayer
01d1e2b374 PD: Make blockUpdate private class member 2024-07-17 20:09:53 +02:00
wmayer
622e46771e PD: modernize C++: use equals default 2023-08-22 13:31:17 +02:00
wmayer
3e09b8ee2d PD: modernize C++: use range-based for loop 2023-08-16 21:54:56 -05:00
wmayer
22e6e2cd40 Part/PD: modernize C++: redundant void arg 2023-08-05 16:50:31 +02:00
wmayer
4c9d881cb6 PD: fix crash on Windows when loading PD workbench 2023-04-14 16:34:00 +02:00
Paddle
ea463a6a53 PartDesign: Fillet/chamger/draft/thickness: change the button strings to 'Preview' and 'Select' 2023-03-28 12:52:42 +02:00
Paddle
27481a68eb PartDesign: Fillet Draft Chamfer Thickness : Add warning message on empty feature creation 2023-03-28 12:52:42 +02:00
Paddle
bc22bf9c0d PartDesign: Fillet, Chamfer, Draft, Thickness : Enable tool to start with no selection. 2023-03-28 12:52:42 +02:00
Paddle
1689c99930 PartDesign: Fillet/chamfer/draft/thickness: Merge Add & Remove buttons. 2023-03-28 12:52:42 +02:00
wmayer
a122aa01a7 PD: move to new style connect() 2023-01-15 14:27:33 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
wmayer
2a33fe77f6 App/Gui: move template classes (ViewProvider)ExtensionPythonT to their own header files 2022-03-04 18:54:42 +01:00
Uwe
a68e017f19 [PD] Gui: Boolean to Groove: remove unused includes 2022-02-21 01:33:04 +01:00
wmayer
b165947625 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
donovaly
21d4a37e1f [PD] set App constraints for their Gui counterparts 
based on Werner's work yesterday, this PR takes care of the missing PD features to use the constraints already defined in App
 2021-03-04 11:03:24 +01:00
wmayer
48f56169de PD: [skip ci] fix regression caused by fdf7e6acbe120 
In the accept() method the view provider of the edited object must be made visible if it's valid as otherwise it can happen that the view is empty.

See https://forum.freecadweb.org/viewtopic.php?f=13&t=55915
 2021-02-23 11:20:45 +01:00
donovaly
3fdce54be7 [PD] fix dressup feature display when broken 
As discussed in https://forum.freecadweb.org/viewtopic.php?p=479647#p479377
the user can end up without either seeing nothing or an inexisting dressup feature.

This PR fixes this.
 2021-02-19 14:51:52 +01:00
Chris Hennes
40c99417bd [PD] Catch Python exceptions in dtors (Coverity) 
In some PartDesign task dialogs, the destructors call functions that may
throw exceptions. If that occurs and the exception is uncaught, this
will ususally end up terminating the program. This commit adds try-catch
blocks around each instance of that (identified by Coverity) and handles
the Python exception in the normal reporting workflow.
 2021-02-08 21:30:22 +01:00
donovaly
b483fc0518 [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
wmayer
950943f15e PartDesign: [skip ci] optimize when removing items from dress-up features 2020-02-23 14:58:48 +01:00
donovaly
fc66ea1778 [PD] only recompute once per deletion action 
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383&p=370357#p370357
 2020-02-23 12:43:11 +01:00
donovaly
320499f714 [PD] enable selection of fillets etc. using arrow keys in Dlg 
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383&p=370758#p370758
 2020-02-21 09:27:00 +01:00
donovaly
1a718a6371 improve code as suggested by Werner 
see https://forum.freecadweb.org/viewtopic.php?p=369921#p369921
 2020-02-18 23:16:48 +01:00
donovaly
d5c8ae0d16 [PD] missing changed from commit d4be4a02 
(key event handling for more dialogs)
 2020-02-18 22:29:53 +01:00
donovaly
83a4a918a0 try to squash GCC compile error 2020-02-18 00:08:58 +01:00
donovaly
c94ddff90c catch case that users tries to delete all items in the dialog list 2020-02-18 00:08:28 +01:00
donovaly
38b6160faa remove unnecessary code and comment 2020-02-18 00:07:01 +01:00
donovaly
58bb17478c enable selection in the dialog item list 
now the user can use the Ctrl and/or Shift key to select multiple items to be deleted
 2020-02-17 22:36:42 +01:00
donovaly
0283cb09fb improve fillet dialog logic 
- now also the case of only one item in the list is handled properly (single-click will highlight it, double-click will show the final fillet)
 2020-02-17 21:53:45 +01:00
wmayer
b06251e853 PartDesign: [skip ci] fix possible segmentation fault in destructors of dressup task panels 2020-02-16 20:58:44 +01:00
donovaly
9d28b3d390 [PD] add feature to highlight references in some dialogs 
- also fix some logic issues and avoid to break the feature (deleting the last item is now no longer possible)
 2020-02-16 05:18:29 +01:00
donovaly
1dfa6d40b4 [PD] enable to de/selecet several entities at once 
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383
 2020-02-15 04:07:09 +01:00
wmayer
60d9607112 PartDesign: use QKeySequence::Delete instead of a QString 2020-02-14 10:11:09 +01:00
donovaly
0310a99f4e [PD] add shortcut to context menus 
- people should be informed that there is a shortcut available (that was recently added)
- make the shortcut also translatable since "Del" means nothing in e.g. German
- minor code style fix in TaskDressUpParameters.h
 2020-02-14 09:59:46 +01:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity 
This PR fixes header uniformity across all PartDesign WB files
 2019-12-22 00:58:38 +01:00
Zheng, Lei
cd2b7e297c PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
1e6cfd430c support Del shortcut in several PD task dialogs 2019-02-27 13:36:45 +01:00
wmayer
1631935bc4 fixes 0003652: Missing little expression icon 2018-11-09 16:48:44 +01:00
sL1pKn07
6674467254 [For v018] Fix build with Qt5 beta 
Seems need add some headers for build with incoming Qt 5.11 (Tested with 5.11.0beta2)
 2018-04-10 12:59:41 +02:00
wmayer
dd7c91ddcf fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
Mateusz Skowroński
a8d37dabbe QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-04-15 11:55:12 +02:00
Stefan Tröger
463070b1f6 Fix crash on aborted pattern external axis 2016-04-12 18:12:22 +02:00
Alexander Golubev
771c2b2fce PartDesign/Gui: rename some fonctions in ReferenceSelection.cpp 
e.g. getPythonStr -> buildLinkListPythonStr etc
 2016-04-12 18:12:17 +02:00
Alexander Golubev
9347f66a9e PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Alexander Golubev
595f1e19f4 PartDesignGui: move signal connections in several parameter dialogs after ui initialization 2016-04-12 18:12:15 +02:00
Alexander Golubev
6778c548f4 PartDesign: move common code for TaskDlg{SketcherBased,DressUp}Parameters into new base class 
Added a new class: TaskDlgFeatureBased which currently contains common
code for TaskDlgSketcherBasedParameters::reject() as well as the same
methode for TaskDlgDressUpParameters.
It's likely that other Feature task dialogs will inherit this class too.
 2016-04-12 18:12:15 +02:00
Stefan Tröger
afee98c1e9 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
jrheinlaender
9dee5333e7 Fixed bugs in various features that reversed the list of selections 2016-04-12 18:11:57 +02:00