Commit Graph

518 Commits

Author SHA1 Message Date
donovaly
b0faf1197c [PD] fix wording for skew prisms
the UI and the property is not consistent. In the dialog we use the term angle upon user feedback while the property still has the name "skew" in it.
I simply forgot this change in my PR that implemented skew prisms.

This is now corrected by this PR.
2020-09-15 22:13:26 +02:00
wmayer
308baeaeab PartDesign: [skip ci] fix L2 parameter in pad feature when using custom direction 2020-09-12 17:26:41 +02:00
donovaly
91ef59fdbe [PD] allow to pad in any direction
It saves a lot of work if one can directly pad in any direction and OCC allows this.

This PR adds the possibility to define a custom vector for the padding direction.
2020-09-12 16:33:44 +02:00
donovaly
6bbab49723 [PD and Part] add possibility to create skew prisms 2020-09-12 13:28:00 +02:00
wmayer
a507a533f3 [PartDesign] [skip ci] #fixes 4367: Thread size out of range using hole-feature 2020-08-24 17:36:48 +02:00
wmayer
8076c3394d PartDesign: [skip ci] fix broken tooltip of Pad property 2020-08-08 13:08:27 +02:00
Zheng, Lei
35007e30e5 PartDesign: fix pattern transformation 2020-07-31 14:46:33 +02:00
wmayer
e9ce75d544 LGTM: [skip ci] fix: Empty branch of conditional
An empty block after a conditional can be a sign of an omission and can decrease maintainability of the code.
Such blocks should contain an explanatory comment to aid future maintainers.
2020-07-26 15:49:14 +02:00
luz paz
e82f7f74f4 Fix Crowdin typos + trim superfluous whitespace [skip-ci]
Some issues that this PR fixes (but not all listed):  
https://crowdin.com/translate/freecad/27911/en-en#6581578  
https://crowdin.com/translate/freecad/27911/en-en#6579080  
https://crowdin.com/translate/freecad/27911/en-en#6581580  
https://crowdin.com/translate/freecad/27911/en-en#6579086
2020-07-23 13:52:44 +02:00
Zheng, Lei
da4ee7e526 PartDesign: fix DressUp SupportTransform
Skip multiple consequtive DressUp features when SupportTransform is
enabled.
2020-07-11 13:03:44 +02:00
Zheng, Lei
a045f58a85 PartDesign: change feature DressUp behavior when used for pattern
Repurpose DressUp.SupportTransform property to define the following
behavior,

* When disabled (default), only the dressing will be used for patterning.

* When enabled, the additive/subtractive shape of the dressed base
  feature will be used for patterning. Any dressing that is not applied
  to the based feature will be ignored.

* If the dressing is applied to non-additive/subtractive feature, then
  only the dressing will be used for patterning.

New API FreatureAddSub::getAddSubShape() is added to account for the
fact that a dressing (e.g. a fillet) can be either additive or
subtractive, which means that a DressUP feature may contain both
additive and subtractive shapes.

FeatureTransformed is modified to perform both fusion and cut if
required.
2020-07-11 13:03:21 +02:00
Zheng, Lei
8b23d814f8 PartDesign: fix line ending in source code 2020-07-11 13:02:49 +02:00
wmayer
acf3b5a256 boost: [skip ci] fix for boost < 1.60 2020-06-15 21:33:56 +02:00
wmayer
d6169d6478 boost: fix for boost < 1.60 2020-06-15 19:38:39 +02:00
wmayer
730154a684 boost 1.73.0: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated 2020-06-12 17:51:33 +02:00
wmayer
a9743b3471 PartDesign: [skip ci] fix typo 2020-06-08 00:59:46 +02:00
vocx-fc
b8dd14b01d PartDesign: replace unicode characters with simple hyphens 2020-06-03 14:51:01 +02:00
mwganson
6883f4687a [Part Design] fix refine feature in Hole feature 2020-06-02 17:44:20 +02:00
wmayer
e3a2f7f76d PartDesign: [skip ci] fix wrong property values in UI file
set step size of angle property to 1.0
2020-05-24 12:18:19 +02:00
wmayer
f4b169e811 PartDesign: [skip ci] set group name for chamfer properties 2020-05-24 11:25:15 +02:00
Abdullah Tahiri
d5f29f79d3 PartDesign: Chamfer feature corrections and improvements
========================================================

- Correction to mustExecute() to account for the new properties
- Make properties not used by the mode as read-only.
- Gui: apply() only for construction mode valid features
2020-05-23 12:24:08 +02:00
Armandas Jarušauskas
8c303d3f25 PartDesign: Chamfer direction flipping support 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas
84afdc6d96 PartDesign: Chamfer - updated parameter validation code. 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas
83b77f1500 PartDesign: Chamfer with multiple creation modes 2020-05-23 12:24:08 +02:00
Zolko
d81178ad61 setting Datum Line size manually 2020-05-13 11:23:28 +02:00
Armandas Jarušauskas
be82131803 Fixed issues introduced in #3456
- Copy-paste error when setting angle dimensions.
- Max angle limit set to 180 degrees.
2020-05-12 14:29:28 +02:00
wmayer
5ece278c94 remove deprecated std::binary_function 2020-05-11 13:46:37 +02:00
Armandas Jarušauskas
cce4aaab58 Added chamfer angle support to PartDesign. 2020-05-10 18:59:30 +02:00
Zheng, Lei
46618410ce PartDesign: allow multiple faces in feature ProfileBased 2020-03-20 16:38:00 +01:00
Zheng, Lei
a657e54450 PartDesign: fix SubShapeBinder solids fuse 2020-03-20 15:02:20 +01:00
Zheng, Lei
7ee0ccbcf3 PartDesign: remove SubShapeBinder.Support hidden status
Change Immutable status to ReadOnly, which makes it easy to set value
in script, but still block editing in property view by default. This is
to discourage user editing support using property editor, because
SubShapeBinder requires relative link correction.
2020-03-20 15:02:20 +01:00
Zheng, Lei
af119b9ca6 PartDesign: improve SubShapeBinder property documentation 2020-03-20 15:02:20 +01:00
Zheng, Lei
4364efca47 PartDesign: change SubShapeBinder claim children behavior 2020-03-20 15:02:20 +01:00
Zheng, Lei
709cc591fd PartDesign: disable SupportTransform on legacy dressup feature
Because in order to SupportTransform, dressup must calculate its
AddSubShape, which is empty for existing legacy dressup feature.
2020-03-20 14:50:59 +01:00
Zheng, Lei
0795ca671a PartDesign: fix dressup AddSubShape transformation
AddSubShape must not have local transformation.
2020-03-20 14:50:59 +01:00
wmayer
e91c2d6afd fixes #0004286: PartDesign hole: angle of the tapered hole does not match the tapered angle specified [skip ci]
See https://forum.freecadweb.org/viewtopic.php?f=13&t=44056#p375915
2020-03-12 11:39:09 +01:00
luz.paz
ebe194a9e9 Fix typos
Found via  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-06 14:50:35 +01:00
wmayer
ddbc02fee1 PartDesign: [skip ci] fixes #0004276: Loading a project takes much more time compared to previous versions 2020-03-02 10:06:16 +01:00
Zheng, Lei
2fee0c3b0c PartDesign: fix DressUp base shape checking 2020-02-23 11:04:54 +01:00
Zheng, Lei
17d7f09fc8 PartDesign: fix FeatureDressUp base checking 2020-02-14 13:34:03 +01:00
Zheng, Lei
379e07ef30 PartDesign: support transformed pattern in FeatureDressUp
Fixes #1650
2020-02-14 13:34:03 +01:00
wmayer
141c3bca53 fixes #0004158: FreeCAD crashes when deleting spline [skip ci] 2020-01-03 14:24:53 +01:00
wmayer
ecfcc30fee PartDesign: [skip ci] replace int with proper enum type 2019-12-30 17:19:59 +01:00
Zheng, Lei
3b8ed7a791 PartDesign: improve SubShapeBinder transformation cache 2019-12-30 17:17:14 +01:00
Zheng, Lei
2034323bf4 PartDesign: fix SubShapeBinder lost of placement 2019-12-30 17:17:14 +01:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
wmayer
8bed7e4bd1 issue #0004225: FreeCAD crash when making draft in PartDesign [skip ci] 2019-12-16 15:26:34 +01:00
asapelkin
ced8100ab9 use emplace_back instead of push_back where justified 2019-11-21 14:48:09 +01:00
Zheng, Lei
38fd061716 PartDesign: fix Body getSubObject() 2019-10-16 10:55:53 +02:00
Zheng, Lei
c146fbbdba Replace use of Matrix.inverse() with inverseGauss()
Because of possible scaling involved.
2019-10-07 17:24:30 +02:00