Commit Graph

81 Commits

Author SHA1 Message Date
WandererFan
b255deb354 [TD]fix view loses dimensions (fix #19968) (#20122)
* [TD]fix view loses dimensions (fix #19968)

* [TD]Apply review comment
2025-03-22 11:12:42 -05:00
Andrea
da66720d3a REMOVE old QT<= 5.14 code
Ubuntu 22.04  use qt 1.15.3.
In the code is still used qt code <5.10.
A cleanup was done by removing qT code version used in ubuntu 18.04.
2025-03-05 09:32:06 +01:00
Benjamin Bræstrup Sayoc
b386e461c2 Remove magic number and hard type enums in DrawViewPart.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Bræstrup Sayoc
835905f76e TechDraw: Use QStringLiteral 2025-02-10 18:32:44 +01:00
wandererfan
d26812e048 [TD]fix crash on delete while dialog open (#18120) 2025-02-03 17:51:46 +01:00
wandererfan
01f4e08f47 [TD]fix front view position in projection group (fix #19085) 2025-01-27 17:34:13 +01:00
Benjamin Bræstrup Sayoc
36f2aa6152 [TechDraw] Translations and grammer (#16301)
Co-authored-by: WandererFan <WandererFan@gmail.com>
2024-12-02 12:27:39 -05:00
wmayer
4fe1513365 TD: Fix compiler warnings
This fixes the compiler warning: unused parameter 'mode' [-Wunused-parameter]

It's a regression of #16889 to not initialize the class member m_createMode any more that causes UB,
i.e. whenever m_createMode is accessed it may return an unexpected value.
2024-10-07 17:40:32 +02:00
wandererfan
02ebe18356 [TD]fix handling of projection convention (fix #16788 #16785) 2024-09-28 10:39:30 -04:00
PaddleStroke
8339bd9618 TechDraw: ProjGroup Fix dim disappearing on upgrade. And also scale and scaleType properties not reappearing on downgrade. 2024-08-08 10:23:07 -04:00
wandererfan
d98aa70d0e [TD]fix camera/front buttons on Proj Group dialog 2024-07-06 12:49:18 -04:00
wmayer
fada9ed82c TD: Fix compiler warning
Warning: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Wstring-compare]
2024-04-25 10:46:24 +02:00
PaddleStroke
55fbbb5d6e TechDraw: Insert tool insert DrawViewProjGroupItem that can then be transfered into groups and back. 2024-04-22 15:53:14 +02:00
PaddleStroke
4ebe22f166 TechDraw: Enable setting a custom direction. Fixes #5821 2024-04-22 15:53:14 +02:00
PaddleStroke
77ed2eeed5 TechDraw: Add taskbox to Part View. Removes Projection Group from toolbar. 2024-04-22 15:53:14 +02:00
ppphp
da7ee06d67 fix: c++20 deprecate [=] 2024-03-31 10:47:32 +02:00
pavltom
aac48eb2f9 [TechDraw] Issue #5903 - Autofill template information 2024-03-23 08:56:47 -04:00
wandererfan
cbc39e989f [TD]fix Projection Group front view position
- also fix checkbox correspondence with view position
2024-02-29 13:06:22 -05:00
wandererfan
456fa53eab [TD]use correct tooltip in first/third angle 2024-02-21 11:46:18 -05:00
wandererfan
f03461a85a [TD]spelling in comments 2023-11-26 16:42:06 -05:00
wmayer
25a63f8750 TD: move to new style connect() 2023-02-01 01:33:34 +01:00
wandererfan
12db3618df [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
023a37b92c [TD] Task*, part 1: remove unused includes
- also some sorting
2022-12-07 16:15:40 +01:00
berniev
34f41572b2 QString.midRef is removed in Qt6 2022-12-01 12:17:49 +01:00
wandererfan
cdda6f2c38 [TD]fix fail on missing base view (#7856) 2022-11-22 20:38:46 -05:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
74cdc6db61 [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
2d4c5a4cfb Mod: use emplace_back 2022-08-05 10:36:16 +02:00
wmayer
e7edda9679 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
Uwe
31bc9f3913 [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
2e5e4dced8 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
7c1c31e10e [TechDraw] Improve readability of TaskProjGroup.cpp 2022-07-15 11:31:11 -04:00
Chris Hennes
c44ccc0ff2 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
wmayer
fd8719c85c TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Benjamin Bræstrup Sayoc
4f9e5cd464 Improve code simplicity/readability 2022-02-01 09:10:36 -05:00
luz paz
73d330b0c8 [TD] Renamed ProjectionGroup, Hatch, GeomericHatch 2021-04-17 11:38:10 +02:00
donovaly
b5f57ed2f0 [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
luz paz
a3cb87b117 TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
16f953ad65 PVS: V1004 A pointer was used unsafely after it was verified against nullptr 2020-07-18 10:59:27 +02:00
donovaly
e50db2ed78 [TD] add spacing to ProjGroup dialog
Add the setting to auto-distribute projections to the dialog
2020-06-21 08:22:49 -04:00
donovaly
74b2321cbf Merge branch 'master' of github.com:FreeCAD/FreeCAD into TD-DetailWork 2020-05-09 01:36:49 +02:00
wandererfan
0a3f7ae312 [TD]handle ProjectionAngle changes 2020-04-24 11:13:49 -04:00
donovaly
6d06bdffb5 [TD] some Detail View fixes
see https://forum.freecadweb.org/viewtopic.php?f=35&t=45236&p=388925#p388925 for a description of the changes
2020-04-18 14:56:01 +02:00
wmayer
ec8b1bc072 [skip ci] use QLocale class consistently to make it possible to change it application-wide 2020-03-26 16:37:45 +01:00
donovaly
914edfc2ce TD renaming tools
as discussed in https://forum.freecadweb.org/viewtopic.php?p=344899#p344800
we need a more consistent naming for the Wiki
2019-11-17 08:22:09 -05:00
wandererfan
5bb659e7e2 [TD]Transition to on demand page updates ph1 2019-10-23 14:19:52 -04:00
Zheng, Lei
62423cb79a TechDraw: fix projection group editing update 2019-08-17 15:32:51 +02:00
wandererfan
198c2258d4 Remove superfluous updates
- under certain conditions, unnecessary screen paints
  were being performed.
2019-03-07 10:58:28 +01:00