Commit Graph

115 Commits

Author SHA1 Message Date
Benjamin Bræstrup Sayoc
b386e461c2 Remove magic number and hard type enums in DrawViewPart.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Nauck
8cc98b9a88 Mod: Use new addObject<T>(...) that requires additional changes 2025-02-10 18:35:38 +01:00
Benjamin Nauck
dd6aa9f3c7 Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
PaddleStroke
55fbbb5d6e TechDraw: Insert tool insert DrawViewProjGroupItem that can then be transfered into groups and back. 2024-04-22 15:53:14 +02:00
PaddleStroke
4ebe22f166 TechDraw: Enable setting a custom direction. Fixes #5821 2024-04-22 15:53:14 +02:00
PaddleStroke
77ed2eeed5 TechDraw: Add taskbox to Part View. Removes Projection Group from toolbar. 2024-04-22 15:53:14 +02:00
wandererfan
cbc39e989f [TD]fix Projection Group front view position
- also fix checkbox correspondence with view position
2024-02-29 13:06:22 -05:00
wandererfan
414e06d54d [TD]apply translateLabel after all addObject calls 2023-08-17 19:23:29 -04:00
Benjamin Bræstrup Sayoc
15fe52a04b [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
wandererfan
d3f8132273 [TD]fix error in DPG from bf00a1afc9 2023-04-09 21:43:43 -04:00
Benjamin Bræstrup Sayoc
bf00a1afc9 [TechDraw] Improve readability of DrawProjGroup.cpp 2023-04-05 14:35:58 -04:00
wandererfan
12db3618df [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
wandererfan
cdda6f2c38 [TD]fix fail on missing base view (#7856) 2022-11-22 20:38:46 -05:00
Uwe
03a3ae8cd8 [TD] DrawD* - DrawT*: remove unused includes - part 2/2
- also sort includes
- also additions to precompiled header
2022-10-08 17:21:26 +02:00
wandererfan
ec9d256d0e [TD]space secondary views by row/columns 2022-09-10 12:00:31 -04:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
luz paz
1a7ddfdc24 Fix typos and whitespace
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,siz,strack,substraction,te,technic,thist,thru,tread,uint,unter,uptodate,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-08-23 18:49:47 +02:00
Wanderer Fan
e8a25a8fdf [TD]code review changes for dgh, dpg, dpgi, dra 2022-08-18 19:43:04 -04:00
Wanderer Fan
74cdc6db61 [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
Wanderer Fan
6df801ed96 [TD]respect AutoDistribute on load 2022-08-18 09:34:32 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
7ab531c51a [TD] last part of removal of superfluous nullptr checks 2022-07-20 12:17:16 +02:00
Uwe
40d8ebb372 [TD] remove some more superfluous nullptr checks 2022-07-20 11:54:28 +02:00
Uwe
31bc9f3913 [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
93796e2d92 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
Wanderer Fan
fb1a7af360 [TD]fix ProjGroup view spacing 2022-06-18 14:34:28 -04:00
Wanderer Fan
4b47d38eb6 [TD]fix dimension update on scale change 2022-06-18 14:34:28 -04:00
Wanderer Fan
00c8916341 [TD]Fix group item moving when locked 2022-05-13 13:41:37 -04:00
Zheng, Lei
3ef438eaf0 Fix mixed line endings 2022-04-26 12:52:55 -05:00
Chris Hennes
c44ccc0ff2 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Wanderer Fan
5926060281 [TD]fix ScaleType change behaviour 2022-03-07 09:30:39 -05:00
Benjamin Bræstrup Sayoc
4f9e5cd464 Improve code simplicity/readability 2022-02-01 09:10:36 -05:00
wandererfan
b7e8ad9a4e [TD]DPG spacing for oblique views 2020-07-07 15:26:20 -04:00
donovaly
d2bc4a66b4 [TD] add missing update for Projection Group
currently when changing the scale or spacing this change is not taken into account until one explicitly marked the ProjGroup for recomputation
2020-06-15 08:04:14 -04:00
WandererFan
92dfdf605b [TD]prevent extra recompute on X,Y change 2020-05-10 11:03:15 -04:00
wandererfan
0a3f7ae312 [TD]handle ProjectionAngle changes 2020-04-24 11:13:49 -04:00
wandererfan
e80c576241 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
wandererfan
4104a0e263 [TD]Use PropertyXLinkList for external Sources 2020-04-14 10:24:29 -04:00
donovaly
8c45bef57c [TD] add missing repaints for DrawView
- this enables to see e.g. changes of the rotation of all kinds of views directly

- also fix a bug, see https://forum.freecadweb.org/viewtopic.php?f=35&t=44571
2020-03-26 08:08:41 -04:00
wandererfan
37b578bf49 [TD]support App::Link in View Source 2020-03-13 09:00:14 -04:00
wandererfan
3a42205cb4 [TD]fix autoscale for DPG 2020-02-14 07:44:56 -05:00
donovaly
78e6861127 TD: DrawProjGroup: add units for spacing
-also improve some tooltips
2019-12-10 06:50:27 -05:00
wandererfan
54d9e04304 [TD]use XDirection to align DPGI in DPG 2019-11-27 07:31:45 -05:00
wandererfan
92dfecea75 [TD]correct alignment of Section & Detail with Base 2019-11-27 07:31:45 -05:00
wandererfan
a7ad04ba4a [TD]const-ness for dump function parameter 2019-11-10 15:58:45 -05:00
wandererfan
5bb659e7e2 [TD]Transition to on demand page updates ph1 2019-10-23 14:19:52 -04:00
Zheng, Lei
5bef136deb TechDraw: avoid touching children if possible
There are lots of dependency inversion problem in TechDraw, the ideal
organization should let a child depend on project group, instead of the
other way round, e.g. using PropertyLinkListHidden.

This patch is just a cheap fix. The problem occurs when the user uses
any expression to update properties like Scale in a projection group.
The Scale property will be changed on recomputing projection group,
which triggers children update, but since the group depends on the
children, the children has already been recomputed.
2019-08-30 14:47:05 +02:00
Zheng, Lei
d26f772035 TechDraw: Link related changes
* Support link and group objects

* Support view sync by implementing view provider API getMDIView()

* Use handleChangedPropertyType() for object migration instead of
  reimplementing Restore() because of a lots of changes in
  PropertyContainer::Restore().

* Various other small fixes.
2019-08-17 15:15:46 +02:00
wandererfan
71a095360a Hide Caption property where not applicable 2019-06-01 15:59:26 -04:00