Commit Graph

1166 Commits

Author SHA1 Message Date
wmayer
ee0b91961b improve whitespaces 2018-01-13 15:49:39 +01:00
Abdullah Tahiri
40459e73cd Sketcher: Remove errors in reporting view while deleting
=======================================================

fixes #2275

https://freecadweb.org/tracker/view.php?id=2275

Deletion of coincidents rely on selected vertex. The original code was trying to delete a coincident without checking whether one was there.

The implementation now relies on checking whether a coincident is present.
2018-01-13 15:47:02 +01:00
wmayer
adaf9323f3 improve whitespaces 2018-01-13 14:07:15 +01:00
Abdullah Tahiri
e1bf2045dd Sketcher: Overload delConstraintonPoint Python to allow deletion on GeoId and Pos 2018-01-13 13:55:56 +01:00
Abdullah Tahiri
74b097ee75 Sketcher: Improve validation ui to select whether to ignore construction geometry or not
========================================================================================

Users generally expect that validate Sketch checks the visible part, perhaps because it is not called from the sketcher's edit view, but from the 3D view, perhaps
because that part is relevant for further construction.

On the other hand the tool's name is Validate Sketch and construction geometry belongs to the sketch.

So a new checkbox is introduced, by default enabled to ignore construction, but still allowing the user to make it operate in one direction or the other.

See:
https://forum.freecadweb.org/viewtopic.php?f=3&t=26139&p=208582#p208693
2018-01-13 11:31:11 +01:00
Abdullah Tahiri
362ba9c473 Sketcher: Fix "highlight open vertex" visualization
===================================================

fixes #3306
2018-01-13 11:30:48 +01:00
Abdullah Tahiri
3c6fa1f0ed Sketcher: Validation tool improvement
======================================

The sketch validation tool offers the functionality to detect missing coincidences. It is a problem that internal geometry causes detected missing coincidences.

Additionally, the tool only shows the visible profile and not the construction geometry.

This commit introduces the ignoring of construction geometry, which "fixes" the two behaviours indicated above.

fixes #3298
2018-01-13 11:30:35 +01:00
wmayer
5cdee243a1 fix const correctness 2018-01-01 22:25:11 +01:00
Abdullah Tahiri
8814d5ada6 Sketcher: Settings Dialog new color for dependent constraints 2018-01-01 21:00:06 +01:00
Abdullah Tahiri
c80e6a8d60 Sketcher: Special sketcher color for dimensions having an expression
fixes #3285
2018-01-01 21:00:06 +01:00
Abdullah Tahiri
d4e8b95197 Sketcher: Support for detecting expressions in constraints 2018-01-01 21:00:06 +01:00
wmayer
ad26e922ef improve whitespaces 2018-01-01 20:51:12 +01:00
Abdullah Tahiri
e85da016fe Sketcher: Solver angle -pi,pi conversion corrected
fixes #3288
2018-01-01 20:28:53 +01:00
Abdullah Tahiri
300ca1d88e Sketcher: Match angle on lines representation match solver result 2018-01-01 20:28:41 +01:00
wmayer
51c47f1efb improve whitespaces 2018-01-01 19:36:57 +01:00
Abdullah Tahiri
952aaa458e Sketcher: Fix transfer of tangency and perpendicular end-to-endpoint constraints
================================================================================

When transfering constraints to coincident points on deletion of geometry, a tangency/perpendicular constraint
cannot be blindly transfered as the destination edge may not be tangent/perpendicular leading to unexpected behaviour.

However, the user does expect that something that was coincident with such end-to-endpoint constraint (which implicitly includes a coincident constraint)
remains coincident after deletion. Therefore, the change of type to coincident.

This implicitly solves the problem of representation of constraints leading to a crash in coin3d.

fixes #3291
2018-01-01 19:27:41 +01:00
wmayer
125329f0bd simplify debugging of changing datum constraints 2017-12-31 11:48:44 +01:00
wmayer
1050378a2e avoid error 'Duplicate constraint not allowed' when deleting a constraint 2017-12-31 01:57:44 +01:00
wmayer
bf379642eb implement PropertyConstraintListItem::assignProperty to add item for each datum constraint 2017-12-30 19:49:34 +01:00
wmayer
4edfa9eac9 fix heap corruption due to invalid static_cast 2017-12-29 22:32:10 +01:00
luzpaz
4eb5a431fa Sketcher: comment typos 2017-12-25 10:59:48 +01:00
wmayer
178794610d fixes #0003252: External geometry tool keeps hovered item active after leaving 2017-12-25 10:47:51 +01:00
wmayer
6d999a98de restore removed link to preferences-sketcher.svg 2017-12-23 17:07:12 +01:00
Abdullah Tahiri
19585e6b4b Sketcher: new UI command for arbitrary sides polygon
fixes #1639
2017-12-23 14:45:39 +01:00
Abdullah Tahiri
d580b7579f Sketcher: Dialog for arbritary sides regular polygon 2017-12-23 14:45:39 +01:00
Abdullah Tahiri
915378861d Sketcher: Icons for arbitrary regular polygon 2017-12-23 14:45:39 +01:00
Abdullah Tahiri
89071f74b7 Sketcher: Wrong mapping of constraints to axes
==============================================

Expressions for remapping of geometry where simply wrong.

Surprisingly no bug reports were filed for this one.
2017-12-12 23:08:44 +01:00
Abdullah Tahiri
d64575a111 Sketcher: Merge, copy expressions
===================================

Support for copying expressions instead of hard values.

fixes #2936
2017-12-12 23:08:44 +01:00
Abdullah Tahiri
f2cca2e05a Sketcher Solver: Means to reset the initilization of movement
=============================================================

Just amazed it was working "so well" without never reseting to zero this.

It might bring advantages and close bugs... who knows!
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
a309e417fc Sketcher: New Setting for improved dragging mode 2017-12-12 22:20:27 +01:00
Abdullah Tahiri
a014c1cbc1 Sketcher: Clean code and adapt previous solution only to non-relative cases
===========================================================================

Cleaning up ViewProviderSketch, as relative mode is never used for points.

Adapting the recalculation of the initial solution only to non-relative cases.

For relative movement cases (movePoint with relative=true) no cases where such a solution will be advantageous have been identified
and applying a similar solution involves changing the current behaviour too much, as to run the risk of introducing further bugs.

Decision to be revised if such cases where an advantage can be found are discovered.
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
7b086ba8b2 Sketcher: jumping while dragging - force recalculate initial solution
=====================================================================

fixes #1734

Upon dragging, the initial solution is first calculated and them DogLeg is left with the work of solving for a solution next to the initial solution.

When the change is too big and the gradients are no longer accurate to continue dragging, the dragging flips and jumps.

The solution offered here is, not to update always the solution, as this also creates artifacts, but update it if the dragging goes beyond 20 times the initial dragging distance.

https://forum.freecadweb.org/viewtopic.php?f=3&t=7589#p203580

https://forum.freecadweb.org/viewtopic.php?f=3&t=7589#p203712
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
c49981c41b Sketcher: Do not show support when entering sketch edit mode if it is a datum plane
=====================================================================================

https://forum.freecadweb.org/viewtopic.php?f=10&t=25700
2017-12-07 11:39:35 +01:00
Abdullah Tahiri
ea8652f54e Sketcher: Fixing Polyline Arc Endpoint autoconstraints
======================================================

fixes #3091

Autoconstraints did not check whether the arc was CW or CCW, as such the autoconstraint on the second position was sometimes assigned to the start point.
2017-12-07 11:31:35 +01:00
Abdullah Tahiri
5e6e289d69 Sketcher: Fixes no horizontal/vertical on edge if previous horizontal/vert aligment on vertex
=============================================================================================

fixes #3257
2017-12-07 11:11:40 +01:00
Abdullah Tahiri
f0a4d6a524 Sketcher: Fix Polygon disappearing on creation with autoconstraints on
======================================================================

Fixes #3154

About the fix:
- If a non-zero vector is passed to seekAutoConstraint, it will suggest a vertical/horizontal constraint, which does not
make sense in the construction method.
- Passing a zero vector enables to treat it like a point, so for example point on object will be suggested, but not vertical/horizontal constraints.
2017-12-07 10:59:49 +01:00
Abdullah Tahiri
0f021940b9 Sketcher: BSpline, prevent 0 mm Radius for poles on creation
============================================================

https://forum.freecadweb.org/viewtopic.php?f=10&t=25701
2017-12-07 10:52:28 +01:00
Unknown
198ba0a123 SVG cleanup: remove all redundant <dc:title> content
Removed duplicate mentions of `[agryson] Alexander Gryson`
2017-12-02 14:02:14 +01:00
wmayer
9612c31572 fixes #0003176: Sketcher: always over-constrained when referencing external B-Spline 2017-12-02 13:02:42 +01:00
wmayer
337657e85d when painting items make sure that constraint id is in range 2017-12-02 10:11:45 +01:00
Eivind Kvedalen
71f9f4824f Sketcher: Fixed regression in fix for issue #3245. 2017-11-28 19:14:57 +01:00
wmayer
1a6e5db7f6 move encodeAttribute from Property to Persitence to avoid code duplication 2017-11-26 18:38:45 +01:00
wmayer
794a39684a fix crashes when using sketch tools 2017-11-23 13:22:37 +01:00
wmayer
952a4a781f fixes #0002290: Point-on-object constraint icon not selectable 2017-11-20 14:06:12 +01:00
wmayer
f1f2a90190 fix coverity issues 2017-11-18 18:07:00 +01:00
Jeff
7f633cfbb2 Added color prefs to sketcher create commands
Create geometry commands in sketcher now have configurable crosshair color and editCurve color.
2017-11-18 15:30:41 +01:00
luzpaz
cc87c20afe Make uniform the use of B-spline visible to users
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=8&t=25411
This commit does not include fixes to source  comments unless they were 'doxygenated'.
No .xml files were altered either.
2017-11-17 19:30:37 -05:00
Eivind Kvedalen
5b22a8a133 Sketcher: Fix for issue #3245, including regression test. 2017-11-16 21:44:23 +01:00
luzpaz
35ec477426 More typos, grammar fixes, uniformity 2017-11-15 10:46:43 -05:00
wmayer
d591ec7b07 fix German translation 2017-11-12 16:37:06 +01:00