Commit Graph

1676 Commits

Author SHA1 Message Date
Yorik van Havre
27053d90b0 Arch: Fixed backwards compatibility issues 2020-10-16 12:40:09 +02:00
Yorik van Havre
2682700850 Arch: Made default door/windows openable 2020-10-15 12:55:27 +02:00
Yorik van Havre
dd51cbccb2 Arch: Fixed translation of wall (better version) 2020-10-12 15:58:41 +02:00
Yorik van Havre
a0114ac41a Arch: Fixed translation of wall 2020-10-12 15:57:15 +02:00
luz paz
da7f105ef1 Arch: fix typo in ArchBuildingPart.py [skip-ci]
Found by user PMac in https://forum.freecadweb.org/viewtopic.php?f=3&t=51049
2020-10-12 11:51:13 +02:00
vocx-fc
f799717f4d Arch: consider DraftText objects in the section plane for compatibility
After the reorganization of the Draft Workbench,
the `'DraftText'` objects are now of Proxy.Type `'Text'`.
In the `DraftAnnotation` class the `__setstate__` method
was defined to automatically migrate the Type.

The `Arch SectionPlane` only handles `'Text'` objects. If for
some reason there is still an old `'DraftText'` object
which has not been migrated to the new Type, it won't be found.
This is corrected by adding `'DraftText'` to the list of objects
to process.
2020-10-12 11:43:37 +02:00
Roy-043
611bcdd4c4 Arch: 4 additional tests for ArchRoof (bug fix)
ArchRoof bug fix:
* Removed unnecessary use of FreeCAD.Vector. Renamed some functions and variables for clarity (in this description the new names are used). Reformatted the code. Moved imports to the top of the file. Updated the tooltips. Tweaked the title text "Parameters ...".
* Fixed the length of list properties bug.
* Flip direction did not work properly. The adopted solution is to reverse the edges the roof is based on.
* Added support for consecutive parallel edges.
* Added support for zero angle roof segments.
* The code now handles zero length runs without throwing an error.
* To handle triangular roofs with a zero length eave, "eave" (egde) has been turned into "eavePtLst" (list of points).
* The ridges of opposite parallel roof segments (if they do not use a relative profile) are recalculated if the sum of their runs is larger than the distance between their edges. The old version of the command would do this only if segments connected to gables and only properly if the corners between the edges of the segments and the gable were 90 degrees.
* Revised backGable and nextGable. They now call helperGable.
* Revised the 6 other back/next functions. They now call helperSloped. This also fixes several cases where cookie-cutter outlines (profilCurr["points"]) were wrong. In nextHigher, backHigher, nextLower and backLower a point was wrongly projected on the X-axis. In nextHigher the point on the higher ridge was wrongly included.
* Improved the cookie-cutter outlines for roof segments with lower overhangs and higher ridges in corners.
* Data from a relative profile is no longer used if it in turn references a relative profile.
* Changed the default idrel to -1 and changed calcMissingData to not process this value. This avoids confusion for users who are unaware of the relative profile feature.
* Introduced find_inters as a workaround for DraftGeomUtils.findIntersection. The latter finds intersections for parallel lines that share a point. Find_inters uses a modified version of getLineIntersections from DraftGeomUtils.findIntersection.
* Calling DraftVecUtils.removeDoubles later in the program flow as it does not compares the first and the last vector.
* Avoided the QTreeWidget scrolling to the top on every change, by not clearing it but updating existing items instead.
* Added self.tree.setRootIsDecorated(False). This gets rid of the 1st column's extra left margin. Removed item.setTextAlignment(0,QtCore.Qt.AlignLeft) as this did not work.
2020-10-12 11:43:04 +02:00
Roy-043
aff5da530e Arch: ArchRoof bug fix
* Removed unnecessary use of FreeCAD.Vector. Renamed some functions and variables for clarity (in this description the new names are used). Reformatted the code. Moved imports to the top of the file. Updated the tooltips. Tweaked the title text "Parameters ...".
* Fixed the length of list properties bug.
* Flip direction did not work properly. The adopted solution is to reverse the edges the roof is based on.
* Added support for consecutive parallel edges.
* Added support for zero angle roof segments.
* The code now handles zero length runs without throwing an error.
* To handle triangular roofs with a zero length eave, "eave" (egde) has been turned into "eavePtLst" (list of points).
* The ridges of opposite parallel roof segments (if they do not use a relative profile) are recalculated if the sum of their runs is larger than the distance between their edges. The old version of the command would do this only if segments connected to gables and only properly if the corners between the edges of the segments and the gable were 90 degrees.
* Revised backGable and nextGable. They now call helperGable.
* Revised the 6 other back/next functions. They now call helperSloped. This also fixes several cases where cookie-cutter outlines (profilCurr["points"]) were wrong. In nextHigher, backHigher, nextLower and backLower a point was wrongly projected on the X-axis. In nextHigher the point on the higher ridge was wrongly included.
* Improved the cookie-cutter outlines for roof segments with lower overhangs and higher ridges in corners.
* Data from a relative profile is no longer used if it in turn references a relative profile.
* Changed the default idrel to -1 and changed calcMissingData to not process this value. This avoids confusion for users who are unaware of the relative profile feature.
* Introduced find_inters as a workaround for DraftGeomUtils.findIntersection. The latter finds intersections for parallel lines that share a point. Find_inters uses a modified version of getLineIntersections from DraftGeomUtils.findIntersection.
* Calling DraftVecUtils.removeDoubles later in the program flow as it does not compares the first and the last vector.
* Avoided the QTreeWidget scrolling to the top on every change, by not clearing it but updating existing items instead.
* Added self.tree.setRootIsDecorated(False). This gets rid of the 1st column's extra left margin. Removed item.setTextAlignment(0,QtCore.Qt.AlignLeft) as this did not work.
2020-10-12 11:43:04 +02:00
Bernd Hahnebach
566d32177a Arch: import IFC, support multiple styles in styled items in IFC4 2020-10-06 19:27:54 +02:00
Bernd Hahnebach
3b6e0a9342 Arch: import ifc, small fix in colors 2020-10-06 19:10:52 +02:00
Bernd Hahnebach
4c057c95bf Arch: import ifc, colors in IFC4 print warning not implemented 2020-10-06 19:08:48 +02:00
Bernd Hahnebach
6d7ed787b2 Arch: import ifc, fix typo in material colors 2020-10-06 17:20:32 +02:00
Bernd Hahnebach
8292664f49 Arch: import ifc, fix import break if colors dictionary contains None values 2020-10-06 17:16:42 +02:00
Bernd Hahnebach
d45e143f17 Arch: ifc import, typo in var name 2020-10-06 10:53:56 +02:00
Yorik van Havre
5876a5287b Arch: Added .tsv export format to Arch schedule 2020-10-01 14:59:55 +02:00
Yorik van Havre
a01d045498 Arch: Fixed group support in IFC export 2020-10-01 10:30:26 +02:00
Yorik van Havre
69fa329223 Arch: Added 'Show Label' view property to section planes 2020-10-01 10:30:09 +02:00
Yorik van Havre
3247414686 Arch: Fixed custom csv bug in ArchProfile 2020-10-01 10:29:33 +02:00
Yorik van Havre
089ed768cc Merged crowdin translations 2020-09-30 14:37:02 +02:00
Yorik van Havre
2a92a7b5a7 Updated ts files 2020-09-30 13:06:53 +02:00
Bernd Hahnebach
82a2c1b753 Arch: ifc export, workaround for draft array export and some small improvements 2020-09-24 17:50:42 +02:00
Yorik van Havre
35d5c5dc4c Arch: allow exporting of objects with no solid or shell to IFC 2020-09-22 13:31:04 +02:00
Roy-043
f04849446a Arch: Minor improvements to testWallMultiMatAlign unit test. 2020-09-16 13:08:45 +02:00
Roy-043
1e4593aac0 Arch: Arch_Wall fix MultiMaterial alignment bug (unit test)
Added the testWallMultiMatAlign unit test. Have kept the testWall test. Changed the code to 'import FreeCAD as App'.
2020-09-16 13:08:45 +02:00
Roy-043
8ef5e8e333 Arch: Arch_Wall fix MultiMaterial alignment bug. 2020-09-16 13:08:45 +02:00
Yorik van Havre
e2071de5bc Arch: small bugfixes in multicore IFC importer 2020-09-10 13:43:02 +02:00
Yorik van Havre
b82716ca51 Arch: Better support for colors in multicore IFC importer 2020-09-09 14:36:20 +02:00
Yorik van Havre
c925194cf5 Merge branch 'master' of github.com:FreeCAD/FreeCAD into master 2020-09-09 14:26:11 +02:00
Vanuan
61f7347235 [Arch/TechDraw] Clean up _ArchDrawingView: remove getDXF
Properties and method were removed in 54a8e856cc
2020-09-09 14:18:23 +02:00
vocx-fc
d8f056352d Arch: small changes to color methods in IFC importer 2020-09-09 14:16:03 +02:00
carlopav
6f2691631c Draft: fixed obj.TypeId output after utils.get_type() change
.


.
2020-09-09 14:13:29 +02:00
SurajDadral
e311471769 Skip rebar shape to be subtracted from structure
To fix issue:
https://github.com/amrit3701/FreeCAD-Reinforcement/issues/81

And it eventually will fix issue of this thread:
https://forum.freecadweb.org/viewtopic.php?f=23&t=49481
2020-09-09 12:55:35 +02:00
vocx-fc
5cf799dd85 Draft: rename svg parameter to fillspaces (lowercase) 2020-09-09 12:53:54 +02:00
vocx-fc
7627d0b81a Draft: move getSVG to draftfunctions submodule
Small fixes where the `get_svg` function is used, for example,
in the (obsolete) `DrawingView` class and `Arch_SectionPlane`.

Also update the unit tests accordingly.
2020-09-09 12:53:54 +02:00
John Yani
7f3814faec [Arch] ViewProviderPanelSheet: Too many arguments
setProperties was called incorrectly
2020-09-08 16:14:22 +02:00
SurajDadral
03d273c656 Calculate length of rebar derived from Part::Helix 2020-09-08 15:50:23 +02:00
SurajDadral
1f15f04b17 Initialize mark and add compatibility for rebar.RebarShape
- Initialize rebar mark with rebar label
- Add compatibility for attribute rebar.RebarShape to work with changes
  done in this PR:
  https://github.com/amrit3701/FreeCAD-Reinforcement/pull/65/commits
2020-09-03 12:20:51 +02:00
Vanuan
0811c61435 Fix non-center aligned wall with multimaterial 2020-08-11 12:21:41 +02:00
vocx-fc
fdbfee279c Arch: clean up message printing during IFC import 2020-08-11 12:10:50 +02:00
vocx-fc
bef440f2b0 Arch: small cleanup of IFC helper module
Remove unnecessary comments; as long as the variables
and functions have a clear name, they are self documenting,
so they don't need additional comments.
2020-08-11 12:10:50 +02:00
vocx-fc
c1476cd96f Arch: small cleanup of IFC importer and exporter
Clarify the import of IfcOpenShell's `geom`.

In some cases it fails importing and initializing the regular way,
`import ifcopenshell.geom`.

But it works in this way
```
from ifcopenshell import geom
geom.settings()
```
2020-08-11 12:10:50 +02:00
luz paz
59e3ea096e Crowdin: Merge new translations [skip-ci] 2020-08-07 17:17:35 +02:00
luz paz
74ab9ccd9c Crowdin - Fix typos found by translators + Random typos [skip-ci]
https://crowdin.com/translate/freecad/6766/en-fr#6582288
2020-07-31 09:05:23 +02:00
vocx-fc
25da304b5a Arch: further small fixes in importIFC 2020-07-30 08:36:49 +02:00
vocx-fc
7dc66ce11b Arch: simple cleanup to the importer, spacing, and PEP8 2020-07-30 08:36:49 +02:00
Bernd Hahnebach
74ffe857dc Arch: export IFC, better default preferences 2020-07-30 08:10:13 +02:00
Bernd Hahnebach
ebaac63777 Arch IFC import, add simplificated method to get pset properties 2020-07-28 06:00:31 +02:00
SurajDadral
75ba0b8a77 Add Mark property to ArchRebar object
As discussed here:
https://forum.freecadweb.org/viewtopic.php?f=23&t=44580&p=418377#p418630
And required for reinforcement drawing/dimensioning.
2020-07-24 13:50:29 +02:00
luz paz
752f84046c Crowdin: Edits based on feedback from translators [skip-ci]
https://crowdin.com/translate/freecad/27911/en-en#6581566  
https://crowdin.com/translate/freecad/6766/en-en#6584432  
https://crowdin.com/translate/freecad/549/en-en#6578092
2020-07-24 13:49:59 +02:00
vocx-fc
3c35504deb Arch: improve import and export IFC preferences pages
Some tooltips are made more readable by adding newlines.

For `IFC import`, better tooltip for the `Number of cores` option;
also the `Replace 'Project'...` option.

For `IFC export`, better tooltip for the `Export type`;
also `IFC file units`.
Also add `General options` in case other options are added.
2020-07-24 13:48:44 +02:00