Commit Graph

2899 Commits

Author SHA1 Message Date
Paddle
b3fc34d61b Sketcher : Replace toggle icons. 2023-11-25 20:55:50 -03:00
wmayer
624b5a396a MSVC: fix warnings about unused variable 2023-11-21 23:10:03 +01:00
wmayer
fb770778d3 Qt: fix duplicate widget names 2023-11-21 23:10:03 +01:00
Chris Hennes
1372070452 Update translations 2023-11-20 13:46:22 -06:00
Paddle
a101037e2c Fix autoconstraints of arcslot tool. 2023-11-20 14:19:51 -03:00
PaddleStroke
cce89e4fec [Sketcher] Auto horizontal/vertical (#11330)
* Refactor sketcher horizontal / vertical constraints and adds a horizontal/vertical command.

* Sketcher : HorVer : change tool icon.

---------

Co-authored-by: Paddle <PaddleStroke@users.noreply.github.com>
2023-11-20 11:00:22 -06:00
Paddle
bd7a468a39 Group Trim/extend/split. 2023-11-20 10:58:17 -06:00
Paddle
ca80f8eee2 Fix ESC key for Sketcher_Dimension 2023-11-15 14:41:43 +01:00
Paddle
5c11f39be7 Sketcher OVP setting : add missing default. 2023-11-15 14:40:03 +01:00
Abdullah Tahiri
62365dd7dd SketcherGui: Fix preselectAtPoint for non X-Y orientations 2023-11-15 14:34:11 +01:00
Paddle
8108aa95cf Slot fix vertical/horizontal constraints 2023-11-14 14:22:26 +01:00
Paddle
c2789a300e Slot DSH : fixes 2023-11-14 14:22:26 +01:00
Paddle
94fc037678 Slot DSH : implement tool parameters. 2023-11-14 14:22:26 +01:00
Abdullah Tahiri
352d1f5bc3 SketcherGui: DSH - parameter unused depending of constexpr fixed 2023-11-14 14:12:16 +01:00
Abdullah Tahiri
d3399305cd SketcherGui: Compiler warning fix 2023-11-13 21:09:13 +01:00
Abdullah Tahiri
f20b7579e2 SketcherGui: DSH Default - return reference in ShapeConstraint helpers 2023-11-13 20:52:04 +01:00
Abdullah Tahiri
f63a06afa8 SketcherGui: ArcSlot lints 2023-11-13 18:19:10 +01:00
Abdullah Tahiri
1a880d3e12 SketcherGui: Fix lints 2023-11-13 18:18:50 +01:00
Paddle
6b89039661 ArcSlot DSH : implement the Arc slot tool with tool parameters support. 2023-11-13 15:05:36 +01:00
Paddle
83db40179b Circle DSH : Implement tool parameters. 2023-11-13 14:00:18 +01:00
Paddle
28744a9bbc Ellipse DSH : add cursor texts and remove showInternal checkbox. 2023-11-13 14:00:18 +01:00
Paddle
ccbe4c1c49 Ellipse DSH : Implement tool parameters. 2023-11-13 14:00:18 +01:00
Paddle
314449cef9 Arc DSH : implement tool parameters. 2023-11-13 14:00:18 +01:00
Paddle
c2bb84de8e DSH : modify drawDoubleAtCursor so that it can draw an angle. 2023-11-13 14:00:18 +01:00
Paddle
dfd4d6a6d9 Adds areColinear function to Utils. 2023-11-13 14:00:18 +01:00
Paddle
d8d1692bcb Adds CircleEllipseConstructionMethod. 2023-11-13 14:00:18 +01:00
Abdullah Tahiri
cd601fb488 Sketcher: DSH Default - improve return value of ShapeGeometry functions
=======================================================================

Previous version return an reference to the smart pointer to generic Part::Geometry.

This version returns a type specific naked pointer, while ShapeGeometry keeps ownership
and memory management, so if an arc is created a Part::ArcOfCircle is returned.
2023-11-12 17:53:36 +01:00
Abdullah Tahiri
99889ac487 Sketcher: Box Selection - refactor
==================================

Full refactor of this function without change of functionality (hopefully).
2023-11-11 21:19:12 +01:00
Abdullah Tahiri
6eb55822a0 Sketcher: Box selection - Hyperbola/Parabola endpoint fix 2023-11-11 21:19:12 +01:00
Abdullah Tahiri
2d499873b0 Sketcher: DSH - improving geo creation helpers for ShapeGeometry
================================================================

In some DSHs instead of the convenience function, the code is being duplicated because
of the need to access the geometry after pushing it to the std::vector.

This commit leverages emplace_back return reference to improve code reuse.
2023-11-11 21:18:20 +01:00
Abdullah Tahiri
c4085b0a8f Sketcher: Adapt DSHs to new dynamic cursor 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
1d0c72a685 Sketcher: DSHController - extend framework to make cursors OVP visibility dependent 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
c863f2f341 Sketcher: DSH - new cursor drawing functions 2023-11-11 11:15:54 +01:00
Chris Hennes
f25af97811 Update translations 2023-11-09 12:23:56 -06:00
Abdullah Tahiri
f56eebea64 Sketcher: Fix lints 2023-11-08 17:46:34 +01:00
Abdullah Tahiri
2f40dd34c8 Sketcher: Encapsulate function to ensure MDI focus 2023-11-08 17:46:34 +01:00
Paddle
fd0f300415 Line DSH : hide widget if OVP disabled. 2023-11-08 15:20:13 +01:00
Paddle
c7f0b19eaa Remove moveCursorToSketchPoint on init. 2023-11-08 15:20:13 +01:00
Paddle
8be614abcc Fix bug where M key stop working in some cases by giving focus to MDI on reset. 2023-11-08 15:20:13 +01:00
Paddle
fc55350abf Rectangle DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
379ab4cd90 Polygon DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
80d4a9b2ab Offset DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
0984b6e7dc Line DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
988aecea6c Add preference for OVP visibility. 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
9db65bbf9a Sketcher: Update DSHs to set value via framework only when they are visible 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
ed9e6d104b Sketcher: DrawSketchController - Extend framework to support hiding OVPs via preference 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
dca052bd9d Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
d0f9869f6d Sketcher Gui: DrawSketchController - lints 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
13e3491148 Sketcher: Handling of right mouse button during handler execution
=================================================================

    Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
    delegates the action to DrawSketchHandler.

    DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

    DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
    in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Abdullah Tahiri
cc5e928d74 Sketcher: Handling of ESC keypress during handler execution
===========================================================

Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
delegates the action to DrawSketchHandler.

DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00