Commit Graph

587 Commits

Author SHA1 Message Date
PaddleStroke
b92bda03da Sketcher: Rename movePoint to moveGeometries. 2024-12-06 16:45:47 +01:00
PaddleStroke
70972b3926 Sketcher: Group dragging 2024-12-04 10:58:29 +01:00
PaddleStroke
ac788df608 Sketcher: Rename External to Projection 2024-11-29 11:36:55 -05:00
Florian Foinant-Willig
5969df37f4 Sketcher infinite axes 2024-11-25 18:27:10 +01:00
PaddleStroke
fbd7f7090c Sketcher: ViewProviderSketch remove unecessary updateColor and applyCursor. 2024-11-25 12:25:58 -05:00
PaddleStroke
a9bff78974 Sketcher: Fix double click of wire and remove selection that was not working 2024-10-08 10:53:00 -05:00
CalligaroV
fd28d94f6a Sketcher/Gui: check if there's a 3D view while executing ViewProviderSketch::unsetEdit()
Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
2024-09-20 08:29:48 -05:00
Zheng, Lei
3da4b59b37 Sketcher/Toponaming: call SketchObject::convertSubName() in ViewProviderSketch::addSelection2() 2024-09-15 19:26:48 +02:00
Kacper Donat
e260cf5c8a Sketcher: AutoColor should update only colors
Previously AutoColor property forced reinitialization of all subscribed
parameters. It was mostly fine as most of them should stay in sync with
user settings but it also affected grids.
2024-09-09 21:19:35 -05:00
Pieter Hijma
5f74b4b299 Core: Fix a missing interpreter lock 2024-08-12 11:45:46 -04:00
bgbsww
e15646d158 Toponaming: Tests, cleanup, and fix axis drawing 2024-07-26 11:49:56 -04:00
PaddleStroke
a1487106ab Sketcher: re-apply cursor of tool when clicking. 2024-07-14 22:35:07 -05:00
Max Wilfinger
7d21d9edb8 Fix source string typos mentioned on Crowdin (#15261) 2024-07-08 17:18:31 -05:00
ppphp
51c6dbd3e3 fix unique ptr usage in sketch (#15008)
* fix unique ptr usage in sketch

* [pre-commit.ci] auto fixes from pre-commit.com hooks
2024-07-08 10:53:49 -05:00
Chris Hennes
e60d43fcdc Merge pull request #14386 from maxwxyz/sketcher-draw-style
Sketcher: Changes override draw style when entering sketch edit mode.
2024-06-24 10:48:19 -05:00
CalligaroV
4a486b21ed Sketcher: fix external edges selection
* fix selection from Sketcher Task Panel
 * fix selection from 3D View
 * Synchronize selection between Task Panel and 3D View

Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
2024-06-24 10:35:54 -05:00
PaddleStroke
22a98d81f0 Sketcher: - Give focus to the MDI so that keyboard events are caught after starting edit. Else pressing ESC right after starting edit will not be caught to exit edit mode.
- After tool handler is purged, give back focus to MDI to make sure VPSketch receive the keyboard event. Else if user start a tool, dismiss it with ESC, then press ESC again to exit edit mode it won't be detected.
2024-06-13 14:44:30 -05:00
Kacper Donat
8def94e6f8 Gui: Update sketcher colors after file load
This commit introduces AutoColor property for sketches that when
enabled ensures that sketches are updated with the color of user
preference. It ensures that sketches from different users will be
still visible on different themes.

To ensure backward compatiblity migration strategy is to compute default
value for this property based on the color. If it is non-white (the
default value in FreeCAD) we assume that the change was inentional and
that it should be kept as-is turning automatic coloring off. In other
cases it is enabled by default.

Fixes: FreeCAD#13980
2024-06-03 11:15:36 -05:00
Max Wilfinger
4e8f3f0381 Added preference for disabling shaded override draw style when entering sketch edit mode.
Storing previous override draw style and applying it when leaving the sketch.
2024-05-30 21:07:30 +02:00
Max Wilfinger
5c7d287f6b Changes override draw style when entering sketch edit mode. 2024-05-30 11:17:35 +02:00
Syres916
e7c11a01be [Sketcher] Change HeadlightIntensity entering and exiting Edit Mode (#14013)
* [Sketcher] Change HeadlightIntensity entering and exiting Edit Mode

* [Gui] Fix Lint Warning

* [Sketcher] Fix Lint Warning

* [Sketcher] Remove duplicate parameter check

* [Gui] Add const
2024-05-27 11:27:11 -05:00
0penBrain
b9db90ea20 Gui: offer possibility to editing view provider to handle "Select All" command 2024-05-27 10:52:00 -05:00
PaddleStroke
7075e3c1d5 Sketcher: Fix line to arc point distance movement problem 2024-05-20 11:15:56 -05:00
wmayer
b64e3e750f Sketch: add command to context-menu to change value of constraint
The edit datum dialog is opened by double-clicking on a dimensional constraint in a sketch. However, the double-clicking event doesn't work realiably on
some systems. As a workaround this PR adds the command to the context-menu.

For more details see the forum thread: https://forum.freecad.org/viewtopic.php?t=71137
2024-04-08 18:01:44 +02:00
Max Wilfinger
33abd923b3 Update Sketcher context menu.
Refine poposed constraints on point selection.
Add symmetry constraint to context menu.
Rearrange commands to be consistent with the toolbar.
2024-04-08 17:58:28 +02:00
wmayer
d92267c6a7 Fix several compiler warnings
* fix -Winconsistent-missing-override
* fix -Wunused-but-set-variable
* fix -Wunused-parameter
* fix -Wunused-lambda-capture
* fix -Wunused-private-field
* fix -Wpessimizing-move
2024-04-03 10:04:56 +02:00
sliptonic
75c589d355 Merge pull request #12602 from FlachyJoe/arc-distance
Sketcher : ArcLength Constraint
2024-04-01 10:43:35 -05:00
Max Wilfinger
6ca8b2daae update hardcoded XPMs to .svg files. Updated .svg icons for clarity. 2024-03-30 11:25:13 +01:00
Florian Foinant-Willig
646b4381f9 Sketcher: ArcLength GUI 2024-03-25 22:32:20 +01:00
luzpaz
5839134e95 Fix various typos throughout the codebase (#13029)
* Fix various typos throughout the codebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-03-18 16:54:30 -05:00
Max Wilfinger
4ca8e3b283 add constraint perpendicular to the context menu if a conic and line is selected. 2024-03-18 13:24:16 -04:00
PaddleStroke
b3fe5bba28 Sketcher: Chamfer tool (and fillet refactor) 2024-03-18 13:23:54 -04:00
Chris Hennes
d9fc266772 Sketcher: Remove trailing spaces from translations 2024-03-12 22:42:19 -05:00
xtemp09
9961f2949a Fix segmentation fault in Sketcher
Closes #11954.
2024-03-11 16:02:15 +01:00
Josh Coalson
a8ae56e06a Part: Rename AttachExtension::Support property to AttachmentSupport, to avoid name conflict with base features. Fixes #7052 2024-03-04 18:22:43 +01:00
Roy-043
8145eed95f Sketcher: Sketcher_ConstrainHorizontal before Sketcher_ConstrainVertical in GUI
Changes to TaskSketcherElements.cpp are not required, but were done for consistency. The order in the file follows the GUI.
2024-03-04 11:12:38 -06:00
wmayer
51a01b9e2b Fix compiler warnings:
fix [-Winconsistent-missing-override]
fix [-Wunused-lambda-capture]
fix [-Wunused-variable]
fix [-Wswitch]
2024-02-26 11:01:37 -06:00
wmayer
a38e73135e Sketcher: fixes #12343: Undo/Redo for sketcher constraints doesn't work correctly 2024-02-25 00:59:35 +01:00
Max Wilfinger
e135f68e8a add new Sketcher commands translate and scale to context menu 2024-02-12 21:50:07 +01:00
wmayer
df7e783513 Mod: fix several compiler warnings:
* fix -Wsometimes-uninitialized
* fix -Wunused-parameter
* fix -Wunused-variable
* fix -Winconsistent-missing-override
* fix -Wsign-compare
* fix -Wreorder-ctor
* fix -Wtautological-overlap-compare
2024-02-12 11:39:32 -06:00
Max Wilfinger
4164919e58 Improvements to contextual right click menu in Sketcher.
Consider preselection, external geo and copy/cut/paste commands.
2024-02-12 11:04:06 -06:00
Max Wilfinger
0bef2e927b [Sketcher] enable BSpline commands in contextual right click menu 2024-01-22 12:21:01 -06:00
Paddle
6db820a580 Sketcher: Define double click on edges : Select the whole wire. 2024-01-17 11:05:28 -03:00
Max Wilfinger
476089a2ad sketcher: create contextual right click menu 2024-01-08 12:39:17 -05:00
Abdullah Tahiri
4586f71d86 Refactor ViewProvider move constraint code 2023-12-17 16:01:29 +01:00
Florian Foinant-Willig
d2a579bdc6 Sketcher: Extend distance constraint to arcs 2023-12-17 16:01:29 +01:00
Florian Foinant-Willig
94eaa7db78 Sketcher: Arc to arc or circle distance constraint 2023-12-17 16:01:29 +01:00
Paddle
05c382f6d9 When moving an angle, we did not take into account the case where they are reversed. This fixes that. 2023-11-24 15:07:30 +01:00
Abdullah Tahiri
97d3665757 SketcherGui: Fix preselectAtPoint for non X-Y orientations 2023-11-15 14:34:11 +01:00
Abdullah Tahiri
55639df573 Sketcher: Box Selection - refactor
==================================

Full refactor of this function without change of functionality (hopefully).
2023-11-11 21:19:12 +01:00