Commit Graph

89 Commits

Author SHA1 Message Date
Markus Lampert
115fbd68bb Blanket black formatting for Path python files 2022-03-20 13:23:48 -07:00
Russell Johnson
66d27bbbef Path: Fix overcut under model below selected faces
Fixes address issues where incorrect paths are generated that include clearing paths below selected faces on underside of model. In forum presented at https://forum.freecadweb.org/viewtopic.php?f=15&t=64111 and https://forum.freecadweb.org/viewtopic.php?f=15&t=65421.
2022-02-12 10:55:58 -06:00
Russell Johnson
d34de288d7 Path: Black formatting only 2022-02-12 10:55:57 -06:00
sliptonic
8638ceba12 Pocket translation cleanup 2022-01-24 17:54:08 -06:00
sliptonic
7572372926 pocket black 2022-01-24 17:11:08 -06:00
Russell Johnson
4c1951aedc Path: Allow parent job assignment
Modifications focus on allowing the creation of operations to include direct provision of parent job.
Path: Remove `useGui` implementation
2021-08-13 19:02:40 -05:00
Russell Johnson
544a87e235 Path: Remove unnecessary commented-out code blocks 2021-07-16 12:02:24 -05:00
Russell Johnson
44b82bfda9 Path: Correct tuple lengths in return values
PathAreaOp needs tuples of three items, after rotational code purge.  This module was missed for tuple length adjustment.
2021-07-16 12:02:24 -05:00
luz paz
60c055e62d Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
Eric Trombly
24e681c63b add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
Russell Johnson
f8a4e20adc Restore manual override of FinalDepth values
Manual entries of FinalDepth values are now respected, even if below the calculated bottom of selected geometry.
Affected modules include PathPocketShape, PathPocket, PathCircularHoleBase, and PathAreaOp-based operations.

Fix format syntax issues
2020-02-14 19:38:35 -06:00
Markus Lampert
81bbb0066d Removed dead code for debugging shortcut warnings. 2020-01-03 23:13:55 -08:00
Russell Johnson
00703a5179 3D Pocket: upgrade to adaptive start and finish
apply algorithms to some pockets to eliminate air milling and adapt start and finish heights and paths to top and bottom of certain pockets.
Depth correction & flake8 formatting
use list to track successive cuts so variations of settings are tracked and applied correctly
Apply faceType specific depth calculations
Planar face requires one depth source, non-planar requires a different source.
2019-07-21 21:21:24 -05:00
Russell Johnson
b4b244c85d Fix SetupProperties() property syntax issue
fix for SetupProperties() issue presented at:
https://forum.freecadweb.org/viewtopic.php?f=15&t=37368#p318253
2019-07-01 22:02:18 -05:00
Markus Lampert
0065ed5d7b Catching new warnings due to merge 2019-07-01 15:32:54 -07:00
Markus Lampert
6410393092 switched to pylint3 and fixed additional warnings 2019-07-01 15:32:54 -07:00
Russell Johnson
e2d04ec991 3D Pocket: Upgrade to collective face processing!
New property added: `HandleMultipleFeatures`.
New property and related code allows for improved, and expected, 3D Pocket operations.
Improvement combines faces selected to create one envelope to be processed as the path shape ('collectively' setting).
Old behavior is available with 'Individually' setting.
Enjoy!
2019-06-30 14:06:37 -05:00
sliptonic
617c619d2f remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
sliptonic
c8e945a3ab Path: normalize proxy stratements
remove bare exceptions
2019-06-21 13:01:01 -05:00
luz.paz
ec12ffae0c Path: source comment typo fixes
Found via `codespell`
2019-05-30 19:57:25 +02:00
Markus Lampert
34224aa7f8 Added multi base model support to Pocket 3D op. 2018-09-11 07:24:36 +02:00
Markus Lampert
0603448a92 Operation setting support for all pocket ops. 2018-09-02 00:32:22 -07:00
Markus Lampert
353ec4a646 Added name parameter to operation proxy constructor. 2018-09-02 00:32:22 -07:00
Markus Lampert
9cd8ac46f7 Add job as parameter to opSetDefaultValues 2018-09-02 00:32:22 -07:00
Markus Lampert
bf46c47616 Removed PathGeom class and moved functionality into module interface. 2018-06-19 21:38:20 -07:00
Markus Lampert
749fe3631a Consolidated all depth calculations. 2017-09-28 11:27:47 -07:00
Markus Lampert
7febd40788 Fixed pocket final depth calculation and hide it from user modifications. 2017-09-17 18:46:00 +02:00
Markus Lampert
69e5f791a2 Reduced logging for pocket ops again. 2017-08-22 10:16:58 -03:00
Markus Lampert
5cf63ae2de Refactored pocket and facing to use the same base class; added min travel and keep tool down to the interface - latter one is hidden since it currently doesn't seem to work. 2017-08-22 10:16:58 -03:00
Markus Lampert
684b4f6e7e Added doc strings to operations. 2017-08-22 10:16:58 -03:00
Markus Lampert
62c9bcc39a Added support for baseobject into PathOp, used by almost all ops anyway. 2017-08-22 10:16:58 -03:00
Markus Lampert
f4c20e7c61 Moved base functionality into PathOp and renamed AreaOp interface to areaOp... 2017-08-22 10:16:58 -03:00
Markus Lampert
a8a9e3c4a8 Converted MillFace to be based on PathAreaop. 2017-08-22 10:16:57 -03:00
Markus Lampert
6f334e84a5 Renamed PathProfile to PathProfileFaces for consistency; moved common depth calculation for ops with BaseGeometry into PathAreaOp. 2017-08-22 10:16:57 -03:00
Markus Lampert
0617d360d0 Converted PathProfile to be based on PathAreaOp. 2017-08-22 10:16:57 -03:00
Markus Lampert
c0c2fc5dfb Fixed issues with BaseGeometry UI processing and extended interface to support multiple shapes. 2017-08-22 10:16:57 -03:00
Markus Lampert
98c9c544b4 Moved pocket specific logic back into PathPocket. 2017-08-22 10:16:57 -03:00
Markus Lampert
bd83f3d776 Split pocket gui into its own file and based on PathAreaOpGui. 2017-08-22 10:16:57 -03:00
Markus Lampert
bf025123a0 Moved PathPocket to use PathAreaOp. 2017-08-22 10:16:57 -03:00
sliptonic
0b0c3b2b2e Path: fix #3048 Visibility on recompute is now preserved 2017-07-10 19:17:41 -03:00
sliptonic
4063609e89 Path: cleanup start points
Make sure we're storing path parms for debugging
2017-07-07 16:42:06 -05:00
sliptonic
f444f96c7d re-arrange TestPathPost setup to simplify testing muliple posts 2017-07-07 16:42:06 -05:00
sliptonic
5f77eea2aa Path: Adding Apply buttons
Give user more control of when long
running updates are executed in task
panels
2017-06-28 21:46:44 +02:00
sliptonic
38de5a247c Path: cancel for pocket 2017-06-28 21:46:44 +02:00
sliptonic
7532011104 Path: remove obsolete code from cmake
also refactored depthparams and fixes to depths
on various operations
2017-06-28 21:46:44 +02:00
sliptonic
ae29107aa9 path: more collision support
Made depthparams an iterable.
2017-06-28 21:46:44 +02:00
sliptonic
5305247140 Path: fix potential crash bug. 2017-06-18 17:32:16 +02:00
sliptonic
6da8c1ba94 Path: added a hidden property to store the areaparams
Useful for debugging.
2017-06-15 14:42:30 -03:00
sliptonic
239514e825 Path: fix bug in drilling
hemispherical faces have an odd edge that doesn't have a Curve attribute.
2017-06-15 14:42:30 -03:00
sliptonic
91551520e8 Path: usecomp setting toggles the availability of the side property 2017-06-15 14:42:30 -03:00