Commit Graph

17966 Commits

Author SHA1 Message Date
luz paz
bd3fdd288e Web: Fix header uniformity, whitespace, doxygen headers 2020-11-18 08:58:38 +01:00
luz paz
26636dbbad Test: Fix header uniformity, whitespace, doxygen headers 2020-11-18 08:58:06 +01:00
Bernd Hahnebach
3cdbbe6dbc FEM: typo in coding conventions 2020-11-18 08:16:01 +01:00
Bernd Hahnebach
f6978f419e Material: pep8 code formating 2020-11-18 08:15:50 +01:00
sliptonic
3c0bbd25e4 Merge pull request #3916 from Russ4262/fix_PocketShape
Path: Pocket_Shape - Improved fixes for FinalDepth and rotational issues
2020-11-17 17:31:31 -06:00
luz paz
1572971772 TechDraw: minor cosmetic readability change in Gui/Workbench.cpp
[skip ci]
2020-11-16 14:52:42 +01:00
luz paz
ec52d5fd28 Arch: Added licence blurbs with attributions to authors
[skip ci]
2020-11-16 14:51:53 +01:00
luz paz
ccf30d98d2 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
wmayer
385e4df10c PartDesign: [skip ci] fixes #0004494: Error "Result is empty" for Pads and Pockets with non zero Offset 2020-11-16 14:45:55 +01:00
Yorik van Havre
1cce61670c Draft: better checks for no active document 2020-11-16 13:25:12 +01:00
Yorik van Havre
b502de4c40 Merge branch 'master' of github.com:FreeCAD/FreeCAD 2020-11-16 13:24:33 +01:00
Yorik van Havre
6a1209dc17 Merge pull request #4054 from Roy-043/ArchRoof_processSubShapes_placement_fix
Arch: Fix for ArchRoof. When processing a roof's subshapes the placement of the roof was ignored.
2020-11-16 13:06:11 +01:00
Yorik van Havre
48e928cee5 Draft: Enabled 'apply to selected' button in SetStyle dialog 2020-11-16 12:59:44 +01:00
wmayer
5e07809384 PartDesign: [skip ci] support negative values as second length of a pocket 2020-11-16 11:35:05 +01:00
wmayer
2e83e95f3a PartDesign: [skip ci] support negative values as second length of a pad 2020-11-16 11:26:51 +01:00
wmayer
55e3aad3c7 Part: allow to open attachment editor via context-menu 2020-11-15 19:16:22 +01:00
wmayer
178ee5b94e Part: move ViewProviderPrimitive to its own source files 2020-11-15 18:44:27 +01:00
wmayer
e6e7995b9c Part: [skip ci] include needed headers into PCH file 2020-11-15 13:30:32 +01:00
tomate44
ae6c2b7d30 fixes and typos 2020-11-15 13:20:41 +01:00
tomate44
3c93dba15a Part: add BezierCurve constrained interpolation 2020-11-15 13:20:41 +01:00
wmayer
d8a36bc1b2 Part: [skip ci] include generated ui files from within source file 2020-11-15 13:17:52 +01:00
donovaly
bfa2ac9d31 [Part] show location dialog when creating a Primitive
- there is no reason to hide it and even a bit tiring to open it manually since most no new primitives should be at the origin
- give the combobox to select the primitive type a reasonable name, this helps to understand the code better
2020-11-15 12:56:16 +01:00
Roy-043
9292bb60b0 Update ArchRoof.py
The processSubShapes function was wrongly called without providing the placement argument.
2020-11-15 12:02:02 +01:00
wmayer
596077cf67 PartDesign: [skip ci] if numpy fails to load due a RuntimeError then handle this exception but still load the workbench 2020-11-15 11:47:19 +01:00
wmayer
65474964f9 Sketcher: [skip ci] revert minimum size hint from widgets in datum dialog
because this leads to a squashed appearance on some systems.

For more details see: https://forum.freecadweb.org/viewtopic.php?f=34&t=52139
2020-11-15 11:07:19 +01:00
donovaly
c9c5f12629 [PD] Hole countersink angle work
- fix bug that custom angles were overwritten
- the norms only define screw heads, not the cut for them, so also a custom angle is possible to sink a metric screw
- use better step in UI since one changes the presets only in fractions of a millimeter (otherwise it would be a different hole size)
- handle case of no cut
- calculate change in diameter when adding depth to countersinks
2020-11-14 19:24:32 +01:00
luz paz
ae71abd1cc TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
wmayer
384b085b68 Image: [skip ci] move the import of Draft trackers inside scaling function. This gives a more useful error message in case of a failure to load it 2020-11-14 12:08:03 +01:00
Russell Johnson
60249f543c Path: Delete irrelevant code 2020-11-13 16:34:59 -06:00
Russell Johnson
6046e0600b Path: Fix div by zero error
Fix MillFace div by zero error reported in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=51415.
Rotational-related variables were exposed to non-rotational code block.  They have been moved into correct rotational code block.
2020-11-13 16:34:59 -06:00
Russell Johnson
5bb979e34a Path: LGTM cleanup 2020-11-13 16:34:59 -06:00
Russell Johnson
cae33892e1 Path: Organize rotational code in areaOpShapes() method
Relocate the rotational analysis code into smaller independent methods to allow for easier maintenance and support.
Commented out recently added debug object creation statement.
2020-11-13 16:34:59 -06:00
Russell Johnson
45832af35b Path: Fix and cleanup removal shape creation code
The `isFaceUp()` method in the PathAreaOp module was returning false results in some instances.
Rotational code has been consolidated and better organized to fix certain errors reported in the forum.
Overall, this code section has been better organized as a part of the necessary fixes.
2020-11-13 16:34:59 -06:00
Russell Johnson
947bfa345d Path: Improve accuracy of isFaceUp() method
This method is used in rotational operations and some standard operations to identify if a face's normal-direction Z value is +1.0
2020-11-13 16:07:18 -06:00
Russell Johnson
760fa482ef Path: Remove null comments and improve debugging
Added method to create a FreeCAD object when in debug mode.
2020-11-13 16:07:18 -06:00
sliptonic
610f3ebf75 Merge pull request #3989 from Russ4262/Surface_fixes
Path: 3D Surface fix to apply `CutMode` when `CutPattern = Offset`; and LGTM cleanup
2020-11-13 14:25:19 -06:00
wmayer
679731f75e PartDesign: [skip ci] make cut type modes of hole feature translatable 2020-11-13 17:51:41 +01:00
donovaly
0c34461410 [PD] fix issue 3968
https://tracker.freecadweb.org/view.php?id=3968

Don't set the tip to features that cannot hold the tip
2020-11-13 17:03:19 +01:00
wmayer
64152be6f3 Part: [skip ci] rearrange line page to save some vertical space 2020-11-13 15:35:07 +01:00
donovaly
6498795b50 [Part] remove unnecessary vertical whitespace in dialogs
on smaller screens it is very annoying that the Part dialogs have too much vertical whitespace.

This PR gets rid of some unnecessary whitespace.
2020-11-13 13:52:31 +01:00
donovaly
49a94ca14b [PD] add measure tools
use Part's measure tools also for PartDesign
2020-11-13 12:38:42 +01:00
donovaly
38d5e99a78 [Part] improve tube dialog
- remove vertical whitespace
2020-11-13 12:37:57 +01:00
wmayer
ce0c9d8f59 Part: [skip ci] show dialog directly when creating a tube feature 2020-11-13 12:33:59 +01:00
marioalexis
dcfba722f4 Draft: Fixes #0004293: Vertical dimensions can't be created in XZ and YZ working plane 2020-11-13 10:58:34 +01:00
donovaly
83f6c27be7 [PD] hole UTS fixes
- propose cut values also for UTS profiles
- the UTS defines coarse and fine while for ISO it is regular and fine, thus fix the name
- for the dialog: set minimum values to zero (angles etc. cannot be negative)
2020-11-13 09:07:27 +01:00
donovaly
58168f4e89 [PD] more hole cut work
- add definitions for IS 2009, 7046 and 12474
- remove useless file for a ISO 14583 since there are no such screws on the market
- rename "coarse" to "regular" since this what it actually is according to the norms
- uniform the x1 threads (for x2.0 etc we use a trailing zero and for some we use x1, for some already x1.0, thus consistently use x1.0)
- add some ISO 10642 entries
- correct ISO 4762:
  - correct some values
  - the does does not define a size M27
  - add the two missing sizes
2020-11-12 17:41:53 +01:00
M G Berberich
983ca52aed cut-profiles with identical names for different threads
Allow cut-profiles with identical names for different threads.
see:
https://forum.freecadweb.org/viewtopic.php?f=19&t=51491&start=60#p446854
https://forum.freecadweb.org/viewtopic.php?f=19&t=51491&start=60#p446902
2020-11-12 17:38:18 +01:00
sliptonic
84002ae6a6 Merge pull request #4038 from daveseff/pathworks
Pathworks
2020-11-12 10:08:48 -06:00
wmayer
62ed3dcaf9 Part: [skip ci] implement editor dialog for tube feature 2020-11-12 16:45:38 +01:00
wmayer
9b88bdcc9b Part: [skip ci] make sure to open a transaction when starting edit mode of primitives via context-menu 2020-11-12 16:35:58 +01:00