Commit Graph

30457 Commits

Author SHA1 Message Date
Uwe
bdc23a5b02 [FEM] register new result values to DataAtPoint filter
- also sorting to keep the overview
2023-02-13 02:50:34 +01:00
Jonas Bähr
4a77843845 PD: Improve InvoluteGear's fillet generatrion
Previously, the fillet started at a fixed value, tailored at 20° pressure
angle, a fillet radius of 0.375 and a dedendum of 1.25. With PR #8184
those values became user-adjustable and thus the assumptions of the
original code are not fullfilled any more. This resulted in significant
artefacts, especially for higher pressure angles or smaller dedendums as
commonly found in splines.

This commit actually calculates the junction between fillet and involute
so that the tangents of the both curves match.
The mathematical approach is described in source code comments.

The change in the fillet calculation also affects compatibility with
files generated by earlier versions of FreeCAD. Those changes are way
below 0.1% per tooth, however the earlier test required absolute equality
down to the micron. This was relaxed and also changed to a relative, per
tooth, tolerance.

There is one particular case where the new algorithm performs slightly
worse, though. That is when the fillet radius is too large to the
dedendum, i.e. resulting in a single arc instead of two fillets, and
effectively cannibalizes some of the clearance. This happens with internal
gears having less than 25 teeth. At about 15 teeth it becomes visible
that the fillet is not 100% tanget any more. However, as such a low
number of teeth is highly unusual for internal gears and the effect,
although noticeable, is minor, the overall benefits of the new algorithm
outweighs the drawbacks. And now with the fillet radius being adjustable
it is easy to fix, too.
The technical reason is that the tangency is calculated correctly, but
the fillet circle is displaced aferwards to avoid an overlap of the two
fillets. For the new fillet position, the tangents do not align any more.
2023-02-13 02:31:28 +01:00
Jonas Bähr
4f56b2654e PD: Expose new gear properties to the SVG generator
This little script has proven to be a vauable debugging aid, so it got
some love. All the new properties from #8184 can now be set, together
with the option to generate internal gears.
2023-02-13 02:31:28 +01:00
Uwe
4382bd199a [Part] extend SectionCutting feature for intersecting objects
- it is a well-known and often feed-backed missing feature that SectionCuttings fails for intersecting objects.
To resolve this, the objects must be put int a BooleanFragments object.
- this PR adds this functionality as option.
- since a BooleanFragments objects has a specific color, the different colors of the objects cannot be preserved. Because of this disadvantage, the BooleanFragments option will not be the default.

- this PR also modernize all for loops
2023-02-13 00:46:37 +01:00
Uwe
1bcaaec26c [App] License.cpp: add missing include
- does otherwise not compile on Windows
2023-02-12 21:25:08 +01:00
wmayer
38e02e6f36 App: support of method unsetupObject in Python feature classes 2023-02-12 20:01:09 +01:00
wmayer
4036613fd2 App: refactor license handling to reduce code duplication 2023-02-12 19:57:41 +01:00
wmayer
91048d7900 Part: fixes to create a NURBS for the arc of a conic
See forum: https://forum.freecad.org/viewtopic.php?t=75846
2023-02-12 19:45:00 +01:00
0penBrain
ba25e9a82f [Core] Add possibility to set color with tuple of integers, fixes #8344 2023-02-12 18:16:59 +01:00
wandererfan
4dff7db187 [TD]fix face hatch location inSvg export 2023-02-12 11:50:20 -05:00
Roy-043
b6af6c9330 [Draft] fix #8433 regression (#8452) 2023-02-12 14:22:52 +01:00
Adrien GUICHARD
87c5403b69 Add TaackPLM_workbench_icon.svg in resources 2023-02-12 10:38:47 +01:00
alexneufeld
8f06403537 Gui: Add CERN OHL to default licenses list 2023-02-12 10:31:59 +01:00
ieternalleo
bececf6384 Mesh: Update error message to inform of missing mesh file format upon export 2023-02-12 10:29:35 +01:00
marioalexis
d8d3bb8120 App: Fix warnings -Wignored-qualifiers 2023-02-11 14:16:46 -08:00
luzpaz
516509dbf0 Draft: [skip ci] fix typo in source comment (#8434)
Fixed typo in `draftutils/gui_utils.py`
2023-02-11 21:02:27 +01:00
paul
6c76637a10 [Arch Component] Fix placement multiplication problem (re-PR) (#6617)
* [Arch Component] Fix placement multiplication problem (re-PR)

- see forum discussion : https://forum.freecadweb.org/viewtopic.php?f=23&t=67008

* Update ArchComponent.py

Manual edit to avoid merge conflicts.

---------

Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>
2023-02-11 20:43:28 +01:00
wandererfan
502ef8c9ba [TD]fix validation of hybrid dimension 2023-02-11 13:30:15 -05:00
wandererfan
cd79b8744f [TD]centralize balloon prefs 2023-02-11 13:30:15 -05:00
Roy-043
7f2f5e9414 [Draft] fix diffuse color issue when creating arrays (#8436) 2023-02-11 18:57:28 +01:00
wmayer
c7a21ecbee Fixes #8206: FreeCAD segfaults being run with parameters (e.g .desktop file has /usr/bin/freecad --single-instance) 2023-02-11 17:49:52 +01:00
Roy-043
5d6b447149 [Draft] some arrays did not have a Count property (#8433) 2023-02-11 17:09:02 +01:00
Roy-043
c437b79ada [Draft] update of Draft_Clone related to gui_utils.get_diffuse_color (#8430) 2023-02-11 16:21:18 +01:00
Roy-043
6cc22f2a54 [Draft] fix Draft_Mirror diffuse color issue. (#8427) 2023-02-11 11:18:00 +01:00
Uwe
ee4beba619 [FEM] fix bug in potential constraint task panel
- fix logic of a checkbox
2023-02-11 04:41:15 +01:00
Uwe
7fb40b1d70 [Material] editor: improve float input
- it is very annoying to get a dozen decimals on editing floats. 6 do the job for all cases and a spinBox is preferred.
2023-02-11 04:14:30 +01:00
Chris Hennes
eeb4dbdcf0 Addon Manager: Add data for integration tests 2023-02-10 16:19:17 -07:00
Chris Hennes
d53ece025a Addon Manager: Prep Addon for refactoring 2023-02-10 15:31:06 -07:00
Chris Hennes
b2d06f18c7 Addon Manager: Add more unit test mocks 2023-02-10 14:37:16 -07:00
wmayer
8f7a275bf1 FEM: raise an exception if no valid object is selected 2023-02-10 21:10:25 +01:00
Chris Hennes
b75c7c8388 App: Add basic test for new Metadata code 2023-02-10 12:40:55 -07:00
Chris Hennes
6db8887983 App: Cleanup Metadata 2023-02-10 12:40:55 -07:00
Chris Hennes
65513b48d0 App: Add support for in-memory Metadata creation 2023-02-10 12:40:55 -07:00
Chris Hennes
c8b65c91ce Addon Manager: Reload page when following links
Partially addresses #8361 by ensuring that when an external link is followed, the internal page gets reloaded instead of showing an error page.
2023-02-10 12:19:44 -07:00
Uwe
95a6d1e208 [FEM] Elmer: add support for 3D magnetodynamics
- adds the corresponding Elmer equation (it is now possible to do Elmer's tutorial example no. 14)
2023-02-10 19:48:31 +01:00
Uwe
f26481ca20 [FEM] change hiding logic on calling task panels
- the typical workflow is to change e.g. a constraint setting or material property and to check how and if this change changes the simulation result. it is therefore very annoying that on every call of a task panel the results are hidden.
This PR changes this to hide only meshes and the filter functions but to keep the results. If a user don't like to see results for example to select faces, he hides results anyway.
2023-02-10 16:47:52 +01:00
Uwe
67d73f31a8 [FEM] ViewProviderFemPostObject: fix a typo 2023-02-10 16:08:03 +01:00
wmayer
c0bbff3f28 Spreadsheet: fix some warnings and issues reported by GH actions 2023-02-10 16:06:46 +01:00
wmayer
108e30d8ba smesh: std::iterator<> is deprecated in C++17 2023-02-10 14:18:01 +01:00
Uwe
3f29b469a4 [FEM] Elmer: fixes for Magneto2D writer
- assure a 2D coordinate system is used
- get rid of annoying numerical artifacts
2023-02-10 02:21:21 +01:00
Uwe
b3e8add2e4 [FEM] use extended current density constraint for 2D
-also a fix bug that for 2D there is no z-component of magnetization
2023-02-10 01:30:14 +01:00
Uwe
aca9e15f66 [FEM] extend current density to 3D
- to be used for magnetodynamic 3D equation
2023-02-10 01:30:14 +01:00
sliptonic
16cacfb3fb Merge pull request #8307 from LarryWoestman/staging
Path:  Refactored the add_parameters function into individual functions.
2023-02-10 00:37:09 +01:00
Uwe
04f0b66ef7 [FEM] use magnetization constraint for 2D
- uses the constraint for 2D magnetodynamics to perform e.g. Elmer's tutorial non. 15

- modify the Material manager to get rid of magnetization but keep the vectorial functionality because in future there will be support for e.g. birefringence materials etc.
2023-02-09 15:43:42 +01:00
Uwe
04915b694b [FEM] add new constraint for magnetization 2023-02-09 14:41:25 +01:00
Uwe
c59a10be77 [FEM] add support to show absolute value result fields
- for harmonically driven forces, the results of course also have an imaginary part. Elmer outputs the real and the imaginary parts as separate result field. However, for several applications one needs the absolute (sqrt(Re^2+Im^2)
- therefore offer also absolute field if there are real/imaginary results
2023-02-09 14:36:26 +01:00
Uwe
aa4700f12b [FEM] Elmer: magneto 2D use magnetization
- take magnetization into account for the magnetodynamic2D equation
2023-02-09 07:27:44 +01:00
Uwe
cbe634719d [Material] allow to use vectorial properties
- for electromagnetics we have vector fields and thus need to specify components
- as first step use the new material "Magnetization"

- also get rid of annoying debug messages output on normal use in the material dialog
2023-02-09 07:26:22 +01:00
Uwe
436703e8ce [Material] new card for Iron 2023-02-09 06:25:43 +01:00
Uwe
c074fe1c95 [App] fixes for Magnetization property 2023-02-09 05:32:20 +01:00