Commit Graph

1807 Commits

Author SHA1 Message Date
Markus Lampert
c1549ba3a8 Allowing QuantitySpinBox to be reused for different attribute; using properties to get values to work around build differences. 2020-12-17 22:56:42 -08:00
Markus Lampert
d136394376 Rearranged BitTool shape update so dependent ops don't execute with invalid tool. 2020-12-17 20:27:42 -08:00
Markus Lampert
a5e992f700 Make BitShape read/writeable, so the tool can be edited when shared to a different system 2020-12-17 19:59:44 -08:00
Markus Lampert
3da82fa6af Hide document when loading a ToolBit. 2020-12-17 19:55:59 -08:00
Markus Lampert
7049c09448 Only update the shape if it has changed. 2020-12-17 19:14:44 -08:00
sliptonic
b920bbf73a Merge pull request #4143 from mlampert/bugfix/vcarve-depth
Path: Bugfix/vcarve depth
2020-12-14 17:18:30 -06:00
sliptonic
07e2e8fcf3 Merge pull request #4141 from gauna85/PathToolcontroller
Path: Added missing signal-connection causing spindle speed not to be updated using ToolControllerDlg Bug 4479
2020-12-14 12:28:56 -06:00
Markus Lampert
ee92a1d2f9 Adding g0 to safety to base op so it's applied to all ops 2020-12-13 15:00:05 -08:00
Stefan Endres
a7edfcf1cb Path: Added missing signl-connection causing spindle speed not to be updated using ToolControllerDlg 2020-12-13 22:12:08 +01:00
Markus Lampert
ed7be8674e meld h and v speeds for v-carve commands depending on incline 2020-12-13 11:31:58 -08:00
Markus Lampert
1511fae5fe Consistent TC naming/labeling, regardless of how created. 2020-12-13 11:31:58 -08:00
Markus Lampert
70364c0277 Fixed thread-milling icon reference. 2020-12-13 11:31:58 -08:00
Markus Lampert
c955bf4a4e Fixed v-carve depth calculation in the presence of a bottom diameter, added unit tests and cleaned up the v-bit parameter naming. 2020-12-13 11:31:58 -08:00
Stefan Endres
e7085cb47e Path: Sort edges before splitting at selected vertex 2020-12-13 19:27:13 +01:00
Markus Lampert
85cd4af06b More py2 special handling for unit tests 2020-12-03 19:39:33 -08:00
Markus Lampert
9eebafbe4b Added consistent encoding headers and fixed whitespaces 2020-12-03 18:15:36 -08:00
Markus Lampert
134fe23c8f Fixed unit test breakage for py2 2020-12-03 18:15:36 -08:00
markus
aa2881e08e Use new ToolBits (and only those) for thread milling. 2020-12-03 18:15:36 -08:00
markus
d5beaf806d Filter all TCs for suitability for a given op. 2020-12-03 18:15:36 -08:00
markus
b7a356cceb Catch exception if shape file does not include a thumbnail. 2020-12-03 18:15:36 -08:00
Markus Lampert
b1c385f909 Cleaned up properties 2020-12-03 18:15:36 -08:00
Markus Lampert
c11aaafc54 Added support for imperial threads to thread milling 2020-12-03 18:15:36 -08:00
Markus Lampert
15141e33dc Added actual thread milling path generation. 2020-12-03 18:15:36 -08:00
Markus Lampert
0a96a861c3 Added thread milling radii calculation 2020-12-03 18:15:36 -08:00
Markus Lampert
b29d168132 Add basic thread milling op 2020-12-03 18:15:36 -08:00
sliptonic
be190a948a Merge pull request #4097 from Russ4262/millface_fix
Path: Millface fix - Address rounding issue
2020-12-03 13:29:14 -06:00
sliptonic
b935769fe3 Add finaldepth property.
Operation now sets start/final depth more reasonably.
Will not violate the finaldepth.
2020-12-02 15:05:08 -06:00
Russell Johnson
53091320c6 Path: Swap list instantiation per senior devs specifications 2020-12-02 11:34:58 -06:00
Russell Johnson
384541eede Path: Instate obj.removalshape property for debugging purposes 2020-12-02 11:34:58 -06:00
Russell Johnson
f869fbf598 Path: Address problem with rounding issue
Translate removal shape down into buffer zone to offset rounding issue.
2020-12-02 11:34:58 -06:00
sliptonic
caf30cd7ce Merge pull request #4071 from Russ4262/fix_rotational_drilling_depth
Path: Fix Drilling Op issues when using rotation feature
2020-12-02 10:22:01 -06:00
sliptonic
60e1d7a7f7 Merge pull request #4096 from sliptonic/bug/toolbit
[path]  make toolbit reject invalid filenames and prompt user for valid toolbit working location
2020-12-02 08:51:49 -06:00
luzpaz
22c652f766 Path: Added revision suggested by @cheenes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
[skip ci]
2020-12-02 06:57:56 -05:00
luz paz
5dc381a71d Path: fix translation to reflect the correct context
[skip ci]
2020-12-02 06:57:28 -05:00
luz paz
0e4cf2e758 Path: Added missing Path_Custom in previous commit 2020-12-02 06:57:28 -05:00
luz paz
fe547195bf Path: Change filenames in the rest of the Path code
Reflects changes in 
* PathOpGui.SetupOperation()
* GetResources()
* sPIxmap
* pixmap
* *.UI files

Also contains minor translation context renames (these were edits made near to original intent of this commit)
2020-12-02 06:57:28 -05:00
sliptonic
af153643f2 PR review suggestions and fixes 2020-12-01 09:43:45 -06:00
Russell Johnson
2461d942af Path: Delete unnecessary comment block 2020-11-30 21:09:58 -06:00
Russell Johnson
99beebc2af Path: Replace all-caps variable name 2020-11-30 21:09:58 -06:00
Russell Johnson
43d54e7f18 Path: Simplify ActiveDocument references 2020-11-30 21:09:58 -06:00
Russell Johnson
d52a96f2b5 Path: Fix rotational errors and organize/simplify some rotational code
Fix rotational alignment and drilling depth issues for rotational drilling ops.
Issues identified in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=52262.
Path:
2020-11-30 20:57:25 -06:00
Russell Johnson
43cd864f8f Path: Clean up comments and simplify one code block 2020-11-30 20:57:25 -06:00
Russell Johnson
693db4e4b6 Path: Synchronize methods with same in PathAreaOp module
The affected methods exist in the PathAreaOp module.  This commit synchronizes the versions here with those.
2020-11-30 20:57:25 -06:00
Russell Johnson
aa2d35cad8 Path: Apply the user's Final Depth value 2020-11-30 20:57:25 -06:00
sliptonic
3eb300a8c2 fix ui bugs 2020-11-30 15:35:30 -06:00
sliptonic
3d822cf269 [path] make toolbit reject invalid filenames
help user create toolbit working location
2020-11-30 15:32:28 -06:00
sliptonic
fc3bf09512 Merge pull request #4073 from Russ4262/fix_slot
Path: Fix arc slotting direction in Slot operation
2020-11-23 15:08:40 -06:00
sliptonic
40d79fc048 Merge pull request #4014 from sliptonic/feature/toolbitdock
[PATH] Feature/toolbitdock
2020-11-23 10:12:58 -06:00
Russell Johnson
d41369ad52 Path: LGTM cleanup 2020-11-22 18:27:21 -06:00
Russell Johnson
c6d5bb8404 Path: Implement LazyLoader for Arcs module 2020-11-22 18:27:21 -06:00