pre-commit-ci[bot]
c19eb5c0e0
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2026-01-06 01:40:39 +00:00
Ajinkya Dahale
9791d3f6d5
Sketcher: Override clang-format for some readability
...
See https://github.com/FreeCAD/FreeCAD/pull/22951#discussion_r2314544159 .
2026-01-06 07:08:17 +05:30
Ajinkya Dahale
e9469d93cc
[Sketcher] Use replaceGeometries() in join()
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
50a091c0ca
[Sketcher] Use auto where possible
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
c02969da9c
[Sketcher] Refactor SketchObject::updateGeometryRefs()
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
9993cc123c
[Sketcher] Refactor SketchObject::onChanged()
...
Break into pieces depending on which property has been passed.
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
e34d6604d7
[Sketcher] Refactor removeAxesAlignment()
...
Use switch case for more readability, and move some if and for indentations
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
abc3c74abd
[Sketcher] Refactor SketchObject::validateExpression()
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
585ce5ec03
[Sketcher] Refactor SketchObject::migrateSketch()
...
Manipulate some if-else statements, for loops, and possibly replace them with
std algorithms.
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
169a10c7d2
[Sketcher] Refactor some if-else statements in SketchObject
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
0c2f4df8d5
[Sketcher] Refactor addSymmetric and getSymmetric
...
Rearrange some if-else and use `std::find_if` instead of looping.
[Sketcher][WIP] Refactor `getSymmetric` and `addSymmetric`
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
78cdd8d59d
[Sketcher] Refactor delExternalPrivate()
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
0ea4c7c280
[Sketcher] Move some checks to Constraint
2026-01-06 05:59:10 +05:30
Ajinkya Dahale
38a0443195
[Sketcher] Use range-for loop where straightforward
2026-01-06 05:59:04 +05:30
Ajinkya Dahale
db5ffb4769
[Sketcher] Refactor SketchObject::addCopy()
...
if and for rearrangement for readability.
2026-01-06 05:42:44 +05:30
Ajinkya Dahale
43a257a1cb
[Sketcher] Refactor SketchObject some more
2026-01-06 05:42:44 +05:30
Ajinkya Dahale
8e46e74ee5
[Sketcher] Refactor based on loops and extraction into functions
...
May contain some untested changes
2026-01-06 05:42:44 +05:30
Ajinkya Dahale
a16be08159
[Sketcher] Refactor some loops for understandability
...
Changes include:
1. Modernize `for` loops with range whenever possible.
2. Flip `if` statements for a "flatter" flow.
3. Use internal functions for repeated identical tasks.
2026-01-06 05:42:44 +05:30
Ajinkya Dahale
ca97889e47
[Sketcher] Refactor SketchObject:validateExternalLinks()
2026-01-06 05:42:44 +05:30
Ajinkya Dahale
404482f48e
[Sketcher] Fix issue in replaceGeometries when more old than new
2026-01-06 05:42:44 +05:30
PaddleStroke
c8106982de
Sketcher: Use DenseQR for small sketches to avoid SparseQR rank issues ( #26559 )
2026-01-04 14:57:13 -06:00
ᴩʜᴏɴᴇᴅʀᴏɪᴅ
670da3d796
SPDX [ 41 ][ Src / Mod / Sketcher ] ( #25135 )
2025-12-25 12:00:22 -06:00
marbocub
176ef6da4e
Sketcher: add reverse mapping correction to Carbon Copy ( #25745 )
...
* Sketcher: add reverse mapping correction to Carbon Copy
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Replace M_PI with std::numbers::pi
* Replace vector initialization with Base::Vector3d::UnitX/UnitY, apply suggestions from code review
Co-authored-by: Kacper Donat <kadet1090@gmail.com >
* Fix guard clause logic, apply suggestions from code review
* Replace std::numbers::pi with pi via `using std::numbers`
* Fix issues reported by the linter
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kacper Donat <kadet1090@gmail.com >
2025-12-22 15:00:49 +01:00
Chris Hennes
16032ae34c
Merge pull request #25914 from AjinkyaDahale/sk-fix-25281
...
Sketcher: Handle angle constraint on sketchobject changes
2025-12-15 10:15:13 -06:00
theo-vt
29eeab3624
Sketcher: Do not autoscale if there are blocked geometries
2025-12-15 09:20:20 -06:00
Ajinkya Dahale
0800791a0f
Sketcher: Only transfer angle to relevant segment on trim etc.
2025-12-12 11:23:00 +05:30
Ajinkya Dahale
78e5729520
Sketcher: Handle angle constraint on sketchobject changes
...
Primarily trim, but also expected to affect split, extend etc.
2025-12-12 09:17:05 +05:30
PaddleStroke
a49d106807
Sketcher: Fix errors message when selecting circle seam point. ( #25953 )
2025-12-05 07:17:30 +00:00
PaddleStroke
6ddb0165ff
Sketcher: fix new external always construction ( #25733 )
2025-12-01 21:49:24 -06:00
marbocub
8ea5075385
Sketcher: Fix error when first constraint is DistanceX/DistanceY to vertex ( #25813 )
2025-12-01 10:50:31 -06:00
Chris Hennes
dfb9baf678
Merge pull request #24262 from mnesarco/pyi-fixes-1
2025-11-29 20:23:37 -06:00
PaddleStroke
74aafcee75
Sketcher: External Face: decide between defining and construction ( #25390 )
2025-11-24 10:47:12 -06:00
theo-vt
15d9e14851
Sketcher: Proceed to chamfer/fillet on a vertex if there are more than 2 lines but only two non-construction lines
2025-11-15 10:08:22 -06:00
theo-vt
d4bfa82161
Sketcher.planegcs: solve reference constraints with lower priority ( #25318 )
2025-11-15 09:54:56 -06:00
pre-commit-ci[bot]
5e0dd60ee5
[pre-commit.ci] auto fixes from pre-commit.com hooks
...
for more information, see https://pre-commit.ci
2025-11-11 19:34:32 +00:00
Frank Martinez
3561d25c2d
[License] Fix pyi license headers.
2025-11-11 13:26:18 -05:00
Frank Martinez
93e4858b01
[bindings] remove redundant signatures. batch2
2025-11-11 13:23:10 -05:00
Frank Martinez
1cf57d6e11
[bindings] Format with yapf (precommit will reformat)
2025-11-11 13:23:10 -05:00
Frank Martinez
2ada443c18
Clean unused imports in .pyi files
2025-11-11 13:23:10 -05:00
Frank Martinez
39d15c011e
black formatting
2025-11-11 13:23:10 -05:00
Frank Martinez
0eae00b9a1
[bindings] Code formatting
2025-11-11 13:23:09 -05:00
Frank Martinez
748004b4e4
[bindings] fix signatures in pyi files
2025-11-11 13:16:26 -05:00
pre-commit-ci[bot]
25c3ba7338
All: Reformat according to new standard
2025-11-11 13:49:01 +01:00
Ajinkya Dahale
857190a20a
Sketcher: Only transfer equality in specific cases in trim
...
The transfer on should apply to (arcs of) conics.
Fixes #25008 .
2025-11-05 12:48:05 -06:00
PaddleStroke
7023e83843
Sketcher: Add support for tangent singularity when concentric circles ( #24227 )
2025-10-20 09:28:37 -05:00
PaddleStroke
8275916601
Sketcher: Fix deactivated Block bug ( #24548 )
...
* Sketcher: Fix deactivated Block bug
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update Sketch.cpp
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-14 11:58:22 +02:00
matthiasdanner
62c222c211
Sketcher: Fix Angle Constraint jumping to opposite side on movement ( #24150 )
...
* Sketcher: Fix Angle Constraint jumping to opposite side on movement
* implement way to dynamically disable snapping where not needed
---------
Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com >
2025-10-13 18:07:09 +02:00
Florian Foinant-Willig
f4fe303829
Sketcher: rename DeriVector2::crossProdNorm to DeriVector2::crossProdZ
2025-10-13 17:57:51 +02:00
PaddleStroke
331e51cdfc
Sketcher: Fix toggle construction not undoable ( #24539 )
...
* Sketcher: Fix toggle construction not undoable
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-09 12:31:50 -05:00
PaddleStroke
365af33fc6
Sketcher: Symmetric arc when center is on symmetry line. ( #24228 )
...
* Sketcher: Symmetric arc when center is on symmetry line.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-06 11:02:42 -05:00