Commit Graph

68 Commits

Author SHA1 Message Date
wmayer
c1a7edc221 PD: Fix possible crashes in dress-up task panels 2024-07-18 15:13:29 +02:00
wmayer
351397e088 PD: Replace helper functions in subclasses of TaskDlgFeatureParameters with a template function 2024-07-18 00:02:07 +02:00
xtemp09
3ab53aba3d Fix crash described in 14370 (issue comment)
The crash occurs because
PartDesignGui::TaskDressUpParameters::setSelection was invoked with
nullptr.
2024-06-17 11:27:07 -05:00
wmayer
9456df5a4b Fix compiler warnings 2024-06-04 20:23:19 +02:00
bgbsww
96aa878b7e Toponaming: reformat code 2024-06-03 19:29:01 -04:00
Zheng, Lei
6474a44c87 Toponaming: update TaskDressUp addAllEdges 2024-06-03 11:22:55 -04:00
wmayer
ca1cb21498 PD: modernize C++: use equals default 2023-08-22 13:31:17 +02:00
wmayer
9a1f8a11d6 PD: modernize C++: use range-based for loop 2023-08-16 21:54:56 -05:00
wmayer
899932cec0 Part/PD: modernize C++: redundant void arg 2023-08-05 16:50:31 +02:00
wmayer
fa8bdfd550 PD: harmonize API of view provider classes
* add virtual method featureName() to ViewProviderTransformed
* add featureIcon() to ViewProviderTransformed and ViewProviderDressUp
2023-04-24 12:25:04 +02:00
wmayer
396a7060ef PD: don't use a static variable as otherwise it won't be translated after changing the language 2023-04-21 12:08:20 +02:00
wmayer
c93b5e27c9 PD: fix crash on Windows when loading PD workbench 2023-04-14 16:34:00 +02:00
Paddle
18a9c164d6 PartDesign: Fillet/chamger/draft/thickness: change the button strings to 'Preview' and 'Select' 2023-03-28 12:52:42 +02:00
Paddle
47cc265b4f PartDesign: Fillet, Chamfer, Draft, Thickness : Enable tool to start with no selection. 2023-03-28 12:52:42 +02:00
Paddle
8ada7af302 PartDesign: Fillet/chamfer/draft/thickness: Merge Add & Remove buttons. 2023-03-28 12:52:42 +02:00
wmayer
9a5d9880d5 PD: replace slots with member function pointers 2023-02-03 00:21:38 +01:00
luz paz
c726b69d7e PD: remove trailing whitespace 2022-11-10 10:32:04 +01:00
luz paz
1a7ddfdc24 Fix typos and whitespace
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,siz,strack,substraction,te,technic,thist,thru,tread,uint,unter,uptodate,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-08-23 18:49:47 +02:00
wmayer
88accdb421 PD: [skip ci] Fix several clazy issues:
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
2022-07-25 13:40:19 +02:00
Kuzemko Aleksandr
c3bbb9a135 [PartDesign] Fix and expose ViewProvider strings to translation
Closes https://github.com/FreeCAD/FreeCAD-translations/issues/24
2022-05-08 14:52:39 -05:00
wmayer
3608ee7f51 PD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Uwe
278abf5675 [PD] remove more unused includes 2022-02-22 01:19:32 +01:00
Mark Ganson TheMarkster
aa76cbc875 [PartDesign Fillet/Chamfer] add UseAllEdges boolean property (#5340)
- [PartDesign Fillet/Chamfer] add UseAllEdges boolean property
- add UseAllEdges checkbox to fillet and chamfer dialogs
- put UseAllEdges property into Chamfer and Fillet groups, create Fillet group for fillets and put Radius into it, too.
2022-02-05 01:50:51 +01:00
wmayer
2d1c083d9a PD: fix crash in thickness dialog when clicking 'Add Face' button 2022-01-16 18:59:26 +01:00
wmayer
c855a3072e PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code 2021-12-31 17:03:16 +01:00
wmayer
e1b03bc0eb [skip ci] fix some typos 2021-12-31 14:03:51 +01:00
mwganson
a930d4ebac [PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode 2021-12-31 14:01:43 +01:00
wmayer
3ee1d91b88 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
donovaly
e0d07257b7 [PD] fix dressup feature display when broken
As discussed in https://forum.freecadweb.org/viewtopic.php?p=479647#p479377
the user can end up without either seeing nothing or an inexisting dressup feature.

This PR fixes this.
2021-02-19 14:51:52 +01:00
wmayer
4a494fec69 Coverity: Dereference null return value 2020-07-20 17:34:26 +02:00
wmayer
8c0dc92426 PartDesign: fix issues of PR #3108
* in the undo/redo list use an object's label and not the internal name
* check by the transaction ID instead of name to open a transaction to make the workbenches independent of implementation details of the core system
* when rejecting a task do not call undo() because this is not the same as aborting a pending transaction
* this also fixes the warning: <App> Document.cpp(1182): Cannot commit transaction while transacting
2020-03-14 14:51:45 +01:00
Zheng, Lei
096f64cca6 PartDesign: fix task dressup/transformed creation cancel 2020-03-14 14:51:45 +01:00
luz.paz
180805c55e Fix typos
Found via  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-06 14:50:35 +01:00
wmayer
389b26c48e PartDesign/Fem: [skip ci] when handling Del key make sure that deleteAction is instantiated 2020-02-19 11:31:40 +01:00
wmayer
19148d3051 PartDesign: [skip ci] add missing header 2020-02-18 23:23:49 +01:00
donovaly
cc3b21fa0b improve code as suggested by Werner
see https://forum.freecadweb.org/viewtopic.php?p=369921#p369921
2020-02-18 23:16:48 +01:00
donovaly
01e8e7f777 try to squash GCC compile error 2020-02-18 00:08:58 +01:00
donovaly
0a7d82b0bb enable selection in the dialog item list
now the user can use the Ctrl and/or Shift key to select multiple items to be deleted
2020-02-17 22:36:42 +01:00
donovaly
702b37aa06 improve fillet dialog logic
- now also the case of only one item in the list is handled properly (single-click will highlight it, double-click will show the final fillet)
2020-02-17 21:53:45 +01:00
wmayer
177afc7b91 PartDesign: [skip ci] fix possible segmentation fault in destructors of dressup task panels 2020-02-16 20:58:44 +01:00
wmayer
17bad8504d PartDesign: [skip ci] do forward declaration if possible to reduce build timw 2020-02-16 19:26:48 +01:00
donovaly
a2eecf3059 TaskDressUpParameters: GCC compile fix 2020-02-16 05:47:54 +01:00
donovaly
d40eb2dbfc [PD] add feature to highlight references in some dialogs
- also fix some logic issues and avoid to break the feature (deleting the last item is now no longer possible)
2020-02-16 05:18:29 +01:00
donovaly
a10a0d9e0f fix logic
now also the case that one switches from add mode directly to remove mode is correctly handled
also remove doubled code that is already executed
2020-02-15 04:30:26 +01:00
donovaly
3877e18e06 [PD] enable to de/selecet several entities at once
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383
2020-02-15 04:07:09 +01:00
luz.paz
d38f18af23 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
Zheng, Lei
11a93a0578 PartDesign changes
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
2019-08-17 15:15:47 +02:00
wmayer
664cf65d26 fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
wmayer
f44df3cdf0 do not use doCommand without using format string, add overloaded method of runCommand 2016-09-15 18:53:37 +02:00