Commit Graph

1731 Commits

Author SHA1 Message Date
Russell Johnson
c357cb77a1 Path: Remove null comments and improve debugging
Added method to create a FreeCAD object when in debug mode.
2020-11-13 16:07:18 -06:00
sliptonic
9c49dc595f Merge pull request #3989 from Russ4262/Surface_fixes
Path: 3D Surface fix to apply `CutMode` when `CutPattern = Offset`; and LGTM cleanup
2020-11-13 14:25:19 -06:00
Dave Seff
139fac133f Make the tool setup images a bit nicer. 2020-11-12 16:59:22 +10:00
Daniel Wood
0392ca9b79 [Path] rename TurnPart to TurnPartoff 2020-11-11 08:44:09 +00:00
Daniel Wood
8713916658 [Path] Add Turning Roughing Selection 2020-11-09 21:14:19 +00:00
Russell Johnson
70473ab422 Path: Fix missing variable declaration for rotational scan
Missing default logical choice within `if...:` block.
Reported in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=44473&start=60#p412303
2020-11-08 22:56:49 -06:00
Russell Johnson
b94cbb617e Path: Fix unsorted arc order for circular cut pattern in some cases 2020-11-08 22:56:49 -06:00
Russell Johnson
220bf0e396 Path: Fix cut direction when CutPatternReversed is true for Circular 2020-11-08 22:56:49 -06:00
Russell Johnson
4c558f1a30 Path: Restructure code to fix closedGap LGTM issue 2020-11-08 22:56:49 -06:00
Russell Johnson
dea85bc999 Path: Some LGTM cleanup 2020-11-08 22:56:49 -06:00
Russell Johnson
604cfaf779 Path: Apply missing CutMode setting when CutPattern = Offset
The `CutMode` toggle had no effect. This fix applies the `CutMode` toggle when the `CutPattern = Offset`.  The indicated `CutMode` may not be accurate depending on the situation, but the toggle will change the cut direction as intended.
2020-11-08 22:56:49 -06:00
Daniel Wood
5807c38416 [Path] Fix Typo - Stock object requires uppercase 'S' 2020-11-06 20:01:56 +01:00
luz paz
b75cd3dd52 Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
GaryH
75b8ff3665 Modify code format to PEP8
Add --marlin-config argument
  Marlin requires certain configuration settings in order to work well
  with FreeCAD. Those configuration settings will be added to the
  end of the gcode file as comments, when --marlin-config is entered
  as a post processor argument.
  For PEP8 conformity:
      Change some double-quotes to single-quotes.
      Change sequence of import statements.

Modify code format to PEP8
  Indentation and line length meet PEP8 requirements.
  Other aspects of PEP8 are partially implemented.

Add code to remove embedded comments
  Also, minor tweaks throughout

Change outstring to outList for clarity
  Change format_outstring to format_outList
  Change: if PathUtil.opProperty(obj, 'Active') is False:
    To: if PathUtil.opProperty(obj, 'Active') == False:

Format file to PEP8 standard
  Format first pass using:
    autopep8 --in-place --aggressive --aggressive
  Manually adjust format for better appearance
  Recheck format using http://pep8online.com/
  Change code related to pythonopen into with open() code
  Minor refactoring
2020-11-04 19:55:02 +01:00
GaryH
d632130831 Refactor marlin_post.py
Change G4 P to G4 S for Marlin
  Marlin uses P for milliseconds, S for seconds.
  FreeCAD uses P for seconds, so change P to S.

Remove code for G20 inch mode and G91 relative mode
  Due to the fundamentals of the FreeCAD pre-processor,
  this post processor can only operate in the following modes:
  G90 Absolute positions
  G21 Metric units (mm)
  G17 XY plane (3 axis vertical milling only)

Expand RETURN_TO option to float values for XYZ
  The RETURN_TO option previously only accepted integer values, and
  only for X and Y.
  This change allows float values for XY and optionally Z.

Add class: "Drill" within drill_translate()
  The nested functions within drill_translate() need to modify the
  variable that was named trBuff. To allow this, trBuff was changed
  to class: "Drill" with property "gcode".
  Within drill_translate(), including within the nested functions,
  modifying "trBuff" is now replaced with modifying "Drill.gcode".

Merge in updated portions of grbl_post.py
  Prior verson was derived from an older grbl_post.py.
  Merge in the portions of the newer grbl that seem improved.
  Refactor overall after the merge.

Add options for partial comments
  Add option:  --no-finish-comments
  Add option:  --no-path-comments
2020-11-04 19:55:02 +01:00
GaryH
0e0156a2c2 Add files via upload 2020-11-04 19:55:02 +01:00
Daniel Wood
9c296217e5 [Path] Tidy imports 2020-10-29 21:35:24 +00:00
Daniel Wood
c1302fb4fa [Path] PEP8 whitespace fixes 2020-10-29 21:29:25 +00:00
Daniel Wood
4f6c7797ab [Path] set the default max diameter 2020-10-29 21:27:32 +00:00
Daniel Wood
65e3476e20 [Path] PEP8 Formatting fixes 2020-10-29 19:55:45 +00:00
Daniel Wood
5c4ad1a7de [Path] Add TurnPart selection 2020-10-29 19:55:05 +00:00
Daniel Wood
e64cb66a32 Reorder imports to match PEP8 guidance 2020-10-28 17:10:51 +00:00
Daniel Wood
7618dba49d silence lgtm warnings 2020-10-28 17:09:49 +00:00
Daniel Wood
7a55d5120d PEP8 whitespace fixes 2020-10-28 06:50:04 +00:00
Daniel Wood
811fa90efe [Path] Enable Face selection for axis selection (JobSetUp) 2020-10-27 21:28:30 +00:00
sliptonic
7f83281551 Merge pull request #3991 from Russ4262/patch-1
Path: Fixes ticket #4471
2020-10-26 20:29:23 -05:00
sliptonic
3c307b7a3c Merge pull request #3969 from sliptonic/bug/bugfixes
[PATH]  Minor bugfixes
2020-10-26 08:12:20 -05:00
Markus Lampert
09e6552fbb Fixed 'o' and depth issue 2020-10-25 16:33:13 -07:00
Markus Lampert
4c16bef132 Allow voronoi edges to be traversed in any direction and use that to sort the sequence of milling the wires. 2020-10-25 16:33:13 -07:00
Markus Lampert
fb2a747aee Added sorting over all wires, not just the ones of a single face 2020-10-25 16:33:13 -07:00
Markus Lampert
2046db0990 Added sorting of voronoi wires to minimize rapid moves 2020-10-25 16:33:13 -07:00
Markus Lampert
ebe5bb0e71 New vcarve wire detection algorithm using the new z-values of toShape 2020-10-25 16:33:13 -07:00
luz paz
9f74b422a9 Fix various typos [skip-ci] 2020-10-24 12:25:46 +02:00
Russell Johnson
88f0ea629d Path: Fixes ticket #4471 2020-10-22 10:55:51 -05:00
J-Dunn
950269834d Add files via upload
Path: grbl_post G83 expansion , G1 on initial move to retract_Z height to allow retraction height to remain inside hole. This can be useful to avoid widening hole entrance with multiple drill re-entries.moves
2020-10-18 21:07:21 +01:00
sliptonic
3764b404f1 Merge pull request #3966 from sliptonic/feature/RtoIJarcs
[PATH] Add RtoIJ function to PathUtils.  fixes #2606
2020-10-18 14:28:12 -05:00
sliptonic
b00acc78be Merge pull request #3962 from sliptonic/feature/boundaryenforcecontrol
PATH: add boundary enforcement to the task panel
2020-10-18 14:26:17 -05:00
sliptonic
02157cdbff fix deburr direction. 2020-10-16 14:14:08 -05:00
sliptonic
4ce860cbf9 Allow the probe data file to have blank lines. 2020-10-16 14:13:08 -05:00
sliptonic
6db7bf6046 Fix File Dialog 2020-10-16 14:13:08 -05:00
sliptonic
c8712b83f8 more pythonic params (thanks plaes) 2020-10-16 13:49:47 -05:00
sliptonic
015910448a add RtoIJ function to PathUtils. fixes #2606
function is unused at this time.  It should be used by preprocessor scripts like gcode_pre to
convert radius mode arcs to IJ mode.
2020-10-16 11:02:29 -05:00
sliptonic
053b8e9e32 add boundary enforcement to the task panel 2020-10-14 22:19:06 -05:00
sliptonic
46f050eece handle missing target directory
better output messages
2020-10-14 15:21:27 -05:00
sliptonic
68ad4f2f1d Merge pull request #3941 from sliptonic/bug/deburr
[Path] Deburr bug fixes
2020-10-12 16:04:55 -05:00
sliptonic
63a244f01e Merge pull request #3938 from sliptonic/feature/dragknifepanel
[PATH]  Task panel for dragknife and axismap dressups.  fixes #2840
2020-10-12 12:50:44 -05:00
sliptonic
ffd7693815 Fix deburr CW/CCW calculation 2020-10-12 12:39:14 -05:00
Daniel Wood
61dc5dea04 Add a task panel page for controlling turning diameters 2020-10-11 07:57:59 +01:00
Daniel Wood
66afbc36a8 Add turning selection gate 2020-10-11 07:57:59 +01:00
sliptonic
ed61873b2c make deburr ignore non-vertical faces
fixes #4327
2020-10-09 12:50:06 -05:00