Commit Graph

21562 Commits

Author SHA1 Message Date
wmayer
c5dfa7fa01 Sketcher: fix warnings:
* fix -Winconsistent-missing-override
* fix -Woverloaded-virtual that is also a bug because the DrawSketchHandlerArcOfParabola didn't set the suitable mouse cursor
2022-02-17 21:14:37 +01:00
Abdullah Tahiri
d8c052c666 DrawSketchHandler: activation and deactivation via NVI pattern
==============================================================

With the introduction of overridable default behaviour for commands, it makes sense to keep control of the execution path of the activation and deactivation.

Non-virtual interface pattern enforces execution control of the virtual functions, while allowing the behaviour to be overriden in a case by case basis.
2022-02-17 19:37:48 +01:00
sliptonic
74371fd1f1 Merge pull request #5343 from Russ4262/fix/open_edge_zero_start
[Path] Fix open edge zero value start point
2022-02-17 12:36:38 -06:00
wmayer
54cf7713f4 PD: make sure that Attachment editor shows up the context-menu of datum objects 2022-02-17 19:28:01 +01:00
wmayer
c3511ba2f0 Sketch: make sure that Attachment editor shows up in the context-menu 2022-02-17 19:27:11 +01:00
wmayer
59ffad387c Part: in ViewProviderAttachExtension check if feature has the AttachExtension 2022-02-17 19:26:11 +01:00
Chris Hennes
cfabcbe9d5 TD: Fix MSVC compilation failure
Also shifts to snprintf to eliminate overrun risk.
2022-02-17 11:33:52 -06:00
sliptonic
c4d5b68a5b Merge pull request #6387 from SamuelMayer/kinetic_nc_pp
Path: Added KineticNC Postprocessor 2nd try
2022-02-17 10:01:32 -06:00
0penBrain
3b1d8fd918 [Sketcher] Fix typo 2022-02-17 16:17:04 +01:00
0penBrain
a360829e9b [Sketcher] Disable constraint selectability on Shift press 2022-02-17 16:17:04 +01:00
0penBrain
34106f49e7 [Sketcher] Disable constraints selection when geometry/constraint handler is active 2022-02-17 16:17:04 +01:00
edi271
3ffae251bf Update CommandExtensionDims.cpp 2022-02-17 10:05:56 -05:00
edi271
adc8574d52 Update CommandExtensionDims.cpp 2022-02-17 10:05:56 -05:00
edi271
2c1c322d68 Update TaskCustomizeFormat.ui 2022-02-17 10:05:56 -05:00
edi271
65cad2e54b New extension tool: cutomize format 2022-02-17 10:05:56 -05:00
edi271
0cba14638a Icons and Ui-files 2022-02-17 10:05:56 -05:00
edi271
6f731a7d23 Force tree update 2022-02-17 10:05:56 -05:00
Yorik van Havre
18ab2c80fb Merge pull request #6355 from Roy-043/Draft-Housekeeping-call-'make'-functions-with-new-name-(3)
Draft: Housekeeping: call 'make' functions with new name (3)
2022-02-17 11:40:59 +01:00
Yorik van Havre
a2bd8da848 Merge pull request #6384 from 0penBrain/tuxMouseModel
Tux: get rid of timer usage to update navigation style
2022-02-17 11:35:30 +01:00
SamuelMayer
020998cf41 added KineticNC_post.py 2022-02-17 11:22:30 +01:00
wmayer
b6ebeef6f3 Part: fix regression by commit 289a9bcc8
* Standard_Version.hxx is required for the OCC version check macro
* group sorted header includes by library
2022-02-17 11:09:35 +01:00
Uwe
289a9bcc87 [Part] ViewProviderExt: remove unused includes
- also sort them
2022-02-17 05:00:17 +01:00
Uwe
414ac4cb7d [PD] ViewProvider: remove unused includes 2022-02-17 04:43:16 +01:00
Uwe
aa02ab5c66 [Part] add context menu icon for color face
- the other context menu entries have icons and we use this icon already in the View menu

- also sort the includes
2022-02-17 03:20:31 +01:00
0penBrain
7ae60bdb92 Tux: get rid of timer usage to update navigation style 2022-02-16 15:48:04 +01:00
sliptonic
a46592d45a Merge pull request #5488 from dirkolbrich/path-cmakelists-link-fix
[Path] remove duplicate link of PathCommands.py
2022-02-16 08:38:32 -06:00
sliptonic
013dd8be55 Merge pull request #6378 from mlampert/bugfix/abort-op-creation-without-tc
Gracefully handle op creation abort when no TC is available or selected.
2022-02-16 08:35:18 -06:00
sliptonic
54fb832dae Merge pull request #6357 from sliptonic/master
[Path] Warn user if current schema doesn't generate proper velocity (unit/min)
2022-02-16 08:34:26 -06:00
sliptonic
55208aae47 Merge pull request #6377 from sliptonic/bug/drillheight
[Path]  Drilling gcode bug.  Fixes #6367
2022-02-16 08:33:52 -06:00
wmayer
95f583a677 Part: fix typos in make* functions 2022-02-16 12:48:02 +01:00
Uwe
7786e24fcd [PD] change default FaceMaker to Bullseye
Part does already use this FaceMaker since it can also handle islands.

The PR therefore
- uniforms the behavior of PD and Part
- fixes #6366
- enables to use nested sketches for the various PD features like Revolve
2022-02-16 11:20:02 +01:00
Chris Hennes
ce6d9e7573 Addon Manager: Better failure diagnostics 2022-02-15 22:55:59 -06:00
Uwe
df3569b799 [Part] Bullseye whitespace fixes 2022-02-16 03:40:07 +01:00
markus
09c10dada0 Gracefully handle op creation abort when no TC is available or selected. 2022-02-15 13:44:13 -08:00
wmayer
6e012520d9 Sketcher: for Linux systems put definition of GeoElementId members back to header file to fix possible linker errors 2022-02-15 22:01:51 +01:00
sliptonic
f637a6a9c8 add option to preferences to suppress velocity warning 2022-02-15 14:30:34 -06:00
wmayer
a5e561b31d Base: fix Matrix4D::hasScale
* If all column vectors of the 3x3 sub-matrix are equal the function incorrectly claims that it's uniform scaling.
* Detect also non-uniform scaling and if was applied from the left or right side
* Replace the int with an enum and expose it to Python
* Add several new unit tests
2022-02-15 21:05:11 +01:00
Chris Hennes
48e2ee100c Addon Manager: Fix race condition 2022-02-15 13:04:49 -06:00
sliptonic
06bea999d4 Fixes #6367
Use correct startpoint.
2022-02-15 09:48:16 -06:00
Roy-043
8a92953f2a TechDraw: Use Draft.get_svg instead of Draft.getSVG
The Draft.getSVG has been renamed. Using it results in warnings in the Report view. The new function Draft.get_svg has the same signature.
2022-02-15 08:58:25 -05:00
0penBrain
30daaa66bc Sketcher: add GeoID on extended naming of geometries 2022-02-15 14:02:07 +01:00
0penBrain
6037553f3c Sketcher: add construction mode display for points in element list 2022-02-15 14:02:07 +01:00
Ajinkya Dahale
8888489aed [Sketcher] Add comment suggesting future segfault fixes
Apparently B-Spline knot insertion is challenging the sketcher update process
and spurious GUI updates sometimes occur in the intermediate step after the
knot is inserted but before the internal geometries are re-defined. This set of
comments points to a previous fix and related discussion as a suggestion.
2022-02-15 13:44:02 +01:00
Ajinkya Dahale
82edb612ad [Sketcher] Check constraint type before drawing icons
Change is in `EditModeConstraintCoinManager::drawConstraintIcon` on the lines of 247a9f0876.
2022-02-15 13:44:02 +01:00
Ajinkya Dahale
4ad0bdc5b2 [Sketcher] Reformat statements in EditModeConstraintCoinManager.cpp 2022-02-15 13:44:02 +01:00
marioalexis
f9c4c88768 Part: Part_SectionCut command active only if view is View3DInventor class 2022-02-15 10:19:15 +01:00
Uwe
ccbc0863a9 [Part] remove unused precompiled headers 2022-02-15 05:57:27 +01:00
Uwe
f0f30b47f6 [Part] try to fix compilation error without precompiled headers 2022-02-15 05:46:40 +01:00
Uwe
ab6ac65455 [Part] more simplification of SectionCut code 2022-02-15 05:06:14 +01:00
Chris Hennes
0ce24d985f Addon Manager: Fix bug in macro git state 2022-02-14 21:56:13 -06:00