Commit Graph

141 Commits

Author SHA1 Message Date
asapelkin
55e758c2f9 used make_shared and make_unique for creating shared pointers 2019-11-21 18:51:43 +01:00
asapelkin
ced8100ab9 use emplace_back instead of push_back where justified 2019-11-21 14:48:09 +01:00
howetuft
5807ee2022 Fix -Wclass-memaccess warning
Replace C-style memset with C++ value-initialization/assignment (smarter and safer: see https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#slcon3-avoid-bounds-errors)
2019-11-18 12:32:27 +01:00
howetuft
3e5d3460c7 Fix -Wdeprecated-copy warnings (rule of 5/3/0)
Fix -Wdeprecated-copy warnings in various places. Consists in enforcing
rule of five/three/zero (https://en.cppreference.com/w/cpp/language/rule_of_three)
mainly by deleting redundant copy constructors or copy assignment operators
that replicate default constructors/operators, or more rarely by adding
missing copy/move constructors/operators.
See also https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c20-if-you-can-avoid-defining-default-operations-do
2019-10-20 17:02:17 +02:00
wmayer
e48c52c480 force strict ISO C++ (-Wpedantic)
for Drawing, Image, Inspection, Mesh, MeshPart, Part, Path, Points, Raytracing, ReverseEngineering, Spreadsheet, Start, Surface, Web

TODO: fix several -Woverflow in area
2019-09-18 11:32:42 +02:00
kreso-t
614c071d3e PathAdaptive: Increased accuracy for small tools 2019-09-07 20:00:35 +02:00
luz.paz
7af7c10cf1 Fix misc. typos, whitespace, and http:// to https:// issues 2019-09-03 11:11:43 -03:00
Zheng, Lei
cfc6c0ee89 Path changes
* Relaxed valid base shape requirement, as long as it can return a
  shape using part.getShape()

* Improve ViewProviderPath performance by sharing the same selection
  observer

* Relocate libarea binary installation
2019-08-17 15:15:48 +02:00
kreso-t
3bb20a9322 PathAdaptive: bugfix
fix for "path to nowhere" that occurs on some enviroments
2019-07-23 23:07:34 +02:00
wmayer
cb53719821 Fix a couple of clang compiler warnings:
-Wunused-variable
-Winconsistent-missing-override
-Wdelete-non-virtual-dtor
-Wunused-private-field
-Wformat
2019-06-23 15:19:12 +02:00
wmayer
3fa43e8b9c fix some compiler warnings 2019-05-26 14:35:09 +02:00
lo
069746975c cmake: manually add dynamic_lookup flag to area-target 2019-05-24 14:37:33 +02:00
lo
1922c84ca0 cmake: add option to disable linking of python extension modules to python-libraries 2019-05-24 14:37:33 +02:00
MA-DEVELOP\apeltauer
7f827874f4 pybind11 mod 2019-04-04 23:37:12 +02:00
luz.paz
ad0ee86589 Misc. source comment typos 2019-03-22 10:44:14 -03:00
wmayer
21c1301df1 PVS: V794 The assignment operator should be protected from the case of 'this == ...' 2019-03-13 12:38:46 +01:00
wmayer
7e482a5002 PVS: V730 Not all members of a class are initialized inside the constructor 2019-03-12 18:33:25 +01:00
wmayer
61eeca41e1 fix -Wmaybe-uninitialized 2019-03-03 15:04:24 +01:00
wmayer
3e12a59d41 fix several Py3 issues 2019-01-03 18:11:37 +01:00
kreso-t
0b6bd3c2ae Path: Adaptive - bugfix
fix for path cleaning, related to uncleared regions
2018-12-11 09:10:08 -03:00
wmayer
4accbb257c Fix scan coverity issues:
CID 184299:  Null pointer dereferences  (FORWARD_NULL)
CID 184297:  Error handling issues  (UNCAUGHT_EXCEPT)
CID 184296:  Uninitialized members  (UNINIT_CTOR)
CID 184292:  Uninitialized members  (UNINIT_CTOR)
2018-11-13 13:20:16 +01:00
Zheng, Lei
b6c0cf8ce5 Path.Area: minor optimization 2018-11-06 12:02:12 -03:00
kreso-t
4032bd302a Path: Adaptive - fix for path cleaning
- fix for side-effect introduced by last change
(completely collinear paths were filtered out)
2018-10-29 23:29:08 +01:00
kreso-t
9d60ced83d Path: Adaptive - finishing path improvements
- fixed bug in path cleaning (artifacts on the finish path)
- increased path discretization resolution
2018-10-29 10:28:54 -03:00
kreso-t
b8c030066b Path: Adaptive - adjustments to path smoothing 2018-10-04 16:23:20 +02:00
kreso-t
90315b3752 Path: Adaptive - Small adjustment to link path cleaning 2018-09-29 18:12:45 +02:00
kreso-t
c4c9ce85e4 Path: Adaptive - small performance improvement
- related to linking path smoothing
2018-09-29 18:12:28 +02:00
kreso-t
51f1cabadb Path: Adaptive - improvements and bug fixes
- more accurate path smoothing
- fix for missing helix lead-in in some cases
- fix for cleaning of helix center point
- increased max allowed step-over to 75%
2018-09-29 18:12:09 +02:00
kreso-t
cdbb902ae8 Fix for crash on windows env. 2018-09-26 17:05:29 +02:00
kreso-t
e6abbef296 Path: Adaptive - small improvement
- tendency to join cuts when possible
2018-09-26 17:05:05 +02:00
kreso-t
f24b838b57 Path: Adaptive - enhancements and bug fixes
- more accurate path cleaning
- fix for uncleared area remaining
- linking paths smoothing
2018-09-23 10:45:45 +02:00
kreso-t
2104222f45 Path: Adaptive - fix for profiling operation
- improved handling for sharp corners for profiling op.
2018-09-19 18:29:18 +02:00
kreso-t
214b45a180 Path: Adaptive - enhancements and bug fixes
- cleanup & spelling corrections
- lead-in/lead-out improvements
- safer transition of linking path into lead-in/cut
- self-intersection check for keep tool down path
- additional perf. optimisations by parameter tuning
2018-09-19 18:28:48 +02:00
kreso-t
b1fb3b02d1 Fix for compiler warnings 2018-09-17 09:57:47 +02:00
kreso-t
a76dfc6254 Path: Adaptive - small enhancement
- improved handling in spiky corners
2018-09-17 09:57:47 +02:00
kreso-t
3e11598247 Path: Adaptive - performance optimization for larger models
- utilizing bounding boxes
- changed the alg. for resolving tool down linking paths,
   resolution is no longer based on clipper offsets as
   offset alg. tends to become slow
- new tool down linking alg. also should be better in finding
   shorter linking paths
- lead-in lead-out improvements
2018-09-17 09:57:46 +02:00
luz.paz
af7180270e Typo and whitespace fixes
Found via `codespell -q 3 -I ../fc-word-whitelist.txt --skip=".git,*.ts,*.po,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/zipios++" -L "entires,fle,actuall"`
2018-09-15 19:13:52 +02:00
wmayer
e71d991e87 fix some MSVC & clang warnings 2018-09-11 11:02:43 +02:00
kreso-t
7e661ef425 Path: Adaptive - fix for convetional mode detection 2018-09-11 11:02:43 +02:00
kreso-t
30dc39938e Path: Adaptive - fix for offset glitches 2018-09-11 11:02:43 +02:00
kreso-t
3246283097 Path: Adaptive - prepping the PR 2018-09-11 11:02:43 +02:00
kreso-t
6bb5a080f6 Path: Adaptive - fixes 2018-09-11 11:02:42 +02:00
kreso-t
02da157bef Path : Adaotive - fix for finishing pass supression outside stock 2018-09-11 11:02:42 +02:00
kreso-t
70837364bd Path: Adaptive - fixes 2018-09-11 11:02:42 +02:00
kreso-t
7b0ba1915e Path: Adaptive - fix 2018-09-11 11:02:42 +02:00
kreso-t
640d3fa39b Path: Adaptive -fix 2018-09-11 11:02:41 +02:00
kreso-t
8edd584b68 Path: Adaptive - keep tool down ratio option + bugfixes 2018-09-11 11:02:41 +02:00
kreso-t
ae861300ed Path: Adaptive - bug fixes 2018-09-11 11:02:41 +02:00
kreso-t
4e8ca5fff0 Path: Adaptive - linking optimization - chaining by distance 2018-09-11 11:02:41 +02:00
kreso-t
93ceff643d Path: Adaptive - fix for VS build 2018-09-11 11:02:40 +02:00