Commit Graph

39 Commits

Author SHA1 Message Date
Chris Hennes
667514e21b PD: Correct typo in pattern parameters 2024-02-28 13:56:16 -06:00
André Althaus
3936f49ee2 Fix linter hints 2024-02-28 17:29:59 +01:00
André Althaus
0c70b0bd1e Refactor the apply function to be virtual public 2024-02-21 15:04:38 +01:00
André Althaus
30f5595e2a Reformat files with clang-format 2024-02-17 17:13:14 +01:00
André Althaus
cf627f5ce4 Fix apply() method not called consistently
The python console commands where not consistenly reported because
the apply function was not called or not implemented.

The function is now called from the base class and also when
a subfeature is closed in MultiTransform.

Some missing properties are also added.
2024-02-17 17:13:14 +01:00
André Althaus
565b83d8fe Refactor: optimize member access specifiers
After refactoring many members have unnecessarily open access specifiers.
This changes as many members as possible to private or protected.
2024-02-17 17:12:59 +01:00
André Althaus
8694874080 Refactor: remove unused functions 2024-02-17 17:12:59 +01:00
André Althaus
f82663cfb0 Refactor: add default member initializers 2024-02-17 17:12:59 +01:00
André Althaus
0b3eb1ae08 Move duplicated code to the base class
All pattern sublcasses contain the same code for handling the
feature list. This code is now moved into the base class that handles
the common ui.

The subclasses now only need to call the setupUI/setupParameterUI function
in their constructors and implement the setupParameterUI function
to create their parameter ui into the specified widget.

The MultiTransform also handles it's common ui and the subclasses
can reuse setupParameterUI without code duplication.
2024-02-17 17:12:32 +01:00
Kacper Donat
148c497eba PD: Add offset / overall angle modes for PolarPatterns
This commit adds two separate modes for defining angular spacing between
elements in the PD's Polar Pattern:

1. Overall Angle - which behaves exactly like it behaved before,
2. Offset Angle - which allows user to specify separation angle between
   consecutive elements.

This change is analogue to that introduced for LinearPattern in previous
commits.
2023-08-27 12:45:53 +02:00
wmayer
622e46771e PD: modernize C++: use equals default 2023-08-22 13:31:17 +02:00
wmayer
a122aa01a7 PD: move to new style connect() 2023-01-15 14:27:33 +01:00
berniev
180edfa3cc Mod: Single arg ctors must be explicit 2022-08-24 16:55:20 +02:00
berniev
71dc5ead2f Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
4cd69ee774 [PD] Task dialogs: remove unused headers 2022-03-23 19:43:47 +01:00
wmayer
d1d4b996e7 PD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Uwe
ee48c0b8d5 [PD] Gui: remove unused includes
- also some sorting
2022-03-02 02:51:01 +01:00
wmayer
dd31be3b19 PD: improve task panel for polar patterns:
* set range of Occurrences property to spin box
* connect signals after initializing widgets to avoid superfluous recomputes and possible inconsistencies
2021-03-03 10:32:46 +01:00
donovaly
b483fc0518 [PD] make pointers to the UI std::unique_ptr
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
2021-02-05 18:01:57 +01:00
wmayer
87e7a3762b PartDesign: [skip ci] move indexesMoved() to base class TaskTransformedParameters to avoid code duplication 2020-07-31 13:16:44 +02:00
donovaly
ccd0f58e60 [PD] allow to change feature order in patterns
As discussed here: https://forum.freecadweb.org/viewtopic.php?f=27&t=48998#p420352
The pattern dialogs need a feature to change the order of the features to be patterned
2020-07-31 11:47:31 +02:00
donovaly
ba5fbc5778 [PD] spread the fix from commit 319f38cafc to 3 other affected dialogs 2020-02-15 17:00:26 +01:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
wmayer
dd7c91ddcf fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
Stefan Tröger
6b7b2176fb Fix transform feature crash on apply
-Redundant "reset edit" and command commit removed
-Redundant apply call removed
2016-04-12 18:12:22 +02:00
DeepSOIC
3d93c906d1 PartDesign: rework axis and plane comboboxes and make it work without part.
Rework combobox filling and link hadling for revolution and transformed features, in order to get rid of hard-coded item indexes and make the lists more dynamic.
2016-04-12 18:12:14 +02:00
jriegel
2c617fca47 Fixes some merge Bugs 2016-04-12 18:12:01 +02:00
jrheinlaender
011dbf53da Enable multiple originals for the transformed features 2016-04-12 18:11:56 +02:00
jrheinlaender
4524103dbc Allow datum lines and planes for Transformed features' references 2016-04-12 18:11:50 +02:00
Eivind Kvedalen
56c95964b8 PartDesign: Replaced QuantitySpinBox by SpinBox for "occurrences" input field. 2015-09-30 15:54:19 +02:00
Eivind Kvedalen
8e112bd2db PartDesign: Added support for expressions. 2015-09-21 14:51:09 +02:00
wmayer
f03cd23df7 0001110: Decimal point entry in LinearPattern length field 2013-07-12 17:15:05 +02:00
logari81
3562efa5d5 PartDesign: Refactor pattern features and gui
- remove StdDirection,StdAxis and StdMirrorPlane properties
- support sketch H_Axis, V_Axis, N_axis as valid references in patterns
- polish reference selection gui (unified for standard axes and custom references)
2013-01-09 23:18:38 +01:00
logari81
4091b661b4 PartDesign: use selection filter gate for picking references for pattern/transform features 2012-09-15 08:14:36 +02:00
logari81
d9808b4b97 PartDesign: fix bug in checkbox "Update View" of pattern features and do some code refactoring 2012-09-13 15:46:46 +02:00
logari81
cba163a803 PartDesign: restrict patterns to only one original and improve selection of references 2012-09-11 16:54:45 +02:00
logari81
afc6327b56 PartDesign: fix small issue with embedded TaskPanels in MultiTransform 2012-09-10 11:37:48 +02:00
jrheinlaender
023c7fa0b1 PartDesign: implement Transform and Pattern features 2012-09-07 11:55:26 +02:00