Commit Graph

40774 Commits

Author SHA1 Message Date
Roy-043
9eca869c95 Draft: fix Trimex visibility change
Fixes #19966
2025-03-04 10:13:44 +01:00
Roy-043
29c03a43a3 Draft: fix make_sketch hang
Fixes #19978

The onebyone argument of makeMissingPointOnPointCoincident and makeMissingVerticalHorizontal should be set to False.
2025-03-04 10:12:44 +01:00
Andrew Shkolik
1155182ac3 Sketcher: Preference pattern and width added for External defining geometry 2025-03-03 23:51:26 -06:00
Chris Hennes
01092f66b1 TD: Add missing Boost headers to PCH 2025-03-03 23:18:47 -06:00
Chris Hennes
b090e27dcf App: Switch to isNullOrEmpty() 2025-03-03 19:24:15 -06:00
Chris Hennes
66e1710956 App: Minor formatting from review
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-03-03 19:21:05 -06:00
bofdahof
091f73f09f Calling static via instance 2025-03-03 19:21:04 -06:00
bofdahof
035d789ffa Narrowing conversion 2025-03-03 19:21:04 -06:00
bofdahof
3ddf2fe67b Don't use endl 2025-03-03 19:21:04 -06:00
bofdahof
4811be9881 Reserve vector size 2025-03-03 19:21:04 -06:00
bofdahof
8ff4b1b018 Redundant c_str() 2025-03-03 19:21:04 -06:00
bofdahof
31825c28aa Else after return 2025-03-03 19:21:04 -06:00
bofdahof
4bfe65b48c Declaration hides previous 2025-03-03 19:21:04 -06:00
bofdahof
ee849b6349 C++ style cast instead of C 2025-03-03 19:21:04 -06:00
bofdahof
78696bdaee Join declaration and assignment 2025-03-03 19:21:04 -06:00
bofdahof
2ab03306ca Use auto 2025-03-03 19:21:04 -06:00
bofdahof
c3eee2dc99 Simplify expression 2025-03-03 19:21:04 -06:00
bofdahof
819faf71ed DRY 2025-03-03 19:20:59 -06:00
Maxim Moskalets
b59cd79427 Add support of compile/link jobs pooling 2025-03-03 18:51:27 -06:00
clsergent
545553557a Update UtilsParse.py
Fixed an error where strings were added to a list (gcode) using the addition assignment operator ('+=') rather than the 'list.append' method, resulting in adding every character as a list member
2025-03-03 22:49:42 +01:00
Joao Matos
77203eaa06 App: Capitalize exception message in Document.cpp. 2025-03-03 21:22:22 +00:00
Joao Matos
0ba8e3f769 App: Reorder includes in App/private/DocumentP.h. 2025-03-03 21:22:22 +00:00
Joao Matos
f9a6044828 PartDesign: Refactor ViewProviderTransformed::recomputeFeature. 2025-03-03 21:22:22 +00:00
Joao Matos
8710bbd825 Part/PartDesign/TechDraw: Simplify calls to DocumentObject::recomputeFeature. 2025-03-03 21:22:22 +00:00
Joao Matos
ea8ff59c27 App: Refactor with early exit in Document::recomputeFeature. 2025-03-03 21:22:22 +00:00
Joao Matos
9f6810adc8 Gui: Remove unused Command::updateAll. 2025-03-03 21:22:22 +00:00
Joao Matos
97bd38f6f9 PartDesign: Refactor Command::finishFeature. 2025-03-03 21:22:22 +00:00
Joao Matos
527e7eae22 Gui: Refactor StdCmdRefresh::activated. 2025-03-03 21:22:22 +00:00
Joao Matos
855ad6c709 CMake: Add GCC/Clang -fdiagnostics=color compiler option. 2025-03-03 18:13:39 +01:00
wandererfan
d7e98b61cc [TD]change scaling default for Draft & BIM views 2025-03-03 10:44:03 -06:00
paul
1f695e36f8 [ArchWindow] Improve SubVolume() HoleDepth deduction algorithm (#19774)
* [ArchWindow] Improve SubVolume() HoleDepth deduction algorithm

https://github.com/FreeCAD/FreeCAD/issues/19559
https://forum.freecad.org/viewtopic.php?t=92360
https://forum.freecad.org/viewtopic.php?p=812844#p812844

Current HoldeDepth deduction algorithm is too 'agressive' and may punch holes in adjacent wall segment.

With improved algorithm, ArchComponent pass the Window's host information to ArchWindow getSubVolume() to deduce HoleDepth taking into account of Wall's Width /getWidths for Wall Base is ArchSkech

TODO: For future development - More robust approach
With ArchSketch, on which wall segment an ArchObject is attached to is declared by user and saved.
The extrusion of each wall segment could be done per segment, and punch hole in the exact wall segment before fusing them all. No need to care about each wall segement thickness.

* [ArchWindow] Typo Lint reported

* [ArchWindow] Fix getSubFace(self) raise NotImplementedError

Github comment - https://github.com/FreeCAD/FreeCAD/pull/19774#discussion_r1972052310
2025-03-03 17:38:22 +01:00
Chris Hennes
72d8a7be71 Merge pull request #19411 from benj5378/enums2
TechDraw: hard type enums, part 2
2025-03-03 10:37:21 -06:00
Chris Hennes
215e966c3e Merge pull request #19753 from benj5378/tag
TechDraw: centralize tag functionality
2025-03-03 10:36:24 -06:00
Aurélien Pascal
e97aa7d47e TechDraw: Fix hatch drawing (#19458)
* TechDraw: Fix hatch drawing (#16353)

* TechDraw: Fix hatch drawing in Tech View
2025-03-03 10:35:13 -06:00
WandererFan
b4b93763ae Broken view no compress19647 (#19688)
* [TD]fix broken view does not collapse

* [TD]delint and clean up code

* Update src/Mod/TechDraw/App/DrawBrokenView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.h

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.h

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* Update src/Mod/TechDraw/App/DrawBrokenView.cpp

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>

* [TD]fix merge errors

---------

Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2025-03-03 10:34:23 -06:00
Chris Hennes
b08a259b50 Merge pull request #19930 from marioalexis84/fem-current_density
Fem: Improve current density boundary condition
2025-03-03 10:32:35 -06:00
xtemp09
4cb8384145 [Spreadsheet] Fix unset zoom level 2025-03-03 10:27:39 -06:00
tritao
7d28636e05 Remove Python-generated bindings comparison against XML-generated version. 2025-03-03 10:22:41 -06:00
PaddleStroke
50394a6ef3 Update PreCompiled.h 2025-03-03 10:21:37 -06:00
Roy-043
4d48c0de55 Draft: fix Draft_Trimex boundary subelement selection
Fixes #19614

Instead of using the whole object, the hovered subelement should be used for the boundary.

With this PR the handling of the boundary is also  'nesting-aware'. This is however still not the case for the object being extended/trimmed. That object has to be in the global space.
2025-03-03 17:18:25 +01:00
Roy-043
8a0d6a23bb Draft: fix Draft_Edit isAttachedToDocument issue
Fixes #19939

The `isAttachedToDocument` method only works in certain circumstances.
https://forum.freecad.org/viewtopic.php?t=94709
2025-03-03 17:17:55 +01:00
Roy-043
ff9e84e181 Draft: fix NaN issue with Draft_Rotate
Fixes #19690

The issue was caused by a zero distance between the center and the point picked for the rotation angle.
2025-03-03 17:09:11 +01:00
Roy-043
084a0b3b4a Draft: fix polar coords regression
Fixes #19961

Regression caused by #19179.
2025-03-03 17:07:20 +01:00
Alfredo Monclus
8925ccc91a refactor: add if braces for linters 2025-03-03 11:30:43 -03:00
Alfredo Monclus
19ea0f625c revert: icon to manually painted one
windows icon is very different let's try to keep the look unified
2025-03-03 11:21:44 -03:00
Alfredo Monclus
94f2fa30fa revert: review suggestion from constexpr to const 2025-03-03 11:10:51 -03:00
Alfredo Monclus
2dfcacea7e taskpanel lineup comments 2025-03-03 10:49:27 -03:00
Alfredo Monclus
ed1193edbb taskpanel group early return 2025-03-03 10:49:26 -03:00
Alfredo Monclus
acee460dd3 Apply suggestions from code review
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
2025-03-03 10:45:22 -03:00
Benjamin Nauck
0952d4de63 Use designated initializers and remove zero-initialized fields 2025-03-03 11:02:19 +01:00