Commit Graph

194 Commits

Author SHA1 Message Date
luz.paz
cb4a0adf71 Misc. typos
Found via `codespell`
2019-02-08 11:01:24 -02:00
luz.paz
f3123b25a4 Crowdin: Sketcher/Gui/CommandCreateGeo.cpp fix typos 2019-01-30 11:08:03 -02:00
luz.paz
ab63398a69 Crowdin: Sketcher/Gui/CommandCreateGeo.cpp typo fix 2019-01-30 11:08:03 -02:00
wmayer
21d01fe6fc Replace Base::Exception with appropriate subclass 2018-11-14 19:27:52 +01:00
Abdullah Tahiri
7abc5fec65 Sketcher: Fillet UI command Improved exception handling 2018-10-28 18:35:41 +01:00
Abdullah Tahiri
af581dc689 Sketcher: GUI command updated to support filleting of bounded curves 2018-10-28 18:34:23 +01:00
Abdullah Tahiri
b3cf67dffe Sketcher: filleting arcofconic-arcofconic command 2018-10-28 18:32:02 +01:00
mwganson
dfdc05f5c5 sketcher: clear selection after failed addExternal geometry to prevent crash 2018-10-05 11:26:07 +02:00
luz.paz
360e581672 Misc. typo and whitespace fixes
ref: https://forum.freecadweb.org/viewtopic.php?f=3&t=30988#p256964
along with other misc. fixes
2018-09-19 17:26:03 +02:00
Abdullah Tahiri
779b4f641d Sketcher: Automatic redundant removal mechanism
===============================================

It is a long felt need that redundant constraints are not generated while autoconstraining.

The solver sketcher in v0.17 is überpicky with redundants due to the new popularity contest algorithm. The former behaviour is exhacerbated.

This new mode enables automatic redundant constraint removal.

In UI operations IN EDIT MODE, upon detection of redundancy by the solver, the Sketcher will remove all redundant constraints detected by that solve.

This makes the sketcher much less annoying.

How to test this?

The easiest example is to create a vertical line. Then make the endpoints symmetric with respect to the horizontal axis. Without this mode,
the vertical constraint and the symmetry constraint are redundant. With this mode, the vertical constraint gets automatically removed by the Sketcher.
2018-08-26 20:54:01 +02:00
Abdullah Tahiri
3eb5759da5 Sketcher: Improved B-Spline creation 2018-05-31 14:33:58 +02:00
Abdullah Tahiri
4fe44f9e95 Sketcher: Snap polyline arcs to 45 degrees pressing ctrl fixes #3472 2018-05-21 10:45:13 -03:00
Abdullah Tahiri
1c4e586946 Sketcher: fix menu periodic bspline call 2018-04-22 07:39:15 +02:00
Abdullah Tahiri
6b5836dcc7 Sketcher: Bug fix - prevent inter part/body links
=================================================

With the support for external geometry during carbon copy, it was introduced a way for creating inter-part/inter-body links. See:
https://forum.freecadweb.org/viewtopic.php?f=10&t=27700&p=223736#p223736

This commit closes this door, while still allows carbon copy with external geometry support within the same body.
2018-03-30 21:00:24 +02:00
luz.paz
1d5799e5b3 Misc. typos
Inspired by @normandc per https://gitter.im/FreeCAD/FreeCAD?at=5a729c6ece68c3bc742df205
2018-02-07 09:40:03 +01:00
wmayer
76b12d242d fix syntax errors 2018-01-31 20:53:42 +01:00
luz.paz
69216f3604 sWhatsThis fixes
ref: https://forum.freecadweb.org/viewtopic.php?f=10&t=26687
2018-01-31 19:07:07 +01:00
Abdullah Tahiri
19585e6b4b Sketcher: new UI command for arbitrary sides polygon
fixes #1639
2017-12-23 14:45:39 +01:00
Abdullah Tahiri
ea8652f54e Sketcher: Fixing Polyline Arc Endpoint autoconstraints
======================================================

fixes #3091

Autoconstraints did not check whether the arc was CW or CCW, as such the autoconstraint on the second position was sometimes assigned to the start point.
2017-12-07 11:31:35 +01:00
Abdullah Tahiri
f0a4d6a524 Sketcher: Fix Polygon disappearing on creation with autoconstraints on
======================================================================

Fixes #3154

About the fix:
- If a non-zero vector is passed to seekAutoConstraint, it will suggest a vertical/horizontal constraint, which does not
make sense in the construction method.
- Passing a zero vector enables to treat it like a point, so for example point on object will be suggested, but not vertical/horizontal constraints.
2017-12-07 10:59:49 +01:00
Abdullah Tahiri
0f021940b9 Sketcher: BSpline, prevent 0 mm Radius for poles on creation
============================================================

https://forum.freecadweb.org/viewtopic.php?f=10&t=25701
2017-12-07 10:52:28 +01:00
wmayer
794a39684a fix crashes when using sketch tools 2017-11-23 13:22:37 +01:00
wmayer
f1f2a90190 fix coverity issues 2017-11-18 18:07:00 +01:00
Jeff
7f633cfbb2 Added color prefs to sketcher create commands
Create geometry commands in sketcher now have configurable crosshair color and editCurve color.
2017-11-18 15:30:41 +01:00
Abdullah Tahiri
bfa6de056e Sketcher: Restore inter-body expression engine links in Carbon Copy 2017-11-02 19:52:26 +01:00
wmayer
9adddc08ac remove possibility of directly cross-referencing other body, use shape binder instead! 2017-10-13 17:28:21 +02:00
wmayer
1d17c043eb re-enable sketcher to reference elements of other body 2017-10-05 15:20:39 +02:00
wmayer
fde42545ba fix various coverity issues 2017-09-15 11:48:38 +02:00
Abdullah Tahiri
58210251ca Refactoring solve+recompute and reinstating initial solve+recompute behaviour 2017-08-19 17:14:27 +02:00
wmayer
5661d91371 fixes #0002710: Freecad doesn't show sketch elements added when overconstrained
issue #0002836: Crash in sketcher
2017-08-19 17:14:27 +02:00
wmayer
9948041175 fix text of commands to create B-spline curves 2017-07-17 11:54:18 +02:00
luzpaz
17df8c858d Sketcher: typo 2017-07-11 13:08:29 -04:00
wmayer
a5a04e359c fix bug in pr774, improve whitespaces 2017-06-19 13:32:27 +02:00
Alexander Lin
b05c9393df Fix 'shrink curve' misbehaviors for Sketcher Extend 2017-06-19 13:07:55 +02:00
Alexander Lin
144e4759ce Adds extend feature to Mod/Sketcher
Fixes #1187
2017-06-19 13:07:37 +02:00
wmayer
d6b62293a0 various fixes from pr813:
fix crash due to invalifated iterator
minor performance improvement
do not connect twice automatically connected signal-slot
fix compiler warning
2017-06-18 21:25:31 +02:00
wmayer
1533947e49 improve readability, minor performance improvements 2017-06-18 18:01:27 +02:00
Abdullah Tahiri
2cf73103dc Sketcher: redundant autoconstraint avoidance - Edit control checkbox
fixes #3079
2017-06-18 17:37:27 +02:00
Abdullah Tahiri
107fdc5996 Sketcher: extension of redundant avoidance to indirect coincidence 2017-06-18 17:37:27 +02:00
Abdullah Tahiri
b4e65f64d0 horiz/vert redundant autoconstraint avoidance extended to Polyline tool 2017-06-18 17:37:27 +02:00
Abdullah Tahiri
354350c5cf Sketcher: avoid horiz and vertical autoconstraint redundants on line creation 2017-06-18 17:37:27 +02:00
Abdullah Tahiri
4e9c5bd4c6 fixes #0003018 2017-05-26 23:28:08 +02:00
asiersarasua
289f901c29 Fix typos 2017-04-23 18:48:21 -03:00
Abdullah Tahiri
1d6f677781 Sketcher: change carbon copy alignment by-pass from ALT to ALT+CTRL for Linux compatibility 2017-04-12 14:28:43 +02:00
wmayer
8195b10fc6 consistently use term 'B-spline' in the sketcher GUI 2017-04-12 09:37:58 +02:00
wmayer
ba9ffed16b fix scan coverity issues 2017-04-11 15:06:37 +02:00
Abdullah Tahiri
8e4ac4dd70 Sketcher: Carbon Copy - Allow cross-body sketcher links
=======================================================

The instructions are shown on the status bar.

press CTRL to allow cross-body link

press ALT to by-pass directional requirements

press CTRL+ALT to allow a cross-body link and by-pass directional requirements
2017-04-10 18:55:23 +02:00
Abdullah Tahiri
fdf040f5b7 Sketcher: Carbon Copy
=====================

Carbon copy checks for parallel planes, translated origin and rotated axes, so that it can provide flipping detection when using reverse mappings.

This commit enables you to press CTRL will activating the tool in order to bypass this checks. Without the checks you will get a sketch exactly as the one
you want to copy, there are no corrections at all. This enables you to copy a profile on a new plane at a different direction for example for lofting purposes.
2017-04-10 08:57:25 +02:00
Abdullah Tahiri
19565c3270 Sketcher: Carbon Copy - inform user of the limitations and disallow selection 2017-04-10 08:57:25 +02:00
Abdullah Tahiri
0ad91f79bd Sketcher: Carbon Copy toolbar command 2017-04-10 08:57:25 +02:00