Commit Graph

17484 Commits

Author SHA1 Message Date
tomate44
cbb1faf116 convert Geom_TrimmedCurve to subclass 2020-09-20 18:25:39 +02:00
tomate44
b81f654905 Part: remove uIso and vIso methods. Methods from base class GeomSurface will be used instead 2020-09-20 18:25:39 +02:00
vejmarie
4e524cbb1c Fix MacOS build with boost 1.73 and updated Homebrew packages 2020-09-19 19:35:39 +02:00
donovaly
78efc9c34f [PD] simplify item handling
according to https://github.com/FreeCAD/FreeCAD/commit/c1fd0320

"QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous"
2020-09-18 17:30:09 +02:00
wmayer
4e101a555f Web: [skip ci] when dropping local file on StartPage then open it instead of downloading it 2020-09-18 13:14:09 +02:00
donovaly
8217e0f0d0 [PD] make sections sortable
- allow to sort loft sections by dragging: https://forum.freecadweb.org/viewtopic.php?f=19&t=50222

- fix bug of uninitialized options: https://forum.freecadweb.org/viewtopic.php?f=19&t=50221

- use better code for the context menu of the listWidget (the same we use in other placed of PD)

- add missing tooltip for mirror feature
2020-09-17 23:59:15 +02:00
wmayer
17e758ec69 MeshGui: [skip ci] expose highlightSegments() to Python 2020-09-17 18:25:14 +02:00
wmayer
c69612c748 PD: improve reference highlighting of a pipe
This change allows to highlight the spline, auxiliary spine, profile and sections of a pipe.
This gives the user a much better feedback of what external shapes are already used to build the pipe
2020-09-17 16:19:38 +02:00
wmayer
44b1a27cd4 PD: [skip ci] fixes for pipe task panel
+ Add/Remove are checkable buttons so if user unchecks it then disable highlighting of spine
+ Avoid superfluous char* -> QString conversion
2020-09-17 14:04:36 +02:00
wmayer
8fa096f23b PD: fixes for pipe task panel
+ fix Qt4 build failure
+ fix handling of adding items to spine/auxiliary spine/sections to allow to remove them again
+ QListWidget::takeItem() returns a pointer to the removed item. So a previous call of QListWidget::item() is superfluous
2020-09-17 11:35:41 +02:00
donovaly
329c763916 [PD] add context menus to sweep Dialog
- elements in the list of edges/spines/sections can now be deleted by pressing DEL and there is a context menu for this action

see https://forum.freecadweb.org/viewtopic.php?f=19&t=50222&p=431021#p431021
2020-09-17 00:45:43 +02:00
wmayer
1f1048d7c9 PartDesign: [skip ci] hide base feature of pad after it successful recompute 2020-09-16 17:18:49 +02:00
vocx-fc
7b34a43c16 Draft: small fixes to the closest function.
Correct the Pythonic style for the changes made in 85286bf044.
2020-09-16 13:09:57 +02:00
vocx-fc
b202b0d469 Draft: move getDXF to draftfunctions submodule
Update the appropriate interface in `Draft.py`.
2020-09-16 13:09:13 +02:00
Roy-043
cc8bc60e02 Arch: Minor improvements to testWallMultiMatAlign unit test. 2020-09-16 13:08:45 +02:00
Roy-043
b6f17bfa55 Arch: Arch_Wall fix MultiMaterial alignment bug (unit test)
Added the testWallMultiMatAlign unit test. Have kept the testWall test. Changed the code to 'import FreeCAD as App'.
2020-09-16 13:08:45 +02:00
Roy-043
48218690ce Arch: Arch_Wall fix MultiMaterial alignment bug. 2020-09-16 13:08:45 +02:00
Roy-043
80a1505530 Draft: Again revised the 5 scale unit tests. No longer relying on the math module.
Also avoided the use of a Boolean 'result' variable.
2020-09-16 13:07:50 +02:00
Roy-043
2ac6909671 Draft: Revised the 5 Draft.scale unit tests. No longer using scale_vector_from_center.
The old Draft.scale unit tests uses the scale_vector_from_center function from Draft.scale. This obviously didn't make sense.
2020-09-16 13:07:50 +02:00
Roy-043
19e7cff253 Draft: added 5 scale unit tests to test_modifications
The added functions are test_scale_part_feature_arcs, test_scale_part_feature_lines, test_scale_rectangle, test_scale_spline and test_scale_wire.
When comparing vectors and floats a tolerance of 1e-8 is used, but only for the midpoints of the arcs in test_scale_part_feature_arcs is this tolerance required. Scaling a part feature is not possible with the Draft_Scale command, but Draft.scale does support it.
2020-09-16 13:07:50 +02:00
wmayer
e426c12787 PartDesign: make sure to remove selection gate when closing task panel 2020-09-16 12:15:19 +02:00
wmayer
7723ad94f9 Fem: make sure to remove selection gate when closing task panel 2020-09-16 12:15:01 +02:00
wmayer
23a178edc4 Part: do not use local event loop in sweep and thickness panel 2020-09-16 12:14:04 +02:00
donovaly
b0faf1197c [PD] fix wording for skew prisms
the UI and the property is not consistent. In the dialog we use the term angle upon user feedback while the property still has the name "skew" in it.
I simply forgot this change in my PR that implemented skew prisms.

This is now corrected by this PR.
2020-09-15 22:13:26 +02:00
sliptonic
922ec0dce5 Merge pull request #3861 from Russ4262/profile_reset_fix
[Path] Fixes #4433 - `Cut Side` reset with certain Base Geometry changes
2020-09-15 14:12:01 -05:00
sliptonic
968ea0061e Merge pull request #3862 from Russ4262/pocketshape_fix
[Path] PocketShape - fix improper path generation
2020-09-15 14:09:57 -05:00
sliptonic
0e21c31d37 Merge pull request #3813 from xform3/feature/base_geometry_multi_object_select
[Path] Enable for selection of multiple objects in Base Geometry list
2020-09-15 13:54:54 -05:00
sliptonic
e1cfe7144b Merge pull request #3849 from Schildkroet/deburr+dressup
[Path] Fixed DeburrOp not moving to safe height
2020-09-15 12:48:33 -05:00
sliptonic
555699fae1 Merge pull request #3870 from vocx-fc/Path_fix_CMakeLists
Path: add missing postprocessor to CMakeLists
2020-09-15 12:47:17 -05:00
wmayer
fb03c31b28 PD: whitespace improvements 2020-09-15 14:20:24 +02:00
wmayer
17859d5ffb PD: do not use active document in task dialogs because this is error-prone
and optimize string creation in TaskSketchBasedParameters::getFaceReference
2020-09-15 14:13:23 +02:00
wmayer
dc7de6b195 PD: do not use active document in task dialogs because this is error-prone 2020-09-15 13:21:32 +02:00
mwganson
7d392d1209 [Part Design] allow for preselecting loft sections and pipe spines prior to invoking command 2020-09-15 10:48:09 +02:00
vocx-fc
00dc2c8476 Path: use 4-space indentation, and keep lines short 2020-09-15 00:56:17 -05:00
vocx-fc
ff79e28054 Path: add missing postprocessor to CMakeLists 2020-09-14 22:18:00 -05:00
wmayer
ebecdfa8d0 Part: [skip ci] Coverity: Uninitialized scalar field 2020-09-14 19:30:21 +02:00
wmayer
033e4d900b Base: [skip ci] Coverity: Uncaught exception 2020-09-14 18:34:25 +02:00
wmayer
1c9573e8d2 dxf: [skip ci] Coverity: Buffer not null terminated 2020-09-14 14:37:20 +02:00
wmayer
11e52fc696 TechDraw: [skip ci] Coverity: Dereference null return value 2020-09-14 14:04:18 +02:00
wmayer
716433e55b TechDraw: [skip ci] Coverity: Uninitialized scalar variable/Uninitialized scalar field 2020-09-14 13:54:55 +02:00
hrobeers
7f36e21d4b [OpenSCAD] consistent FreeCADGui imports, fixes headless CSG import 2020-09-14 13:28:40 +02:00
Syres916
50d531061b [Sketcher] Improve Solver Message Visibility...
...when using dark(er) style sheets.
See discussion https://forum.freecadweb.org/viewtopic.php?f=3&t=50094
2020-09-13 12:52:28 +02:00
Cheuksan Wang
a178990acb Move the aliases before other content of cells
When a user performs insert rows, remove rows, insert columns, or
remove rows, we need to move multiple cells as a batch. The cells are
moved sequentially. For each cell, its dependent alias positions are
looked up and dependencies are added.  However, those cells with
aliases may be moved later in the batch. Thus the earlier dependencies
become wrong. This commit fixes this bug by moving all the aliases
before moving the cells. Unit tests are added to for this bug.

fixes issue #4429
2020-09-13 11:58:54 +02:00
bitacovir
7a899be600 Add SVG icon for Part Reverse Shape command
Part Reverse Shape command does not have icon for the FreeCAD UI (Part WB).

This commit adds SVG file with icon for this command. Also, it makes the necessary changes on Command.cpp and Part.qrc files.

The new SVG icon follows the FreeCAD Artwork Guidelines and were saved as Plain SVG format.

The icon designs keep the style of the existing icons in the Part Workbench:
https://wiki.freecadweb.org/Part_Module

The discussion with the request can be found in the UX/UI Design FreeCAD Forum:
https://forum.freecadweb.org/viewtopic.php?f=34&t=44278&hilit=bitacovir
2020-09-13 10:01:50 +02:00
wmayer
600b463af0 MeshPart: [skip ci] import MeshPartGui in order to load icon resources 2020-09-13 09:59:14 +02:00
bitacovir
5a505fe565 Auto stash before rebase of "upstream/master" 2020-09-12 22:47:45 +02:00
wmayer
2520569cc7 fixes #0004426: [skip ci] Patch to add MinLength and MaxLenght to the Netgen options in the Python API (provided by thomasFreeCAD) 2020-09-12 19:37:12 +02:00
wmayer
308baeaeab PartDesign: [skip ci] fix L2 parameter in pad feature when using custom direction 2020-09-12 17:26:41 +02:00
Russell Johnson
3efe9efb68 [Path] PocketShape - fix improper path generation
Forum identification and discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49513.
2020-09-12 09:35:34 -05:00
donovaly
91ef59fdbe [PD] allow to pad in any direction
It saves a lot of work if one can directly pad in any direction and OCC allows this.

This PR adds the possibility to define a custom vector for the padding direction.
2020-09-12 16:33:44 +02:00