Commit Graph

873 Commits

Author SHA1 Message Date
wmayer
a7539e2c97 fix various warnings 2017-02-02 20:42:56 +01:00
Abdullah Tahiri
b71616219d Sketcher: Polyline continuous mode support 2017-02-02 10:42:38 +01:00
Abdullah Tahiri
48ca83dc15 Sketcher: BSpline deletion/special hideunused internal geometry
===============================================================

The implementation of BSpline differs from previous complex forms.

The BSpline is created constraint to be polynomic (non-rational), with radius of first circle and equality constraints.

Hide unused internal geometry considers as unused the following constraints:
- A pole which has equality constraints with another pole of the same bspline
- Any radius constraint on a pole

Deletion of a BSpline will delete the internal geometry that is unused as per the definition above.

If there is another constraint (other than the Internal alignment constraint) it will leave the internal geometry having such constraint undeleted.
2017-02-02 10:42:38 +01:00
AjinkyaDahale
c00a627397 Changes based on wwmayer's comments 2017-01-31 17:07:45 +01:00
AjinkyaDahale
8a911f3ef3 Moved Perpendicular to constraint mode framework
A couple of combinations, endpoint-endpoint and endpoint-curve, do not
work, and the latter probably should not work ever since endpoint-curve-
curve exists.
2017-01-31 17:07:45 +01:00
AjinkyaDahale
ccfc4d943a Brought back select then constraint for all constraint tools yet converted 2017-01-31 17:07:45 +01:00
AjinkyaDahale
00ca4d3a36 Miscellaneous changes to constraint creation modes
Parallel constraints can also be made by select-then-constraint way.
Preliminary preparations for perpendicular constraint making mode.
Selection actually works when for constraints involving multiple
elements few of them are selected (thanks abdullah).
etc.
2017-01-31 17:07:45 +01:00
Abdullah Tahiri
16c87a5e11 Sketcher: Fixing Green selection on new style constraints 2017-01-31 17:07:45 +01:00
AjinkyaDahale
994b8a7fd3 Moved point on object to general constraint mode framework 2017-01-31 17:07:45 +01:00
AjinkyaDahale
63323ec85a Moved parallel to general constraint mode framework 2017-01-31 17:07:45 +01:00
AjinkyaDahale
de0301dc66 Moved coincident and vertical to general constraint mode framework 2017-01-31 17:07:45 +01:00
AjinkyaDahale
f2fbd8ba2b Moved CmdSketcherConstrainLock to general constraint mode framework 2017-01-31 17:07:45 +01:00
AjinkyaDahale
d1eab78b93 Generalize DrawSketchHandlerGenConstraint::releaseButton
The select-then-constrain method has been temporarily sacrificed
2017-01-31 17:07:45 +01:00
AjinkyaDahale
c4675b521c CmdSketcherConstraint::applyConstraint() is now used in DrawSketchHandlerGenConstraint 2017-01-31 17:07:45 +01:00
AjinkyaDahale
3b5c72357c Initial commit with DrawSketchHandlerGenConstraint
Plus made CmdSketcherConstrainHorizontal subclass of
CmdSketcherConstraint, and made it use DrawSketchHandlerGenConstraint.
2017-01-31 17:07:45 +01:00
AjinkyaDahale
d326c9e018 Replace All SelectionFilterGates in Constraint Modes by GenericConstraintSelection 2017-01-31 17:07:45 +01:00
AjinkyaDahale
24215170fc Addition to CmdSketcherConstraint and GenericConstraintSelection
Also making CmdSketcherConstrainLock a subclass of CmdSketcherConstraint
2017-01-31 17:07:45 +01:00
AjinkyaDahale
7718dd9aea Coincident constraint mode works on root (origin) too 2017-01-31 17:07:45 +01:00
AjinkyaDahale
137db465db Skeleton of general CmdSketcherConstraint Class 2017-01-31 17:07:45 +01:00
Alexander Gryson
73e6d48517 Correct outline color in sketcher icon
The select constraint icon incorrectly showed icon as having an orange outline. This was corrected, but after merge of PR.
2017-01-29 20:21:22 +01:00
Abdullah Tahiri
5b4602be33 Sketcher: Documentation of delete functions 2017-01-29 00:25:34 +01:00
Abdullah Tahiri
3dc67c2547 Sketcher: Fix deletion of geometry having internal geometry inserted before the geometry 2017-01-28 23:08:27 +01:00
Alexander Gryson
f253171bee Update Metadata 2017-01-28 09:29:20 +01:00
Alexander Gryson
45c0ddde40 Update xpm icons 2017-01-28 09:29:19 +01:00
Alexander Gryson
6ac4160776 Align Sketcher Workbench icons to guidelines 2017-01-28 09:29:19 +01:00
wwmayer
aab3cdbed4 Merge pull request #475 from abdullahtahiriyo/bspline_stage1b_2017_firstdeliverable
Bspline stage1b 2017 firstdeliverable
2017-01-27 18:20:16 +01:00
Abdullah Tahiri
c1620e7a87 Sketcher: BSpline - avoid tiny circles on removal of equality 2017-01-26 23:41:02 +01:00
Abdullah Tahiri
675e6c4e41 Sketcher: BSpline Creation - as single command for one-step undo 2017-01-26 21:31:03 +01:00
Abdullah Tahiri
da5c5b22b4 Sketcher: BSpline Creation fix - Remove introduced pole if creation cancelled 2017-01-26 21:31:03 +01:00
Abdullah Tahiri
fe929559e1 Sketcher: BSpline Creation improvement - Add constraints by groups 2017-01-26 21:31:03 +01:00
Abdullah Tahiri
68d5a13b9a Sketcher: BSpline Creation acceleration - pole constraining on pole creation 2017-01-26 21:31:02 +01:00
Abdullah Tahiri
4e19839bb9 Sketcher: BSpline Creation solver call reduction 2017-01-26 21:31:02 +01:00
Abdullah Tahiri
e18dc4147b Sketcher: BSpline Creation - pole circle on click
=================================================

This method creates the pole circles on every click. This allows to properly detect the closing of the curve
2017-01-26 21:31:02 +01:00
Abdullah Tahiri
c809bfbed8 Sketcher: InternalAligment Python extension to InternalAlignmentIndex
=====================================================================

Extension of Constraint Python code to consider the case with 4 ints, where the last int is InternalAligmentIndex for InternalAligment constraint
2017-01-26 21:31:02 +01:00
wmayer
97905b8c7b issue #0002816: Trimming tool crashes 2017-01-23 19:06:48 +01:00
Abdullah Tahiri
2a58ed0576 Sketcher: BSpline creation mode end on right-click
==================================================

Now the BSpline ends with right-click, but creates the BSpline if at least two poles have been entered.

If continous creation mode is enabled, then it only exits when right-clicking without having entered any pole.
2017-01-22 00:38:23 +01:00
wmayer
c10f6fdd07 fix a couple of compiler warnings 2017-01-20 22:54:10 +01:00
wmayer
e262d3b127 write consistently 'B-spline' in menus and tooltips 2017-01-20 20:59:32 +01:00
wmayer
939ac5e936 Several fixes:
+ use different iterator variable for nexted loops
+ avoid loss of data warnings
+ improve layout
2017-01-20 19:40:49 +01:00
wmayer
d065c2fe5b fix whitespaces 2017-01-20 19:22:50 +01:00
abdullahtahiriyo
8d9af6f203 Merge branch 'master' into bspline_2017 2017-01-18 22:48:27 +01:00
wmayer
b26e3c3143 fix crashes in creation of parabola or hyperbola 2017-01-16 23:07:09 +01:00
Abdullah Tahiri
12de8e21a9 Sketcher: Symmetry support for BSpline 2017-01-16 21:47:03 +01:00
Abdullah Tahiri
ad977868a5 Sketcher: Array/Copy/Clone support for BSpline 2017-01-16 21:28:40 +01:00
Abdullah Tahiri
84041c0e50 Sketcher: BSpline SnellsLaw - unsupported 2017-01-15 22:34:14 +01:00
Abdullah Tahiri
6bf7d4d6c9 Sketcher: BSpline point-on-object - unsupported 2017-01-15 22:29:21 +01:00
Abdullah Tahiri
43e40f12df Sketcher: Enable relative movement of BSpline edge 2017-01-15 22:21:18 +01:00
AjinkyaDahale
4c001f40f3 Horizontal and Vertical Constraint creation modes 2017-01-15 17:00:45 +01:00
Abdullah Tahiri
4dfacb9888 Sketcher: BSpline solver improvement
===================================

In the unusual event that endpoint knot multiplicity is edited, avoid trying to force the bspline end-point
to match the corresponding control point (aka pole), as this leads to unsolvable sketches.
2017-01-15 01:49:45 +01:00
Abdullah Tahiri
6f09b31456 Sketcher: BSpline - Equality not supported user indication 2017-01-15 01:40:04 +01:00