Commit Graph

15816 Commits

Author SHA1 Message Date
Bernd Hahnebach
cf474f60ed Arch: rebar, allow to make rebars from an edge too 2020-04-08 14:38:17 +02:00
vocx-fc
35b0e0e227 Draft: polararray, clean up imports, docstrings, and checks 2020-04-08 11:08:29 +02:00
vocx-fc
cf7cae0d17 Draft: orthoarray, add strictly rectangular arrays 2020-04-08 11:08:29 +02:00
vocx-fc
5658ae17eb Draft: orthoarray, clean up imports, docstrings, and checks 2020-04-08 11:08:29 +02:00
vocx-fc
8141096344 Draft: circulararray, clean up imports, docstrings, and checks 2020-04-08 11:08:29 +02:00
vocx-fc
ea1649c038 Draft: arc_3points, clean up imports and checks 2020-04-08 11:08:29 +02:00
vocx-fc
4c806caeb9 Draft: utils, add function to log calls 2020-04-08 11:08:29 +02:00
vocx-fc
26864d9633 Draft: moved some unit tests to TestDraftGui
Those unit tests that are registered in `Init.py` will always run,
while those that are registerd in `InitGui.py` will only run
when the graphical interface is available.

This allows us to more clearly distinguish functions that
should be able to run always, from those that may run only
when the interfce is available.
2020-04-08 11:07:51 +02:00
vocx-fc
5147ffd496 Draft: Coin (Pivy) tests only when the graphical interface is up 2020-04-08 11:07:51 +02:00
vocx-fc
c55a5a9146 Draft: unit tests registered in Init.py
This means that now the unit tests will run from
the console mode when using
```
FreeCADCmd -t 0
FreeCAD --console -t 0
```

This will allow us to catch errors more easily,
as we separate better the behavior of non-GUI
and GUI-required modules.

Also small spacing fixes and position of the license.
2020-04-08 11:07:51 +02:00
Bernd Hahnebach
7d8ab175a6 Arch: rebar, add error prints 2020-04-07 21:12:33 +02:00
0penBrain
f9fc96047d [PartDesign] Remove 'Set tip' from Body contextual menu ; fixes #4304 2020-04-07 19:38:01 +02:00
luz.paz
2ed5786d07 [skip-ci] Various typo fixes
Found via codespell  v1.17.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-07 18:17:03 +02:00
vocx-fc
a101e911f9 Draft: gui_utils, add small stylistic changes
These changes are added by carlopav in pull request #3102.
We add them in this commit already so that this branch and
that branch are easier to rebase and merge.
2020-04-07 18:12:06 +02:00
vocx-fc
7a6b586a66 Draft: move ShapeString to the creation tools
Previously it was placed in the `annotation` category
but since it creates a group of shapes, it is better
in the `creation` category.

Also small fixes in the menu text and tooltip.
2020-04-07 18:12:06 +02:00
vocx-fc
dfedd10f3d Draft: importSVG.py, FreeCADGui with interface only
Also small fixes in imports and spacing
2020-04-07 18:12:06 +02:00
vocx-fc
691a3cdf08 Draft: gui_utils, autogroup return when GuiUp is False 2020-04-07 18:12:06 +02:00
vocx-fc
932938e36f Draft: clean up init_tools and messages 2020-04-07 18:12:06 +02:00
vocx-fc
ec5dcdc087 Draft: gui_trackers clean up docstrings and spaces (3)
Many small spacing fixes in the code, to improve the Pythonic
style according to PEP8.
Also add many docstrings in triple quotes.
2020-04-07 18:12:06 +02:00
vocx-fc
da1f71dfc0 Draft: gui_trackers clean up docstrings and spaces (2)
Many small spacing fixes in the code, to improve the Pythonic
style according to PEP8.
Also add many docstrings in triple quotes.
2020-04-07 18:12:06 +02:00
vocx-fc
1cde3156b0 Draft: gui_trackers clean up docstrings and spaces
Many small spacing fixes in the code, to improve the Pythonic
style according to PEP8.
Also add many docstrings in triple quotes.
2020-04-07 18:12:06 +02:00
vocx-fc
009a7aacf9 Draft: gui_snaps cleanup 2020-04-07 18:12:06 +02:00
vocx-fc
d91cc369f3 Draft: gui_snapper clean up docstrings and spaces (2) 2020-04-07 18:12:06 +02:00
vocx-fc
3f33f04827 Draft: gui_snapper clean up docstrings and spaces 2020-04-07 18:12:06 +02:00
vocx-fc
b5fa36953f Draft: gui_selectplane cleanup
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Added many docstrings to clarify the methods, and spaces
after commas in order to comply with Python PEP8 style.
Also break many lines so that they are shorter than 80 characters.
2020-04-07 18:12:06 +02:00
vocx-fc
3e77ded2c4 Draft: gui_polararray cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstrings,
and the position of the license.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Use proper `ToDo` class instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
aad2969a28 Draft: gui_orthoarray cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
and the position of the license.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Use proper `ToDo` class instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
6c4b2161e3 Draft: gui_edit, many small spacing and docstring edits 2020-04-07 18:12:06 +02:00
vocx-fc
c1fe916f00 Draft: gui_edit cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
the position of the license, and trailing spaces.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Properly import `gui_trackers` module and use tracker
classes prefixed accordingly.
2020-04-07 18:12:06 +02:00
vocx-fc
dd9b694422 Draft: gui_circulararray cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
and the position of the license.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Use proper `ToDo` class instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
43c93b886e Draft: clean up gui_arrays and gui_base
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
and the position of the license.

Remove unused imports. And use proper `ToDo` class
instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
cf7b774e92 Draft: DraftGeomUtils clean up docstrings and spaces 2020-04-07 18:12:06 +02:00
vocx-fc
b532c74e3d Draft: DraftGeomUtils clean up imports, and Python 2 compatibility
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Also fix copying of a list in order to keep compatibility
with Python 2.
2020-04-07 18:12:06 +02:00
vocx-fc
033d0091e5 Draft: WorkingPlane.py clean up imports and docstrings
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Cleaned up the class docstring, so it is in only one place
below the class definition. Also small fixes
in the docstrings of the class methods.

The class is now in upper case `Plane` to conform with Python
guidelines. An alias in lowercase `plane` is still provided
for compatibility purposes; this will be deprecated
in the future.
2020-04-07 18:12:06 +02:00
vocx-fc
ad0a50c79a Draft: DraftVecUtils.py clean up imports and messages
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide the functions
to print text to the console.
Also use `Matrix` prefixed by the `FreeCAD` module.
2020-04-07 18:12:06 +02:00
vocx-fc
046be91982 Draft: gui_trackers.py clean up imports and spaces
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the `ToDo` class with this new name
following Python guidelines.
2020-04-07 18:12:06 +02:00
vocx-fc
a9a10a7fd7 Draft: gui_snapper.py clean up imports and spaces
Small spacing fixes like imports in separate lines
for more clarity.
Also use the `OrderedDict` prefixed with the `collections` module.
2020-04-07 18:12:06 +02:00
vocx-fc
f33dcf69db Draft: todo.py clean up header, imports and messages
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide
the functions to print text to the console.

Use two `DEBUG` variables to print information about
the `ToDo` class in order to see the scheduled commands
when the graphical commands are executed.
2020-04-07 18:12:06 +02:00
vocx-fc
3b6c06d095 Draft: gui_utils.py clean up imports
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide the functions
to print text to the console.
2020-04-07 18:12:06 +02:00
vocx-fc
e9742da7d8 Draft: utils.py clean up header and imports
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide the functions
to print text to the console.
2020-04-07 18:12:06 +02:00
vocx-fc
d45321f7ff Draft: Draft.py improve imports of utility functions 2020-04-07 18:12:06 +02:00
vocx-fc
4018a47885 Draft: Draft.py clean up header and imports 2020-04-07 18:12:06 +02:00
vocx-fc
f00fe58061 Draft: DraftTools.py clean up header and imports
Small spacing fixes like imports in separate lines for
more clarity, and the position of the license.
Also use the class name `ToDo` in `CamelCase`,
as it is indicated in Python guidelines for classes.
2020-04-07 18:12:06 +02:00
vocx-fc
d1c0f2f2f0 Draft: docstrings for the submodules 2020-04-07 18:12:06 +02:00
0penBrain
cbefa8e6fe [Sketcher] Improve elements color tampering with edge coloring
Use HSV colorspace for maximum Qt4 compatibility
2020-04-07 17:05:37 +02:00
0penBrain
634e47f318 [Sketcher] Fix Qt4 compatibility in MultIcon + minor improvement 2020-04-07 17:05:37 +02:00
Abdullah Tahiri
9752de8602 Sketcher: Element Widget External/Construction icons fixes
==========================================================

Changes:
- Move multIcon structure to be internal to TaskSketcherElements class
- Change Caps to MultIcon for consistency
- Move tamperIcon from TaskSketcherElements to MultIcon struct
- Change tamperIcon method to be the constructor of MultIcon and change from struct to class
- Update the tamperIcon algorithm, so that only the point that is not marked in green as selected
is made pink.

Bug fix:

UpdateIcons and SlotElementsChanged are methods sharing code (they could benefit from a refactoring), but
they are conceptually different and are called in very different circumnstances.

UpdateIcons preserves selection. This means that one may select the stating point of line1, press z to switch
to edges, select the edge of line 2 and do a point on object constraint all without touching the 3D view.

SlotElementsChanged occurs when there are additions or removals in the number of geometry elements of the widget.

Warning:

This code requires QT 5.6 because of function pixelColour(int, int):
https://doc.qt.io/qt-5/qimage.html#pixelColor-1

Travis without QT5 complains with:

/home/travis/build/FreeCAD/FreeCAD/src/Mod/Sketcher/Gui/TaskSketcherElements.cpp:1120:31: error: ‘class QImage’ has no member named ‘pixelColor’; did you mean ‘setColor’?
2020-04-07 17:05:37 +02:00
0penBrain
9b2e7b22c5 [Sketcher] Distinguish normal/reference/construction elements in task dialog 2020-04-07 17:05:37 +02:00
sliptonic
d1205005ee Merge pull request #3316 from realthunder/FixPathSort
Path: handle open edges when sorting path
2020-04-07 09:31:01 -05:00
wmayer
815db40a9c Cloud: [skip ci] fix linking issues on macOS 2020-04-07 15:52:29 +02:00