Commit Graph

2027 Commits

Author SHA1 Message Date
Chris Hennes
cf84c171e6 Merge pull request #10978 from FlachyJoe/modernize-type-check
Modernize type and derived type checking
2023-11-06 10:44:32 -06:00
Adrian Insaurralde Avalos
9c093ba041 Sketcher: fix Line tool settings mode name 2023-11-05 07:36:22 +01:00
Abdullah Tahiri
1de8d9f10f Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
882262bfa8 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Paddle
dc2da5aba1 Offset fix isActive function. 2023-11-04 08:58:50 +01:00
Paddle
b4a54abed5 Polygon DSH : Small syntax improvements. 2023-11-04 08:58:50 +01:00
Paddle
785ec817c8 Line DSH : syntax and remove potential issues. For example in width+length mode, if user input 0 and 0, instead of validating it will unset the spinboxes. Preventing creation of null lines. 2023-11-04 08:58:50 +01:00
Paddle
3242144128 Rectangle DSH : Fix a bug where 3p rectangle with radius, radius would not apply. Also fix various edge cases. Improve syntax. 2023-11-04 08:58:50 +01:00
Paddle
b72da63139 Offset DSH : Add pointer SVG. Some remove unecessary member initialization 2023-11-04 08:58:50 +01:00
Paddle
5fc39a5add DSDWC : typo 2023-11-04 08:58:50 +01:00
Paddle
aa4a158e0c Prevent passing the focus to a spinbox when it shouldn't.
In some DSH some mode (seekSecond for example) don't have onViewParameter. In this case it would wrongly try to give focus to the previous spinbox with focus.
2023-11-04 08:58:50 +01:00
Paddle
336691cd5a Redraw on construction method changed. Avoid a small issue where you had to move mouse first before being able to rechange the methode by the M key. 2023-11-04 08:58:50 +01:00
Paddle
8788bcc0f4 SketcherToolDefaultWidget : Add a blockParameterFocusPassing bool that let us set parameters without passing focus. To fix undue passing of focus when using shortcuts U/J. For example in Polygon. 2023-11-04 08:58:50 +01:00
Paddle
aef013473b DrawSketchController and DrawSketchDefaultWidgetController : fix lint warnings 2023-11-03 14:02:25 +01:00
Paddle
a0609b1a28 Sketcher: Polygon DSH 2023-11-03 14:02:25 +01:00
Paddle
b65b1ff8de Sketcher: Offset DSH 2023-11-03 14:02:25 +01:00
Paddle
c9f6639810 Sketcher: Rectangle DSH 2023-11-03 14:02:25 +01:00
Paddle
6769166bf4 Sketcher: Line DSH 2023-11-03 14:02:25 +01:00
Paddle
c5de96fbd6 Sketcher: Point DSH 2023-11-03 14:02:25 +01:00
Paddle
3483090279 DSDH : add canGoToNextMode() methode in onButtonPressed. So that we can prevent going to the next mode on certain conditions. 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3f1f1047b2 Sketcher: Make GeometryConstructionMode an enum class
=====================================================

Enforce strong typing to avoid all kinds of abusive implicit conversionsm, the corresponding associated bugs and make code more readable.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
82fed5bbfc Sketcher: New flexible DSH Architecture
=======================================

Rewrite of the architecture to accomodate on-view parameters and to enable code reuse
between the default widget and custom widgets.
2023-11-03 14:02:25 +01:00
Paddle
a5b5d01c22 DSH architecture: On-view spinboxes 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
677694b0ba Sketcher: New DSH architecture to support multiple input
========================================================

Architecture to support multiple input from a widget and a mouse.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3ad624236b Sketcher: DrawSketchHandler - refactor functions to draw/clear edit curve and markers 2023-11-03 14:02:25 +01:00
Chris Hennes
cbd0ef5975 Merge branch 'main' into modernize-type-check 2023-10-25 16:07:28 -05:00
Paddle
d19a16ddd5 SketcherToolDefaultWidget : add 3 parameter configuration functions.
And remove the units from setParameter.
2023-10-24 19:28:13 +02:00
Paddle
5ced1c2680 SketcherToolDefaultWidget : add functions to set combobox item icons and checkboxes icons. 2023-10-23 20:24:20 +02:00
Florian Foinant-Willig
a32851073d Sketcher: modernize type checking 2023-10-23 18:09:23 +02:00
Paddle
f45fd8fe35 Sketcher: commandConstraint : remove leftover bothexternal variable. 2023-10-22 13:51:21 +02:00
wmayer
ce9c57383a Sketch: use new-style connect() in new code 2023-10-20 14:23:21 +02:00
wmayer
7f23467674 Sketch: fix several compiler and lint warnings
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
2023-10-20 12:29:59 +02:00
wmayer
5a6cfafda8 Sketch: fix Qt6 build failure
QRegExp has been replaced with QRegularExpression and isn't part of the base of Qt6 any more
2023-10-20 11:57:21 +02:00
Abdullah Tahiri
71a9eca750 Sketcher: ToolSettings Widget - Tool Management
===============================================

Sets the full interface between the DrawSketchHandler and a tool widget available somewhere in the UI.

Signalling is as follows:
1. On activation of the tool, DrawSketchHandler notifies the tool widget.
2. The tool widget retrieves tool information necessary for representation (type of widget, visibility, ...)
3. When the tool widget has created an appropriate widget, it notifies back a widget change.
4. The tool receives the widget handler and can now configure and interact with the widget.
2023-10-15 15:20:03 +02:00
Paddle
9538aafc9a Sketcher: DrawSketchHandler - add getViewer function to drawsketchHandler to simplify code. 2023-10-15 15:20:03 +02:00
Paddle
c62f5f30fd ToolWidget-Sketcher: Tool widget basic framework
================================================

Provides a framework to show in the taskbar a taskbox with a tool settings dialog.
2023-10-15 15:20:03 +02:00
Paddle
951edf3ec4 Fix typo making Sketcher_Dimension fails for angles. 2023-10-10 13:48:07 +02:00
wmayer
56820718c5 Core: Revert superfluous changes made with PR #9521 2023-10-09 15:06:45 +02:00
Abdullah Tahiri
96efff81c7 Sketcher: Fix segfault when activating a tool in a different view
=================================================================

When in Sketcher edit mode, a tool button is activated, while the view has been changing to view of a different type, it segfaults.

This commit checks the pointer of the view to ensure correct type before activation, and refusing to activate if not of the correct type.

fixes #10809
2023-10-07 09:00:06 +02:00
Paddle
37b68f3931 Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates 2023-10-07 07:43:39 +02:00
AgCaliva
2212e68a30 merge master via cli 2023-10-04 13:28:48 -03:00
liukaiwen
18af697795 Merge remote-tracking branch 'origin/master' into remove_redundant_definition 2023-10-02 01:42:37 +08:00
Chris Hennes
5dfd4d5190 Update translations 2023-09-29 22:57:37 -05:00
liukaiwen
4f8fe8fd4a [cmake] some definitions do not matter build now 2023-09-27 18:17:14 +08:00
AgCaliva
1f9bae0de7 Merge branch 'master' into User/Document/Feature_level_units_selection_#7746 2023-09-25 22:58:23 -03:00
Chris Hennes
730d471fb1 Update translations 2023-09-19 22:25:14 -05:00
wmayer
ab4abab53d Sketch: fix a few minor issues:
* fix compiler warning about unused variable
* fix const correctness
* fix access type of setExpression()
* removed duplicated method
2023-09-19 22:01:19 +02:00
Chris Hennes
0bbb10864b Merge pull request #10656 from Ondsel-Development/dim_arc_angle
Sketcher_Dimension: Adds arc angle mode.
2023-09-19 12:42:56 -05:00
Paddle
e3445388a2 Sketcher_Dimension : adds arc-angle mode for arcs. 2023-09-19 08:25:45 +02:00
Paddle
55420d96af Sketcher: Angle constraint: when moving it with mouse, it enables user to switch of supplementary angle. 2023-09-19 07:22:50 +02:00