Commit Graph

42 Commits

Author SHA1 Message Date
wmayer
a247b7e6a5 force strict ISO C++ (-Wpedantic)
for Drawing, Image, Inspection, Mesh, MeshPart, Part, Path, Points, Raytracing, ReverseEngineering, Spreadsheet, Start, Surface, Web

TODO: fix several -Woverflow in area
2019-09-18 11:32:42 +02:00
luz.paz
039d6eac01 Fix typos in various src/Mod directories 2019-08-17 15:32:49 +02:00
Zheng, Lei
34ed8a8e00 Spreadsheet: convert PropertySheet to link type property
PropertySheet is changed to derive from PropertyExpressionContainer,
which makes it a link type property that is capable of external linking.
It now relies on the unified link property API to manage object
depenency, and tracking of object life time, relabeling, etc.

This patch also includes various fix and improvement of Spreadsheet,
such as improved recompute efficiency, correct handling of document
label change, etc.
2019-08-17 14:52:09 +02:00
wmayer
c9b4f4ba67 fix possible crash in PropertySheet when removing dependencies 2019-01-17 18:33:06 +01:00
wmayer
fc16bcbfca Replace Base::Exception with appropriate subclass 2018-11-14 18:02:49 +01:00
wmayer
c6745d1b5b fixes 0003610: App::PropertyFloatList not updating in Spreadsheet 2018-10-13 14:02:03 +02:00
Eivind Kvedalen
5d2a889a80 Fixed issue #3506: Certain alias names with a number at the end caused exceptions when deleting cells in a spreadsheet. 2018-08-01 19:23:16 -03:00
Eivind Kvedalen
d2f9ab6a11 Spreadsheet: Fixed issue #3361. 2018-07-31 16:11:37 -03:00
Eivind Kvedalen
13da3dd830 Revert "fixes #0003361: Spreadsheet: Inserting Row Cause Crash - FC Daily v0.17"
This reverts commit f485a0786f.
2018-07-31 16:11:37 -03:00
wmayer
f485a0786f fixes #0003361: Spreadsheet: Inserting Row Cause Crash - FC Daily v0.17 2018-03-25 13:39:21 +02:00
Eivind Kvedalen
5fe7a9af71 Spreadsheet: Fix for issue #3225.
Done by adding a selector function to Document::renameObjectIdentifiers(...) to ensure
that the Spreadsheet document object is not rewritten twice.
2017-11-08 23:15:16 +01:00
luzpaz
ab8f8919b6 Misc. typos
+ some are doxy others are just comment code.  
+ some minor whitespace and grammatical tweaks. 
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
2017-10-04 17:59:11 +02:00
Eivind Kvedalen
338ca55622 Spreadsheet: Fixed issue #2894: Unit strings could be used as aliases. 2017-03-07 13:45:53 -03:00
Eivind Kvedalen
8fe0d42450 Spreadsheet: Fixed undo/redo (issue #2483). 2016-04-04 19:58:19 +02:00
Eivind Kvedalen
a21571a652 Spreadsheet: Removed own expression parser and instead use the one in App. 2016-04-02 12:01:04 +02:00
Eivind Kvedalen
b606ed8ce4 Spreadsheet: Added AtomicPropertyChange object to avoid excessive property change reporting. 2016-03-08 16:09:30 +01:00
Eivind Kvedalen
b74b3f3358 Spreadsheet: Refactor code and reuse visitors from ExpressionVisitors.h 2016-02-18 16:54:42 +01:00
Eivind Kvedalen
1802d94a1a Spreadsheet: Override DocumentObject::renameObjectIdentifiers() to get better renaming support. 2016-02-18 16:54:42 +01:00
Eivind Kvedalen
8c943d0ad7 Spreadsheet: Refactored code to use AtomicPropertyChangeInterface. 2016-02-18 16:54:40 +01:00
Eivind Kvedalen
53dcaccd4e Spreadsheet: Refactored alias checking code, so GUI and Python error messages are aligned. 2016-02-18 16:54:39 +01:00
Ed Martin
d71a12db05 Spreadsheet: Issue #2355: Do not recompute the spreadsheet and its dependents unless the change affects the spreadsheet 2016-01-26 12:04:55 +01:00
Eivind Kvedalen
ed29d8ef9a Spreadsheet: Fixed crash when removing aliases. 2016-01-26 11:14:06 +01:00
Eivind Kvedalen
d45a95bf3a Spreadsheet: Issue #2402: Added functionality to get cell address given an alias. 2016-01-26 10:52:00 +01:00
Eivind Kvedalen
ae6b934207 Spreadsheet: Fixed PropertySheet::Paste(); undo did not work correctly. 2015-12-09 12:15:15 +01:00
Eivind Kvedalen
71605e63ef Spreadsheet: Fixed issue #2352, removal of rows and columns. 2015-12-09 12:15:13 +01:00
Eivind Kvedalen
4b5ae54e88 App: Removed VariableExpression::setName(), and replace call by setPath(); it's use caused a crash (#2352). 2015-12-09 12:15:12 +01:00
Eivind Kvedalen
e2650860cc Spreadsheet: Expressions using a spreadsheet cell address are now correctly renamed when rows/columns are removed/inserted. 2015-10-11 09:41:16 +02:00
Eivind Kvedalen
a80ccb9451 Spreadsheet: Renaming an alias will now traverse the document and update expressions referencing it. 2015-10-11 09:41:15 +02:00
Eivind Kvedalen
4d5646fa5d Spreadsheet: Replaced own Expression classed by the ones in App. 2015-09-21 14:51:11 +02:00
Eivind Kvedalen
bee11897a1 Spreadsheet: Fixed bug with dangling pointer when a document object is deleted. 2015-09-21 14:51:01 +02:00
Eivind Kvedalen
61cbad8a12 Spreadsheet: Removed 'using namespace App'; preparation for moving Expression
classes to App.
2015-09-21 14:51:00 +02:00
Eivind Kvedalen
f7625481a2 Spreadsheet: Made freecad_dynamic_cast calls unambiguous (preparation for next commit). 2015-09-21 14:50:58 +02:00
wmayer
cac09437c8 + fix various warnings 2015-08-29 23:01:19 +02:00
Alexander Golubev
d2176be234 Mod/Spreadsheet: fix yet another warning (potentialy harmful)
Warning was -Woverloaded-virtual
2015-08-29 18:36:02 +02:00
wmayer
dd2b39ddd6 + fixes #0002075: Analysis of FreeCAD by PVS-Studio static analyzer 2015-05-01 16:56:31 +02:00
Eivind Kvedalen
3743008cda - Self-reference bug
- Refactoring/clean-up of code
- Dependency tracking of aliased cells
- Various resolution errors
- Rewriting of ranges when columns/rows are inserted/removed
- References to aliases keep their units.
2015-03-04 22:18:20 +01:00
Eivind Kvedalen
c3af4232a4 Spreadsheet: getProperty does not return 0 when property is not found, but throws an exception. Handle this instead. 2015-02-17 11:47:56 +01:00
Eivind Kvedalen
4ab13b9fea Spreadsheet: Remove empty set from documentObjectToCellMap. 2015-02-17 11:47:11 +01:00
Eivind Kvedalen
43e777c7e5 Spreadsheet: docDeps property was not properly maintained, resulting in spurious links to other objects. 2015-02-17 11:46:12 +01:00
Eivind Kvedalen
1b43ca109b Spreadsheet: Consistently use App::Document::Label as reference for document names when tracking dependencies. 2015-02-17 11:44:55 +01:00
Eivind Kvedalen
d153fb2dbd + Fixed merge of cells to retain value in upper left cell+ Replaced std::map::at() with iterators and find. Removed some superfluous calls to std::map::find()
+ Visual Studio fixes
+ Fixed return values
+ Removed unused variables
2015-02-13 21:53:59 +01:00
Eivind Kvedalen
383ffa6e15 Initial implementation of Spreadsheet module (C++ version) by Eivind Kvedalen.
Various fixes for Windows by
Peter Lama <peterldev94@gmail.com>
Werner Mayer <wmayer@users.sourceforge.net>
2015-02-13 21:53:58 +01:00