Commit Graph

15555 Commits

Author SHA1 Message Date
Bernd Hahnebach
817eb41aef FEM: extend coding conventions 2020-03-14 21:44:40 +01:00
Russell Johnson
8e9d704556 4th-axis fixes and improvements
Fix rotational orientation of pockets.  Need to apply same fix to ProfileFaces.
Fix final depth issue based upon error in rotational orientation fixed here.
Add property, `LimitDepthToFace` to facilitate easier pockets and face profiling on rotational-enabled operations.
Hide rotational support properties when operations do not use rotation.
Remove unnecessary property, `B_AxisErrorOverride`, and delete dead code that used it.
2020-03-14 11:36:21 -05:00
wmayer
cbee07d53a PartDesign: fix issues of PR #3108
* in the undo/redo list use an object's label and not the internal name
* check by the transaction ID instead of name to open a transaction to make the workbenches independent of implementation details of the core system
* when rejecting a task do not call undo() because this is not the same as aborting a pending transaction
* this also fixes the warning: <App> Document.cpp(1182): Cannot commit transaction while transacting
2020-03-14 14:51:45 +01:00
Zheng, Lei
e9bbae0a89 PartDesign: fix task dressup/transformed creation cancel 2020-03-14 14:51:45 +01:00
donovaly
f344791939 add icons for line style
- also break a too long tooltip
2020-03-14 08:05:47 -04:00
donovaly
74b6249b28 add missing tooltips
- also some wording improvements
2020-03-14 08:05:47 -04:00
donovaly
4cdf567023 [TD] add missing signal/slot for decimals
- also update some tooltips
2020-03-14 08:05:47 -04:00
Tobias Ellinghaus
ccabe852b3 TD: Fix decimal separator of dimensions
When the system separator isn't '.' we want to make sure to use it.
2020-03-14 08:04:49 -04:00
Daniel Wood
b1d9d9f98d [Path] - Use PathUtil to check if op is active.
Just a bit of house keeping.
2020-03-14 10:56:29 +00:00
Daniel Wood
d364eaead6 [Path] - Handle Post Processing Operations with Dressups 2020-03-14 10:49:23 +00:00
mwganson
938dd27cae [Spreadsheet] fix tooltip to show newline instead of \n characters 2020-03-13 15:40:30 +01:00
mwganson
f6f80256c8 [Spreadsheet] add tooltip for alias line edit. Also, per user request, make it so when creating a new spreadsheet it is open for viewing/editing 2020-03-13 15:40:30 +01:00
mwganson
e2e0018df6 [Spreadsheet] fix minor bug where failure to set alias message appears erroneously. Fixes #4287 2020-03-13 15:40:30 +01:00
donovaly
9f106983c6 [TD] wording fixes and improvement for HLR prefs 2020-03-13 09:05:40 -04:00
Tobias Ellinghaus
cfc04404b6 Fix label of angular dimensions
According to ISO 129-1 labels of angular dimensions may never be upside
down (that is also true for other labels but not relevant for this
commit).
2020-03-13 09:02:37 -04:00
donovaly
cc0ae914c6 improve another tooltip as discussed:
https://forum.freecadweb.org/viewtopic.php?f=35&t=21857&p=376366#p376381
2020-03-13 09:01:43 -04:00
donovaly
391cd78afe some more wording 2020-03-13 09:01:43 -04:00
donovaly
4fe75ceb01 another improvement 2020-03-13 09:01:43 -04:00
donovaly
6d85cb908c [TD] wording fixes and improvement for advanced prefs 2020-03-13 09:01:43 -04:00
donovaly
36406ec937 better UI names for arrow ends,
see https://forum.freecadweb.org/viewtopic.php?f=35&t=21857&p=376366#p376381
2020-03-13 09:01:06 -04:00
donovaly
23bf029d66 [TD] fix arrow end None for dimensions
This was not merged from my PR to PR #3153

- also uniform the combobox appearance in the preferences
2020-03-13 09:01:06 -04:00
wandererfan
99a9964231 [TD]support App::Link in View Source 2020-03-13 09:00:14 -04:00
Bernd Hahnebach
2e4ee3e706 FEM: examples, some code improvements 2020-03-13 09:19:27 +01:00
Bernd Hahnebach
b3d75d977e FEM: extend code conventions 2020-03-13 09:19:20 +01:00
Bernd Hahnebach
96bd3c58e9 FEM: typo 2020-03-13 06:52:22 +01:00
mwganson
2609ec5441 [Spreadsheet] fix bug where duplicate / bad aliases were being allowed. 2020-03-12 15:47:54 +01:00
mwganson
54549d0931 [Spreadsheet] add alias line edit next to contents line edit -- add back in some inadvertently removed code 2020-03-12 15:47:54 +01:00
mwganson
77114fa942 [Spreadsheet] add alias line edit next to contents line edit 2020-03-12 15:47:54 +01:00
Yorik van Havre
81e6454c61 Arch: Fixed regression in layers 2020-03-12 11:33:07 -03:00
triplus
946fd7352b Draft - enable toggle grid command in edit mode
Some people would like to have more control over draft grid visibility  while in Sketcher edit mode.  Hence this PR enables the usage of Draft ToggleGrid  command in Sketcher edit mode.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=34&t=43265&start=20#p374747
2020-03-12 09:26:48 -03:00
danreb25
621c30db50 getColors BUG correction
correction proposed as explained in the forum topic https://forum.freecadweb.org/viewtopic.php?f=3&t=42191
2020-03-12 09:25:05 -03:00
vocx-fc
81d7267e72 Draft: add new viewprovider icon for radius dimension
If it is a linear dimension show the older icon;
if it is a radius or diameter dimension show a new icon.

These three modes use the same Proxy class
and the same viewprovider class. Depending on the linked geometry
one icon or the other will be shown.
2020-03-12 09:12:11 -03:00
vocx-fc
dce7f63c02 Draft: add new viewprovider icons for specific objects
When there are many Draft objects in the tree view
the icon can be used to tell different objects apart quickly.
One icon is used for objects that are "straight lines",
whose Proxy is of type `Line`, `Wire` or `Polyline`; another icon
for "regular geometrical" shapes of type `Rectangle` or `Polygon`;
and another icon for "curved" objects of type `Circle`,
`Ellipse`, `BSpline`, `BezCurve`, or `Fillet`.

Other objects use the older default icon.
2020-03-12 09:12:11 -03:00
carlopav
8f2cd4526e [Draft] Remove AddPoint and DelPoint commands from UI
[Draft] Edit: Remove Bezcurve interface from Edit Ui


[Draft] Edit: cleanup


small improvement to tooltip
2020-03-12 09:11:34 -03:00
carlopav
6d2c8b5df3 [Draft] Uniform length and xyz inputfield behaviour
Single returnPressed to accept point if cursor is parallel to xyz axis for bot setfocus on x and on length inputfields.
[Draft] Edit_updated tooltip


[Draft] DraftGui Further cleanup and bugfix
2020-03-12 09:11:34 -03:00
carlopav
4396b40fec [Draft] DraftGui and DraftEdit Cleanup to remove AddPoint & DelPoint
Lines to be deleted in DraftGui in the future, are now commented.
2020-03-12 09:11:34 -03:00
carlopav
786eac8c01 [Draft] DraftGui Bugfix on selecting inputfields
https://forum.freecadweb.org/viewtopic.php?f=23&t=43145&p=367517#p367517
2020-03-12 09:11:34 -03:00
vocx-fc
7a622e7021 Draft: implement unit test for angular dimension
Previously the `makeAngularDimension` function produced
error messages in the report view due to internal rounding
of `App::PropertyAngles`.
This was fixed in `Base::Quantity`, which now supports
Python's `__round__` function.
2020-03-12 09:06:11 -03:00
vocx-fc
07a0bdcabe Draft: implement unit test for radial dimension 2020-03-12 09:06:11 -03:00
vocx-fc
8c08fb27fb Draft: cleanup of unit tests code 2020-03-12 09:06:11 -03:00
vocx-fc
9c6162f88c Draft: unit test for arc by 3 points 2020-03-12 09:06:11 -03:00
vocx-fc
85bce262b4 Draft: add script to produce a test file as example
The test script can be run by the program's executable
or run as a macro.
```
freecad draft_test_objects.py
```

It can also be used as a Python module within the program
to create a test file on demand.
```
import drafttests.draft_test_objects as dt
dt.create_test_file()
```

The produced test file will be added in a different commit
once this commit is merged.
The idea is to have a test file created by a certain
stable version of the master branch. Then as the code
continues to change and grow, this file can be opened
with future versions of the program to test for compatibility
and regressions.
2020-03-12 09:06:11 -03:00
wandererfan
303335e8af [TD]accept QGraphicsItem from Python 2020-03-12 07:58:38 -04:00
wmayer
e91c2d6afd fixes #0004286: PartDesign hole: angle of the tapered hole does not match the tapered angle specified [skip ci]
See https://forum.freecadweb.org/viewtopic.php?f=13&t=44056#p375915
2020-03-12 11:39:09 +01:00
Bernd Hahnebach
4db6d7cafa FEM: improve Python type checking and Python imports 2020-03-12 10:02:33 +01:00
Bernd Hahnebach
70f8bfbeef FEM: qrc, add comment 2020-03-12 05:28:44 +01:00
Bernd Hahnebach
021ef0a0db FEM: result mesh vp, automate get icon 2020-03-12 05:28:32 +01:00
Bernd Hahnebach
5a9459a256 FEM: rename icon, mesh result object 2020-03-12 05:28:24 +01:00
Patrick Felixberger
208c20ec53 Merge branch 'millface-drilling-improvements' of https://github.com/Schildkroet/FreeCAD into millface-drilling-improvements 2020-03-12 00:01:20 +01:00
Patrick Felixberger
a853187977 Changed property names 2020-03-12 00:00:44 +01:00