Commit Graph

1861 Commits

Author SHA1 Message Date
Yorik van Havre
afa40aa049 Merge pull request #4299 from three-ddd/archstairs_connections_flight_landing
[0.20] [Arch] connections between stair flight and landing
2021-03-30 13:17:24 +02:00
Yorik van Havre
111184a770 Merge pull request #4517 from Roy-043/Arch_Roof_fix_for_adjust_list_len
[ARCH] Arch_Roof fix for adjust_list_len function
2021-03-30 13:05:10 +02:00
Yorik van Havre
a346a10c88 Merge pull request #4547 from chennes/lgtmArchUnusedIterationVariable1
[Arch] Refactor to eliminate unused variable
2021-03-30 13:01:06 +02:00
Matthijs Kooijman
cc88c21fae Arch: Fix displayed rotation values when adding or editing window components
This ensures the rotation edge and mode GUI elements are cleared when starting
to add or edit a component. Previously, when adding a new component or
editing one without rotation, the GUI elements would retain the value
from the previously edited component, which made it hard to check that
components did not have any rotation, and would make it easy to
accidentally add rotation to components that did not need it (just by
clicking edit and confirming).
2021-03-30 12:40:06 +02:00
Yorik van Havre
09e5ad7e67 Merge pull request #4550 from chennes/lgtmDice3DSIssues
[Arch] LGTM issues in Dice3DS
2021-03-26 11:30:11 +01:00
Yorik van Havre
9b2dc76b63 Merge pull request #4631 from sde1000/webgl-export-camera-buttons
Fix camera position buttons in WebGL export
2021-03-26 11:29:03 +01:00
Yorik van Havre
d8dd64e72a Merge branch 'master' into Arch_Roof_fix_for_adjust_list_len 2021-03-26 11:23:56 +01:00
Yorik van Havre
6dcb1686f2 Merge pull request #4453 from regularfry/lgtm-arch-unused-imports
Arch: removes unused imports
2021-03-26 11:22:11 +01:00
Yorik van Havre
49c71cb0b3 Merge branch 'master' into alafr-arch-structure 2021-03-26 11:08:01 +01:00
Stephen Early
75b4225d45 Fix camera position buttons in WebGL export
Fix the "View Top" and "View Front" buttons on pages generated with the
WebGL exporter to select the same views as the FreeCAD Navigation Cube.
2021-03-17 18:48:19 +00:00
David Osterberg
43bc30da84 Beautify xml step 1: These changes do not affect the uic output 2021-03-02 16:29:11 +01:00
Chris Hennes
62ebad19d6 [Arch] LGTM issues in Dice3DS
LGTM identified a few minor issues in the Dice3DS code -- none of them
appear to be real errors, so the changes here should not affect the
behavior of the code.
2021-03-01 10:35:39 -06:00
Yorik van Havre
deaf74856b Arch: Fixed SectionPlane outside objects bug in ArchSectionPlane - Fixes #4549 2021-03-01 16:49:31 +01:00
Chris Hennes
ac4b02f5a0 [Arch] Refactor to eliminate unused variable
LGTM complains about the unused variable in a loop that is really only
using the variable to iterate a set number of times. This replaces that
loop with a multiplication by the length of the array, eliminating the
unused iteration variable and clarifying the intent of the code.
2021-02-28 23:42:14 -06:00
Yorik van Havre
958009c2ca Merged crowdin translations 2021-02-25 13:27:48 +01:00
Yorik van Havre
5ba28fa7ff Merged crowdin translations 2021-02-24 18:07:59 +01:00
Roy-043
87349d19cf [ARCH] Arch_Roof fix for adjust_list_len function
LGTM code analysis did not like that the adjust_list_len function would mutate default list values. De function now always clones the list.
See: https://forum.freecadweb.org/viewtopic.php?f=23&t=55943
2021-02-23 19:58:39 +01:00
Bernd Hahnebach
f5a567a1fc Arch: ifc export, save guid to obj attribute 2021-02-22 01:50:47 +01:00
Yorik van Havre
7c3911f61b Merge pull request #4479 from Roy-043/ArchRoof-compatibility-fix-2
[Arch] ArchRoof: Improved compatibility fix
2021-02-18 15:46:52 +01:00
Roy-043
9a444671b7 [Arch] ArchStructure.py wrongly used Part.Line (endless line) to close a wire. 2021-02-17 23:29:01 +01:00
Roy-043
30c4c58f0b [Arch] ArchRoof: Improved compatibility fix
The check if a relative profile in turn references a relative profile has been improved. Added: run or angle of profilRel must be zero.
2021-02-17 21:35:51 +01:00
Bernd Hahnebach
2cc764f5ca Arch: add BIM_Classification command before make use of it 2021-02-15 16:13:30 +01:00
Yorik van Havre
070b5560d0 Merge pull request #4449 from paullee0/ArchSectionPlane_BugFixes_01
[ArchSectionPlane]  Fix Swing for Windows(Doors) Link in ArchView/TD
2021-02-15 13:25:36 +01:00
Yorik van Havre
47c52cf051 Merge pull request #4434 from Roy-043/Arch_Fix_ArchPipe
[Arch] Fix for ArchPipe: getProfile returned Shape instead of Wire
2021-02-15 13:24:28 +01:00
Alex Young
79449b8ce9 Arch: removes unused imports
Removes unused imports as reported by LGTM.

There are exceptions: `import Arch_rc` is shown as an alert, but has side effects.  It's not clear what the best thing to do in those cases is, so I've left them for now.
2021-02-14 16:27:06 +00:00
paul lee
f05cc354b1 [ArchSectionPlane] Fix Swing Symbol for Windows(Doors) Link in ArchView/TechDraw
Forum Discussion  :  [ Link in Arch/BIM -- 4 ] Link of Door : Swing Not Shown in ArchView/TechDraw
- https://forum.freecadweb.org/viewtopic.php?f=23&t=55526
2021-02-14 03:13:36 +08:00
Yorik van Havre
84b8282f48 Updated ts files 2021-02-12 14:47:37 +01:00
Roy-043
5683d054d4 [Arch] Fix for ArchPipe: getProfile returned Shape instead of Wire
Fix for ArchPipe: getProfile returned Shape instead of Wire
2021-02-11 21:13:36 +01:00
Chris Hennes
8228d64ac4 [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Yorik van Havre
bcb5c8786f merged crowdin translations 2021-02-09 16:12:18 +01:00
luz paz
d00f1099f3 Arch: update tooltip ref. to LibreOffice version within ArchSchedule
Ref: https://crowdin.com/translate/freecad/6766/en-en?filter=basic&value=0#6576778
2021-02-08 12:56:53 -05:00
Yorik van Havre
298004a39c Updated master TS files 2021-02-08 16:35:41 +01:00
three_d
c2f333f2a9 Merge branch 'master' into archstairs_connections_flight_landing 2021-02-05 22:44:48 +01:00
luz paz
d064cdc215 Arch: Fix LGTM warning of missing param for translate() in ArchPanel.py
Even though this is ignored per the docs[1], LGTM complains[2] about it. This commit adds the superfluous param. Note: there is precedent in ArchReference.py[3] and ArchWall.py[4].
 
 [1]https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Draft/draftutils/translate.py#L73-L78  
[2] 17db14c970/files/src/Mod/Arch/ArchPanel.py (L32)  
[3] 45dd1a7f60/src/Mod/Arch/ArchReference.py (L39)  
[4] 45dd1a7f60/src/Mod/Arch/ArchWall.py (L42)
2021-02-03 10:28:21 -05:00
Stefan Tröger
446ce21517 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Roy-043
a78ef319c6 Fixed typo in Arch_Schedule
Typo
2021-01-22 20:17:47 +01:00
three_d
de017757c8 Update ArchStairs.py 2021-01-22 19:09:18 +01:00
three_d
f1d95d372d Arch: connections between stair flight and landing
Added some features to allow the user to change the types of connections between the flight of stairs and landing.
This issue is discussed in the forum thread: https://forum.freecadweb.org/viewtopic.php?f=22&t=53018
2021-01-21 18:41:23 +01:00
Roy-043
649a767f6a Update ArchRoof.py
A relative profile can now be used if it references itself. This fixes a compatibility issue with the V0.18 version of ArchRoof, where the first profile initially always references itself.
2021-01-20 19:17:30 +01:00
paul lee
ed15b99a40 [ArchComponent] Fix Link Of Window Hosts if empty got error as Wall Child 2021-01-18 02:08:39 +08:00
Yorik van Havre
c745f4ef5e Arch: Fixed non-workng Panel tools 2021-01-12 15:10:16 +01:00
paul lee
9211037781 [ArchComponent] Link of Window get opening now 2021-01-09 03:19:36 +08:00
danreb25
3b2e3a730f Merge branch 'master' into BBLPatch_ArchComponentDiffuseColor 2021-01-05 20:01:16 +01:00
Yorik van Havre
d7692e359e Arch: Fixed wrong section fill when using archvrm module 2021-01-05 16:52:56 +01:00
danrenb
a89e4dfbeb deal with missing DiffuseColor attributes on obj.CloneOf.ViewObject 2021-01-05 12:27:05 +01:00
luz paz
ff96cb301e Fix typos [skip ci]
Found via `codespell v2.1.dev0`
2020-12-23 14:32:38 -05:00
Yorik van Havre
799a2e1f5d Reverting files wrongly committed with 5a974f824 2020-12-23 15:21:43 +01:00
Yorik van Havre
5a322d75cb Merged crowdin translations 2020-12-23 15:13:05 +01:00
Yorik van Havre
5a974f824c Updated ts files 2020-12-23 14:51:04 +01:00
Digvijay Patankar
652d62878c Indian standard H and U profiles added to profiles.csv 2020-12-21 07:13:33 +05:30