kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions 1 Packages Projects 9 Releases 2 Wiki Activity
32,237 Commits 41 Branches 6 Tags
d27e69bdc9cf42489067ec2fbda8e17a17d35929
Commit Graph

62 Commits

Author SHA1 Message Date
wmayer
f8827198ee PD: fix crash in TaskRevolutionParameters::fillAxisCombo 
* Replacing the static_cast with a dynamic_cast in 2aa232bef9 is a regression because it cannot be guaranteed that the linked object is a sketch.
  In fact it can also be a shape binder which is explicitly allowed.
  Forum: https://forum.freecadweb.org/viewtopic.php?f=19&t=74939
* Move initialization of some variables into the if-statement
 2023-01-02 09:49:27 +01:00
wmayer
7acc67ea43 PD: fix crash in TaskRevolutionParameters::addAxisToCombo 
and some warnings reported by GH actions
 2022-11-09 18:56:11 +01:00
wmayer
1911fe50ff PD: [skip ci] improve the exception text 2022-11-09 17:46:46 +01:00
Uwe
2aa232bef9 [PD] TaskDlgRevolutionParameters: fix some CI warnings 
- reported here: https://github.com/FreeCAD/FreeCAD/pull/7667/commits/f0a0e563
- and here: https://github.com/FreeCAD/FreeCAD/pull/7719/commits/8f3f17f8
 2022-11-09 17:33:33 +01:00
wmayer
a76dc0ade2 PD: use Base::StateLocker to simplify handling of blockUpdate and make it exception-safe 2022-11-05 19:29:20 +01:00
wmayer
18781bcf63 PD: fixes #7629: Keep sketch visible during revolution tasks 2022-11-05 19:09:54 +01:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
35f75064a0 [PD] remove superfluous nullptr checks 2022-07-17 18:12:41 +02:00
wmayer
3608ee7f51 PD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Uwe
7c8031d356 [PD] Hole, Pipe and Revolution: remove unused includes 2022-02-19 18:47:26 +01:00
wmayer
a27b3067ba PD: eliminate the boolean argument from TaskSketchBasedParameters::onSelectReference 2021-12-07 11:04:22 +01:00
wmayer
3ee1d91b88 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
wmayer
036c6b0d25 PD: improve task panel for revolution/groove: 
* set range Angle property to spin box
* connect signals after initializing widgets to avoid superfluous recomputes
 2021-03-03 15:42:48 +01:00
wmayer
bc1b9ea1bb PD: [skip ci] set value range to angle spin box 2021-03-03 15:22:53 +01:00
David Osterberg
f1d6c78cbe PartDesign: Allow use of circle edge as axis in ProfileBased 2021-03-01 14:48:24 +01:00
donovaly
2ac84872ec [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
luz paz
faa8688ee5 PartDesign: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the PartDesign Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
wmayer
b33f92898b PartDesign: [skip ci] Improve revolution function 
+ Fix hard crash when selecting an edge or face of the created feature before selecting option to choose a reference.
+ In ProfileBased::getAxis() convert OCCT into FreeCAD exception to simplify handling of calling instances.
+ Change return value of getReferencedSelection() from void to bool to mkae it easier for calling instance to detect if the selection failed.
  This is needed to avoid to add invalid items to the combo box of the revolution task panel
 2020-10-14 15:20:52 +02:00
Zheng, Lei
11a93a0578 PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
6e898575c2 various fixes: 
+ fix invalid cast
+ some minor optimizations
+ improve exception handling
 2017-10-18 12:33:41 +02:00
wmayer
004324bbc5 fix scan coverity issues: uncaught exception 2017-04-11 14:03:08 +02:00
wmayer
294b2308d6 fix crash when cancelling revolution task panel 2017-01-23 23:24:40 +01:00
wmayer
664cf65d26 fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
Stefan Tröger
f712f5e4ac PartDesign: Modeling features work with faces 
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
 2016-04-12 18:12:22 +02:00
Stefan Tröger
5002e8e430 Fix crash on aborted pattern external axis 2016-04-12 18:12:22 +02:00
Alexander Golubev
d43525370c PartDesignGui: small rework to sketch-based task parameters 
This done mostly for thurther unification them with other task
parameters/dialogs.
 2016-04-12 18:12:21 +02:00
Alexander Golubev
0cfc0cd424 Fix warnings introduced in new PartDesign 
Mostly unused wariables and compare of signed & unsigned
 2016-04-12 18:12:21 +02:00
Alexander Golubev
1a26f7551f PartDesign: add Origin to the Body and unstrap the module from the Parts 2016-04-12 18:12:18 +02:00
Alexander Golubev
2c2d155ee9 OriginGroup: add new abstraction layer between the Part and the GeoFeatureGroup 2016-04-12 18:12:18 +02:00
Alexander Golubev
797d6d3a11 App/Origin: big refactoring 
- Rebase App::Origin on App::DocumentObject
 - Keep all control over the Origin structure inside the Origin and it's
   ViewProvider
 - Add OriginFeature class as common base for App::Plane and App::Line
 - Rebase App::Plane and App::Line on top of newly created class and
   move to the file.
 - Change Origin's ViewProvider API associated with temporary display
 - Lots of associated changes to files
 - Several minor fixes
 - Lots of new bugs
 2016-04-12 18:12:18 +02:00
Alexander Golubev
c4f094bba4 PartDesign/Gui: rename some fonctions in ReferenceSelection.cpp 
e.g. getPythonStr -> buildLinkListPythonStr etc
 2016-04-12 18:12:17 +02:00
Alexander Golubev
c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Alexander Golubev
f16829baee PartDesignGui: Make DressUp and SketchSupport propertie dialogs use common accept() structure 2016-04-12 18:12:15 +02:00
DeepSOIC
125dda4d70 PartDesign: Make groove work via Revolution ui 
Purpose: remove duplicate code.
Remaining: wrong title and icon in task dialog.
 2016-04-12 18:12:14 +02:00
DeepSOIC
9776d30b87 PartDesign: rework axis and plane comboboxes and make it work without part. 
Rework combobox filling and link hadling for revolution and transformed features, in order to get rid of hard-coded item indexes and make the lists more dynamic.
 2016-04-12 18:12:14 +02:00
DeepSOIC
34784b2d29 PartDesign: Fix revolution 
It failed to close task if starting a body.
 2016-04-12 18:12:12 +02:00
DeepSOIC
03be8e1bba PartDesign: tidy up sketch support and base feature confusion 
Not complete, transformPlacement and positionBySketch are pending...
 2016-04-12 18:12:11 +02:00
Stefan Tröger
6347fe8c86 make origin work correct with multiple parts 2016-04-12 18:12:08 +02:00
Stefan Tröger
ec125cf9f2 make origin lines usable in revolution 2016-04-12 18:12:08 +02:00
jrheinlaender
f1b5a6044d Allow extruding from a datum plane to another face or plane, optionally with an offset 2016-04-12 18:11:53 +02:00
jrheinlaender
026242231e Changed tree ordering of booleans and bodies 2016-04-12 18:11:51 +02:00
jrheinlaender
75dc92fd90 Enable edges and datum lines as rotation axis for Groove and Revolution features 2016-04-12 18:11:51 +02:00
jrheinlaender
b815656649 Refactored code of SketchBased features to have common code in an abstract superclass 2016-04-12 18:11:50 +02:00
jrheinlaender
63f782d8f0 More bug fixes for Body insertion/deletion of features 2016-04-12 18:11:48 +02:00
jrheinlaender
ee47c53339 Bug fixes for Body feature insert/remove functionality 2016-04-12 18:11:48 +02:00
Mateusz Skowroński
cd2db00f22 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-01-05 16:07:25 +01:00
Eivind Kvedalen
ddfbe349cf PartDesign: Added support for expressions. 2015-09-21 14:51:09 +02:00
wmayer
fb19ea5089 + fixes #0001870: Revolution and Groove in Part-Design do not hide the sketch and parent-feature for some geometries 2015-01-06 15:00:24 +01:00
wmayer
dfea0206ca + fix doc string 2014-07-22 14:49:25 +02:00