Commit Graph

2487 Commits

Author SHA1 Message Date
sliptonic
de6977db73 translation cleanup PathGeom 2022-01-03 10:48:39 -06:00
sliptonic
d567266c51 Translation cleanup PathHop
PathHop transaction
2022-01-03 10:48:39 -06:00
sliptonic
d0d15f956f Translation cleanup PathUtils/PathUtil 2022-01-03 10:48:39 -06:00
sliptonic
240d44238b translation cleanup PathCustom/gui 2022-01-03 10:48:39 -06:00
sliptonic
958c912104 translation cleanup PathComment
transaction PathComment
2022-01-03 10:48:39 -06:00
sliptonic
41ea04f875 tranlation cleanup PathCopy
transaction PathCopy
2022-01-03 10:48:39 -06:00
sliptonic
0fae42230c black reformat
black reformat for PathCommands

Black reform PathCopy

Black reform PathComment

Black reformat PathCustom/gui

Black reformat PathUtil/PathUtils

Black reformat PathHop

Black reformat PathGeom

Black reformat

Black reformat

Black reformat

Black reformat

Black reformat

black reformat

Black reformat

black
2022-01-03 10:48:39 -06:00
sliptonic
6cbd7651ac Merge pull request #5008 from Russ4262/fix/childless_job
[Path] Fixes #4645
2022-01-03 10:37:27 -06:00
jim
88669b5456 allow user to specify a seed value for jitter pseudorandomness so that multiple operations/tools can follow the same sequence 2022-01-02 07:38:56 -08:00
jim
5179781438 Correct typo in jitter dimension calculation 2022-01-01 19:59:24 -08:00
sliptonic
7558945c2b Use run() instead of Popen() to avoid need for communicate() call. 2021-12-31 10:04:17 -06:00
sliptonic
189d3c72a2 use subprocess.Popen() the right way 2021-12-30 16:58:45 -06:00
sliptonic
1e1f134361 fix #4810
use subprocess.Popen() to avoid executing arbitrary code
2021-12-30 16:32:17 -06:00
Russell Johnson
d6a17b1491 Black formatting only 2021-12-25 00:29:05 -06:00
Russell Johnson
293868c46b Path: Fix 'NoneType' argument error in '_stepTransitionCmds()'
The 'p1' argument is passed in as 'None' on occasion.  This fix cancels the efficient transition between the two points.  3D Surface is and experimental op, and therefore this fix needs additional user testing with various complex models.
2021-12-25 00:27:19 -06:00
sliptonic
43f4fffa61 Merge pull request #5271 from sundtek/sundtek-discretize-bug
[PATH] change discretize value to fix issues
2021-12-19 12:35:13 -06:00
sundtek
f3ccd77f91 Update PathAdaptive.py
the internal unit is mm, only lowering the accuracy should be enough.
2021-12-20 01:15:59 +08:00
sundtek
0eead0d3c6 change discretize value to fix issues
Discretize of 0.0001 is okay for inches, but for metric <1microns would be quite small, this fixes some issues when generating paths for curves that look inward.
I found following post in the forum: https://forum.freecadweb.org/viewtopic.php?f=15&t=42755
I have experienced similar issues with other curves in my object.
2021-12-19 19:23:09 +08:00
sliptonic
49f8edeaa8 Modified combobox selection
cleaned up translation method

Profile translation cleanup

Incorporating additional suggestions
2021-12-17 08:35:41 -06:00
Russell Johnson
564114e1c5 Path: Translation Solution POC 2021-12-17 08:35:41 -06:00
sliptonic
5ad32fb8cf PathOpGui Black reformat 2021-12-17 08:35:41 -06:00
luz paz
63138c67ea Path: fix file header uniformity 2021-12-10 02:36:56 +01:00
Peter Roß
35d29b5174 Merge branch 'FreeCAD:master' into RRF-PP-for-Path 2021-12-06 12:33:23 +01:00
sliptonic
3b9dfeb672 Merge pull request #5205 from sliptonic/bug/depthsteps
[PATH]  depthparams handles negative steps and finish step correctly. Unit tests
2021-11-26 20:24:25 -06:00
sliptonic
03f05b5ef9 make sure depthparams handles negative steps and finish step correctly
revised test
2021-11-26 13:27:44 -06:00
sliptonic
54d593e116 face outerwires aren't always the first wire in the Wires list.
Added logic to compare hashCodes()

https://forum.freecadweb.org/viewtopic.php?f=13&t=50567
2021-11-15 18:40:28 -06:00
P-C-R
d7c1de814d Update rrf_post.py 2021-11-15 08:20:06 +01:00
P-C-R
bc3e8fbbc7 Bugfix for "Before Tool Change" Commands 2021-11-15 08:15:07 +01:00
luz paz
91b4207cba Fix header uniformity 2021-11-13 06:20:19 -05:00
P-C-R
42e888c7d9 Upload of a PP for RRF (RepRapFirmware)
Modified Marlin PP for RRF.
2021-11-03 15:33:51 +01:00
Russell Johnson
93115dfe83 Application of Black formatting 2021-10-06 19:56:42 -05:00
Russell Johnson
6d6ddb5751 Fix incorrect arguments list
This commit fixes the error reported in the forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=33121&start=50#p537787.

This error was introduced when another user replaced the `extractFaceOffset()` method from the PathSurfaceSupport.py module with an improved `getOffsetArea()` function in the PathUtils.py module.  The two instances of the improved `getOffsetArea()` calls here in this fix did not get corrected when that improvement was originally made.
2021-10-06 19:56:03 -05:00
sliptonic
08108b2f1b Black reformat 2021-09-29 16:51:00 -05:00
sliptonic
46eb7a50cf Job object doesn't exist in this context.
Derive output name in the output section or default if unknown
2021-09-29 16:51:00 -05:00
Russell Johnson
eaba444e7c Path: Strict application of Black code formatting to module file
This commit ONLY contains application of `Black` code formatting.  No other alterations have been made in this commit.
2021-09-27 20:53:09 -05:00
Russell Johnson
9cbed30c76 Path: Restore removal shape envelope buffer
This buffer application was removed in PR #4978 with removal of rotational code.

The buffer is required to provided adequate significant digit or rounding  in later processing of envelope in Path.Area().

NOTE:  I suggest separate `removalshape` envelopes  be created without the necessary `buffer` adjustment to allow for usage of the `removalshape` for subsequent REST type operations.
2021-09-27 20:53:09 -05:00
sliptonic
3bb37bd471 Merge pull request #5009 from Russ4262/fix/ramp_dressup
[Path] Fix for inactive ramp dressup base operation
2021-09-27 15:34:43 -05:00
sliptonic
0613f8a142 Merge pull request #5050 from jimzim111/PathArray_Z
Path: PathArray translate copies along Z axis as it does along X/Y
2021-09-27 15:19:43 -05:00
sliptonic
382053d069 Merge pull request #4975 from Russ4262/cleanup/pathprofile
[Path] LGTM cleanup of PathProfile module
2021-09-27 15:16:20 -05:00
Russell Johnson
6a47bc3f5d Path: Fixes #4645
Fixes bug #4645.
This PR adds a simple `integrityCheck()` method to Job object class.  The method is called on the Gui side before openning the task panel to edit the job.  The same method is also called upon document restoration.
2021-09-24 06:43:16 -05:00
Russell Johnson
1931c6b013 Path: Delete unnecessary comments 2021-09-24 06:40:53 -05:00
Russell Johnson
8e09da7f0b Path: LGTM cleanup 2021-09-24 06:40:53 -05:00
Russell Johnson
628f640d7c Path: Fix Face Region boundary shape usage
This commit removes automatic edge extension for `Face Region` boundary shape.  It applies the `Clear Edges` toggle for `Face Region`.  It applies `Exclude Raised Areas` correctly.  The problem of collision paths for `Clear Edges` with `Exclude Raised Areas` for certain use cases remains and is not fixed with this commit.
2021-09-24 06:39:25 -05:00
Russell Johnson
faaf33c2b5 Path: Remove unused import 2021-09-24 06:39:25 -05:00
Russell Johnson
4b3cb142ea Path: Add docString and comments for getAllIncludedFaces() method 2021-09-24 06:39:25 -05:00
Russell Johnson
7f0b3c40bb Path: LGTM fix
Prompted by LuzPaz in Gitter.im/FreeCAD/Path chatroom
2021-09-24 06:39:25 -05:00
Russell Johnson
5e9cd07ef6 Path: Black code formatting only 2021-09-24 06:38:39 -05:00
Russell Johnson
2384ad9860 Path: Add Base.Active check early in execute() method
This commit adds a `Base.Active` check to determine if the Base is Active.  If the Base is Inactive, the new code sets the `obj.Path` property to the same inactive message used in PathOp module and the `execution()` method returns immediately, stopping further execution.
2021-09-24 06:38:39 -05:00
jim
1b1e7e2a23 PathArry translate copies along Z axis as it does along X/Y 2021-09-20 21:10:49 -07:00
Chris Hennes
38eb31e01d Path: LGTM - don't catch BaseException 2021-09-19 14:37:11 -05:00